Hi Penghui, Yes, I agree with all your comments and I will update the PIP by adding that information.
Thanks, Rajan On Sun, Oct 29, 2023 at 7:17 PM PengHui Li <peng...@apache.org> wrote: > Hi Rajan, > > The proposal looks good to me. > The context and the goal are clear. > > I have 2 comments here > > 1. The change will not only affect the shared subscription, but it will > also affect > the Failover and Key_Shared subscriptions. > 2. We should also mention the behavior of other consumers when one consumer > calls the unSubscribe method after we support force unSub. Of course, the > behavior > is the same as the Admin API. Just for visibility. > 3. If I understand correctly, if users want to use the force unSub. They'd > better disable > the subscription auto-creation? Otherwise, the subscription will be > created again by the > consumer reconnection. > > Regards, > Penghui > > On Fri, Oct 27, 2023 at 8:25 AM Rajan Dhabalia <rdhaba...@apache.org> > wrote: > > > Hi, > > > > We have an issue created regarding unsubscription of shared subscription > in > > Pulsar spout at : https://github.com/apache/pulsar/issues/21451 > > This PIP addresses the issue and allows users to unsubscribe subscription > > with additional force option. > > > > PIP: https://github.com/apache/pulsar/pull/21452/files > > > > Thanks, > > Rajan > > >
