Hi, Thank you for the quick resonse.
Raised a PR here, https://github.com/apache/pulsar/pull/21517. If there is no other opinion, I guess we can disable it. Thanks, Heesung On Sun, Nov 5, 2023 at 8:14 PM tison <wander4...@gmail.com> wrote: > As it's a low traffic requirement, I agree that we can disable it and > enable it temporarily when necessary. Although it introduces a bit chore > commits to toggle the button, due to its low frequency, it should be fine. > > Best, > tison. > > > Heesung Sohn <hees...@apache.org> 于2023年11月6日周一 12:07写道： > > > Hi, > > > > This is the previous discussion of why we enabled the `rebase and merge` > > option. > > > > https://github.com/apache/pulsar/pull/20325 > > > > The example(https://github.com/apache/pulsar/pull/20321) seems to be a > > legit case for `rebase and merge.` > > > > Maybe we should be just careful(especially when using github app) > > > > Thanks, > > Heesung > > > > On Sun, Nov 5, 2023 at 7:50 PM Rajan Dhabalia <rdhaba...@apache.org> > > wrote: > > > > > I remember, It was always disabled since we open sourced Pulsar. Who > > > enabled it and what was the reason for enabling that option? It's > > > definitely not a good option and we should disable it asap. > > > > > > Thanks, > > > Rajan > > > > > > On Sun, Nov 5, 2023 at 7:36 PM Heesung Sohn <hees...@apache.org> > wrote: > > > > > > > Hi, > > > > > > > > I recently merged my PR without squash by mistake. > > > > https://github.com/apache/pulsar/pull/21408 > > > > > > > > To prevent this human error, can we disable `rebase and merge` > option, > > > > like below? > > > > > > > > [image: Screen Shot 2023-11-05 at 7.21.34 PM.png] > > > > > > > > How to disable Rebase and merge: > > > > > > > > > > > > > > > > > > https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-rebasing-for-pull-requests > > > > > > > > Thanks, > > > > heesung > > > > > > > > > > > > > >
