Re: [ANNOUNCE] New Pulsar Committer: LinLin

Congratulations LinLin! -- Thanks Xiaolong Ran 在 2021年1月7日 +0800 AM11:46，Huanli Meng ，写道： > Congratulations LinLin! > > BR//Huanli > > > On Jan 7, 2021, at 11:41 AM, Wesley Peng wrote: > > > > Congrats Linlin~ > > > > Regards. > > > > On Wed, Jan 6, 2021 at 5:25 PM Jinfeng Huang >

Re: [ANNOUNCE] New Pulsar Committer: LinLin

Congratulations LinLin! BR//Huanli > On Jan 7, 2021, at 11:41 AM, Wesley Peng wrote: > > Congrats Linlin~ > > Regards. > > On Wed, Jan 6, 2021 at 5:25 PM Jinfeng Huang > wrote: > Congratulations to Linlin~ > > Best Regards, > Jennifer > > > On Wed, Jan 6, 2021

Re: [ANNOUNCE] New Pulsar Committer: LinLin

Congratulations LinLin! Regards, Shivji Kumar Jha http://www.shivjijha.com/ +91 8884075512 On Wed, Jan 6, 2021 at 12:35 PM PengHui Li wrote: > The Apache Pulsar PMC recently extended committer karma to LinLin and he > has accepted. > LinLin has done a lot of contributions to Pulsar core featur

[GitHub] [pulsar-dotpulsar] dionjansen commented on pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#issuecomment-755502834 @blankensteiner thanks for the comments I managed to fix most of it with a view side comments/ questions (see above). Let me know what you think --

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552896507 ## File path: src/DotPulsar/ConsumerOptions.cs ## @@ -101,5 +101,16 @@ public ConsumerOptions(string subscriptionName, string topic) ///

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552896429 ## File path: src/DotPulsar/ConsumerOptions.cs ## @@ -101,5 +101,16 @@ public ConsumerOptions(string subscriptionName, string topic) ///

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552894826 ## File path: src/DotPulsar/Internal/ConsumerChannel.cs ## @@ -108,6 +108,9 @@ public async Task Send(CommandAck command, CancellationToken cance

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552892420 ## File path: tests/DotPulsar.Tests/Internal/MessageAcksTrackerTests.cs ## @@ -0,0 +1,172 @@ +namespace DotPulsar.Tests.Internal +{ +using Dot

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552892332 ## File path: tests/DotPulsar.Tests/Internal/MessageAcksTrackerTests.cs ## @@ -0,0 +1,172 @@ +namespace DotPulsar.Tests.Internal +{ +using Dot

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552892281 ## File path: tests/DotPulsar.Tests/Internal/MessageAcksTrackerTests.cs ## @@ -0,0 +1,172 @@ +namespace DotPulsar.Tests.Internal +{ +using Dot

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552892166 ## File path: tests/DotPulsar.Tests/Internal/MessageAcksTrackerTests.cs ## @@ -0,0 +1,172 @@ +namespace DotPulsar.Tests.Internal +{ +using Dot

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552892033 ## File path: tests/DotPulsar.Tests/Internal/MessageAcksTrackerTests.cs ## @@ -0,0 +1,172 @@ +namespace DotPulsar.Tests.Internal +{ +using Dot

Re: [ANNOUNCE] New Pulsar Committer: LinLin

Congratulations Enrico Olivelli 于2021年1月6日周三 下午8:27写道： > Congratulations > > Enrico > > Il Mer 6 Gen 2021, 12:09 Sijie Guo ha scritto: > > > Congrats Lin! > > > > Looking forward to more contributions from him! > > > > - Sijie > > > > On Tue, Jan 5, 2021 at 11:05 PM PengHui Li wrote: > > > >>

[GitHub] [pulsar-dotpulsar] blankensteiner commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

blankensteiner commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552592326 ## File path: src/DotPulsar/Internal/InactiveUnackedMessageTracker.cs ## @@ -0,0 +1,31 @@ +namespace DotPulsar.Internal +{ +using System.

[GitHub] [pulsar-dotpulsar] blankensteiner commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

blankensteiner commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552588860 ## File path: src/DotPulsar/Internal/UnackedMessageTracker.cs ## @@ -0,0 +1,101 @@ +namespace DotPulsar.Internal +{ +using Abstractions;

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552565957 ## File path: src/DotPulsar/Internal/UnackedMessageTracker.cs ## @@ -0,0 +1,101 @@ +namespace DotPulsar.Internal +{ +using Abstractions; +

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552565028 ## File path: src/DotPulsar/Internal/UnackedMessageTracker.cs ## @@ -0,0 +1,101 @@ +namespace DotPulsar.Internal +{ +using Abstractions; +

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552562735 ## File path: tests/DotPulsar.StressTests/DotPulsar.StressTests.csproj ## @@ -7,6 +7,7 @@ + Review comment: ah yes done he

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552561276 ## File path: src/DotPulsar/Internal/Abstractions/IMessageQueue.cs ## @@ -0,0 +1,10 @@ +namespace DotPulsar.Internal.Abstractions +{ +using Sy

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552560936 ## File path: src/DotPulsar/Internal/MessageQueue.cs ## @@ -0,0 +1,45 @@ +namespace DotPulsar.Internal +{ +using Abstractions; +using DotP

Re: [ANNOUNCE] New Pulsar Committer: LinLin

Congratulations Enrico Il Mer 6 Gen 2021, 12:09 Sijie Guo ha scritto: > Congrats Lin! > > Looking forward to more contributions from him! > > - Sijie > > On Tue, Jan 5, 2021 at 11:05 PM PengHui Li wrote: > >> The Apache Pulsar PMC recently extended committer karma to LinLin and he >> has accep

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552557276 ## File path: src/DotPulsar/Internal/InactiveMessageAcksTracker.cs ## @@ -0,0 +1,30 @@ +namespace DotPulsar.Internal +{ +using Abstractions; +

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552557117 ## File path: src/DotPulsar/Internal/InactiveUnackedMessageTracker.cs ## @@ -0,0 +1,31 @@ +namespace DotPulsar.Internal +{ +using System.Thre

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552556303 ## File path: tests/DotPulsar.Tests/Internal/MessageAcksTrackerTests.cs ## @@ -0,0 +1,172 @@ +namespace DotPulsar.Tests.Internal Review comment:

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552556164 ## File path: src/DotPulsar/Internal/UnackedMessageTracker.cs ## @@ -0,0 +1,101 @@ +namespace DotPulsar.Internal Review comment: Done 7ad

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552555901 ## File path: src/DotPulsar/Internal/MessageQueue.cs ## @@ -0,0 +1,45 @@ +namespace DotPulsar.Internal Review comment: Done 7ad89a2 --

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552553628 ## File path: src/DotPulsar/Internal/InactiveUnackedMessageTracker.cs ## @@ -0,0 +1,31 @@ +namespace DotPulsar.Internal +{ +using System.Thre

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552553274 ## File path: src/DotPulsar/Internal/InactiveUnackedMessageTracker.cs ## @@ -0,0 +1,31 @@ +namespace DotPulsar.Internal +{ +using System.Thre

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552532933 ## File path: src/DotPulsar/Internal/MessageAcksTracker.cs ## @@ -0,0 +1,103 @@ +namespace DotPulsar.Internal +{ +using Abstractions; +usi

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552532271 ## File path: src/DotPulsar/Internal/MessageAcksTracker.cs ## @@ -0,0 +1,103 @@ +namespace DotPulsar.Internal +{ +using Abstractions; +usi

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552532114 ## File path: src/DotPulsar/Internal/MessageAcksTracker.cs ## @@ -0,0 +1,103 @@ +namespace DotPulsar.Internal +{ +using Abstractions; +usi

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552531082 ## File path: src/DotPulsar/Internal/InactiveMessageAcksTracker.cs ## @@ -0,0 +1,30 @@ +namespace DotPulsar.Internal +{ +using Abstractions; +

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552529934 ## File path: src/DotPulsar/Internal/MessageAcksTracker.cs ## @@ -0,0 +1,103 @@ +namespace DotPulsar.Internal Review comment: Done 7ad89a2

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552529784 ## File path: src/DotPulsar/Internal/InactiveUnackedMessageTracker.cs ## @@ -0,0 +1,31 @@ +namespace DotPulsar.Internal Review comment: D

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552529667 ## File path: src/DotPulsar/Internal/Abstractions/IUnackedMessageTracker.cs ## @@ -0,0 +1,16 @@ +namespace DotPulsar.Internal.Abstractions Revie

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552529562 ## File path: src/DotPulsar/Internal/InactiveMessageAcksTracker.cs ## @@ -0,0 +1,30 @@ +namespace DotPulsar.Internal Review comment: Done

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552529280 ## File path: src/DotPulsar/Internal/Abstractions/IMessageQueue.cs ## @@ -0,0 +1,10 @@ +namespace DotPulsar.Internal.Abstractions Review comment:

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552528802 ## File path: src/DotPulsar/Internal/Abstractions/IMessageAcksTracker.cs ## @@ -0,0 +1,13 @@ +namespace DotPulsar.Internal.Abstractions +{ +us

[GitHub] [pulsar-dotpulsar] dionjansen commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

dionjansen commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552528290 ## File path: src/DotPulsar/Internal/Abstractions/IMessageAcksTracker.cs ## @@ -0,0 +1,13 @@ +namespace DotPulsar.Internal.Abstractions Review co

Re: [ANNOUNCE] New Pulsar Committer: LinLin

Congrats Lin! Looking forward to more contributions from him! - Sijie On Tue, Jan 5, 2021 at 11:05 PM PengHui Li wrote: > The Apache Pulsar PMC recently extended committer karma to LinLin and he > has accepted. > LinLin has done a lot of contributions to Pulsar core features and bug > fixes. I

[GitHub] [pulsar-dotpulsar] blankensteiner commented on pull request #67: Support for (optional) ack timeout and nack delay for consumers

blankensteiner commented on pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#issuecomment-755206565 Hi @dionjansen Before doing a deep dive into the implementation, I have some comments on little things that can quickly be fixed :-) ---

[GitHub] [pulsar-dotpulsar] blankensteiner commented on a change in pull request #67: Support for (optional) ack timeout and nack delay for consumers

blankensteiner commented on a change in pull request #67: URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552465648 ## File path: src/DotPulsar/ConsumerOptions.cs ## @@ -101,5 +101,16 @@ public ConsumerOptions(string subscriptionName, string topic)

Re: [ANNOUNCE] New Pulsar Committer: LinLin

Congratulations! Best, Dianjin Wang On Wed, Jan 6, 2021 at 3:05 PM PengHui Li wrote: > The Apache Pulsar PMC recently extended committer karma to LinLin and he > has accepted. > LinLin has done a lot of contributions to Pulsar core features and bug > fixes. It is great to have LinLin onboard a

Re: [ANNOUNCE] New Pulsar Committer: LinLin

Congratulations to Linlin~ Best Regards, Jennifer On Wed, Jan 6, 2021 at 3:30 PM Matthias Peng wrote: > congratulations linlin! > > On Wed, Jan 6, 2021 at 3:05 PM PengHui Li wrote: > >> The Apache Pulsar PMC recently extended committer karma to LinLin and he >> has accepted. >> LinLin has don