dionjansen commented on a change in pull request #67:
URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552894826
##########
File path: src/DotPulsar/Internal/ConsumerChannel.cs
##########
@@ -108,6 +108,9 @@ public async Task Send(CommandAck command,
CancellationToken cancellationToken)
}
command.ConsumerId = _id;
+
+ _queue.Acknowledge(new MessageId(messageId));
Review comment:
This would result in that we'd need to start using `MessageIdData` for
both the tracker as well as the `MessageQueue`, is this desirable? I thought
the idea was we'd use `MessageId` for the tracker because they are easier to
use (implements `IEquatable` and `IComparable`). If performance is more
important I can refactor to `MessageIdData`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
