dionjansen commented on a change in pull request #67:
URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r552560936
##########
File path: src/DotPulsar/Internal/MessageQueue.cs
##########
@@ -0,0 +1,45 @@
+namespace DotPulsar.Internal
+{
+ using Abstractions;
+ using DotPulsar.Abstractions;
+ using DotPulsar.Exceptions;
+ using Events;
+ using Microsoft.Extensions.ObjectPool;
+ using PulsarApi;
+ using System;
+ using System.Collections.Generic;
+ using System.Linq;
+ using System.Runtime.CompilerServices;
+ using System.Threading;
+ using System.Threading.Tasks;
+
+ public sealed class MessageQueue : IMessageQueue,
IDequeue<MessagePackage>, IDisposable
+ {
+ private readonly AsyncQueue<MessagePackage> _queue;
+ private readonly IUnackedMessageTracker _tracker;
+ public MessageQueue(AsyncQueue<MessagePackage> queue,
IUnackedMessageTracker tracker)
+ {
+ _queue = queue;
+ _tracker = tracker;
+ }
+ public async ValueTask<MessagePackage> Dequeue(CancellationToken
cancellationToken = default)
+ {
+ var message = await
_queue.Dequeue(cancellationToken).ConfigureAwait(false);
+ _tracker.Add(new MessageId(message.MessageId));
+ return message;
+ }
+ public void Acknowledge(MessageId obj) => _tracker.Ack(obj);
+
+ public void NegativeAcknowledge(MessageId obj)
+ {
+ throw new NotImplementedException();
+ }
+
+ public void Dispose()
+ {
+ _queue.Dispose();
+ _tracker.Dispose();
+ }
+
Review comment:
Done 2edfa35
##########
File path: src/DotPulsar/Internal/MessageQueue.cs
##########
@@ -0,0 +1,45 @@
+namespace DotPulsar.Internal
+{
+ using Abstractions;
+ using DotPulsar.Abstractions;
+ using DotPulsar.Exceptions;
+ using Events;
+ using Microsoft.Extensions.ObjectPool;
+ using PulsarApi;
+ using System;
+ using System.Collections.Generic;
+ using System.Linq;
+ using System.Runtime.CompilerServices;
+ using System.Threading;
+ using System.Threading.Tasks;
+
+ public sealed class MessageQueue : IMessageQueue,
IDequeue<MessagePackage>, IDisposable
+ {
+ private readonly AsyncQueue<MessagePackage> _queue;
+ private readonly IUnackedMessageTracker _tracker;
+ public MessageQueue(AsyncQueue<MessagePackage> queue,
IUnackedMessageTracker tracker)
+ {
+ _queue = queue;
+ _tracker = tracker;
+ }
+ public async ValueTask<MessagePackage> Dequeue(CancellationToken
cancellationToken = default)
+ {
+ var message = await
_queue.Dequeue(cancellationToken).ConfigureAwait(false);
+ _tracker.Add(new MessageId(message.MessageId));
+ return message;
+ }
+ public void Acknowledge(MessageId obj) => _tracker.Ack(obj);
+
+ public void NegativeAcknowledge(MessageId obj)
+ {
+ throw new NotImplementedException();
+ }
+
+ public void Dispose()
+ {
+ _queue.Dispose();
+ _tracker.Dispose();
+ }
+
+ }
+}
Review comment:
Done 2edfa35
##########
File path: src/DotPulsar/Internal/MessageQueue.cs
##########
@@ -0,0 +1,45 @@
+namespace DotPulsar.Internal
+{
+ using Abstractions;
+ using DotPulsar.Abstractions;
+ using DotPulsar.Exceptions;
+ using Events;
+ using Microsoft.Extensions.ObjectPool;
+ using PulsarApi;
+ using System;
+ using System.Collections.Generic;
+ using System.Linq;
+ using System.Runtime.CompilerServices;
+ using System.Threading;
+ using System.Threading.Tasks;
+
+ public sealed class MessageQueue : IMessageQueue,
IDequeue<MessagePackage>, IDisposable
+ {
+ private readonly AsyncQueue<MessagePackage> _queue;
+ private readonly IUnackedMessageTracker _tracker;
+ public MessageQueue(AsyncQueue<MessagePackage> queue,
IUnackedMessageTracker tracker)
+ {
+ _queue = queue;
+ _tracker = tracker;
+ }
+ public async ValueTask<MessagePackage> Dequeue(CancellationToken
cancellationToken = default)
+ {
+ var message = await
_queue.Dequeue(cancellationToken).ConfigureAwait(false);
+ _tracker.Add(new MessageId(message.MessageId));
+ return message;
+ }
+ public void Acknowledge(MessageId obj) => _tracker.Ack(obj);
Review comment:
Done 2edfa35
##########
File path: src/DotPulsar/Internal/MessageQueue.cs
##########
@@ -0,0 +1,45 @@
+namespace DotPulsar.Internal
+{
+ using Abstractions;
+ using DotPulsar.Abstractions;
+ using DotPulsar.Exceptions;
+ using Events;
+ using Microsoft.Extensions.ObjectPool;
+ using PulsarApi;
+ using System;
+ using System.Collections.Generic;
+ using System.Linq;
+ using System.Runtime.CompilerServices;
+ using System.Threading;
+ using System.Threading.Tasks;
+
+ public sealed class MessageQueue : IMessageQueue,
IDequeue<MessagePackage>, IDisposable
+ {
+ private readonly AsyncQueue<MessagePackage> _queue;
+ private readonly IUnackedMessageTracker _tracker;
+ public MessageQueue(AsyncQueue<MessagePackage> queue,
IUnackedMessageTracker tracker)
Review comment:
Done 2edfa35
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
