jlolling commented on PR #600:
URL: https://github.com/apache/poi/pull/600#issuecomment-1966028389
Hi,
There was a code breaking changes in the past! This class is not really a
typical class for direct public usage.
On the other side we get a huge enhancement by using the streaming
jlolling commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504239250
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1798,7 +1814,7 @@ public CellRange removeArrayFormula(Cell
cell) {
// corrupted .x
jlolling commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504238538
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -205,6 +206,10 @@ public void removeRow(Row row) {
return;
}
jlolling commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504240541
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -166,11 +167,11 @@ public SXSSFRow createRow(int rownum) {
"in t
jlolling commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504242635
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1373,33 +1389,33 @@ public void ungroupRow(int fromRow, int toRow) {
*
* Not imp
jlolling commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504241527
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1264,11 +1275,11 @@ public void setColumnGroupCollapsed(int columnNumber,
boolean collapsed
jlolling commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504244871
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -215,8 +220,13 @@ public void removeRow(Row row) {
* @return Row representing the rownu
pjfanning commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504252267
##
build.gradle:
##
@@ -100,7 +100,7 @@ allprojects {
//apply plugin: 'eclipse'
apply plugin: 'idea'
-version = '5.2.5-SNAPSHOT'
Review Comment:
why can
pjfanning commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504254481
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -215,8 +216,13 @@ public void removeRow(Row row) {
* @return Row representing the rown
pjfanning commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504255495
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -215,8 +220,13 @@ public void removeRow(Row row) {
* @return Row representing the rown
jlolling commented on PR #600:
URL: https://github.com/apache/poi/pull/600#issuecomment-1966580238
Sorry, I need to build the lib for my own and changed the version number.
That’s why I have changed the number back. It was not my intention to interfere
your versioning.
> On 27. Feb 2
jlolling commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504257169
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -215,8 +216,13 @@ public void removeRow(Row row) {
* @return Row representing the rownu
pjfanning commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504257293
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1375,7 +1387,7 @@ public void ungroupRow(int fromRow, int toRow) {
*
* @param r
pjfanning commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504259482
##
poi-scratchpad/bin/.gitignore:
##
@@ -0,0 +1,2 @@
+/main/
+/test/
Review Comment:
all these gitignore changes should be removed - you can update your own user
.giti
pjfanning commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504261183
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1431,12 +1443,12 @@ private int findStartOfRowOutlineGroup(int rowIndex) {
private i
jlolling commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504262430
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1375,7 +1387,7 @@ public void ungroupRow(int fromRow, int toRow) {
*
* @param ro
jlolling commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504275708
##
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##
@@ -1431,12 +1443,12 @@ private int findStartOfRowOutlineGroup(int rowIndex) {
private in
pjfanning commented on PR #600:
URL: https://github.com/apache/poi/pull/600#issuecomment-1967624492
@jlolling can we pause this PR for a few days? I'm concerned that we have no
justification for this change - no use case defined by you - no test cases for
us to think through.
The cod
jlolling commented on PR #600:
URL: https://github.com/apache/poi/pull/600#issuecomment-1967691951
Hi pjfanning,
yes of course. It is not my intention to gain all attention. I will write
testcases and will explain better what is my intention for this change.
Best regards
Jan
19 matches
Mail list logo
