jlolling commented on code in PR #600:
URL: https://github.com/apache/poi/pull/600#discussion_r1504241527
##########
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##########
@@ -1264,11 +1275,11 @@ public void setColumnGroupCollapsed(int columnNumber,
boolean collapsed) {
*/
@Override
public void groupColumn(int fromColumn, int toColumn) {
- _sh.groupColumn(fromColumn, toColumn);
+ _sh.groupColumn(fromColumn,toColumn);
}
/**
- * Ungroup a range of columns that were previously grouped
+ * Ungroup a range of columns that were previously groupped
Review Comment:
sorry, have reverted it
##########
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##########
@@ -1344,21 +1357,24 @@ public void groupRow(int fromRow, int toRow) {
public void setRowOutlineLevel(int rownum, int level) {
SXSSFRow row = _rows.get(rownum);
row.setOutlineLevel(level);
- setWorksheetOutlineLevelRowIfNecessary((short)
Math.min(Short.MAX_VALUE, level));
+ if(level > 0 && level > outlineLevelRow) {
+ outlineLevelRow = level;
+ setWorksheetOutlineLevelRow();
+ }
}
- private void setWorksheetOutlineLevelRowIfNecessary(final short levelRow) {
+ private void setWorksheetOutlineLevelRow() {
CTWorksheet ct = _sh.getCTWorksheet();
CTSheetFormatPr pr = ct.isSetSheetFormatPr() ?
ct.getSheetFormatPr() :
ct.addNewSheetFormatPr();
- if(levelRow > _sh.getSheetFormatPrOutlineLevelRow()) {
- pr.setOutlineLevelRow(levelRow);
+ if(outlineLevelRow > 0) {
+ pr.setOutlineLevelRow((short)outlineLevelRow);
}
}
/**
- * Ungroup a range of rows that were previously grouped
+ * Ungroup a range of rows that were previously groupped
Review Comment:
sorry, have reverted it
##########
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFSheet.java:
##########
@@ -1373,33 +1389,33 @@ public void ungroupRow(int fromRow, int toRow) {
*
* <i>Not implemented for expanding (i.e. collapse == false)</i>
*
- * @param row start row of a grouped range of rows (0-based)
+ * @param row start row of a groupped range of rows (0-based)
Review Comment:
sorry, have reverted it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
