jlolling commented on PR #600: URL: https://github.com/apache/poi/pull/600#issuecomment-1966028389
Hi, There was a code breaking changes in the past! This class is not really a typical class for direct public usage. On the other side we get a huge enhancement by using the streaming workbook also in a use case where the workbook is not created from scratch and can be appended. I will write a test, this is a reasonable request. Best regards Jan Lolling > On 26. Feb 2024, at 17:57, PJ Fanning ***@***.***> wrote: > > > Changing the return type of getRow() could break user code as it is a public method in a public class, so I think this can not be approved as it is now. > > IMHO, we also need a junit test for this that tests the new functionality. > > There are also a couple of other things to clean up, like spelling errors introduced by the PR and directly throwing RuntimeException. I think we should not throw RuntimeException in any of these cases. I don't know if the other committers agree with the exception changes that I have proposed instead. > > if there is no test - then we shouldn't merge > > — > Reply to this email directly, view it on GitHub <https://github.com/apache/poi/pull/600#issuecomment-1964646892>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5KS7MWJVYN57H5TIPNGGDYVS5I3AVCNFSM6AAAAABD2LJQK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUGY2DMOBZGI>. > You are receiving this because you authored the thread. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
