Re: please double-check commit message when merging PRs

2023-11-24 Thread Ayush Saxena
There is a standard way of setting co-authors in github mentioned over here [1], We should use that to credit the co-authors, If we use that the co-authors github profile will show that as a contribution & everywhere on github I believe, just not when you use git log --author Attila, If that soun

Re: please double-check commit message when merging PRs

2023-11-23 Thread Sammi Chen
Attila, I'm not proposing to add "Contributed by" to the Ozone commit title. What I mean is if there is a co-author, then add something like "Co-authored-by:" to the commit title. For example, say HDDS-1 is developed mainly by UserA, but there is another contributor UserB who has minor contri

Re: please double-check commit message when merging PRs

2023-11-23 Thread Attila Doroszlai
Hi Sammi, > As for the co-author, what about manually adding it to the title? like this > "Contributed" message > > *HDFS-17086. Fix the parameter settings in > TestDiskspaceQuotaUpdate#updateCountForQuota (#5842). Contributed by > Haiyang Hu.* In your example "Contributed by" indicates the singl

Re: please double-check commit message when merging PRs

2023-11-22 Thread Sammi Chen
Attila, Thanks for raising this attention. It would be good if there is a policy to prevent commit unnecessary long commit history. As for the co-author, what about manually adding it to the title? like this "Contributed" message *HDFS-17086. Fix the parameter settings in TestDiskspaceQuotaUpdat

Re: please double-check commit message when merging PRs

2023-11-22 Thread Attila Doroszlai
> The default message uses the commit title and message if the pull request > contains only 1 commit, or the pull request title and list of commits if > the pull request contains 2 or more commits. You can also choose to use > just the pull request title, the pull request title and commit details,

Re: please double-check commit message when merging PRs

2023-06-10 Thread Ayush Saxena
Hi Attila, Thanx for flagging this, makes sense to me. Following the Github Doc that you shared, reached here [1] The 4th point here: ---> Optionally, under Allow squash merging, select the dropdown menu, then click the format of the default squash commit message presented to contributors when mer

please double-check commit message when merging PRs

2023-06-10 Thread Attila Doroszlai
Hi committers and future committers, Please be careful when merging PRs. Github's default behavior [1] of composing the commit message may not be the best for our purposes. 1. If the PR has a single commit, Github defaults to using the commit's message instead of the PR title. Jira ID might be