There is a standard way of setting co-authors in github mentioned over here [1], We should use that to credit the co-authors, If we use that the co-authors github profile will show that as a contribution & everywhere on github I believe, just not when you use git log --author <User B>
Attila, If that sounds cool, we can call for a vote & if people agree we can go for it -Ayush [1] https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors On Thu, 23 Nov 2023 at 18:30, Sammi Chen <sammic...@apache.org> wrote: > > Attila, > > I'm not proposing to add "Contributed by" to the Ozone commit title. > What I mean is if there is a co-author, then add something like > "Co-authored-by:" to the commit title. > > For example, say HDDS-10000 is developed mainly by UserA, but there is > another contributor UserB who has minor contribution to the JIRA. Then > > Author: UserA's email > AuthorDate: Nov 15 14:30:07 2023 +0800 > Commit: GitHub <nore...@github.com> > CommitDate: Nov 16 12:00:07 2023 +0530 > > HDDS-10000. Support tiered storage (#6000). Co-authorized by UserB. > > For other commits which only have one contributor, then just use the title. > I think it's kind of the same as what you are thinking. > > Sammi > > On Thu, 23 Nov 2023 at 19:23, Attila Doroszlai <adorosz...@apache.org> > wrote: > > > Hi Sammi, > > > > > As for the co-author, what about manually adding it to the title? like > > this > > > "Contributed" message > > > > > > *HDFS-17086. Fix the parameter settings in > > > TestDiskspaceQuotaUpdate#updateCountForQuota (#5842). Contributed by > > > Haiyang Hu.* > > > > In your example "Contributed by" indicates the single author of the > > change, there are no co-authors. > > > > Author: huhaiyang <...> > > AuthorDate: Sat Jul 15 14:30:07 2023 +0800 > > Commit: GitHub <nore...@github.com> > > CommitDate: Sat Jul 15 12:00:07 2023 +0530 > > > > HDFS-17086. Fix the parameter settings in > > TestDiskspaceQuotaUpdate#updateCountForQuota (#5842). Contributed by > > Haiyang Hu. > > > > Reviewed-by: Shilun Fan <...> > > Signed-off-by: Ayush Saxena <...> > > > > > > If we were to add co-authors to the commit title, we would have to add > > the main author, too. For every commit. Manually. (Otherwise > > co-authors would get more "exposure" than the main author.) > > > > I think that would only introduce problems: > > > > 1. another item we need to remember when merging PRs > > 2. makes commit message longer; even longer for multi-author commits > > > > I think using structured header-like items (`Co-authored-by:`, etc.), > > only when necessary, is much better. > > > > -Attila > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org > > For additional commands, e-mail: dev-h...@ozone.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
