Hi Sammi,

> As for the co-author, what about manually adding it to the title? like this
> "Contributed" message
>
> *HDFS-17086. Fix the parameter settings in
> TestDiskspaceQuotaUpdate#updateCountForQuota (#5842). Contributed by
> Haiyang Hu.*

In your example "Contributed by" indicates the single author of the
change, there are no co-authors.

Author:     huhaiyang <...>
AuthorDate: Sat Jul 15 14:30:07 2023 +0800
Commit:     GitHub <nore...@github.com>
CommitDate: Sat Jul 15 12:00:07 2023 +0530

    HDFS-17086. Fix the parameter settings in
TestDiskspaceQuotaUpdate#updateCountForQuota (#5842). Contributed by
Haiyang Hu.

    Reviewed-by: Shilun Fan <...>
    Signed-off-by: Ayush Saxena <...>


If we were to add co-authors to the commit title, we would have to add
the main author, too.  For every commit.  Manually.  (Otherwise
co-authors would get more "exposure" than the main author.)

I think that would only introduce problems:

1. another item we need to remember when merging PRs
2. makes commit message longer; even longer for multi-author commits

I think using structured header-like items (`Co-authored-by:`, etc.),
only when necessary, is much better.

-Attila

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For additional commands, e-mail: dev-h...@ozone.apache.org

Reply via email to