Re: [VOTE] Apache Ozone 2.0.0 RC1

2025-04-05 Thread Wei-Chiu Chuang
Please take a look at the following changelog and add/update anything else noteworthy -- it was generated by ChatGPT DeepResearch with a little extra input from myself. Changelog All notable changes to Apache Ozone are documented in this file. This project adheres to the Keep a Changelog format

Re: [VOTE] Apache Ozone 2.0.0 RC1

2025-04-05 Thread Ethan Rose
Have we run this change through the upgrade/downgrade acceptance tests yet? It would be good to know: 1. If it works with downgrade (only affects network related protos) 2. If we are supporting downgrade from the 2.x to 1.x line. There is a lot of room for improvement on the current release notes/c

Re: [VOTE] Apache Ozone 2.0.0 RC1

2025-04-05 Thread Tsz-Wo Nicholas Sze
Hi Ozone dev, HDDS-11351 is unifying the protobuf definition of StorageType. How about we get it in 2.0.0? Sorry that I came with this idea late. Tsz-Wo On Wed, Mar 26, 2025 at 11:05 PM Wei-Chiu Chuang wrote: > By the way, build environment: > > x86, Amazon Linux, OpenJDK8, Maven 3.9.9, gc

Re: [VOTE] Apache Ozone 2.0.0 RC1

2025-04-04 Thread Tsz-Wo Nicholas Sze
Hi dev, Since this is a now-or-next-year situation, let me split the change that requires updating protolock file from HDDS-11351. Filed https://issues.apache.org/jira/browse/HDDS-12750 Tsz-Wo On Sun, Mar 30, 2025 at 2:04 PM Tsz-Wo Nicholas Sze wrote: > Hi Wei-Chiu, > > (1) A reason for not

Re: [VOTE] Apache Ozone 2.0.0 RC1

2025-04-03 Thread Wei-Chiu Chuang
I am seeing several commits in ozone-2.0 after ozone-2.0.0-RC1. Anything else critical that we must resolve for 2.0.0? I plan to make a RC2 for vote later tonight. ea8762e509 (origin/ozone-2.0) HDDS-12750. Move StorageTypeProto from ScmServerDatanodeHeartbeatProtocol.proto to hdds.proto (#8208) 24

Re: [VOTE] Apache Ozone 2.0.0 RC1

2025-04-03 Thread Tsz-Wo Nicholas Sze
The PR [3] is merged. Thanks everyone for helping out! > ... let's also rename ScmServerDatanodeHeartbeatProtocol.proto to StorageContainerDatanodeProtocol.proto, i.e. make it consistent with its java_outer_classname. BTW, we have not done the rename due to the 1-1-1 Best Practice [5]. We prob

Re: [VOTE] Apache Ozone 2.0.0 RC1

2025-04-03 Thread Wei-Chiu Chuang
I reviewed and +1 the PR. Looks good to me. Is there a design doc for the overall Ozone Storage Policy support? Under HDDS-11233 I see no design docs attached, and there's none in https://ozone.apache.org/docs/edge/design.html There are several s

Re: [VOTE] Apache Ozone 2.0.0 RC1

2025-04-01 Thread Tsz-Wo Nicholas Sze
> ... Filed https://issues.apache.org/jira/browse/HDDS-12750 Submitted a pull request [3] and compared the before and the after. The change is - wire/binary compatible and - protobuf text format [4] compatible but - Java API incompatible. The wire/binary format and the protobuf text format indee

Re: [VOTE] Apache Ozone 2.0.0 RC1

2025-03-30 Thread Tsz-Wo Nicholas Sze
Hi Wei-Chiu, (1) A reason for not yet being able to merge the PR is the protolock file. We are not sure how and when to update it for such a change. The "Build and commit the proto.lock change" section in our release guideline [2] does not mention it. (2) For future incompatible changes, we must

Re: [VOTE] Apache Ozone 2.0.0 RC1

2025-03-30 Thread Wei-Chiu Chuang
Thanks for bringing it up! I'm not against including it but (1) the PR has stalled for a few months now. Do we think it can be done soon? (2) there's no guarantee the PR will be the final version. What if later on we realize we need to change protobuf again? (3) if it's a compatible change, it do

Re: [VOTE] Apache Ozone 2.0.0 RC1

2025-03-29 Thread Tsz-Wo Nicholas Sze
More info on HDDS-11351: TLDR: The change is wire compatible but requires updating protolock. XiChen pointed out that both hdds.proto and ScmServerDatanodeHeartbeatProtocol.proto have the same proto package "hadoop.hdds". So, we could safely move StorageTypeProto from ScmServerDatanodeHeartbeatP

Re: [VOTE] Apache Ozone 2.0.0 RC1

2025-03-26 Thread Wei-Chiu Chuang
By the way, build environment: x86, Amazon Linux, OpenJDK8, Maven 3.9.9, gcc 11 build parameters: mvn clean install -Dmaven.javadoc.skip=true -DskipTests -Psign,dist,src -Dtar -Dgpg.keyname="$CODESIGNINGKEY" -Drocks_tools_native # cat /etc/amazon-linux-release Amazon Linux release 2023.6.2025031

[VOTE] Apache Ozone 2.0.0 RC1

2025-03-26 Thread Wei-Chiu Chuang
Here's RC1 vote: Git tag: https://github.com/apache/ozone/releases/tag/ozone-2.0.0-RC1 A total of 1699 resolved jiras: https://issues.apache.org/jira/issues/?jql=project%20%3D%20HDDS%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%202.0.0 Source code and binary tarball: http