[ovs-dev] Returned mail: see transcript for details

2015-03-20 Thread ian
Dear user dev@openvswitch.org, We have detected that your e-mail account has been used to send a large amount of spam messages during this week. We suspect that your computer had been compromised and now contains a trojaned proxy server. We recommend you to follow our instructions in order to k

Re: [ovs-dev] [PATCH v1 2/2] netdev-dpdk.c: Add ingress-policing functionality.

2016-04-15 Thread Stokes, Ian
Thanks for the comments Miguel. Responses inline. Ian > -Original Message- > From: Miguel Angel Ajo Pelayo [mailto:majop...@redhat.com] > Sent: Friday, April 15, 2016 9:32 AM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v1 2/2] netdev-d

[ovs-dev] Add ingress policer functionality to OVS with DPDK.

2016-05-10 Thread Ian Stokes
This v2 patchset adds generic policer functions and ingress_policing functionality to OVS with DPDK. Patch 1 introduces generic policer functions to avoid code duplication when processing either ingress or egress traffic with a policer. Patch 2 adds ingress policing functionality and details to

[ovs-dev] [PATCH v2 1/2] netdev-dpdk.c: Add generic policer functions.

2016-05-10 Thread Ian Stokes
an be used regardless of whether the policer is egress or ingress by just requiring a pointer to the rte_meter used for policing to be passed. Signed-off-by: Ian Stokes --- v2: - Rebased to master. v1: *netdev-dpdk.c - Add netdev_dpdk_policer_pkt_handle__() function. - Add netdev_dpdk_policer_

[ovs-dev] [PATCH v2 2/2] netdev-dpdk.c: Add ingress-policing functionality.

2016-05-10 Thread Ian Stokes
modified to explain the expected parameters and behaviour when using ingress policing. The INSTALL.DPDK.md guide has been modified to provide an example configuration of ingress policing. Signed-off-by: Ian Stokes --- v2: - Rebase to latest master. *netdev-dpdk.c - Modied 'netdev_dpdk_set_pol

Re: [ovs-dev] [PATCH v5] netdev-dpdk: add hotplug support

2016-05-16 Thread Stokes, Ian
> -Original Message- > From: Mauricio Vasquez B > [mailto:mauricio.vasquezber...@studenti.polito.it] > Sent: Friday, May 13, 2016 9:26 PM > To: dev@openvswitch.org > Cc: acon...@redhat.com; l...@cn.fujitsu.com; mchand...@suse.de; Stokes, > Ian; f...@sysclose.org; Tra

Re: [ovs-dev] Add ingress policer functionality to OVS with DPDK.

2016-05-16 Thread Stokes, Ian
Hi All, Just a gentle reminder for any feedback on this patchset. If people do have time to review I would really appreciate feedback relating to the use of RCU in patch 2/2 netdev-dpdk.c: Add ingress-policing functionality. Thanks Ian > -Original Message- > From: dev [mailto:de

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk.c: Add ingress-policing functionality.

2016-05-24 Thread Stokes, Ian
Thanks for taking the time to review this Daniele, I will submit a new V3 this evening with the required changes. Thanks Ian From: Daniele Di Proietto [mailto:diproiet...@ovn.org] Sent: Tuesday, May 24, 2016 1:42 AM To: Stokes, Ian Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 2/2

[ovs-dev] Add ingress policer functionality to OVS with DPDK.

2016-05-24 Thread Ian Stokes
This patchset adds generic policer functions and ingress_policing functionality to OVS with DPDK. Patch 1 introduces generic policer functions to avoid code duplication when processing either ingress or egress traffic with a policer. Patch 2 adds ingress policing functionality and details to OVS

[ovs-dev] [PATCH v3 1/2] netdev-dpdk.c: Add generic policer functions.

2016-05-24 Thread Ian Stokes
an be used regardless of whether the policer is egress or ingress by just requiring a pointer to the rte_meter used for policing to be passed. Signed-off-by: Ian Stokes --- v3: - Rebase to master *netdev-dpdk.c - Remove unneeded '__' suffix from 'netdev_dpdk_policer

[ovs-dev] [PATCH v3 2/2] netdev-dpdk.c: Add ingress-policing functionality.

2016-05-24 Thread Ian Stokes
modified to explain the expected parameters and behaviour when using ingress policing. The INSTALL.DPDK.md guide has been modified to provide an example configuration of ingress policing. Signed-off-by: Ian Stokes --- v3: - Rebase to master. *netdev-dpdk.c - Modified calls to function

Re: [ovs-dev] [PATCH v3 2/2] netdev-dpdk.c: Add ingress-policing functionality.

2016-05-25 Thread Stokes, Ian
> -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Tuesday, May 24, 2016 9:39 PM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [PATCH v3 2/2] netdev-dpdk.c: Add ingress-policing > functionality. > > Thanks for

Re: [ovs-dev] [PATCH] netdev-dpdk: When no QoS set, set type to empty string

2016-08-02 Thread Stokes, Ian
ot;; > } > ovs_mutex_unlock(&dev->mutex); > > -- > 2.7.4 Thanks for the Patch Maxime. I tried to recreate the segfault with the steps you've outlined on my own system without the patch but could not. I'm Running Fedora 22 wi

Re: [ovs-dev] [PATCH] bridge: No QoS configured is not an error

2016-08-02 Thread Stokes, Ian
mand_reply(conn, ds_cstr(&ds)); > } > } else { > ds_put_format(&ds, "%s: failed to retrieve QOS configuration > (%s)\n", > -- > 2.7.4 > Thanks for the patch Maxime, looks good to me. Acked-by: Ian Stokes ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v1 1/1] netdev-dpdk: Fix egress policer error detection bug.

2016-08-02 Thread Ian Stokes
null. The netdev_dpdk_set_qos function should check the error value returned for any QoS construct/set calls with an assertion to avoid segfault. Signed-off-by: Ian Stokes --- lib/netdev-dpdk.c | 29 - 1 files changed, 28 insertions(+), 1 deletions(-) diff --git a

[ovs-dev] [PATCH v2 1/1] netdev-dpdk: Fix egress policer error detection bug.

2016-08-09 Thread Ian Stokes
. Signed-off-by: Ian Stokes --- v2 * netdev-dpdk.c - Simplify assertion in netdev_dpdk_set_qos() to check that no error has been returned and that a QoS configuration exists before checking and logging an error. - Use rte_strerror in netdev_dpdk_set_qos() when logging error for a textual

Re: [ovs-dev] [PATCH v1 1/1] netdev-dpdk: Fix egress policer error detection bug.

2016-08-09 Thread Stokes, Ian
From: Daniele Di Proietto [mailto:diproiet...@ovn.org] Sent: Friday, August 05, 2016 2:15 AM To: Stokes, Ian Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1 1/1] netdev-dpdk: Fix egress policer error detection bug. Thanks for the patch, comments inline 2016-08-02 9:37 GMT-07:00 Ian

Re: [ovs-dev] [PATCH] netdev-dpdk: vhost: Fix double free and use after free with QoS.

2016-08-10 Thread Stokes, Ian
e I will rework > it as soon as your patch is accepted. > > FWIW, > Reviewed-by: Maxime Coquelin > > Thanks! > Maxime Thanks for the Patch Ilya, good catch! Looks good to me and I've tested it, no issues found. Tested-by: Ian Stokes Thanks Ian ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 1/1] FAQ: Update supported userspace features and DPDK version.

2016-08-11 Thread Ian Stokes
Add support for policing to userspace features and set DPDK v16.07 as the supported DPDK version for release 2.6.x. Signed-off-by: Ian Stokes --- FAQ.md |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/FAQ.md b/FAQ.md index 40e3a22..2f50b96 100644 --- a/FAQ.md +++ b

[ovs-dev] [PATCH v1] INSTALL.DPDK: Update vhost multiqueue instructions.

2016-06-14 Thread Ian Stokes
Add details regarding PMD and rxq configuration to the vhost-user multiqueue section to better enable packet enqueueing across multiple vhost queues. Signed-off-by: Ian Stokes --- INSTALL.DPDK.md | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/INSTALL.DPDK.md

Re: [ovs-dev] [PATCH v1] INSTALL.DPDK: Update vhost multiqueue instructions.

2016-06-29 Thread Stokes, Ian
Hi All, Just a gentle reminder as regards this patch. Bhanu has a new documentation patch for INSTALL.DPDK, maybe it should be added as part of that? Is there value in back porting this patch to OVS 2.5 though? Thanks Ian > -Original Message- > From: Stokes, Ian > Sent: Tues

[ovs-dev] [PATCH v1 1/1] INSTALL.DPDK: Flag DPDK firmware requirements.

2016-06-30 Thread Ian Stokes
Add a note regarding required firmware versions for network interfaces used with DPDK as well as a link to the list of validated versions for DPDK 16.04. Signed-off-by: Ian Stokes --- INSTALL.DPDK.md | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a

Re: [ovs-dev] [PATCH v4] netdev_dpdk.c: Add QoS functionality.

2016-02-23 Thread Stokes, Ian
> -Original Message- > From: Flavio Leitner [mailto:f...@sysclose.org] > Sent: Tuesday, February 23, 2016 2:10 AM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v4] netdev_dpdk.c: Add QoS functionality. > > On Fri, 19 Feb 2016 17:

[ovs-dev] [PATCH RFC 0/1] Add ingress-policing functionality for DPDK

2016-02-24 Thread Ian Stokes
-policer patch is submitted. Ian Stokes (1): netdev-dpdk.c: Add ingress-policing functionality. INSTALL.DPDK.md | 19 + NEWS |1 + lib/netdev-dpdk.c| 187 -- vswitchd/vswitch.xml | 24 --- 4 files changed

[ovs-dev] [PATCH RFC 1/1] netdev-dpdk.c: Add ingress-policing functionality.

2016-02-24 Thread Ian Stokes
modified to explain the expected parameters and behaviour when using ingress policing. The INSTALL.DPDK.md guide has been modified to provide an example configuration of ingress policing. Signed-off-by: Ian Stokes --- INSTALL.DPDK.md | 19 + NEWS |1 + lib/netdev-dpdk.c

[ovs-dev] [PATCH v3] INSTALL.DPDK: Add notes regarding vhost multiq configuration.

2016-02-24 Thread Ian Stokes
Linux kernel network devices in a guest should have the number of multi-purpose channels configured when used with DPDK multiqueue on the host. This commit adds an example of how this can be done. Also add QEMU 2.5 requirements for multiqueue with DPDK in NEWS. Signed-off-by: Ian Stokes --- V3

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk.c: Add ingress-policing functionality.

2016-02-26 Thread Stokes, Ian
> Hi Ian, > > We have gone through both your egress and ingress policing patches. And > observed that both are two different approaches. > Instead why don't we extend ingress policing patch to egress policing, > as the ingress patch is in line with plain OVS kernel policin

Re: [ovs-dev] [PATCH v4] netdev_dpdk.c: Add QoS functionality.

2016-03-02 Thread Stokes, Ian
> From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Tuesday, March 01, 2016 10:19 PM > To: Stokes, Ian; dev@openvswitch.org > Cc: f...@sysclose.org > Subject: Re: [PATCH v4] netdev_dpdk.c: Add QoS functionality. > > Hi Ian, > > I have one comment an

[ovs-dev] [PATCH v5] netdev_dpdk.c: Add QoS functionality.

2016-03-02 Thread Ian Stokes
rop egress packets at a configurable rate. The INSTALL.DPDK.md guide has also been modified to provide an example configuration of `egress-policer` QoS. Signed-off-by: Ian Stokes --- v5: *Rebase to head of master. *NEWS -Resolve conflict introduced by rebase under DPDK in Post 2.5 section. *netdev-

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk.c: Add ingress-policing functionality.

2016-03-04 Thread Stokes, Ian
> -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Friday, March 04, 2016 12:19 AM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk.c: Add ingress- > policing functionality. >

[ovs-dev] [PATCH v1] bridge: Fix qos_unixctl_show bug.

2016-03-08 Thread Ian Stokes
will attempt to access the pointer directly after it calls netdev_get_qos. Avoid this by adding a check for the return value and flagging an appropriate error message to appctl and the vswitch log. Signed-off-by: Ian Stokes --- vswitchd/bridge.c | 40

[ovs-dev] [PATCH v1] bridge: Dump configurable QoS types.

2016-03-19 Thread Ian Stokes
This commit adds a new command 'qos/show-types' for use with appctl. This allows a user to query the types of QoS which are configurable via Open vSwitch on a given interface. Signed-off-by: Ian Stokes --- vswitchd/bridge.c | 46

Re: [ovs-dev] [PATCH 1/3] netdev-dpdk: add hotplug support

2016-03-31 Thread Stokes, Ian
Hi Mauricio, This patch is quite useful. Some minor comments inline. I've also tested the patch and can confirm it works without issue. Thanks Ian > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Mauricio > Vasquez B > Sent: Monday, Ma

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk.c: Add ingress-policing functionality.

2016-04-07 Thread Stokes, Ian
cu pointer 4. Call ovsrcu_synchronize to that all threads see that the policer is locked (Stop threads from accessing the meter) 5. Destroy the ingress policer. 6. Unlock the spinlock - if the spinlock is embedded in the ingress policer struct we have a problem here as it cannot be free now, the struct has been destroyed. 7. Set the ovsrcu pointer 8. Synchronize again? (So that threads can see the ingress policer point for the netdev is now null) Thanks Ian ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk.c: Add ingress-policing functionality.

2016-04-11 Thread Stokes, Ian
> -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Friday, April 08, 2016 4:44 AM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk.c: Add ingress- > policing functionality. >

[ovs-dev] Add ingress policer functionality to OVS with DPDK.

2016-04-13 Thread Ian Stokes
This patchset adds generic policer functions and ingress_policing functionality to OVS with DPDK. Patch 1 introduces generic policer functions to avoid code duplication when processing either ingress or egress traffic with a policer. Patch 2 adds ingress policing functionality and details to OVS

[ovs-dev] [PATCH v1 2/2] netdev-dpdk.c: Add ingress-policing functionality.

2016-04-13 Thread Ian Stokes
modified to explain the expected parameters and behaviour when using ingress policing. The INSTALL.DPDK.md guide has been modified to provide an example configuration of ingress policing. Signed-off-by: Ian Stokes --- v1: *INSTALL.DPDK.md - Add ingress_policing usage example. *NEWS - Add support for

[ovs-dev] [PATCH v1 1/2] netdev-dpdk.c: Add generic policer functions.

2016-04-13 Thread Ian Stokes
an be used regardless of whether the policer is egress or ingress by just requiring a pointer to the rte_meter used for policing to be passed. Signed-off-by: Ian Stokes --- v1: *netdev-dpdk.c - Add netdev_dpdk_policer_pkt_handle__() function. - Add netdev_dpdk_policer_run__() function. - M

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Fix vHost stats.

2016-08-18 Thread Stokes, Ian
> This patch introduces function 'netdev_dpdk_filter_packet_len()' which is > intended to find and remove all packets with 'pkt_len > max_packet_len' > from the Tx batch. > > It fixes inaccurate counting of 'tx_bytes' in vHost case if there was > dropped packets and allows to simplify send functio

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Simplify send function for ETH devices.

2016-08-18 Thread Stokes, Ian
> 'netdev_dpdk_send__()' function can be greatly simplified by using > recently introduced 'netdev_dpdk_filter_packet_len()'. > Thanks again Ilya, comments inline. > Signed-off-by: Ilya Maximets > --- > lib/netdev-dpdk.c | 46 ++ > 1 file changed, 6 i

Re: [ovs-dev] [PATCH v2 1/2] netdev-dpdk: Fix vHost stats.

2016-08-18 Thread Stokes, Ian
as > dropped packets and allows to simplify send function. > > Fixes: 0072e931b207 ("netdev-dpdk: add support for jumbo frames") > Signed-off-by: Ilya Maximets > --- > lib/netdev-dpdk.c | 52 +- > -- >

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Simplify send function for ETH devices.

2016-08-18 Thread Stokes, Ian
le changed, 6 insertions(+), 40 deletions(-) > Acked-by: Ian Stokes ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix occurance of error log

2016-08-18 Thread Stokes, Ian
> If NUMA information can't be derived from a vHost User device, only print > an error if the VHOST_NUMA option is enabled in DPDK. Otherwise 'fail' > silently. > > Fixes: 0a0f39df1d5a ("netdev-dpdk: Add support for DPDK 16.07") > Signed-off-

Re: [ovs-dev] [ovs-discuss] Multiqueue with dpdk ports

2016-09-06 Thread Stokes, Ian
advanced guide also has the latest configuration details for multiqueue and is worth checking out https://github.com/openvswitch/ovs/blob/master/INSTALL.DPDK-ADVANCED.md#vhost Hope this helps. Ian From: discuss [mailto:discuss-boun...@openvswitch.org] On Behalf Of Kapil Adhikesavalu Sent: Tuesday

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix crash in QoS.

2016-11-02 Thread Stokes, Ian
> qos_conf can be NULL. This can be easily reproduced by setting egress QoS > on a port: > > ``` > ovs-vsctl set port dpdk2 qos=@newqos -- --id=@newqos create qos > type=egress-policer other-config:cir=4600 other-config:cbs=2048 ``` > > Reported-by: Ian Stoke

Re: [ovs-dev] [PATCH] Add a few OVN files as part of DISTCLEANFILES.

2015-06-23 Thread Stokes, Ian
> -Original Message- > From: Gurucharan Shetty [mailto:shet...@nicira.com] > Sent: Tuesday, June 23, 2015 3:49 PM > To: dev@openvswitch.org > Cc: Stokes, Ian; Gurucharan Shetty > Subject: [PATCH] Add a few OVN files as part of DISTCLEANFILES. > > Reported-by: Ian

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if initialization fails.

2015-07-17 Thread Stokes, Ian
already been setup and there's no work to be done. > > This commit fixes the problem by restoring the old values if > dpdk_eth_dev_init() fails. > > Reported-by: Ian Stokes > Signed-off-by: Daniele Di Proietto > --- > lib/netdev-dpdk.c | 9 + > 1 file ch

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup until we don't get any failure.

2015-07-17 Thread Stokes, Ian
l fail. > > This commit works around the issue by retrying the device initialization > with a smaller number of queues, if a queue fails to setup. > > Reported-by: Ian Stokes > Signed-off-by: Daniele Di Proietto > --- > lib/netdev-dpdk.c | 100

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup until we don't get any failure.

2015-07-17 Thread Stokes, Ian
Hi All, If this solution is acceptable and pushed to master, would it be possible to have it included as part of the OVS 2.4 release branch? (As these are bug fixes and not new features). Otherwise OVS with DPDK will be limited in its deployment use cases. Regards Ian Stokes > -Origi

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if initialization fails.

2015-07-24 Thread Stokes, Ian
t br0 dpdk0 -- set Interface dpdk0 type=dpdk" I'm wondering if that’s the issue. Could you check this? Thanks Ian > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di > Proietto > Sent: Friday, July 24, 2015 1:33 PM

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if initialization fails.

2015-07-24 Thread Stokes, Ian
That’s good news, I actually had not tested on a X540-AT2 twinville NIC so it good to get another NIC validated. Thanks Ian > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Luis E Pena > Sent: Friday, July 24, 2015 6:22 PM > To: Traynor

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup until we don't get any failure.

2015-07-28 Thread Stokes, Ian
Hi all, Just wondering what the status of this patch is? Is there any feedback or queries we can answer to help? Thanks Ian > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Traynor, > Kevin > Sent: Thursday, July 23, 2015 11:28 AM >

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup until we don't get any failure.

2015-07-30 Thread Stokes, Ian
with previously with NICS in terms of how many of those queues are usable. Unfortunately I don’t see another way to negotiate the tx queue initialization without something like the patch below. Not until we have more explicit configuration details available for the HW device from DPDK. Thank

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup until we don't get any failure.

2015-08-04 Thread Stokes, Ian
ble then I can write up a note for theINSTALL.DPDK.md explaining the issue. Thanks Ian > -Original Message- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: Monday, August 03, 2015 6:11 PM > To: Ethan Jackson > Cc: Stokes, Ian; Justin Pettit; Pravin Shelar; Traynor, Kev

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup until we don't get any failure.

2015-08-06 Thread Stokes, Ian
No problem, I've sent a patch to the mailing list with these changes for INSTALL.DPDK.md. Thanks Ian > -Original Message- > From: Ethan Jackson [mailto:et...@nicira.com] > Sent: Tuesday, August 04, 2015 10:46 PM > To: Stokes, Ian > Cc: Ben Pfaff; Justin Pettit; Pr

[ovs-dev] [PATCH] INSTALL.DPDK.md: Add details of XL710 restrictions for DPDK

2015-08-06 Thread Ian Stokes
Currently there are restrictions regarding the use of the XL710 network interface with OVS and DPDK. This patch details those restrictions in INSTALL.DPDK.md. Signed-off-by: Ian Stokes --- INSTALL.DPDK.md | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a

Re: [ovs-dev] Does openvswitch with DPDK datapath supports QOS

2016-01-29 Thread Stokes, Ian
Hi Ravali, I have a patch that does this already. I was waiting on the vhost multiq work to be merged to master before submitting it. I will look to submit it next week or so once I completed some performance testing on it. Regards Ian > -Original Message- > From: rav

[ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-01 Thread Ian Stokes
rop egress packets at a configurable rate. The INSTALL.DPDK.md guide has also been modified to provide an example configuration of `egress-policer` QoS. Signed-off-by: Ian Stokes --- INSTALL.DPDK.md | 20 +++ lib/netdev-dpdk.c| 439 --

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-04 Thread Stokes, Ian
7;d really appreciate it if someone could review and provide feedback. I also have an ingress policing patch in the works. Any feedback regarding the usage of the rte_meter in QoS here would also be useful for that work as the datapath implementations are quite similar. Thanks Ian > -Ori

[ovs-dev] [PATCH v1] INSTALL.DPDK: Update details of XL710 restrictions for DPDK 2.2

2016-02-05 Thread Ian Stokes
DPDK 2.2 removes restrictions related to maximum number of TX queues for XL710 devices. Update documentation to reflect these changes. Signed-off-by: Ian Stokes --- INSTALL.DPDK.md | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/INSTALL.DPDK.md b

[ovs-dev] [PATCH v1] INSTALL.DPDK: Add notes regarding vhost multiq configuration.

2016-02-05 Thread Ian Stokes
Kernel network devices in a guest should have the number of multi-purpose channels configured when used with DPDK multiqueue on the host. This commit adds an example of how this can be done. Also add QEMU 2.5 requirements for multiqueue with DPDK in NEWS. Signed-off-by: Ian Stokes

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-08 Thread Stokes, Ian
> -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Friday, February 05, 2016 9:45 PM > To: Ben Pfaff; Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality. > > >

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-08 Thread Stokes, Ian
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, February 05, 2016 9:19 PM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality. > > On Thu, Feb 04, 2016 at 09:30:59AM

Re: [ovs-dev] [PATCH] INSTALL.DPDK.md: vhost-user: Note about number of queues inside guest OS.

2016-02-09 Thread Stokes, Ian
Hi Ilya, I've submitted a patch for this last week which is waiting on review if you'd like to provide feedback for it http://openvswitch.org/pipermail/dev/2016-February/065739.html Thaks Ian > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] O

Re: [ovs-dev] [ovs-dev, v1] INSTALL.DPDK: Add notes regarding vhost multiq configuration.

2016-02-09 Thread Stokes, Ian
e v2. > And one comment inlined. > > Best regards, Ilya Maximets. > > On 05.02.2016 19:55, Ian Stokes wrote: > > Kernel network devices in a guest should have the number of > > multi-purpose channels configured when used with DPDK multiqueue on > > the host. T

[ovs-dev] [PATCH v2] INSTALL.DPDK: Add notes regarding vhost multiq configuration.

2016-02-09 Thread Ian Stokes
Linux kernel network devices in a guest should have the number of multi-purpose channels configured when used with DPDK multiqueue on the host. This commit adds an example of how this can be done. Also add QEMU 2.5 requirements for multiqueue with DPDK in NEWS. Signed-off-by: Ian Stokes

[ovs-dev] [PATCH v2] INSTALL.DPDK: Update details of XL710 restrictions for DPDK 2.2.

2016-02-09 Thread Ian Stokes
DPDK 2.2 removes restrictions related to maximum number of TX queues for XL710 devices. Update documentation to reflect these changes. Signed-off-by: Ian Stokes --- INSTALL.DPDK.md | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/INSTALL.DPDK.md b

[ovs-dev] [PATCH] INSTALL.DPDK.md: Correct mergeable buffers parameter.

2016-02-10 Thread Ian Stokes
Update the mergeable buffers paramaters in performance tuning to the correct parameter mrg_rxbuf. Signed-off-by: Ian Stokes --- INSTALL.DPDK.md |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md index d892788..0f340e5 100644 --- a

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-11 Thread Stokes, Ian
Thanks For the review Flavio, much appreciated, comments inline. I'll re-spin a new version also. > -Original Message- > From: Flavio Leitner [mailto:f...@sysclose.org] > Sent: Wednesday, February 10, 2016 7:55 PM > To: Stokes, Ian > Cc: dev@openvswitch.org >

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-11 Thread Stokes, Ian
Thanks for the review Daniele, comments inline. Will re-spin another version. > Thanks for the patch and the review. > > I agree with everything Flavio pointed out, a few more comments below > > On 10/02/2016 11:54, "Flavio Leitner" wrote: > > >On Mon, 1 Feb

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-11 Thread Stokes, Ian
> On Thu, 11 Feb 2016 12:32:56 + > "Stokes, Ian" wrote: > > > Thanks For the review Flavio, much appreciated, comments inline. I'll > re-spin a new version also. > > Thank you for the patch! > comments inline. > > > > > > >

Re: [ovs-dev] [PATCH v2] INSTALL.DPDK: Add notes regarding vhost multiq configuration.

2016-02-11 Thread Stokes, Ian
> Hi, Ian. > I prepared a fix for this problem here: > http://openvswitch.org/pipermail/dev/2016-February/066066.html > > Maybe it will be better than note in documentation. > > Best regards, Ilya Maximets. Thanks for the heads up on this Ilya, am I right in thinking this

Re: [ovs-dev] [PATCH v2] INSTALL.DPDK: Update details of XL710 restrictions for DPDK 2.2.

2016-02-16 Thread Stokes, Ian
> -Original Message- > From: Flavio Leitner [mailto:f...@sysclose.org] > Sent: Friday, February 12, 2016 1:37 AM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2] INSTALL.DPDK: Update details of XL710 > restrictions for DPDK 2.2. >

Re: [ovs-dev] [PATCH] INSTALL.DPDK.md: Correct mergeable buffers parameter.

2016-02-16 Thread Stokes, Ian
> -Original Message- > From: Flavio Leitner [mailto:f...@sysclose.org] > Sent: Friday, February 12, 2016 1:47 AM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] INSTALL.DPDK.md: Correct mergeable > buffers parameter. > > On Wed,

Re: [ovs-dev] [PATCH v2] INSTALL.DPDK: Add notes regarding vhost multiq configuration.

2016-02-16 Thread Stokes, Ian
> -Original Message- > From: Flavio Leitner [mailto:f...@sysclose.org] > Sent: Friday, February 12, 2016 4:58 AM > To: Stokes, Ian > Cc: dev@openvswitch.org; i.maxim...@samsung.com > Subject: Re: [ovs-dev] [PATCH v2] INSTALL.DPDK: Add notes regarding > vhost multiq c

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-17 Thread Stokes, Ian
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Stokes, Ian > Sent: Thursday, February 11, 2016 2:42 PM > To: Flavio Leitner > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality. > &g

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-19 Thread Stokes, Ian
> On Wed, 17 Feb 2016 14:40:26 + > "Stokes, Ian" wrote: > > > > -Original Message- > > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Stokes, > > > Ian > > > Sent: Thursday, February 11, 2016 2:42 PM > > >

[ovs-dev] [PATCH v4] netdev_dpdk.c: Add QoS functionality.

2016-02-19 Thread Ian Stokes
rop egress packets at a configurable rate. The INSTALL.DPDK.md guide has also been modified to provide an example configuration of `egress-policer` QoS. Signed-off-by: Ian Stokes --- v4: *INSTALL.DPDK -Remove unneeded "--" in ovs-vsctl destroy QoS command. *NEWS -Add QoS functionality

Re: [ovs-dev] [PATCH] testsuite: Don't apply the testsuite.patch on non-Windows platforms.

2015-04-23 Thread Stokes, Ian
> -Original Message- > From: Gurucharan Shetty [mailto:shet...@nicira.com] > Sent: Thursday, April 23, 2015 3:22 PM > To: dev@openvswitch.org > Cc: Stokes, Ian; Gurucharan Shetty > Subject: [PATCH] testsuite: Don't apply the testsuite.patch on non- > Windows

Re: [ovs-dev] [PATCH] testsuite: Don't apply the testsuite.patch on non-Windows platforms.

2015-04-23 Thread Stokes, Ian
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Stokes, Ian > Sent: Thursday, April 23, 2015 4:51 PM > To: Gurucharan Shetty; dev@openvswitch.org > Cc: Gurucharan Shetty > Subject: Re: [ovs-dev] [PATCH] testsuite: Don't apply t

[ovs-dev] [PATCH RFC 1/1] netdev-dpdk: Add QoS API for netdev-dpdk.

2015-01-22 Thread Ian Stokes
emented will be user space strict priority queuing or 'us-spq' for short. The netdev-dpdk QoS functions will also be implemented at this stage. Signed-off-by: Ian Stokes --- lib/netdev-dpdk.c| 247 ++ vswitchd/vswitch.xml | 2

Re: [ovs-dev] Some questions about DPDK+OVS

2015-03-18 Thread Stokes, Ian
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of lin > Sent: Tuesday, March 17, 2015 8:59 AM > To: Traynor, Kevin; dev@openvswitch.org > Subject: Re: [ovs-dev] Some questions about DPDK+OVS > > Sorry, I shouldn't drop the mailing list. > > On Tue, Mar 1

[ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-09-30 Thread Ian Stokes
op packets at configurable rate. The INSTALL.DPDK.md guide has also been modified to provide an example configuration of `us-policer` QoS. Signed-off-by: Ian Stokes --- INSTALL.DPDK.md | 52 +++ lib/netdev-dpdk.c| 414 +- vswitchd/v

Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-10-08 Thread Stokes, Ian
Hi All, Just wondering if anyone has had time to review this? Any feedback would be much appreciated. Thanks Ian > -Original Message- > From: Stokes, Ian > Sent: Wednesday, September 30, 2015 1:45 PM > To: dev@openvswitch.org > Cc: Stokes, Ian > Subject: [PATCH] netd

Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-10-12 Thread Stokes, Ian
Hi Daniele, Thanks for providing feedback, answers inline. > -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Friday, October 09, 2015 6:53 PM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] netd

Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-10-14 Thread Stokes, Ian
> -Original Message- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: Tuesday, October 13, 2015 5:24 PM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality. > > On Wed, Sep 30, 2015 at 01:45:15PM

Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-10-14 Thread Stokes, Ian
> -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Tuesday, October 13, 2015 5:14 PM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality. > > > > On

[ovs-dev] [PATCH v2] netdev_dpdk.c: Add QoS functionality.

2015-10-16 Thread Ian Stokes
rop egress packets at a configurable rate. The INSTALL.DPDK.md guide has also been modified to provide an example configuration of `egress-policer` QoS. Signed-off-by: Ian Stokes --- INSTALL.DPDK.md | 20 +++ lib/netdev-dpdk.c| 416 +-

Re: [ovs-dev] [PATCH v2] netdev_dpdk.c: Add QoS functionality.

2015-10-22 Thread Stokes, Ian
Hi All, Just wondering if anyone has input on v2 of the netdev-dpdk QoS patch? Any feedback would be much appreciated. Thanks Ian > -Original Message- > From: Stokes, Ian > Sent: Friday, October 16, 2015 2:28 PM > To: dev@openvswitch.org > Cc: Stokes, Ian >

Re: [ovs-dev] [PATCH v2] netdev_dpdk.c: Add QoS functionality.

2015-11-18 Thread Stokes, Ian
> -Original Message- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: Wednesday, November 04, 2015 3:55 AM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2] netdev_dpdk.c: Add QoS functionality. > > On Thu, Oct 22, 2015 at 09:29

Re: [ovs-dev] Does openvswitch with DPDK datapath supports QOS

2015-11-26 Thread Stokes, Ian
olicer and not a traffic shaper i.e. packets are dropped rather than buffered to be sent later. http://openvswitch.org/pipermail/dev/2015-October/061316.html I'm currently looking at extending this design to include an ingress policer but this will be a separate submission in the future. I

Re: [ovs-dev] [PATCH v2] netdev_dpdk.c: Add QoS functionality.

2015-11-30 Thread Stokes, Ian
> -Original Message- > From: Flavio Leitner [mailto:f...@sysclose.org] > Sent: Thursday, November 26, 2015 8:58 PM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2] netdev_dpdk.c: Add QoS functionality. > > > Funny, everyone is try

Re: [ovs-dev] [PATCH] hotplug: add openvswitch script

2013-04-18 Thread Ian Campbell
On Thu, 2013-04-18 at 12:50 +0100, Ian Campbell wrote: > Based on Waldi's RFC at > http://lists.xen.org/archives/html/xen-devel/2012-09/msg00943.html > > To use it set vif.default.script="vif-openvswitch" in /etc/xen/xl.conf or use > script=vif-openvswitch in the v

Re: [ovs-dev] [PATCH] hotplug: add openvswitch script

2013-04-18 Thread Ian Campbell
(adding ovs list to this subthread too) On Thu, 2013-04-18 at 13:19 +0100, Bastian Blank wrote: > On Thu, Apr 18, 2013 at 12:50:40PM +0100, Ian Campbell wrote: > > Based on Waldi's RFC at > > http://lists.xen.org/archives/html/xen-devel/2012-09/msg00943.html > > BRIDG

Re: [ovs-dev] [PATCH] hotplug: add openvswitch script

2013-04-19 Thread Ian Campbell
On Thu, 2013-04-18 at 19:01 +0100, Ben Pfaff wrote: > On Thu, Apr 18, 2013 at 01:08:40PM +0100, Ian Campbell wrote: > > On Thu, 2013-04-18 at 12:50 +0100, Ian Campbell wrote: > > > Based on Waldi's RFC at > > > http://lists.xen.org/archives/html/xen-devel/2012-09/m

[ovs-dev] [PATCH V2] hotplug: add openvswitch script

2013-04-22 Thread Ian Campbell
dd the VIF to xenbr0 as a trunk port receiving VLANs 99, 100 & 101 Waldi, can you confirm if I have correctly reverse engineered the syntax from the regexp please ;-) Signed-off-by: Ian Campbell Signed-off-by: Bastian Blank Cc: dev@openvswitch.org --- v2: Correct syntax description in commitlog.

Re: [ovs-dev] [PATCH V2] hotplug: add openvswitch script

2013-04-22 Thread Ian Campbell
ed? Even if that were the case I wouldn't want to rely on it, so we should try and clean up explicitly. Is this tap devices which only generates add/remove and not online/offline? Do you happen to know the sequence of events for both types of device? Ian. __

[ovs-dev] [PATCH V3] hotplug: add openvswitch script

2013-04-23 Thread Ian Campbell
dd the VIF to xenbr0 as a trunk port receiving VLANs 99, 100 & 101 Waldi, can you confirm if I have correctly reverse engineered the syntax from the regexp please ;-) Signed-off-by: Ian Campbell Signed-off-by: Bastian Blank Cc: dev@openvswitch.org --- v3: Handle the remove case as well to pr

Re: [ovs-dev] [PATCH V2] hotplug: add openvswitch script

2013-04-23 Thread Ian Campbell
On Mon, 2013-04-22 at 18:20 +0100, Roger Pau Monne wrote: > On 22/04/13 19:05, Ian Campbell wrote: > > On Mon, 2013-04-22 at 17:46 +0100, Roger Pau Monne wrote: > >>> +offline) > >> > >> Don't you need a "remove" here? > >>

Re: [ovs-dev] [PATCH V3] hotplug: add openvswitch script

2013-04-23 Thread Ian Campbell
dev > > Same here. I think this one wants to be a non-fatal error on failure, do allow as much cleanup as possible to go ahead (e.g. the iptables rule below). I think do_without_error is the right answer for this one. I also noticed that we don't set the link d

  1   2   >