> -----Original Message----- > From: Flavio Leitner [mailto:f...@sysclose.org] > Sent: Tuesday, February 23, 2016 2:10 AM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v4] netdev_dpdk.c: Add QoS functionality. > > On Fri, 19 Feb 2016 17:26:30 +0000 > Ian Stokes <ian.sto...@intel.com> wrote: > > > This patch provides the modifications required in netdev-dpdk.c and > > vswitch.xml to allow for a DPDK user space QoS algorithm. > > > > This patch adds a QoS configuration structure for netdev-dpdk and > > expected QoS operations 'dpdk_qos_ops'. Various helper functions are > > also supplied. > > > > Also included are the modifications required for vswitch.xml to allow > > a new QoS implementation for netdev-dpdk devices. This includes a new > > QoS type `egress-policer` as well as its expected QoS table entries. > > > > The QoS functionality implemented for DPDK devices is `egress- > policer`. > > This can be used to drop egress packets at a configurable rate. > > > > The INSTALL.DPDK.md guide has also been modified to provide an example > > configuration of `egress-policer` QoS. > > > > Signed-off-by: Ian Stokes <ian.sto...@intel.com> > > --- > > > > v4: > > > > *INSTALL.DPDK > > -Remove unneeded "--" in ovs-vsctl destroy QoS command. > > > > *NEWS > > -Add QoS functionality to DPDK in post 2.5 section > > > > *vswitch.xml > > -Remove references to srtcm & DPDK sample app from egress-policer > > description. > > > > *netdev-dpdk.c > > -Remove DPDK_MAX_QOS_NAME_SIZE. > > -Replace 'qos_alg_process()' with 'qos_run()'. > > -Replace 'netdev_dpdk_qos_process__()' with 'netdev_dpdk_qos_run__()'. > > -Replace 'egress_policer_process()' with 'egress_policer_run()'. > > -Remove enum egress_policer_action to avoid mixed internal & external > > declarations. > > -Replace strncmp with strcmp in qos_lookup_name function. > > -Simplify 'egress_pkt_handle' to make direct reference to > > e_RTE_METER_GREEN instead of using enum. > > -egress_policer_run() fixed so as not to return incorrect packet count > > containing freed packets. > > -In netdev_dpdk_set_qos() add mutex lock and unlock. > > -In netdev_dpdk_set_qos() treat 'type' not found or 'type'=="" equally > > and delete QoS configuration. > > --- > > INSTALL.DPDK.md | 20 +++ > > NEWS | 1 + > > lib/netdev-dpdk.c | 428 > ++++++++++++++++++++++++++++++++++++++++++++++++-- > > vswitchd/vswitch.xml | 47 ++++++ > > 4 files changed, 483 insertions(+), 13 deletions(-) > > > > Thanks for the patch! Thanks for taking the time to review this!
Daniele - Do these changes look ok to you? Is there any changes you'd like made? Thanks Ian > Acked-by: Flavio Leitner <f...@sysclose.org> > > -- > fbl _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
