[ovs-dev] [PATCH/RFC 0/8] Recirculation for MPLS

2014-03-25 Thread Simon Horman
ted mask using flow [bond megaflow v4 4/4 rebased] ofproto/bond: Implement bond megaflow using recirculation To aid review this series and its dependencies are available in git https://github.com/horms/openvswitch devel/recirculation-andy-v4+mpls Simon Horman (8): flow: Add mf_is_l3_or

[ovs-dev] [PATCH/RFC 1/8] flow: Add mf_is_l3_or_higher()

2014-03-25 Thread Simon Horman
recirculation to occur. Signed-off-by: Simon Horman --- lib/meta-flow.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/meta-flow.h b/lib/meta-flow.h index 91dfecd..d02d320 100644 --- a/lib/meta-flow.h +++ b/lib/meta-flow.h @@ -89,6 +89,8 @@ enum OVS_PACKED_ENUM mf_field_id

[ovs-dev] [PATCH/RFC 5/8] ofproto-dpif: MPLS recirculation

2014-03-25 Thread Simon Horman
. Signed-off-by: Simon Horman --- ofproto/ofproto-dpif-xlate.c | 178 +-- 1 file changed, 172 insertions(+), 6 deletions(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 8011b8d..4f3e31a 100644 --- a/ofproto/ofproto-dpif

[ovs-dev] [PATCH/RFC 8/8] ofproto-dpif: Add MPLS tests

2014-03-25 Thread Simon Horman
Co-Authored-by: Joe Stringer Signed-off-by: Simon Horman --- Previously part of "Add packet recirculation" (v18) --- tests/ofproto-dpif.at | 614 ++ 1 file changed, 614 insertions(+) diff --git a/tests/ofproto-dpif.at b/tests/ofpro

[ovs-dev] [PATCH/RFC 7/8] ofproto-dpif: Break out MPLS controller tests into their own test

2014-03-25 Thread Simon Horman
This makes maintaining the controller test slightly easier by splitting it in two. Based on a similar patch by Joe Stringer. Cc: Joe Stringer Signed-off-by: Simon Horman --- tests/ofproto-dpif.at | 352 ++ 1 file changed, 185 insertions(+), 167

[ovs-dev] [PATCH/RFC 3/8] ofproto-dpif: Add idle_timeout parameter to ofproto_dpif_add_internal_flow()

2014-03-25 Thread Simon Horman
recirculation. Signed-off-by: Simon Horman --- ofproto/bond.c | 2 +- ofproto/ofproto-dpif.c | 10 ++ ofproto/ofproto-dpif.h | 1 + 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/ofproto/bond.c b/ofproto/bond.c index 7086246..13a7e8a 100644 --- a/ofproto/bond.c

Re: [ovs-dev] [PATCH/RFC 4/8] ofproto-dpif: Add recirc_id field to struct rule_dpif

2014-03-25 Thread Simon Horman
> > On Tue, Mar 25, 2014 at 2:24 PM, Simon Horman wrote: > > This is to allow a recirculation id to be associated with a rule > > in the case that its actions cause recirculation. > > > > In such a case if the recirc_id field is non-zero then that value sho

Re: [ovs-dev] [PATCH/RFC 4/8] ofproto-dpif: Add recirc_id field to struct rule_dpif

2014-03-26 Thread Simon Horman
On Tue, Mar 25, 2014 at 09:18:19PM -0700, Andy Zhou wrote: > On Tue, Mar 25, 2014 at 7:19 PM, Simon Horman wrote: > > Hi Andy, > > > > to date, the implementation of MPLS has not provided any entity other > > than the rules themselves. > > I see. I need to s

Re: [ovs-dev] [PATCH/RFC] ofproto-dpif-upcall: Filter translated mask using flow

2014-03-29 Thread Simon Horman
On Thu, Mar 20, 2014 at 09:37:14AM -0700, Ben Pfaff wrote: > On Thu, Mar 20, 2014 at 05:34:23PM +0900, Simon Horman wrote: > > When revalidating a flow convert xout.wc.masks, the mask calculated by > > translation, to a key that relates to the flow present in the datapath. &g

[ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-03-31 Thread Simon Horman
ethertypes that allow mpls_push actions. * It once again applies on top of the master branch Simon Horman (1): datapath: Add basic MPLS support to kernel OPENFLOW-1.1+ | 4 - datapath/Modules.mk | 1 + datapath/actions.c

Re: [ovs-dev] [PATCH] [RFC] flow: Do not clear L3+ fields of flow in flow_push_mpls()

2014-03-31 Thread Simon Horman
On Thu, Mar 20, 2014 at 10:05:44AM -0700, Ben Pfaff wrote: > On Fri, Mar 14, 2014 at 04:19:52PM +0900, Simon Horman wrote: > > When creating a flow in the datapath as the result of an upcall > > the match itself is the match supplied in the upcall while > > the mask of the m

[ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-03-31 Thread Simon Horman
: Simon Horman --- v2.56 * Update whitelist of ethtypes where mpls_push may be used to include the MPLS ethtypes. The whitelist is now: - ETH_P_IP (0x0800) - ETH_P_ARP (0x0806) - ETH_P_RARP (0x0835) - ETH_P_IPV6 (0x86DD) - ETH_P_MPLS_UC (0x8847) - ETH_P_MPLS_MC (0x8847) * Rebase for

Re: [ovs-dev] [bond megaflow v4 4/4 rebased] ofproto/bond: Implement bond megaflow using recirculation

2014-03-31 Thread Simon Horman
On Tue, Mar 25, 2014 at 01:48:39PM -0700, Andy Zhou wrote: > Infrastructure to enable megaflow support for bond ports using > recirculation. This patch adds the following features: > * Generate RECIRC action when bond can benefit from recirculation. > * Populate post recirculation rules in a hidden

Re: [ovs-dev] [bond megaflow v4 4/4 rebased] ofproto/bond: Implement bond megaflow using recirculation

2014-04-01 Thread Simon Horman
On Tue, Apr 01, 2014 at 10:16:05AM -0700, Andy Zhou wrote: > On Mon, Mar 31, 2014 at 9:11 PM, Simon Horman wrote: > > On Tue, Mar 25, 2014 at 01:48:39PM -0700, Andy Zhou wrote: > >> Infrastructure to enable megaflow support for bond ports using > >> recirculation. Th

[ovs-dev] [PATCH v3 repost] ofproto: Support OF version-specific table-miss behaviours

2014-04-02 Thread Simon Horman
packet_in message to all pre-OF1.3 controllers. This covers both the case where there are only pre-OF1.3 controllers and there are both pre-OF1.3 and OF1.3+ controllers. Signed-off-by: Simon Horman --- * v3 - Rebase + Based on merged version of "ofproto: Honour Table Mod set

[ovs-dev] [PATCH] ofproto: per-table statistics

2014-04-02 Thread Simon Horman
than all being credited to table 0. These problems were observed when running make check-ryu and this patch allows many of its tester.py match checks to pass. Signed-off-by: Simon Horman --- ofproto/ofproto-dpif-xlate.c | 6 +- ofproto/ofproto-dpif.c | 42 +- ofproto/ofproto-dpif.h

Re: [ovs-dev] [PATCH] ofproto: per-table statistics

2014-04-03 Thread Simon Horman
ed on table > > > accesses rather than datapath flow hits and misses. > > > > > > * Lookups and matches are credited to the table where they > > > occurred rather than all being credited to table 0. > > > > > > These problems were observed

Re: [ovs-dev] [PATCH v3 repost] ofproto: Support OF version-specific table-miss behaviours

2014-04-03 Thread Simon Horman
On Thu, Apr 03, 2014 at 04:09:46PM -0700, Ben Pfaff wrote: > On Wed, Apr 02, 2014 at 06:04:27PM +0900, Simon Horman wrote: > > OpenFlow 1.1 and 1.2 specify that if a table-miss occurs then the default > > behaviour is to forward the packet the controller using a packet-in > &g

[ovs-dev] [PATCH] ofproto-dpif: Always wait for ovs-ofctl exit

2014-04-07 Thread Simon Horman
Uniformly wait for calls to ovs-ofctl exit in the test-suite. Signed-off-by: Simon Horman --- tests/ofproto-dpif.at | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index f2ddda9..6f70ba0 100644 --- a/tests/ofproto-dpif.at

[ovs-dev] [PATCH] ofproto-dpif: Wait for output for all MPLS tests

2014-04-07 Thread Simon Horman
This corrects an inconsistency in the MPLS tests and avoids a race by waiting for sufficient output before checking its contents Signed-off-by: Simon Horman --- tests/ofproto-dpif.at | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto

[ovs-dev] [PATCH] ofp-parse: Handle buffer resize when parsing actions

2014-04-07 Thread Simon Horman
inter and document usage conventions."). Test cases have also been added to exercise this buffer resize in parse_note(), parse_noargs_dec_ttl(), parse_dec_ttl(). Cc: Jarno Rajahalme Signed-off-by: Simon Horman --- lib/ofp-parse.c | 3 +++ tes

Re: [ovs-dev] [PATCH] ofproto-dpif: Always wait for ovs-ofctl exit

2014-04-07 Thread Simon Horman
On Mon, Apr 07, 2014 at 11:19:17AM -0700, Ben Pfaff wrote: > On Mon, Apr 07, 2014 at 05:39:38PM +0900, Simon Horman wrote: > > Uniformly wait for calls to ovs-ofctl exit in the test-suite. > > > > Signed-off-by: Simon Horman > > This inserts two OVS_APP_EXIT_AND_WA

Re: [ovs-dev] Commit "ofproto-dpif.at: Wait for the monitor's pidfile disappears where necessary" breaks test 700

2014-04-07 Thread Simon Horman
46912 > -NXT_PACKET_IN (xid=0x0): cookie=0xa total_len=64 in_port=1 (via > action) data_len=64 (unbuffered) > -mpls,metadata=0,in_port=0,vlan_tci=0x,dl_src=40:44:44:44:44:43,dl_dst=50:54:00:00:00:07,mpls_label=10,mpls_tc=3,mpls_ttl=64,mpls_bos=0,mpls_lse1=46912 Hi Lori, I have proposed the fo

[ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

2014-04-07 Thread Simon Horman
Uniformly wait for calls to ovs-ofctl exit using OVS_APP_EXIT_AND_WAIT() in the test-suite. Signed-off-by: Simon Horman v2 * Always use OVS_APP_EXIT_AND_WAIT(ovs-ofctl) instead of OVS_WAIT_UNTIL([ovs-appctl -t ovs-ofctl exit]) --- tests/ofproto-dpif.at | 36

Re: [ovs-dev] [PATCH] ofproto-dpif: Wait for output for all MPLS tests

2014-04-07 Thread Simon Horman
.org/patch/3579/ Agreed. > > YAMAMOTO Takashi > > > > > Signed-off-by: Simon Horman > > --- > > tests/ofproto-dpif.at | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at

Re: [ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

2014-04-07 Thread Simon Horman
On Tue, Apr 08, 2014 at 10:00:47AM +0900, YAMAMOTO Takashi wrote: > > Uniformly wait for calls to ovs-ofctl exit using > > OVS_APP_EXIT_AND_WAIT() in the test-suite. > > are they all necessary to avoid some races? > > in commit 0c473314, i intended to make it wait only when necessary. > ie. only

Re: [ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

2014-04-07 Thread Simon Horman
On Tue, Apr 08, 2014 at 10:20:54AM +0900, YAMAMOTO Takashi wrote: > > On Tue, Apr 08, 2014 at 10:00:47AM +0900, YAMAMOTO Takashi wrote: > >> > Uniformly wait for calls to ovs-ofctl exit using > >> > OVS_APP_EXIT_AND_WAIT() in the test-suite. > >> > >> are they all necessary to avoid some races? >

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-09 Thread Simon Horman
On Tue, Apr 01, 2014 at 12:46:20PM +0900, Simon Horman wrote: > Hi Jesse, Hi Pravin, Hi All, > > This patchset makes use of a whitelist to only allow mpls_push actions to > be applied to packets with an ethertype where the tag order is well defined > and implemented. This avoids

Re: [ovs-dev] [PATCH/RFC] ofproto-dpif-upcall: Filter translated mask using flow

2014-04-09 Thread Simon Horman
On Sat, Mar 29, 2014 at 04:01:35PM -0700, Simon Horman wrote: > On Thu, Mar 20, 2014 at 09:37:14AM -0700, Ben Pfaff wrote: > > On Thu, Mar 20, 2014 at 05:34:23PM +0900, Simon Horman wrote: > > > When revalidating a flow convert xout.wc.masks, the mask calculated by > > >

Re: [ovs-dev] [PATCH] [RFC] flow: Do not clear L3+ fields of flow in flow_push_mpls()

2014-04-09 Thread Simon Horman
On Tue, Apr 01, 2014 at 12:21:03PM +0900, Simon Horman wrote: > On Thu, Mar 20, 2014 at 10:05:44AM -0700, Ben Pfaff wrote: > > On Fri, Mar 14, 2014 at 04:19:52PM +0900, Simon Horman wrote: > > > When creating a flow in the datapath as the result of an upcall > > > th

[ovs-dev] [PATCH] ofproto-dpif: Correct typo in documentation of rule_dpif_lookup()

2014-04-13 Thread Simon Horman
This corrects a typo that was added by adcf00ba35a0ce9c ("ofproto/bond: Implement bond megaflow using recirculation"). Cc: Andy Zhou Signed-off-by: Simon Horman --- ofproto/ofproto-dpif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif.c

[ovs-dev] [PATCH] ofproto-dpif: Correct documentation of rule_dpif_lookup_from_table()

2014-04-13 Thread Simon Horman
This corrects an editing error that was added by 6b83a3c5c37a0711 ("ofproto: Support OF version-specific table-miss behaviours"). Signed-off-by: Simon Horman --- ofproto/ofproto-dpif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dp

[ovs-dev] [PATCH v2] ofproto: per-table statistics

2014-04-15 Thread Simon Horman
than all being credited to table 0. These problems were observed when running make check-ryu and this patch allows many of its tester.py match checks to pass. Signed-off-by: Simon Horman -- v2 * Use NULL instead of 0 as NULL pointer argument * Rebase --- ofproto/ofproto-dpif-xlate.c | 6

[ovs-dev] [PATCH v2 02/11] odp-util: Add odp_put_recirc_action() helper

2014-04-15 Thread Simon Horman
Add odp_put_recirc_action() helper and use it in compose_output_action__(). This is in preparation for using the same helper as part of support for using recirculation in conjunction series of actions including with MPLS actions that are currently not able to be translated. Signed-off-by: Simon

[ovs-dev] [PATCH v2 03/11] ofproto-dpif: Add table_is_internal() helper

2014-04-15 Thread Simon Horman
This will be used by a subsequent patch to add support for recirculation for MPLS. Signed-off-by: Simon Horman --- ofproto/ofproto-dpif.c | 10 +- ofproto/ofproto-dpif.h | 2 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto

[ovs-dev] [PATCH v2 09/11] ofp-actions: Allow pop_mpls on MPLS packets

2014-04-15 Thread Simon Horman
With recirculation in place this should be safe. XXX: What if recirculation is disabled??? Signed-off-by: Simon Horman --- lib/ofp-actions.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index ce14004..69d6505 100644 --- a/lib/ofp-actions.c

[ovs-dev] [PATCH v2 05/11] match: Add match_init_recirc() helper

2014-04-15 Thread Simon Horman
Add match_init_recirc() helper and use it in update_recirc_rules(). This is in preparation for using this value in ofproto-dpif-xlate.c when composing recirculation actions added as a result of processing (MPLS) actions. Signed-off-by: Simon Horman --- lib/match.c| 9 + lib/match.h

[ovs-dev] [PATCH v2 06/11] ofproto-dpif: Add recirc_id field to struct rule_dpif

2014-04-15 Thread Simon Horman
to be translated. Signed-off-by: Simon Horman --- ofproto/ofproto-dpif.c | 27 +++ ofproto/ofproto-dpif.h | 1 + 2 files changed, 28 insertions(+) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index d6f73c2..0fe7505 100644 --- a/ofproto/ofproto-dpif.c +++ b

[ovs-dev] [PATCH v2 07/11] dpif: Process recirc action in dpif_execute_helper_cb

2014-04-15 Thread Simon Horman
Process a recirc action in dpif_execute_helper_cb() by doing precisely nothing. This is in preparation for allowing execution of recirculation to be handled in ovs-vswtichd in some cases. Signed-off-by: Simon Horman --- v2 * First post --- lib/dpif.c | 4 +++- 1 file changed, 3 insertions

[ovs-dev] [PATCH v2 00/11]

2014-04-15 Thread Simon Horman
ng patches are required: [PATCH/RFC] ofproto-dpif-upcall: Filter translated mask using flow [PATCH v2] ofproto: per-table statistics To aid review this series and its dependencies are available in git https://github.com/horms/openvswitch devel/mpls-flow-based-recirculation-v2 Simon Horman (1

[ovs-dev] [PATCH v2 01/11] flow: Add mf_is_l3_or_higher()

2014-04-15 Thread Simon Horman
recirculation to occur. Signed-off-by: Simon Horman --- lib/meta-flow.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/meta-flow.h b/lib/meta-flow.h index 91dfecd..d02d320 100644 --- a/lib/meta-flow.h +++ b/lib/meta-flow.h @@ -89,6 +89,8 @@ enum OVS_PACKED_ENUM mf_field_id

[ovs-dev] [PATCH v2 04/11] ofproto-dpif: Move RECIRC_RULE_PRIORITY to common header

2014-04-15 Thread Simon Horman
This is in preparation for using this value in ofproto-dpif-xlate.c when composing recirculation actions added as a result of processing (MPLS) actions. Signed-off-by: Simon Horman --- ofproto/bond.c | 1 - ofproto/ofproto-dpif.h | 3 +++ 2 files changed, 3 insertions(+), 1 deletion

[ovs-dev] [PATCH v2 08/11] ofproto-dpif: MPLS recirculation

2014-04-15 Thread Simon Horman
. Signed-off-by: Simon Horman --- v2 * Loosen assertion for goto table actions to allow goto table from internal rules (created for recirculation). * Recirculate for L3+ action after pop_mpls regardless of resulting ethertype - In particular this allows operating on ARP packets after pop MPLS to

[ovs-dev] [PATCH v2 10/11] ofproto-dpif: Break out MPLS controller tests into their own test

2014-04-15 Thread Simon Horman
This makes maintaining the controller test slightly easier by splitting it in two. Based on a similar patch by Joe Stringer. Cc: Joe Stringer Signed-off-by: Simon Horman --- tests/ofproto-dpif.at | 352 ++ 1 file changed, 185 insertions(+), 167

Re: [ovs-dev] [PATCH v2 02/11] odp-util: Add odp_put_recirc_action() helper

2014-04-15 Thread Simon Horman
ies of actions including > > with MPLS actions that are currently not able to be translated. > > > > Signed-off-by: Simon Horman > > ofproto_dpif_add_internal_flow changes do not seem > related to the rest of the commit. mis-squashing? Yes, thanks for pointing that out.

Re: [ovs-dev] [PATCH v2 11/11] ofproto-dpif: Add MPLS tests

2014-04-16 Thread Simon Horman
On Wed, Apr 16, 2014 at 04:32:26PM +0900, YAMAMOTO Takashi wrote: > > Co-Authored-by: Joe Stringer > > Signed-off-by: Simon Horman > > > > --- > > > > Previously part of "Add packet recirculation" (v18) > > > > v2 > > * Use OV

Re: [ovs-dev] [PATCH v2 08/11] ofproto-dpif: MPLS recirculation

2014-04-16 Thread Simon Horman
On Wed, Apr 16, 2014 at 04:39:24PM +0900, YAMAMOTO Takashi wrote: > > @@ -1762,6 +1765,10 @@ compose_output_action__(struct xlate_ctx *ctx, > > ofp_port_t ofp_port, > > } else if (may_receive(peer, ctx)) { > > if (xport_stp_forward_state(peer)) { > > xlate_ta

Re: [ovs-dev] [PATCH v2 08/11] ofproto-dpif: MPLS recirculation

2014-04-16 Thread Simon Horman
2014/04/16 18:54 "YAMAMOTO Takashi" : > > > On Wed, Apr 16, 2014 at 04:39:24PM +0900, YAMAMOTO Takashi wrote: > >> > @@ -1762,6 +1765,10 @@ compose_output_action__(struct xlate_ctx *ctx, ofp_port_t ofp_port, > >> > } else if (may_receive(peer, ctx)) { > >> > if (xport_stp_forw

[ovs-dev] [PATCH v2] ovs-ofctl: Document that mod-group requires the type field

2014-11-24 Thread Simon Horman
Document that mod-group rather than del-group requires the type field. Signed-off-by: Simon Horman --- utilities/ovs-ofctl.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Rebase to not depend on "ovs-ofctl: Consistently escape '-' in group documentation"

Re: [ovs-dev] [PATCH v2] ovs-ofctl: Document that mod-group requires the type field

2014-11-24 Thread Simon Horman
Sorry, I was a little trigger happy and failed to notice that has already been applied. Thanks for that and please ignore this duplicate. On Tue, Nov 25, 2014 at 11:33:32AM +0900, Simon Horman wrote: > Document that mod-group rather than del-group requires the type field. > > Sign

Re: [ovs-dev] [PATCH/RFC 1/9] Add Netronome vendor Id

2014-11-25 Thread Simon Horman
On Tue, Nov 25, 2014 at 03:22:04PM -0800, Ben Pfaff wrote: > On Wed, Nov 19, 2014 at 09:44:55AM +0900, Simon Horman wrote: > > Add Netronome vendor Id: NMX_VENDOR_ID = 0x1540. > > > > This is based on the Netronome IEEE OUI, 00154D. > > And it has been registered w

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-11-25 Thread Simon Horman
On Tue, Nov 25, 2014 at 03:30:01PM -0800, Ben Pfaff wrote: > On Wed, Nov 19, 2014 at 09:44:54AM +0900, Simon Horman wrote: > > this patch set implements the group select selection method extension that > > I circulated some months ago on the d...@openvswtich.org mailing list. For

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-11-25 Thread Simon Horman
On Tue, Nov 25, 2014 at 03:31:50PM -0800, Ben Pfaff wrote: > On another note, the description of the extension at the end of this > message is useful. Does one of the patches add it to the tree > somewhere? No, but I'm happy to add such a patch. It could go into a header or .c file somewhat but

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-11-26 Thread Simon Horman
On Wed, Nov 26, 2014 at 02:00:07PM -0800, Ben Pfaff wrote: > On Wed, Nov 26, 2014 at 10:37:16AM +0900, Simon Horman wrote: > > On Tue, Nov 25, 2014 at 03:31:50PM -0800, Ben Pfaff wrote: > > > On another note, the description of the extension at the end of this > > > mess

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-11-26 Thread Simon Horman
t until next week because of the Thanksgiving > holiday. > > On November 26, 2014 6:54:16 PM PST, Simon Horman > wrote: > >On Wed, Nov 26, 2014 at 02:00:07PM -0800, Ben Pfaff wrote: > >> On Wed, Nov 26, 2014 at 10:37:16AM +0900, Simon Horman wrote: > >> > O

Re: [ovs-dev] [PATCH/RFC 4/9] Check pre-requisites of selection method fields

2014-12-11 Thread Simon Horman
On Thu, Dec 11, 2014 at 11:49:33AM -0800, Ben Pfaff wrote: > On Wed, Nov 19, 2014 at 09:44:58AM +0900, Simon Horman wrote: > > NMX selection method > > Signed-off-by: Simon Horman > > I'm not sure that it makes sense to check the prerequisites. It's easy > t

Re: [ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

2014-12-11 Thread Simon Horman
On Thu, Dec 11, 2014 at 09:48:15AM -0800, Ben Pfaff wrote: > On Wed, Nov 19, 2014 at 09:44:54AM +0900, Simon Horman wrote: > > The fields field is an ofp_match structure which includes the fields which > > should be used as inputs to bucket selection. ofp_match is described in &g

Re: [ovs-dev] [PATCH/RFC 3/9] Support translation of NMX selection method

2014-12-11 Thread Simon Horman
On Thu, Dec 11, 2014 at 09:46:19AM -0800, Ben Pfaff wrote: > On Thu, Dec 11, 2014 at 09:44:57AM -0800, Ben Pfaff wrote: > > On Wed, Nov 19, 2014 at 09:44:57AM +0900, Simon Horman wrote: > > > Only the default existing behaviour is translated. > > > All other m

Re: [ovs-dev] [PATCH/RFC 2/9] Add types for NMX selection method

2014-12-11 Thread Simon Horman
On Thu, Dec 11, 2014 at 09:41:13AM -0800, Ben Pfaff wrote: > On Wed, Nov 19, 2014 at 09:44:56AM +0900, Simon Horman wrote: > > NMX selection method > > Signed-off-by: Simon Horman > > Hi Simon. Sorry about the delay. Trying to catch up a little on > reviews. I&#x

Re: [ovs-dev] [PATCH/RFC 4/9] Check pre-requisites of selection method fields

2014-12-11 Thread Simon Horman
On Thu, Dec 11, 2014 at 07:02:29PM -0800, Ben Pfaff wrote: > On Fri, Dec 12, 2014 at 11:31:50AM +0900, Simon Horman wrote: > > On Thu, Dec 11, 2014 at 11:49:33AM -0800, Ben Pfaff wrote: > > > On Wed, Nov 19, 2014 at 09:44:58AM +0900, Simon Horman wrote: > > > > NMX s

Re: [ovs-dev] [PATCH/RFC 4/9] Check pre-requisites of selection method fields

2014-12-11 Thread Simon Horman
On Thu, Dec 11, 2014 at 07:16:36PM -0800, Ben Pfaff wrote: > On Fri, Dec 12, 2014 at 12:09:25PM +0900, Simon Horman wrote: > > On Thu, Dec 11, 2014 at 07:02:29PM -0800, Ben Pfaff wrote: > > > On Fri, Dec 12, 2014 at 11:31:50AM +0900, Simon Horman wrote: > > > > On T

[ovs-dev] Bug#771863: Bug#771863: Service does not start or parse interfaces correctly

2014-12-18 Thread Simon Horman
On Thu, Dec 18, 2014 at 05:30:42PM -0800, Joe Stringer wrote: > On 18 December 2014 at 01:00, Fabio Fantoni wrote: > > One maintainer or debian developer can do a new build of ovs with the fix > > available in 2.3.1 please? > > > >> * Version 2.3.0+git20140819-2 of openvswitch is marked for > >>

[ovs-dev] Bug#771863: Bug#771863: [PKG-Openstack-devel] Bug#771863: Service does not start or parse interfaces correctly

2014-12-19 Thread Simon Horman
On Fri, Dec 19, 2014 at 06:39:39PM +0800, Thomas Goirand wrote: > On 12/19/2014 11:50 AM, Simon Horman wrote: > > On Thu, Dec 18, 2014 at 05:30:42PM -0800, Joe Stringer wrote: > >> On 18 December 2014 at 01:00, Fabio Fantoni wrote: > >>> One maintainer or debian d

[ovs-dev] Bug#771863: [PKG-Openstack-devel] Bug#771863: Bug#771863: Service does not start or parse interfaces correctly

2014-12-19 Thread Simon Horman
On Fri, Dec 19, 2014 at 11:43:42PM +0800, Thomas Goirand wrote: > On 12/19/2014 11:32 PM, Thomas Goirand wrote: > > On 12/19/2014 10:25 PM, Simon Horman wrote: > >> On Fri, Dec 19, 2014 at 06:39:39PM +0800, Thomas Goirand wrote: > >>> On 12/19/2014 11:50 AM, Simon Ho

[ovs-dev] [PATCH] ofp-parse: Correctly update bucket lists if they are empty

2015-01-25 Thread Simon Horman
. Without the code change the updated test cases a segmentation when the buckets parameter of ofputil_put_ofp11_bucket() is dereferenced. Signed-off-by: Simon Horman --- * Although somewhat cure the approach of setting the next field to NULL seems far less dangerous than trying to update the list

Re: [ovs-dev] [PATCH] ofp-parse: Correctly update bucket lists if they are empty

2015-01-26 Thread Simon Horman
On Mon, Jan 26, 2015 at 04:40:49PM +0900, Simon Horman wrote: > list_moved() appears to only work reliably if its argument is a non-empty > list. This is because list_moved dereferences the next and prev fields > of the list, which for an empty list are the address of the list itse

Re: [ovs-dev] [PATCH] ofp-parse: Correctly update bucket lists if they are empty

2015-01-26 Thread Simon Horman
Hi Ben, Hi Thomas, On Mon, Jan 26, 2015 at 11:19:53AM -0800, Ben Pfaff wrote: > On Mon, Jan 26, 2015 at 02:44:07PM +0100, Thomas Graf wrote: > > On 01/26/15 at 05:30pm, Simon Horman wrote: > > > On Mon, Jan 26, 2015 at 04:40:49PM +0900, Simon Horman wrote: > > > >

[ovs-dev] [PATCH] ofp-util: constify buckets parameter of ofputil_append*_group_desc_reply()

2015-01-27 Thread Simon Horman
This parameter is not modified so it may be marked as const. Signed-off-by: Simon Horman --- lib/ofp-util.c | 6 +++--- lib/ofp-util.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 2270a93..bf55fb2 100644 --- a/lib/ofp-util.c +++ b

[ovs-dev] [PATCH] ofp-util: constify buckets parameter of ofputil_append*_group_desc_reply()

2015-01-27 Thread Simon Horman
This parameter is not modified so it may be marked as const. Signed-off-by: Simon Horman --- lib/ofp-util.c | 6 +++--- lib/ofp-util.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 2270a93..bf55fb2 100644 --- a/lib/ofp-util.c +++ b

Re: [ovs-dev] [PATCH] ofp-util: constify buckets parameter of ofputil_append*_group_desc_reply()

2015-01-27 Thread Simon Horman
On Tue, Jan 27, 2015 at 05:22:30PM +0900, Simon Horman wrote: > This parameter is not modified so it may be marked as const. > > Signed-off-by: Simon Horman Apologies, I seem to have sent this twice. Please ignore this duplicate. > --- > lib/ofp-util.c | 6 +++--- > lib/ofp-

Re: [ovs-dev] [PATCH] ofp-parse: Correctly update bucket lists if they are empty

2015-01-28 Thread Simon Horman
On Wed, Jan 28, 2015 at 11:33:05PM +0100, Thomas Graf wrote: > On 01/28/15 at 01:22pm, Ben Pfaff wrote: > > Are you sure? What *gms points to, that is, **gms, is freed, but *gms > > should still point to the same location. list_moved() never > > dereferences 'orig', only compares it against list-

[ovs-dev] [PATCH/RFC v2 1/8] Documentation: Add documentation of group selection method property

2015-01-29 Thread Simon Horman
Signed-off-by: Simon Horman --- Documentation/automake.mk | 2 + Documentation/group-selection-method-property.txt | 153 ++ Makefile.am | 1 + 3 files changed, 156 insertions(+) create mode 100644

[ovs-dev] [PATCH/RFC v2 0/8] Group Select: Selection Method Extension

2015-01-29 Thread Simon Horman
on to Documentation directory *** N.B: This patchset depends on *** "[PATCH] ofp-parse: Correctly update bucket lists if they are empty" *** but can be trivially be reworked for Ben Pfaff's proposed solution *** to that problem Simon Horman (8): Documentation: Add documentation of gr

[ovs-dev] [PATCH/RFC v2 3/8] Support decoding of NMX selection method

2015-01-29 Thread Simon Horman
This is in preparation for supporting group mod and desc reply messages with an NMX selection method group experimenter property. NMX selection method Signed-off-by: Simon Horman --- v2 Use list of struct field_array of TLVs rather than OF1.1 match for fields field of NMX selection method

[ovs-dev] [PATCH/RFC v2 2/8] Add types for NMX selection method

2015-01-29 Thread Simon Horman
NMX selection method Signed-off-by: Simon Horman --- * v2 Use array of TLVs rather than OF1.1 match for fields field of NMX selection method property --- include/openflow/automake.mk | 1 + include/openflow/netronome-ext.h | 66 2 files changed, 67

[ovs-dev] [PATCH/RFC v2 4/8] Support encoding of NMX selection method

2015-01-29 Thread Simon Horman
Include NMX selection method experimenter group property in in group mod request and group desc reply. NMX selection method Signed-off-by: Simon Horman --- v2 Use list of struct field_array of TLVs rather than OF1.1 match for fields field of NMX selection method property --- lib/nx-match.c

[ovs-dev] [PATCH/RFC v2 5/8] Support printing of NMX selection method property

2015-01-29 Thread Simon Horman
Support printing of NMX selection method group experimenter property NMX selection method Signed-off-by: Simon Horman --- v2 Use list of struct field_array of TLVs rather than OF1.1 match for fields field of NMX selection method property --- lib/nx-match.c | 41

[ovs-dev] [PATCH/RFC v2 7/8] Support NMX selection method in ovs-ofctl group commands

2015-01-29 Thread Simon Horman
NMX selection method Signed-off-by: Simon Horman --- v2 Use list of struct field_array of TLVs rather than OF1.1 match for fields field of NMX selection method property --- lib/ofp-parse.c | 105 +++ tests/ofproto.at | 4

[ovs-dev] [PATCH/RFC v2 6/8] Support translation of NMX selection method

2015-01-29 Thread Simon Horman
Only the default existing behaviour is translated. All other methods are rejected for now. NMX selection method Signed-off-by: Simon Horman --- v2 Use array of TLVs rather than OF1.1 match for fields field of NMX selection method property --- ofproto/ofproto-dpif-xlate.c | 30

[ovs-dev] [PATCH/RFC v2 8/8] Implement hash fields select group

2015-01-29 Thread Simon Horman
This is intended as a usable demonstration of how the NMX selection method extension might may be used. NMX selection method Signed-off-by: Simon Horman --- v2 Use list of struct field_array of TLVs rather than OF1.1 match for fields field of NMX selection method property --- lib/nx-match.c

Re: [ovs-dev] [PATCH/RFC v2 1/8] Documentation: Add documentation of group selection method property

2015-02-03 Thread Simon Horman
On Tue, Feb 03, 2015 at 03:41:04PM -0800, Ben Pfaff wrote: > On Fri, Jan 30, 2015 at 11:41:49AM +0900, Simon Horman wrote: > > Signed-off-by: Simon Horman > > Thanks, I'm happy with this documentation. > > I have a question about the abbreviation NMX for Netronome. A

Re: [ovs-dev] [PATCH/RFC v2 1/8] Documentation: Add documentation of group selection method property

2015-02-03 Thread Simon Horman
On Tue, Feb 03, 2015 at 05:15:01PM -0800, Ben Pfaff wrote: > On Wed, Feb 04, 2015 at 10:01:53AM +0900, Simon Horman wrote: > > On Tue, Feb 03, 2015 at 03:41:04PM -0800, Ben Pfaff wrote: > > > On Fri, Jan 30, 2015 at 11:41:49AM +0900, Simon Horman wrote: > > > &g

Re: [ovs-dev] [PATCH/RFC v2 3/8] Support decoding of NMX selection method

2015-02-13 Thread Simon Horman
On Fri, Feb 13, 2015 at 02:55:58PM -0800, Ben Pfaff wrote: > On Fri, Jan 30, 2015 at 11:41:51AM +0900, Simon Horman wrote: > > This is in preparation for supporting group mod and desc reply > > messages with an NMX selection method group experimenter property. > > >

Re: [ovs-dev] [PATCH/RFC v2 2/8] Add types for NMX selection method

2015-02-13 Thread Simon Horman
On Fri, Feb 13, 2015 at 01:51:54PM -0800, Ben Pfaff wrote: > On Fri, Jan 30, 2015 at 11:41:50AM +0900, Simon Horman wrote: > > NMX selection method > > Signed-off-by: Simon Horman > > > > --- > > * v2 > > Use array of TLVs rather than OF1.1 match for f

Re: [ovs-dev] [PATCH] ofproto: Fix MPLS multiple Push pop action.

2015-02-14 Thread Simon Horman
On Thu, Dec 18, 2014 at 10:31:43AM -0800, Pravin Shelar wrote: > On Tue, Dec 16, 2014 at 3:10 PM, Jarno Rajahalme > wrote: > > LGTM, > > > > With some comments below: > > > > Acked-by: Jarno Rajahalme > > > > Jarno > > > > On Dec 15, 2014, at 12:37 PM, Pravin B Shelar wrote: > > > >> vSwitchd

Re: [ovs-dev] [PATCH/RFC v2 2/8] Add types for NMX selection method

2015-02-14 Thread Simon Horman
On Fri, Feb 13, 2015 at 03:25:42PM -0800, Ben Pfaff wrote: > On Fri, Feb 13, 2015 at 06:20:40PM -0500, Simon Horman wrote: > > On Fri, Feb 13, 2015 at 01:51:54PM -0800, Ben Pfaff wrote: > > > On Fri, Jan 30, 2015 at 11:41:50AM +0900, Simon Horman wrote: > > > > NMX s

Re: [ovs-dev] [PATCH/RFC v2 2/8] Add types for NMX selection method

2015-02-14 Thread Simon Horman
On Sat, Feb 14, 2015 at 01:21:16PM -0800, Ben Pfaff wrote: > On Sat, Feb 14, 2015 at 02:21:01PM -0500, Simon Horman wrote: > > On Fri, Feb 13, 2015 at 03:25:42PM -0800, Ben Pfaff wrote: > > > On Fri, Feb 13, 2015 at 06:20:40PM -0500, Simon Horman wrote: > > > > On F

Re: [ovs-dev] Stochastic group select using kernel module

2015-02-15 Thread Simon Horman
Hi, On Sun, Feb 15, 2015 at 01:58:21PM +0100, Rhaban Hark wrote: > Hi, > > we want to achieve round-robin over different action-buckets in a group > table. Since we expect packets with identical headers (same ip & mac > address), the current implementation is not sufficient. As far as i know ovs

Re: [ovs-dev] [PATCH/RFC v2 3/8] Support decoding of NMX selection method

2015-02-15 Thread Simon Horman
On Sun, Feb 15, 2015 at 08:51:31AM -0800, Ben Pfaff wrote: > On Fri, Feb 13, 2015 at 06:14:28PM -0500, Simon Horman wrote: > > On Fri, Feb 13, 2015 at 02:55:58PM -0800, Ben Pfaff wrote: > > > On Fri, Jan 30, 2015 at 11:41:51AM +0900, Simon Horman wrote: > > > &

Re: [ovs-dev] [PATCH/RFC v2 3/8] Support decoding of NMX selection method

2015-02-18 Thread Simon Horman
On Tue, Feb 17, 2015 at 11:43:21AM -0800, Ben Pfaff wrote: > On Sun, Feb 15, 2015 at 02:13:14PM -0500, Simon Horman wrote: > > On Sun, Feb 15, 2015 at 08:51:31AM -0800, Ben Pfaff wrote: > > > On Fri, Feb 13, 2015 at 06:14:28PM -0500, Simon Horman wrote: > > > > On F

Re: [ovs-dev] [PATCH/RFC v2 3/8] Support decoding of NMX selection method

2015-03-04 Thread Simon Horman
On Wed, Mar 04, 2015 at 05:28:48PM -0800, Ben Pfaff wrote: > On Wed, Feb 18, 2015 at 09:01:31AM -0500, Simon Horman wrote: > > On Tue, Feb 17, 2015 at 11:43:21AM -0800, Ben Pfaff wrote: > > > On Sun, Feb 15, 2015 at 02:13:14PM -0500, Simon Horman wrote: > > > > On S

[ovs-dev] [PATCH v3 0/8] Group Select: Selection Method Extension

2015-03-08 Thread Simon Horman
ethod fields * Add documentation to Documentation directory To aid review I have made this series available on github: https://github.com/horms/openvswitch.git devel/ext-350+selection_method-v3 Simon Horman (8): Use NTR rather than NTR as prefix for Netronome vendor id Documentation

[ovs-dev] [PATCH v3 1/8] Use NTR rather than NTR as prefix for Netronome vendor id

2015-03-08 Thread Simon Horman
Netronome vendor id. This is in preparation for actually using the Netronome vendor id. Signed-off-by: Simon Horman --- v3 * First post --- include/openflow/openflow-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/openflow/openflow-common.h b/include

[ovs-dev] [PATCH v3 5/8] Support encoding of NTR selection method

2015-03-08 Thread Simon Horman
Include NTR selection method experimenter group property in in group mod request and group desc reply. NTR selection method Signed-off-by: Simon Horman --- v3 * Use fixed array for fields_array rather than constructing a list * Use NTR instead of NMX as Netronome extension prefix v2 * Use

[ovs-dev] [PATCH v3 6/8] Support translation of NTR selection method

2015-03-08 Thread Simon Horman
Only the default existing behaviour is translated. All other methods are rejected for now. NTR selection method Signed-off-by: Simon Horman --- v3 * No change v2 * Use array of TLVs rather than OF1.1 match for fields field of NTR selection method property --- ofproto/ofproto-dpif-xlate.c

[ovs-dev] [PATCH v3 4/8] Support decoding of NTR selection method

2015-03-08 Thread Simon Horman
selection method. NTR selection method Signed-off-by: Simon Horman --- v3 * Add check to only permit known selection methods: currently none * Use fixed array for fields_array rather than constructing a list * Use NTR instead of NMX as Netronome extension prefix v2 * Use list of struct

[ovs-dev] [PATCH v3 2/8] Documentation: Add documentation of group selection method property

2015-03-08 Thread Simon Horman
NTR selection method Signed-off-by: Simon Horman --- v3 * Use NTR instead of NMX as Netronome extension prefix v2 * Initial post --- Documentation/automake.mk | 2 + Documentation/group-selection-method-property.txt | 153 ++ Makefile.am

[ovs-dev] [PATCH v3 3/8] Add types for NTR selection method

2015-03-08 Thread Simon Horman
NTR selection method Signed-off-by: Simon Horman --- This patch does not define any selection method names, however, a subsequent patch proposes a "hash" selection method. v3 * Use NTR instead of NMX as Netronome extension prefix v2 * Use array of TLVs rather than OF1.1 match for fi

[ovs-dev] [PATCH v3 8/8] Implement hash fields select group

2015-03-08 Thread Simon Horman
This is intended as a usable demonstration of how the NTR selection method extension might may be used. NTR selection method Signed-off-by: Simon Horman --- v3 * Update new check in parse_group_prop_nmx_selection_method() to allow decoding hash selection method * Use fixed array for

[ovs-dev] [PATCH v3 7/8] Support NTR selection method in ovs-ofctl group commands

2015-03-08 Thread Simon Horman
NTR selection method Signed-off-by: Simon Horman --- v3 * Use fixed array for fields_array rather than constructing a list * Use NTR instead of NMX as Netronome extension prefix v2 * Use list of struct field_array of TLVs rather than OF1.1 match for fields field of NTR selection method

<    4   5   6   7   8   9   10   11   12   13   >