On Sat, Feb 14, 2015 at 01:21:16PM -0800, Ben Pfaff wrote: > On Sat, Feb 14, 2015 at 02:21:01PM -0500, Simon Horman wrote: > > On Fri, Feb 13, 2015 at 03:25:42PM -0800, Ben Pfaff wrote: > > > On Fri, Feb 13, 2015 at 06:20:40PM -0500, Simon Horman wrote: > > > > On Fri, Feb 13, 2015 at 01:51:54PM -0800, Ben Pfaff wrote: > > > > > On Fri, Jan 30, 2015 at 11:41:50AM +0900, Simon Horman wrote: > > > > > > NMX selection method > > > > > > Signed-off-by: Simon Horman <simon.hor...@netronome.com> > > > > > > > > > > > > --- > > > > > > * v2 > > > > > > Use array of TLVs rather than OF1.1 match for fields field of > > > > > > NMX selection method property > > > > > > > > > > I'm a little surprised that no selection method names are defined in > > > > > this or in the documentation. Is it expected that initially only the > > > > > empty string is used? > > > > > > > > My thinking was to start with a framework no methods defined. > > > > And then to add methods with their implementation as use-cases arise. > > > > > > > > The last patch of this series implements a "hash" method although > > > > it is primarily intended as an example. > > > > > > Ah, OK, I understand now. That's fine. > > > > > > Is the empty string intended to be a valid method? > > > > The intention is that the empty string gives the same behaviour > > as the property being absent. That is the current/default behaviour. > > OK. Is there anything useful about that? It might be better to forbid > the property if it has no effect. (I understand that that might not > work out in the initial commit before there are any methods.)
It was just an arbitrary design decision and I can't think of any reason that your suggested change wouldn't work out. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
