On Wed, Jun 25, 2014 at 02:19:38PM -0700, Ben Pfaff wrote:
> On Tue, Jun 24, 2014 at 08:46:30AM +0900, Simon Horman wrote:
> > The motivation of this series is to allow some sequences of actions
> > that include MPLS actions to be performed using recirculation.
> > Sequences
On Wed, Jun 25, 2014 at 10:51:52AM +0900, Simon Horman wrote:
> On Tue, Jun 24, 2014 at 04:24:37PM -0700, Jesse Gross wrote:
> > On Tue, Jun 24, 2014 at 4:56 AM, Simon Horman wrote:
> > > Allow datapath to recognize and extract MPLS labels into flow keys
> > > and exec
On Sat, Jun 28, 2014 at 08:59:01AM -0700, Jesse Gross wrote:
> On Fri, Jun 27, 2014 at 5:55 PM, Simon Horman wrote:
> > On Wed, Jun 25, 2014 at 10:51:52AM +0900, Simon Horman wrote:
> >> On Tue, Jun 24, 2014 at 04:24:37PM -0700, Jesse Gross wrote:
> >> > * Maybe
mechanism to expose the inner ethernet type beyond that of
the outermost VLAN tag.
Suggested-by: Jesse Gross
Signed-off-by: Simon Horman
---
datapath/flow_netlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
index 5a1a487..bfbf03e
On Tue, Jul 01, 2014 at 04:58:06PM -0700, Jesse Gross wrote:
> On Sun, Jun 29, 2014 at 9:20 PM, Simon Horman wrote:
> > This patch loosens the restrictions surrounding push and pop MPLS actions
> > such that they will be allowed after a pop VLAN action if the inner
> > ethern
On Thu, Sep 11, 2014 at 05:46:03PM -0700, Jesse Gross wrote:
> On Sun, Sep 7, 2014 at 7:18 PM, Simon Horman
> wrote:
> > On Fri, Sep 05, 2014 at 12:07:17PM -0700, Jesse Gross wrote:
> >> On Thu, Sep 4, 2014 at 12:28 AM, Simon Horman
> >> wrote:
> >> >
5545e7826896e861c ("lib/odp-util: Add tunnel tp_src,
tp_dst parsing and formatting") of that tree.
Simon Horman (8):
odp: select group action attributes
netlink: Allow suppression of warnings for duplicate attributes
odp-util: formatting of datapath select group action
datapath: execution
relates to a proposed
Open Flow extension that we have made.
Signed-off-by: Simon Horman
---
datapath/linux/compat/include/linux/openvswitch.h | 31 +++
lib/dpif-netdev.c | 1 +
lib/dpif.c| 1 +
lib/odp
it
is up to the caller to parse the message to extract all the attributes.
This is in preparation for allowing multiple OVS_SELECT_GROUP_ATTR_BUCKET
attributes in a nested OVS_ACTION_ATTR_SELECT_GROUP attribute.
Signed-off-by: Simon Horman
---
lib/netlink.c | 2 +-
lib/netlink.h | 1 +
2 files
Allow formatting of select group action. This is used
when pretty-printing datapath flows. Subsequent patches
will add support for the select group action to the datapath
and ovs-vswtichd.
Signed-off-by: Simon Horman
---
lib/odp-util.c | 67
.
Thus the algorithm and used and its implementation are not central
to the prototype.
Signed-off-by: Simon Horman
---
datapath/actions.c | 70 ++
1 file changed, 70 insertions(+)
diff --git a/datapath/actions.c b/datapath/actions.c
index 8d18848
This is in preparation for using last_action() from
more than one C file as part of supporting an odp select group action.
Signed-off-by: Simon Horman
---
datapath/actions.c | 6 --
datapath/datapath.h | 5 +
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/datapath
This is a quick hack to enable the datapath group select action.
It is in lieu of some combination of:
* probing
* run-time configuration by the end-use.
* run-time heuristic to use the action as appropriate
Signed-off-by: Simon Horman
---
ofproto/ofproto-dpif-xlate.c | 2 +-
1 file changed, 1
Allow validation and copying of select group actions.
This completes the prototype select group action implementation
in the datapath. Subsequent patches will add support to ovs-vswtichd.
Signed-off-by: Simon Horman
---
datapath/flow_netlink.c | 102
This would most likely require further datapath modifications.
Signed-off-by: Simon Horman
---
ofproto/ofproto-dpif-xlate.c | 108 ++-
1 file changed, 107 insertions(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-x
packets may be forwarded
incorrectly.
Signed-off-by: Simon Horman
---
ofproto/ofproto-dpif-rid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-rid.c b/ofproto/ofproto-dpif-rid.c
index b3d98eb..e75dfc8 100644
--- a/ofproto/ofproto-dpif-rid.c
+++ b/ofproto
It is add-groups rather than add-group that takes FILE as an argument.
Signed-off-by: Simon Horman
---
utilities/ovs-ofctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index 4a90155..8dcd72c 100644
--- a/utilities/ovs
On Fri, Sep 19, 2014 at 02:44:49PM +0100, Thomas Graf wrote:
> On 09/18/14 at 10:55am, Simon Horman wrote:
> > Allow formatting of select group action. This is used
> > when pretty-printing datapath flows. Subsequent patches
> > will add support for the select group action to
On Fri, Sep 19, 2014 at 03:06:38PM +0100, Thomas Graf wrote:
> On 09/18/14 at 10:55am, Simon Horman wrote:
> > diff --git a/datapath/datapath.h b/datapath/datapath.h
> > index c5d3c86..74a15e6 100644
> > --- a/datapath/datapath.h
> > +++ b/datapath/datapath.h
On Fri, Sep 19, 2014 at 03:05:27PM +0100, Thomas Graf wrote:
> On 09/18/14 at 10:55am, Simon Horman wrote:
> > +const struct nlattr *bucket_actions(const struct nlattr *attr)
> > +{
> > + const struct nlattr *a;
> > + int rem;
> > +
> > + for (a = nla_d
On Wed, Sep 24, 2014 at 02:06:46PM -0700, Andy Zhou wrote:
> Pushed. Thanks for the fix!
Thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Hi,
this short series proposes to minor simplifications to ofproto-dpif-rid.
They are not related to each other other than that there is a minor
conflict in applying the second patch if the first one is not present.
Simon Horman (2):
ofproto-dpif-rid: remove struct rid_map
ofproto-dpif-rid
struct rid_map only has one member which is a struct hmap.
This allows for a slight simplification of the code by removing
struct rid_map and using a struct hmap directly instead.
Signed-off-by: Simon Horman
---
ofproto/ofproto-dpif-rid.c | 20
1 file changed, 8 insertions
The return value of rid_pool_add() is never used
so the code may be slightly simplified by removing it.
Signed-off-by: Simon Horman
---
ofproto/ofproto-dpif-rid.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/ofproto/ofproto-dpif-rid.c b/ofproto/ofproto-dpif-rid.c
Signed-off-by: Simon Horman
---
I have now had one patch accepted from this address,
I hope there will be more.
I would also like to continue to use ho...@verge.net.au
for work that is not related to Netronome.
---
AUTHORS | 1 +
1 file changed, 1 insertion(+)
diff --git a/AUTHORS b/AUTHORS
helper means it is best off in netlink.h regardless of if it is used more than
one .c file or not. Thus I would like it considered independent
of the work on an odp select group action.
Signed-off-by: Simon Horman
---
datapath/actions.c | 11 +++
datapath/linux
On Wed, Sep 24, 2014 at 09:20:15AM +0100, Thomas Graf wrote:
> On 09/24/14 at 03:00pm, Simon Horman wrote:
> > On Fri, Sep 19, 2014 at 03:06:38PM +0100, Thomas Graf wrote:
> > > Can we rename & move this to instead?
> >
> > Sure, how about nla_is_last()?
>
On Wed, Sep 24, 2014 at 09:19:42AM +0100, Thomas Graf wrote:
> On 09/24/14 at 03:01pm, Simon Horman wrote:
> > > > + /* Only possible type of attributes is
> > > > OVS_SELECT_GROUP_ATTR_BUCKET */
> > > > + for (bucket = nla_d
On Tue, Oct 07, 2014 at 09:50:36PM -0700, Stephen Hemminger wrote:
> On Wed, 8 Oct 2014 09:40:51 +0900
> Simon Horman wrote:
>
> > +struct ovs_offload_ops {
> > + /* Flow offload functions */
> > + /* Called when a flow entry is added to the flow table */
>
On Tue, Oct 07, 2014 at 09:55:21PM -0700, Stephen Hemminger wrote:
> On Wed, 8 Oct 2014 09:40:51 +0900
> Simon Horman wrote:
>
> > +
> > +struct ovs_offload_ops {
> > + /* Flow offload functions */
> > + /* Called when a flow entry is added to the flow
On Fri, Sep 26, 2014 at 04:57:25PM -0700, Ben Pfaff wrote:
> On Thu, Sep 18, 2014 at 10:55:10AM +0900, Simon Horman wrote:
> > This patch is a prototype and has several limitations:
> >
> > * It assumes that no actions follow a select group action
> > because the resu
On Fri, Sep 26, 2014 at 04:55:42PM -0700, Ben Pfaff wrote:
> On Thu, Sep 18, 2014 at 10:55:05AM +0900, Simon Horman wrote:
> > Add a multiple field to struct nl_policy which if set suppresses
> > warning of duplicate attributes in nl_parse_nested().
> >
> > As is the c
On Mon, Oct 13, 2014 at 01:46:24PM -0700, Ben Pfaff wrote:
> On Thu, Oct 09, 2014 at 10:14:36AM +0900, Simon Horman wrote:
> > On Fri, Sep 26, 2014 at 04:57:25PM -0700, Ben Pfaff wrote:
> > > On Thu, Sep 18, 2014 at 10:55:10AM +0900, Simon Horman wrote:
> > > > Thi
ough I'm not sure if upstream likes
to take new API calls that aren't used. Perhaps a good way forwards
would be for me to re-submit this patch against the upstream net-next
kernel.
Pravin, how would you feel about that?
>
>
> On Wed, Sep 24, 2014 at 9:28 PM, Simon Horman
>
2014/10/17 19:25 "Pravin Shelar" :
>
> On Fri, Oct 17, 2014 at 12:16 AM, Simon Horman
> wrote:
> > On Thu, Oct 16, 2014 at 04:50:10PM -0700, Andy Zhou wrote:
> >> Simon, The change makes a lot of sense.
> >>
> >> I am just wondering if we should
ages. A test is also added to exercise
this change.
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 14 ++
tests/ofproto.at | 16
2 files changed, 30 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index d765d03..573f38a 100644
--- a/lib/ofp-util.c
helper means it is best off in netlink.h regardless of if it is used more
than one .c file or not. Thus, I would like it considered independent of
the work on an odp select group action.
Cc: Thomas Graf
Cc: Pravin Shelar
Cc: Andy Zhou
Signed-off-by: Simon Horman
---
include/net/netlink.h
On Fri, Oct 10, 2014 at 09:40:56AM -0700, Ben Pfaff wrote:
> On Wed, Oct 08, 2014 at 02:09:53PM -0700, Daniele Di Proietto wrote:
> > Signed-off-by: Daniele Di Proietto
>
> Can you estimate the additional memory overhead per-datapath flow that
> this adds? Our recent review of customer data (for
On Thu, Oct 16, 2014 at 02:33:03PM -0700, Jarno Rajahalme wrote:
> flow inserts and removals are simplified:
>
> - No need for classifier internal mutex, as dpif-netdev already has a
> 'flow_mutex'.
> - Number of memory allocations/frees can be halved.
>
> Lookup code path is a bit more effcien
On Tue, Oct 28, 2014 at 05:08:08PM -0400, David Miller wrote:
> From: Simon Horman
> Date: Mon, 27 Oct 2014 16:12:16 +0900
>
> > The original motivation for this change was to allow the helper to be used
> > in files other than actions.c as part of work on an odp se
On Tue, Oct 28, 2014 at 02:47:00PM -0700, Alex Wang wrote:
> Hey Simon,
>
> I did the following test:
>
> - Environment:
>
>host 1: 7 pmd threads, each pmd thread handling one rx queue from
>interface dpdk1
>
>
>bash-4.3# ovs-appctl dpctl/show
>netdev@ovs-netdev:
>l
To some extent this is cosmetic because ovs-ovfctl will immediately
exit. However, it does seem to be in keeping with freeing 'gms' in
ofctl_group_mod_file().
Found by inspection using make check-valgrind.
Signed-off-by: Simon Horman
---
utilities/ovs-ofctl.c | 5 +
1 file
Hi,
this short series fixes some (minor) memory leaks
by freeing group buckets.
Found by inspection using make check-valgrind
Simon Horman (2):
ovs-ofctl: Free group buckets
ofp-print-ofctl: Free group buckets
lib/ofp-print.c | 2 ++
utilities/ovs-ofctl.c | 5 +
2 files changed
Found by inspection using make check-valgrind.
Signed-off-by: Simon Horman
---
lib/ofp-print.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index 43bfa17..8dc7f06 100644
--- a/lib/ofp-print.c
+++ b/lib/ofp-print.c
@@ -2167,6 +2167,7
Slightly simplify match_format() by using ds_chomp()
rather than open-coding its logic.
Signed-off-by: Simon Horman
---
lib/match.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/match.c b/lib/match.c
index cbfd735..bd3b13d 100644
--- a/lib/match.c
+++ b/lib/match.c
If usable_protocols_bitwise and usable_protocols_cidr are equal
then it does not matter which one is returned. This leads to
a slight simplification of the selection logic.
Signed-off-by: Simon Horman
---
lib/meta-flow.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib
Slightly simplify ofp10_match_to_string() by using ds_chomp()
rather than open-coding its logic.
Signed-off-by: Simon Horman
---
lib/ofp-print.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index 8dc7f06..d27d8a7 100644
--- a/lib/ofp
On Tue, Nov 04, 2014 at 08:42:23AM -0800, Ben Pfaff wrote:
> On Tue, Nov 04, 2014 at 03:13:21PM +0900, Simon Horman wrote:
> > If usable_protocols_bitwise and usable_protocols_cidr are equal
> > then it does not matter which one is returned. This leads to
> > a slight
parse_ofp_group_mod_str() may limit the usable protocols according
to the group and in particular its actions. However, without this
change ovs-ofctl ignores this calculation.
Signed-off-by: Simon Horman
---
utilities/ovs-ofctl.c | 13 -
1 file changed, 8 insertions(+), 5 deletions
On Thu, Nov 06, 2014 at 03:01:23PM -0800, Ben Pfaff wrote:
> On Wed, Nov 05, 2014 at 01:57:39PM +0900, Simon Horman wrote:
> > parse_ofp_group_mod_str() may limit the usable protocols according
> > to the group and in particular its actions. However, without this
> > change o
including properties
- Used by both group mod and group desc stats
* Bucket actions
- A sub-set of a group's buckets may be added or deleted
Simon Horman (22):
id-pool: re-factor recirculation id allocator into stand-alone id pool
id-pool: Refactor id_pool_alloc_id to allow any 3
Refactor the lock-free portion of the recirculation id allocator
into stand-alone id pool. This is in preparation for re-using
that portion to allocate bucket ids which are part of (draft)
Open Flow 1.5 groups.
EXT-350
Signed-off-by: Simon Horman
---
lib/automake.mk| 2 +
lib/id
id_pool_alloc_id() was created by breaking out the recirculation
allocation code. As it is now a library call it makes sense to remove
the restriction that id 0 is reserved.
Signed-off-by: Simon Horman
---
lib/id-pool.c | 43 ++-
lib/id
Add OFPERR_OFPGMFC_UNKNOWN_BUCKET and OFPERR_OFPGMFC_BUCKET_EXISTS
which are part of (draft) OpenFlow 1.5 groups.
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-errors.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/ofp-errors.h b/lib/ofp-errors.h
index 2516b39..40c7910 100644
EXT-350
Signed-off-by: Simon Horman
---
include/openflow/openflow-1.5.h | 159 +++-
1 file changed, 158 insertions(+), 1 deletion(-)
diff --git a/include/openflow/openflow-1.5.h b/include/openflow/openflow-1.5.h
index a5a51c0..a413755 100644
--- a/include
This is in preparation for supporting (draft) OpenFlow1.5 group mod.
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-msgs.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-msgs.h b/lib/ofp-msgs.h
index a78747e..fc69586 100644
--- a/lib/ofp-msgs.h
+++ b/lib/ofp
The group bucket encoding code appears in two places
in almost identical form. Consolidate this into
a helper function.
The helper name includes ofp11 as later patches
will add and ofp15 version to support (draft) OpenFlow 1.5 buckets.
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-util.c
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-print.c | 39 ---
tests/ofproto.at | 2 +-
2 files changed, 37 insertions(+), 4 deletions(-)
diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index d27d8a7..68f5740 100644
--- a/lib/ofp-print.c
+++ b/lib/ofp
This refactoring is in preparation for supporting encoding
of (draft) OpenFlow 1.5 group mod messages.
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 45 +
1 file changed, 25 insertions(+), 20 deletions(-)
diff --git a/lib/ofp-util.c b/lib
Rename ofputil_pull_buckets() as ofputil_pull_buckets11()
to denote that it decodes OpenFlow 1.1 buckets (also used in
OpenFlow 1.2 to 1.4).
This refactoring is in preparation for supporting decoding
of (draft) OpenFlow 1.5 group mod messages and their
buckets.
EXT-350
Signed-off-by: Simon
This refactoring is in preparation for supporting encoding
of (draft) OpenFlow 1.5 group mod messages.
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 46 +-
1 file changed, 33 insertions(+), 13 deletions(-)
diff --git a/lib/ofp-util.c b/lib
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-print.c| 50 +++--
tests/ofp-print.at | 60 --
2 files changed, 97 insertions(+), 13 deletions(-)
diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index
This refactoring is in preparation for supporting encoding
of (draft) OpenFlow 1.5 group mod messages.
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 37 ++---
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp
This refactoring is in preparation for supporting encoding
of (draft) OpenFlow 1.5 group mod messages.
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 39 +++
1 file changed, 31 insertions(+), 8 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp
-experimenter
properties are defined this patch does not provide parsing or encoding
of group properties.
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-parse.c | 2 +
lib/ofp-util.c | 469 +++-
lib/ofp-util.h | 8 +-
3 files changed, 474
This is to exercise OpenFlow 1.3 group stats replies
messages which include a duration.
Signed-off-by: Simon Horman
---
tests/ofproto.at | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index d5998a8..2adce8a
(Draft) OpenFlow 1.5 adds bucket commands to group mod.
This patch allows parsing of them as a step towards supporting them.
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-parse.c | 60 ++---
1 file changed, 57 insertions(+), 3 deletions
This is part of support for (draft) OpenFlow 1.5 flow mod messages.
This adds support for specifying the bucket_id of buckets of groups in
ovs-ofctl and documents that accordingly.
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-parse.c | 11 +--
utilities/ovs-ofctl.8.in | 7
This motivation for this change is to exercise
(draft) OpenFlow 1.5 group messages.
EXT-350
Signed-off-by: Simon Horman
---
tests/ofproto.at | 68
1 file changed, 64 insertions(+), 4 deletions(-)
diff --git a/tests/ofproto.at b/tests
In preparation for supporting (draft) OpenFlow 1.5
group mod commands enhance the error logging of them.
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 48
1 file changed, 36 insertions(+), 12 deletions(-)
diff --git a/lib/ofp-util.c b
This is in preparation for supporting the bucket commands of
(draft) Open Flow 1.5 group mod messages.
EXT-350
Signed-off-by: Simon Horman
---
lib/ofp-util.c | 67 ++
lib/ofp-util.h | 6 ++
2 files changed, 73 insertions(+)
diff
Handle (draft) OpenFlow 1.5 insert and remove group commands
of group mod messages.
EXT-350
Signed-off-by: Simon Horman
---
ofproto/ofproto.c | 110 +-
1 file changed, 109 insertions(+), 1 deletion(-)
diff --git a/ofproto/ofproto.c b/ofproto
(Draft) OpenFlow 1.5 flow mod commands include commands to manipulate the
buckets of existing groups. This patch add support to ovs-ofctl for these
commands. It also adds documentation and tests for them.
EXT-350
Signed-off-by: Simon Horman
---
tests/ofproto.at | 94
On Mon, Nov 10, 2014 at 09:43:01AM -0800, Ben Pfaff wrote:
> On Mon, Nov 10, 2014 at 01:47:50PM +0900, Simon Horman wrote:
> > Add OFPERR_OFPGMFC_UNKNOWN_BUCKET and OFPERR_OFPGMFC_BUCKET_EXISTS
> > which are part of (draft) OpenFlow 1.5 groups.
> >
> > EXT-350
>
>
On Mon, Nov 10, 2014 at 09:55:53AM -0800, Ben Pfaff wrote:
> On Mon, Nov 10, 2014 at 01:47:51PM +0900, Simon Horman wrote:
> > EXT-350
> > Signed-off-by: Simon Horman
>
> Thanks, Simon!
>
> I see some misspellings of OpenFlow as "OpenFLow"
On Mon, Nov 10, 2014 at 10:13:53AM -0800, Ben Pfaff wrote:
> On Mon, Nov 10, 2014 at 01:47:59PM +0900, Simon Horman wrote:
> > This provides the bulk of the ofproto side of support for
> > OpenFlow 1.5 group messages. It provides for encoding and decoding
> > of updated gro
On Mon, Nov 10, 2014 at 09:58:38AM -0800, Ben Pfaff wrote:
> On Mon, Nov 10, 2014 at 01:47:52PM +0900, Simon Horman wrote:
> > This is in preparation for supporting (draft) OpenFlow1.5 group mod.
> >
> > EXT-350
> > Signed-off-by: Simon Horman
>
> Thanks.
>
On Tue, Nov 11, 2014 at 10:01:01AM +0900, Simon Horman wrote:
> On Mon, Nov 10, 2014 at 09:55:53AM -0800, Ben Pfaff wrote:
> > On Mon, Nov 10, 2014 at 01:47:51PM +0900, Simon Horman wrote:
> > > EXT-350
> > > Signed-off-by: Simon Horman
> >
> > Thanks, Sim
r the new errors
- Remove unused/unnecessary ofp15_* strures
- Do not imply actions are a list: they are a set
* Dropped many patches that have been merged. Thanks Ben!
Simon Horman (13):
ofp-errors: Add (draft) OpenFlow 1.5 group mod errors
ofproto: Add types for (draft) OpenFlow 1.5 grou
Add OFPERR_OFPGMFC_UNKNOWN_BUCKET and OFPERR_OFPGMFC_BUCKET_EXISTS
which are part of (draft) OpenFlow 1.5 groups.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v2
* As suggested by Ben Pfaff
- Use ONF-JIRA: EXT-350 annotation in changelog
- Use correct descriptions for the new errors
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v2
* As suggested by Ben Pfaff
+ Use ONF-JIRA: EXT-350 annotation in changelog
+ Correct spelling: s/FLow/Flow/
+ Removed the following which seem unnecessary in the context of this
patchset:
- struct ofp15_group_bucket_prop_header
-experimenter
properties are defined this patch does not provide parsing or encoding
of group properties.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v2
* Rebase to use actions_len field of struct ofp15_bucket
instead of action_list_len field
* As suggested by Ben Pfaff
- Use ONF-JIRA: EXT-350
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v2
* As suggested by Ben Pfaff
- Use ONF-JIRA: EXT-350 annotation in changelog
---
lib/ofp-print.c | 39 ---
tests/ofproto.at | 2 +-
2 files changed, 37 insertions(+), 4 deletions(-)
diff --git a/lib/ofp
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v2
* As suggested by Ben Pfaff
- Use ONF-JIRA: EXT-350 annotation in changelog
---
lib/ofp-print.c| 50 +++--
tests/ofp-print.at | 60 --
2 files
This is part of support for (draft) OpenFlow 1.5 flow mod messages.
This adds support for specifying the bucket_id of buckets of groups in
ovs-ofctl and documents that accordingly.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v2
* As suggested by Ben Pfaff
- Use ONF-JIRA: EXT-350
This is to exercise OpenFlow 1.3 group stats replies
messages which include a duration.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v2
* As suggested by Ben Pfaff
- Use ONF-JIRA: EXT-350 annotation in changelog
---
tests/ofproto.at | 26 +-
1 file changed, 25
This motivation for this change is to exercise
(draft) OpenFlow 1.5 group messages.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v2
* As suggested by Ben Pfaff
- Use ONF-JIRA: EXT-350 annotation in changelog
---
tests/ofproto.at | 68
In preparation for supporting (draft) OpenFlow 1.5
group mod commands enhance the error logging of them.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v2
* As suggested by Ben Pfaff
- Use ONF-JIRA: EXT-350 annotation in changelog
---
lib/ofp-util.c | 48
Handle (draft) OpenFlow 1.5 insert and remove group commands
of group mod messages.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v2
* As suggested by Ben Pfaff
- Use ONF-JIRA: EXT-350 annotation in changelog
---
ofproto/ofproto.c | 110
(Draft) OpenFlow 1.5 adds bucket commands to group mod.
This patch allows parsing of them as a step towards supporting them.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v2
* As suggested by Ben Pfaff
- Use ONF-JIRA: EXT-350 annotation in changelog
---
lib/ofp-parse.c | 60
On Mon, Nov 10, 2014 at 08:34:30PM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 10:01:03AM +0900, Simon Horman wrote:
> > On Mon, Nov 10, 2014 at 09:55:53AM -0800, Ben Pfaff wrote:
> > > On Mon, Nov 10, 2014 at 01:47:51PM +0900, Simon Horman wrote:
> > > > EXT-35
On Tue, Nov 11, 2014 at 08:49:56AM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 12:39:19PM +0900, Simon Horman wrote:
> > This provides the bulk of the ofproto side of support for
> > OpenFlow 1.5 group messages. It provides for encoding and decoding
> > of updated gro
On Tue, Nov 11, 2014 at 09:15:51AM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 12:39:22PM +0900, Simon Horman wrote:
> > This is part of support for (draft) OpenFlow 1.5 flow mod messages.
> >
> > This adds support for specifying the bucket_id of buckets of groups
On Tue, Nov 11, 2014 at 09:21:36AM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 12:39:25PM +0900, Simon Horman wrote:
> > In preparation for supporting (draft) OpenFlow 1.5
> > group mod commands enhance the error logging of them.
> >
> > ONF-JIRA: EXT-350
>
On Tue, Nov 11, 2014 at 09:33:08AM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 12:39:29PM +0900, Simon Horman wrote:
> > (Draft) OpenFlow 1.5 flow mod commands include commands to manipulate the
> > buckets of existing groups. This patch add support to ovs-ofctl for these
&
On Tue, Nov 11, 2014 at 09:27:56AM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 12:39:27PM +0900, Simon Horman wrote:
> > Handle (draft) OpenFlow 1.5 insert and remove group commands
> > of group mod messages.
> >
> > ONF-JIRA: EXT-350
> > Signed-off-by:
On Tue, Nov 11, 2014 at 09:24:10AM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 12:39:26PM +0900, Simon Horman wrote:
> > This is in preparation for supporting the bucket commands of
> > (draft) Open Flow 1.5 group mod messages.
> >
> > ONF-JIRA: EXT-350
>
On Tue, Nov 11, 2014 at 08:45:59PM -0800, Ben Pfaff wrote:
> On Wed, Nov 12, 2014 at 01:33:50PM +0900, Simon Horman wrote:
> > On Tue, Nov 11, 2014 at 09:27:56AM -0800, Ben Pfaff wrote:
> > > On Tue, Nov 11, 2014 at 12:39:27PM +0900, Simon Horman wrote:
> > > > Hand
On Tue, Nov 11, 2014 at 08:44:29PM -0800, Ben Pfaff wrote:
> On Wed, Nov 12, 2014 at 12:46:08PM +0900, Simon Horman wrote:
> > On Tue, Nov 11, 2014 at 09:21:36AM -0800, Ben Pfaff wrote:
> > > Using a blind array dereference into cmd_str[] in bad_group_cmd() seems
> > &
/unnecessary ofp15_* strures
- Do not imply actions are a list: they are a set
* Dropped many patches that have been merged.
Simon Horman (7):
ofp-util: Do not allow buckets for OFPGC15_REMOVE_BUCKET
ofp-util: Enhanced command error logging during encoding group mod
messages
ofp-util
501 - 600 of 3227 matches
Mail list logo
