Thank Nithin and Ben!
On 4/14/16, 10:14 AM, "Ben Pfaff" wrote:
>On Wed, Apr 13, 2016 at 11:54:03AM -0700, Sairam Venugopal wrote:
>> Enable support for Stateful Firewall in Hyper-V by adding a Connection
>> Tracking module. The module has been ported over from the us
Minor refactors around naming and reusability in lieu of adding support for
other
protocols for tracking connections.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Conntrack-tcp.c | 15 ---
datapath-windows/ovsext/Conntrack.c | 2 +-
datapath-windows/ovsext
Update NetProto.h to include ICMP and ICMPv6 types. Update ICMP header to
keep it consistent with KVM. Add UDP and ICMP min length definitions.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/NetProto.h | 53 +-
1 file changed, 46 insertions(+), 7
Acked-by: Sairam Venugopal
On 4/15/16, 7:05 AM, "Nithin Raju" wrote:
>dead code.
>
>Signed-off-by: Nithin Raju
>---
> datapath-windows/ovsext/User.c | 10 --
> 1 file changed, 10 deletions(-)
>
>diff --git a/datapath-windows/ovsext/User.c
>b/
e-----
>From: dev on behalf of Sairam Venugopal
>
>Date: Thursday, April 14, 2016 at 12:07 PM
>To: "dev@openvswitch.org"
>Subject: [ovs-dev] [PATCH] datapath-windows: Refactor Conntrack Module
>in Hyper-V
>
>>Minor refactors around naming and reusabili
Acked-by: Sairam Venugopal
On 4/15/16, 5:04 PM, "Daniele Di Proietto" wrote:
>The userspace conntrack had a bug in tcp_wscale_get(), where the length
>of an option would be read from the third octet of the option TLV
>instead of the second. This could cause an incorrect
Add braces around the if condition to prevent Visual Studio from giving
the "error C2275: illegal use of this type as an expresion". This happens
when a variable is declared after a block. This error occurs on certain
versions of compilers.
Signed-off-by: Sairam Venugopal
---
datapa
Hi Paul,
Please see the comments inlined.
Thanks,
Sairam
On 4/18/16, 1:31 PM, "Paul Boca" wrote:
>Added OvsExtractLayers - populates only the layers field without
>unnecessary
>memory operations for flow part
>If in STT header the flags are 0 then force packets checksums calculation
>Ensure co
Thanks for incorporating the review comments. I noticed that V2 hasn¹t
been ACKED yet.
Acked-by: Sairam Venugopal
On 3/10/16, 5:33 AM, "Alin Serdean"
wrote:
>A PnP(plug and play) event will be triggered before trying to disable
>the extension. We could use this PnP even
gards,
Sairam Venugopal
On Apr 26, 2016, at 9:08 AM, Alin Serdean
wrote:
>>> -UINT32 encapMss = OvsGetExternalMtu(switchContext) - sizeof(IPHdr) -
>>> sizeof(TCPHdr);
>>> +UINT32 encapMss = OvsGetExternalMtu(switchContext)
>>&
When the recirc action is in middle, the current code creates a clone of
the NBL. However, it overwrites the pointer to point to the cloned NBL
without completing it. This causes a memory leak that crashes the kernel.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Actions.c | 8
Enable support for UDP and ICMP in the connection tracking module on
Hyper-V.
Signed-off-by: Sairam Venugopal
---
datapath-windows/automake.mk | 1 +
datapath-windows/ovsext/Conntrack-other.c | 78 ++
datapath-windows/ovsext/Conntrack.c | 174
Hey Paul,
Thanks for clarifying what OvsExtractLayers was doing. You shouldn¹t have
to extract the layers info for the inner packet since they can be derived
from the STT Header Flags - especially when it¹s CSUM_Partial. That¹s even
mentioned in the STT IETF draft under the STT Flags section -
htt
Hi Paul,
I have added my reply below.
Thanks,
Sairam
On 5/3/16, 5:17 AM, "Paul Boca" wrote:
>Hi Sai,
>
>Please see the comments inline.
>
>Thanks,
>Paul
>
>> -Original Message-
>> From: Sairam Venugopal [mailto:vsai...@vmware.com]
>> Se
Pass down the right sendFlags for re-init fwdCtx. Remove the redundant
call to ExtractFlow. It resets the flowKey causing failure in tunnel
context.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Actions.c | 15 +++
datapath-windows/ovsext/Actions.h | 1 +
datapath
me if I'm wrong.
>
>
>
>Thanks,
>
>Paul
>
>
>
>> -Original Message-----
>
>> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam
>
>> Venugopal
>
>> Sent: Thursday, April 28, 2016 2:23 AM
>
>> To: dev@openvswit
Enable support for UDP and ICMP in the connection tracking module on
Hyper-V.
Signed-off-by: Sairam Venugopal
---
datapath-windows/automake.mk | 1 +
datapath-windows/ovsext/Conntrack-other.c | 78 +
datapath-windows/ovsext/Conntrack.c | 180
Disregard this patch. I have more changes on this.
Thanks,
Sairam
On 5/6/16, 2:21 PM, "Sairam Venugopal" wrote:
>Pass down the right sendFlags for re-init fwdCtx. Remove the redundant
>call to ExtractFlow. It resets the flowKey causing failure in tunnel
>context.
>
Acked-by: Sairam Venugopal
On 5/11/16, 1:49 PM, "Alin Serdean"
wrote:
>OpenSSL version changed from 1.0.2g to 1.0.2h this patch bumps the
>version.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> appveyor.yml | 6 +++---
> 1 file changed, 3 insertions(+),
Acked-by: Sairam Venugopal
On 5/17/16, 10:15 AM, "Nithin Raju" wrote:
>We'll need this for parsing nested attributes.
>
>Signed-off-by: Nithin Raju
>---
> datapath-windows/ovsext/DpInternal.h | 1 +
> datapath-windows/ovsext/User.c | 13
Acked-by: Sairam Venugopal
On 5/17/16, 10:15 AM, "Nithin Raju" wrote:
>While testing DFW and recirc code it was found that userspace
>was calling into packet execute with the tunnel key and the
>vport added as part of the execute structure. We were not passing
>this
Acked-by: Sairam Venugopal
On 5/17/16, 10:15 AM, "Nithin Raju" wrote:
>Move this function out from file scope.
>
>Signed-off-by: Nithin Raju
>---
> datapath-windows/ovsext/Flow.c | 16 +++-
> datapath-windows/ovsext/Flow.h | 2 ++
> 2 files change
Acked-by: Sairam Venugopal
On 5/17/16, 10:15 AM, "Nithin Raju" wrote:
>It is not necessary to do a flow extract in OvsDoRecirc().
>In fact, doing it would overwrite the tunnel key within
>'key'. So, let's remove the call.
>
>Signed-off-by: Nithin Raj
Hi Paul,
Thanks for updating the patch. I had some minor comments that I have added
inline.
It looks good overall.
Thanks,
Sairam
On 5/17/16, 8:23 AM, "Paul Boca" wrote:
>*Added OvsExtractLayers - populates only the layers field without
>unnecessary
>memory operations for flow part
>*If in ST
Thanks for fixing this. Should we log an error if we try to copy more than
allocated packet length?
Acked-by: Sairam Venugopal
On 5/17/16, 8:23 AM, "Paul Boca" wrote:
>Fixed possible deadlock in case NdisGetDataBuffer fails
>Validate the segment length and offset on rea
Acked-by: Sairam Venugopal
On 5/17/16, 8:23 AM, "Paul Boca" wrote:
>Add VLAN to STT header and on receive applyit to encapsulated packet
>
>Signed-off-by: Paul-Daniel Boca
>---
> datapath-windows/ovsext/Stt.c | 22 +-
> 1 file changed,
Hi Alin,
Thanks for the comments. Will resend a patch with some of the updates.
Have responded to some of the comments inline.
Sairam
On 5/26/16, 3:00 AM, "Alin Serdean"
wrote:
>I am unsure if we actual need another file but that maybe a personal
>preference.
Sai: Ideally we should be able to
Hi Paul,
Please see the comments inline.
Thanks!
Sairam
On 5/17/16, 8:23 AM, "Paul Boca" wrote:
>Signed-off-by: Paul-Daniel Boca
>---
> datapath-windows/ovsext/NetProto.h | 10 -
> datapath-windows/ovsext/PacketParser.h | 67
>++
> datapath-windows/ovsext
Enable support for UDP and ICMP in the connection tracking module on
Hyper-V.
Signed-off-by: Sairam Venugopal
---
datapath-windows/automake.mk | 1 +
datapath-windows/ovsext/Conntrack-other.c | 82 ++
datapath-windows/ovsext/Conntrack.c | 177
Enable support for UDP and ICMP in the connection tracking module on
Hyper-V. Define 1s as variable and reuse it.
Signed-off-by: Sairam Venugopal
---
datapath-windows/automake.mk | 1 +
datapath-windows/ovsext/Conntrack-other.c | 82 ++
datapath-windows/ovsext
Disregard this patch. I have sent out a v4 which addresses another review
comment.
On 6/2/16, 5:12 PM, "Sairam Venugopal" wrote:
>Enable support for UDP and ICMP in the connection tracking module on
>Hyper-V.
>
>Signed-off-by: Sairam Venugopal
>---
>
Acked-by: Sairam Venugopal
On 5/9/16, 5:46 PM, "Alin Serdean" wrote:
>Remove ununsed variables, found by inspection.
>
>On fail reset extInfo name.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> datapath-windows/ovsext/Vport.c | 4 +---
> 1 file changed, 1 in
OvsReadEventCmdHandler must now reflect the right event being read. If the
event is a Conntrack related event, then convert the entry to netlink
format and send it to userspace. If it's Vport event, retain the existing
workflow.
Signed-off-by: Sairam Venugopal
---
datapath-windows/o
Post Conntrack delete and create events when entries are deleted or
created.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Conntrack.c | 12
1 file changed, 12 insertions(+)
diff --git a/datapath-windows/ovsext/Conntrack.c
b/datapath-windows/ovsext/Conntrack.c
index
Send out events when a Conntrack entry is created or destroyed. The events can
be listened using the netlink multicast subscription. Also fix few bugs in
Event.c around event handling.
Sairam Venugopal (9):
datapath-windows: Rename OVS_EVENT_ENTRY to OVS_VPORT_EVENT_ENTRY
datapath-windows
Update the datapath to refer to events as vportEvents. This will aid in
the introduction of other events.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Datapath.c | 3 ++-
datapath-windows/ovsext/Event.c| 10 +-
datapath-windows/ovsext/Event.h| 7
on returns back without
releasing the lock. Moving the OvsAcquireEventQueueLock() after the
instance is verified.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Event.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/datapath-windows/ovsext/Event.c b/datapa
Tweak the OvsCreateNlMsgFromCtEntry() method to reuse it for creating
netlink messages from other files. Also define the function in Conntrack.h
to make it accessible.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Conntrack.c | 32 ++--
datapath-windows
Define new Conntrack events (new and delete) and add support for
subscribing to these events. Parse out OVS_NL_ATTR_MCAST_GRP and store it
as part of OVS_EVENT_SUBSCRIBE structure.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Datapath.c | 21 ++---
datapath
Update Event.c to have multiple event queues and mechanism to retrieve the
associated queue. Introduce OvsPostCtEvent and OvsRemoveCtEventEntry
similar to OvsPostVportEvent and OvsRemoveVportEventEntry.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Event.c | 265
OVS_EVENT_ENTRY currently handles only Vport related events. Updating the
name of the struct to OVS_VPORT_EVENT_ENTRY. This will assist in
introducing other structs to manage other events.
Remove OVS_EVENT_STATUS since it's currently not in use.
Signed-off-by: Sairam Venugopal
---
dat
The Hyper-V datapath supports NETLINK_GENERIC and NETLINK_NETFILTER
protocols for netlink communication. Define these two protocols in the
datapath.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Netlink/NetlinkProto.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/datapath
Thanks for the patch!
Acked-by: Sairam Venugopal
On 7/4/16, 2:53 AM, "Paul Boca" wrote:
>"If the length of the payload to be encapsulated exceeds 64KB, or if
>the offset to the L4 header exceeds 255 bytes, then it will not be
>possible to offload the packet to the NIC
se lock in line 359, function
>OvsWaitEventIoctl.
>2. Do we need the lock before OvsGetOpenInstance? If so, please release
>the
>lock inside "if (instance == NULL)"; if not, you should do the same thing
>on line 359.
>
>
>
>
>On Wed, Jul 13, 2016 at 4:38 PM, Sairam
ntroduced NETLINK_NETFILTER, NETLINK_GENERIC.
>
>
>
>Thanks,
>
>Alin.
>
>
>
>> -Mesaj original-
>
>> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
>
>> Venugopal
>
>> Trimis: Thursday, July 14, 2016 2:38 AM
>
>
fine a lock specific to
gOvsSwitchContext inside OvsGetOpenInstance() and not rely on EventQueue
lock to enforce it.
Thanks,
Sairam
On 7/21/16, 6:58 AM, "Alin Serdean"
wrote:
>> -Mesaj original-
>
>> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sa
ToT without being blocked on my other changes.
Thanks,
Sairam
From: Yin Lin mailto:yinli...@gmail.com>>
Date: Thursday, July 21, 2016 at 1:12 PM
To: Sairam Venugopal mailto:vsai...@vmware.com>>
Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>"
mailto:dev@openvswitch
od just one question inlined.
>
>
>
>> -Mesaj original-
>
>> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
>
>> Venugopal
>
>> Trimis: Thursday, July 14, 2016 2:39 AM
>
>> Către: dev@openvswitch.org
>
>> Subiect: [ovs-
afe by itself.
>
>
>
>Thanks,
>
>Alin.
>
>
>
>> -Mesaj original-
>
>> De la: Sairam Venugopal [mailto:vsai...@vmware.com]
>
>> Trimis: Thursday, July 21, 2016 9:52 PM
>
>> Către: Alin Serdean ; Yin Lin
>
>>
>
>> Cc: dev@openvswit
t;
>>
>>
>>
>> As you can see, we need to update these EVENT_FOO to
>> EVENT_VPORT_FOO.
>>
>>
>> On 7/22/16, 10:11 AM, "Alin Serdean"
>> wrote:
>>
>> >Looks good just one question inlined.
>> >
>> >
>> &
+UINT64 pad[10];
>> +} OVS_CT_EVENT_ENTRY, *POVS_CT_EVENT_ENTRY;
>
>Why such a big pad?
>
>Thanks,
>Alin.
>
>> -Mesaj original-
>> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
>> Venugopal
>> Trimis: Thursday, July 14, 2016
Acked-by: Sairam Venugopal
On 7/25/16, 2:58 PM, "Alin Serdean"
wrote:
>_get_osfhandle returns an errno value not a GetLastErrorValue.
>(https://urldefense.proofpoint.com/v2/url?u=https-3A__msdn.microsoft.com_e
>n-2Dus_library_ks2530z6-28v-3Dvs.120-29.aspx&d=CwIG
Will address this in v2.
Thanks,
Sairam
On 7/22/16, 6:20 PM, "Alin Serdean"
wrote:
>Just one comment inlined.
>
>
>
>> -Mesaj original-
>
>> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
>
>> Venugopal
>
>>
Alin Serdean and Yin Lin (around keeping
OvsGetOpenInstance safe).
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Datapath.c | 7 ++-
datapath-windows/ovsext/Event.c| 6 ++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/
and subtypes can be represent by means of masks (eg:
vport up/down, ct delete/add/update etc.,)
Sairam Venugopal (7):
datapath-windows: Explicitly name vport related event to vportEvent
datapath-windows: Fix bugs in Event.c around subscribe and lock
datapath-windows: Define new multicast
es to 0 and
instead read from msgIn). Added Acked-By
Signed-off-by: Sairam Venugopal
Acked-by: Paul Boca
---
datapath-windows/ovsext/Datapath.c | 66 +-
1 file changed, 50 insertions(+), 16 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/dat
h 1/9 and 3/9 into one commit. Added Acked-by.
Signed-off-by: Sairam Venugopal
Acked-By: Yin Lin
Acked-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Datapath.c | 7 ---
datapath-windows/ovsext/DpInternal.h | 10 ++
datapath-windows/ovsext/Event.c | 10 +-
dat
Tweak the OvsCreateNlMsgFromCtEntry() method to reuse it for creating
netlink messages from other files. Also define the function in Conntrack.h
to make it accessible.
v2: Added Acked-By
Signed-off-by: Sairam Venugopal
Acked-By: Yin Lin
Acked-by: Alin Gabriel Serdean
---
datapath-windows
Post Conntrack delete and create events when entries are deleted or
created.
v2: Added Acked-By
Signed-off-by: Sairam Venugopal
Acked-by: Paul Boca
Acked-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Conntrack.c | 12
1 file changed, 12 insertions(+)
diff --git a
of OVS_EVENT_SUBSCRIBE structure.
v2: Squashed patches 2/9 and 5/9 into one. Addressed review comments from
Yin Lin and Alin Serdean
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Datapath.c | 21 ++---
datapath-windows/ovsext/Datapath.h | 3
Update Event.c to have multiple event queues and mechanism to retrieve the
associated queue. Introduce OvsPostCtEvent and OvsRemoveCtEventEntry
similar to OvsPostVportEvent and OvsRemoveVportEventEntry.
v2: Added Acked-By
Signed-off-by: Sairam Venugopal
Acked-by: Paul Boca
Acked-by: Alin
Hi Guru,
Thanks for applying the patches. I will keep note of that for my future
patches. I wasn’t aware of the complications it caused.
Regards,
Sairam
From: Guru Shetty mailto:g...@ovn.org>>
Date: Friday, July 29, 2016 at 8:46 AM
To: Sairam Venugopal mailto:vsai...@vmware.com>>
Hi Alin,
Thanks for the patch! Had some inlined comments about the documentation.
I will run some tests and send out the review comments for other 2 patches.
Thanks,
Sairam
On 8/2/16, 12:51 PM, "Alin Serdean"
wrote:
>This patch updates the documentation on how to set up OVS with multiple
>NI
Nice work putting this together!
I went over the changes and had some comments. Haven¹t tested it yet.
Thanks,
Sairam
On 8/2/16, 12:46 PM, "Alin Serdean"
wrote:
>This patch updates the following commands in the vswitch:
>ovs-vsctl add-br br-test
>ovs-vsctl del-br br-test
>
>ovs-vsctl add-br br
Hi Alin,
I keep getting this error (different GUID( when I try to add a bridge -
'ovs-vsctl add-br br-pif'
OvsAddIpInterfaceNotification:647 Fail to get IF entry for internal port
with GUID ----
OvsHandleInternalAdapterUp:1556 Fail to get IP entry for internal por
Hi Alin,
I took a preliminary look at the patch and have added some review
comments.
I was mainly concerned about the use of switchContext->internalPortId when
we no longer have switchContext->internalVport and we can have multiple
internal ports.
Thanks,
Sairam
On 8/2/16, 12:47 PM, "Alin Ser
Just in case it¹s required for V2:
Acked-by: Sairam Venugopal
On 6/6/16, 9:45 AM, "Paul Boca" wrote:
>Add VLAN to STT header and on receive applyit to encapsulated packet
>
>Signed-off-by: Paul-Daniel Boca
>Acked-by: Sairam Venugopal
>---
>V2: No changes
&g
Just in case it¹s required for V2:
Acked-by: Sairam Venugopal
On 6/6/16, 9:45 AM, "Paul Boca" wrote:
>Fixed possible deadlock in case NdisGetDataBuffer fails
>Validate the segment length and offset on reassemble to avoid buffer
>overflow
>
>Signed-off-by: Pa
Thanks for making the changes.
Acked-by: Sairam Venugopal
On 6/6/16, 9:45 AM, "Paul Boca" wrote:
>*Added OvsExtractLayers - populates only the layers field without
>unnecessary
>memory operations for flow part
>*If in STT header the flags are 0 then force packets che
Thanks for incorporating the changes.
Acked-by: Sairam Venugopal
On 6/6/16, 9:45 AM, "Paul Boca" wrote:
>Signed-off-by: Paul-Daniel Boca
>---
>V2: Removed previously added OvsGetEthHdr and use OveExtractLayers instead
>on STT decapsulation. Extracted layers will
Enable support for UDP and ICMP in the connection tracking module on
Hyper-V. Define 1s as variable and reuse it.
Signed-off-by: Sairam Venugopal
---
datapath-windows/automake.mk | 1 +
datapath-windows/ovsext/Conntrack-other.c | 82 ++
datapath-windows/ovsext
Acked-by: Sairam Venugopal
On 6/3/16, 9:34 AM, "Nithin Raju" wrote:
>In Actions.c, based on the IP Protocol type and L4 port of
>the outer packet, we lookup the tunnel port. The function
>that made this happen took the tunnel type as an argument.
>Semantically, is is
parsing the new
message format.
Netfilter's conntrack related header files have been added to Windows to limit
the userspace changes. Some of them have been intentionally left empty since
Windows datapath does not support them.
Sairam Venugopal (5):
Windows: Add netfilter-conntrack header
Include netfilter-conntrack header files in user-space. This will be used
by Windows userspace for adding debugging support in Conntrack. Some of these
files
are intentionally left blank and will be updated once relevant support is
added in Windows datapath.
Signed-off-by: Sairam Venugopal
Introduce NF_GEN_MSG_HDR similar to GENL_MSG_HDR that will be used for
communicating via netfilter-netlink channel. This will be used by
userspace to retrieve and modify Conntrack data in Windows.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Netlink/Netlink.c | 11
Flush out all conntrack entries or those that match a given zone. Since
the conntrack module is internal to OVS in Windows, this functionality
needs to be added in.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Conntrack.c | 75 +
1 file changed
id is being overwritten to
NETLINK_GENERIC on Windows and datapath has been updated to support the
new message format.
Signed-off-by: Sairam Venugopal
---
lib/automake.mk | 2 ++
lib/dpif-netlink.c | 15 +++
lib/netlink-conntrack.c | 33
Create new NETLINK_CMD and NETLINK_FAMILY to assist in flushing conntrack
entries. Modify
Datapath.c to now support netfilter-netlink messages apart from the
existing netfilter-generic messages. Also hookup the command handler to
execute the OvsCtFlush in Conntrack.c
Signed-off-by: Sairam
an updated version. I will send the one out after
addressing other review comments across the patch series.
Thanks,
Sairam
On 6/13/16, 3:37 PM, "Sairam Venugopal" wrote:
>Create new NETLINK_CMD and NETLINK_FAMILY to assist in flushing conntrack
>entries. Modify
>Datapath.c to
Enable support for UDP and ICMP in the connection tracking module on
Hyper-V. Define 1s as variable and reuse it.
Signed-off-by: Sairam Venugopal
---
datapath-windows/automake.mk | 1 +
datapath-windows/ovsext/Conntrack-other.c | 82 +
datapath-windows/ovsext
Alin,
Thanks for the review. I have sent a v6. I realized that the 2nd comment
was previously addressed in v2, but not reflected in the v5 of the patch.
Thanks,
Sairam
On 6/13/16, 10:31 PM, "Alin Serdean"
wrote:
>Hi Sai,
>
>Thanks for incorporating the comments so far. It looks good but we nee
Acked-by: Sairam Venugopal
On 6/16/16, 10:15 AM, "Nithin Raju" wrote:
>Signed-off-by: Nithin Raju
>---
> datapath-windows/ovsext/Vxlan.c | 5 -
> 1 file changed, 5 deletions(-)
>
>diff --git a/datapath-windows/ovsext/Vxlan.c
>b/datapath-windows/ovsext/
Think this is v2.
Acked-by: Sairam Venugopal
On 6/16/16, 10:17 AM, "Nithin Raju" wrote:
>Signed-off-by: Nithin Raju
>---
> datapath-windows/ovsext/Flow.c | 20 ++--
> datapath-windows/ovsext/Vxlan.c | 5 -
> 2 files changed, 10 insertions(+)
Disregard this patch. I will send a consolidated patch with changes.
On 6/15/16, 4:13 PM, "Sairam Venugopal" wrote:
>Enable support for UDP and ICMP in the connection tracking module on
>Hyper-V. Define 1s as variable and reuse it.
>
>Signed-off-by: Sairam Venugopal
&
Hi Daniele,
I was trying to add conntrack dump support based on this patch and found a
discrepancy in
conntrack-tcp.c.
Can you confirm if this is intended? I have inlined the comment.
Thanks,
Sairam
On 6/10/16, 3:47 PM, "Daniele Di Proietto" wrote:
>New functions are implemented in the con
Enable support for UDP and ICMP in the connection tracking module on
Hyper-V. Define 1s as variable and reuse it.
Signed-off-by: Sairam Venugopal
---
datapath-windows/automake.mk | 1 +
datapath-windows/ovsext/Conntrack-other.c | 82 +
datapath-windows/ovsext
.
Netfilter's conntrack related header files have been added to Windows to limit
the userspace changes. Some of them have been intentionally left empty since
Windows datapath does not support them.
Sairam Venugopal (9):
Windows: Add netfilter-conntrack header files to Include folder
dat
Introduce NF_GEN_MSG_HDR similar to GENL_MSG_HDR that will be used for
communicating via netfilter-netlink channel. This will be used by
userspace to retrieve and modify Conntrack data in Windows.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Netlink/Netlink.c | 11
Create new NETLINK_CMD and NETLINK_FAMILY to assist in flushing conntrack
entries. Modify
Datapath.c to now support netfilter-netlink messages apart from the
existing netfilter-generic messages. Also hookup the command handler to
execute the OvsCtFlush in Conntrack.c
Signed-off-by: Sairam
Return null if Windows fails to allocate memory for the conntrack entry.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Conntrack-other.c | 5 +++--
datapath-windows/ovsext/Conntrack-tcp.c | 4
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/datapath-windows
Include netfilter-conntrack header files in user-space. This will be used
by Windows userspace for adding debugging support in Conntrack. Some of these
files
are intentionally left blank and will be updated once relevant support is
added in Windows datapath.
Signed-off-by: Sairam Venugopal
Flush out all conntrack entries or those that match a given zone. Since
the conntrack module is internal to OVS in Windows, this functionality
needs to be added in.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Conntrack.c | 75 +
1 file changed
Create a new method to create and fill OvsMessage with NfGenMsg. This will
be used for sending Netfilter based Netlink messages.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Netlink/Netlink.c | 39 +++
datapath-windows/ovsext/Netlink/Netlink.h | 4
id is being overwritten to
NETLINK_GENERIC on Windows and datapath has been updated to support the
new message format.
Signed-off-by: Sairam Venugopal
---
lib/automake.mk | 2 ++
lib/dpif-netlink.c | 15 +++
lib/netlink-conntrack.c | 33
This will be used by userspace for dumping conntrack entries - "ovs-dpctl
dump-conntrack".
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Datapath.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
Create the methods used for dumping conntrack entries from the hyper-v
datapath to userspace by means of netfilter netlink messages. Some of the
attributes are not supported by the datapath and have been defaulted to 0.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Conntrack-tcp.c
Clean up unused headers in Datapath.c. Found by inspection.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Datapath.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index 5cc0614..39a4c42 100644
Hi Paul,
Please find the comments inlined.
Thanks,
Sairam
On 6/21/16, 9:51 AM, "Paul Boca" wrote:
>Check if OvsAllocatememoryWithTag succeeded or not.
>In case of failure propagate cleanup and return.
>---
>V2: Checked also NdisGetDataBuffer and MmGetSystemAddressForMdlSafe
>if they return
Cleanup unused headers. Found by inspection.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Event.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/datapath-windows/ovsext/Event.c b/datapath-windows/ovsext/Event.c
index c210da3..abf8f0d 100644
--- a/datapath-windows/ovsext
Release the lock and return if an event entry fails to get allocated.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Event.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/datapath-windows/ovsext/Event.c b/datapath-windows/ovsext/Event.c
index abf8f0d..f9bea7f 100644
1 - 100 of 291 matches
Mail list logo
