Hi Alin, That is true. I will remember to do this in future patches.
Thanks, Sairam On 7/21/16, 6:55 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >Hi Sai, > > > >Thanks a lot for the series. > > > >As a general comment could you please squash commits and have one per >concept (I find them hard to follow): > > > >i.e. 1 and 3 >(https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org >_patch_648116_&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc >ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=eybt4o8VJX0HbeXExij2h0bnIiNvZ4 >taiXuS5vSNrGc&s=ynDG4u-5ZlRyJQY4gklQi0BpnxQQkphx9gapXREbF2s&e= , >https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_ >patch_648110_&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dcr >uz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=eybt4o8VJX0HbeXExij2h0bnIiNvZ4t >aiXuS5vSNrGc&s=W3wJa0-s3z-UnHt4f_dmgb7pHjNMEOpZaG4h3trlcf0&e= ) can be a >single commit since you are renaming events to vport_events > >2, 5 and maybe 8 can be a single commit as well since they are using the >newly introduced NETLINK_NETFILTER, NETLINK_GENERIC. > > > >Thanks, > >Alin. > > > >> -----Mesaj original----- > >> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > >> Venugopal > >> Trimis: Thursday, July 14, 2016 2:38 AM > >> Către: dev@openvswitch.org > >> Subiect: [ovs-dev] [PATCH 0/9] Add support for sending Conntrack events > >> > >> Send out events when a Conntrack entry is created or destroyed. The >>events > >> can be listened using the netlink multicast subscription. Also fix few >>bugs in > >> Event.c around event handling. > >> > >> Sairam Venugopal (9): > >> datapath-windows: Rename OVS_EVENT_ENTRY to > >> OVS_VPORT_EVENT_ENTRY > >> datapath-windows: Add supported netlink family protocols to > >> NetlinkProto.h > >> datapath-windows: Explicitly name vport related event to vportEvent > >> datapath-windows: Fix bugs in Event.c around subscribe and lock > >> datapath-windows: Define new multicast conntrack events > >> datapath-windows: Modify OvsCreateNlMsgFromCtEntry to make it > >> reusable > >> datapath-windows: Add support for multiple event queue in Event.c > >> datapath-windows: Update OvsReadEventCmdHandler in Datapath.c to > >> support different events > >> datapath-windows: Post Conntrack delete and new events > >> > >> datapath-windows/ovsext/Conntrack.c | 44 +++- > >> datapath-windows/ovsext/Conntrack.h | 9 + > >> datapath-windows/ovsext/Datapath.c | 81 +++++-- > >> datapath-windows/ovsext/Datapath.h | 3 +- > >> datapath-windows/ovsext/DpInternal.h | 25 ++- > >> datapath-windows/ovsext/Event.c | 279 >>++++++++++++++++++++-- > >> --- > >> datapath-windows/ovsext/Event.h | 22 +- > >> datapath-windows/ovsext/Netlink/NetlinkProto.h | 3 + > >> datapath-windows/ovsext/Vport.c | 12 +- > >> 9 files changed, 383 insertions(+), 95 deletions(-) > >> > >> -- > >> 2.9.0.windows.1 > >> > >> _______________________________________________ > >> dev mailing list > >> dev@openvswitch.org > >> >>https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailm >>an_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r= >>Dcruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=eybt4o8VJX0HbeXExij2h0bnIiN >>vZ4taiXuS5vSNrGc&s=0zQo_zsVcWpwIeQB21s5d_UtiKCNYYKwF68s6l-sPJU&e= > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
