Yes, I wanted to keep it similar to the VPORT events:
enum {
OVS_EVENT_CONNECT = ((uint32_t)0x1 << 0),
OVS_EVENT_DISCONNECT = ((uint32_t)0x1 << 1),
OVS_EVENT_LINK_UP = ((uint32_t)0x1 << 2),
OVS_EVENT_LINK_DOWN = ((uint32_t)0x1 << 3),
OVS_EVENT_MAC_CHANGE = ((uint32_t)0x1 << 4),
OVS_EVENT_MTU_CHANGE = ((uint32_t)0x1 << 5),
OVS_EVENT_MASK_ALL = 0x3f,
};
As you can see, we need to update these EVENT_FOO to EVENT_VPORT_FOO.
On 7/22/16, 10:11 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com>
wrote:
>Looks good just one question inlined.
>
>
>
>> -----Mesaj original-----
>
>> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
>
>> Venugopal
>
>> Trimis: Thursday, July 14, 2016 2:39 AM
>
>> Către: dev@openvswitch.org
>
>> Subiect: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast
>
>> conntrack events
>
>>
>
>> Define new Conntrack events (new and delete) and add support for
>
>> subscribing to these events. Parse out OVS_NL_ATTR_MCAST_GRP and
>
>> store it as part of OVS_EVENT_SUBSCRIBE structure.
>
>>
>
>> Signed-off-by: Sairam Venugopal <vsai...@vmware.com>
>
>> ---
>
>> datapath-windows/ovsext/Datapath.c | 21 ++++++++++++++++++---
>
>> datapath-windows/ovsext/Datapath.h | 3 ++-
>
>> datapath-windows/ovsext/DpInternal.h | 15 +++++++++++++++
>
>> 3 files changed, 35 insertions(+), 4 deletions(-)
>
>>
>
>
>
>> +enum {
>
>> + OVS_EVENT_CT_NEW = ((uint32_t)0x1 << 0),
>
>> + OVS_EVENT_CT_DELETE = ((uint32_t)0x1 << 1),
>
>> + OVS_EVENT_CT_MASK_ALL = 0x3
>
>
>
>[Alin Gabriel Serdean: ] Any particular reason for not using: 1 << 0, 1
><< 1, 1 << 2, etc?
>
>> +};
>
>> +
>
>> +/* Supported mcast event groups */
>
>> +enum OVS_MCAST_EVENT_ENTRIES {
>
>> + OVS_MCAST_VPORT_EVENT,
>
>> + OVS_MCAST_CT_EVENT,
>
>> + __OVS_MCAST_EVENT_ENTRIES_MAX
>
>> +};
>
>> +#define OVS_MCAST_EVENT_ENTRIES_MAX
>
>> (__OVS_MCAST_EVENT_ENTRIES_MAX -
>
>> +OVS_MCAST_VPORT_EVENT)
>
>>
>
>> typedef struct _OVS_VPORT_EVENT_ENTRY {
>
>> UINT32 portNo;
>
>> --
>
>> 2.9.0.windows.1
>
>>
>
>> _______________________________________________
>
>> dev mailing list
>
>> dev@openvswitch.org
>
>>
>>https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailm
>>an_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=
>>Dcruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=iSTxSaNGMjpm4rJ9g61SytrFDZZ
>>UmN9pPUtTtra_Jio&s=C57tzRDXzgUTFoJQMs5YrgcOVl_5UQLicoBzRg2b7lI&e=
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
