[ovs-dev] What's your wife's favorite time-spending?

2015-08-20 Thread Russell
Spend holidays in bed, and do not forget style2 { text-align: center; color: #D90003; font-family: Cambria, 'Hoefler Text', 'Liberation Serif', Times, 'Times New Roman', serif; font-size: 20px; font-weight: bold; } style4 {border: 1px solid #707070; } style5 {text-align

Re: [ovs-dev] [PATCH v2] ovn: Add software l2 gateway.

2016-04-14 Thread Russell Bryant
On Thu, Apr 14, 2016 at 1:05 AM, Ben Pfaff wrote: > On Mon, Apr 04, 2016 at 05:58:28AM -0700, Russell Bryant wrote: > > This patch implements one approach to using ovn-controller to implement > > a software l2 gateway between logical and physical networks. > > > > A n

[ovs-dev] [PATCH] python: Update Python version checks.

2016-04-14 Thread Russell Bryant
Instead of checking the raw version, use the six.PY2 and six.PY3 helpers to determine if Python 2 or Python 3 are in use. In one case, the check was to determine if the Python version was >= 2.6. We now only support >= 2.7, so this check would always be true. Signed-off-by: Russell

Re: [ovs-dev] [PATCH v3 1/2] ovn-controller: Warn if system-id is missing.

2016-04-14 Thread Russell Bryant
On Thu, Apr 14, 2016 at 12:50 AM, Ben Pfaff wrote: > On Thu, Apr 07, 2016 at 11:39:32AM -0400, Russell Bryant wrote: > > If 'system-id' is missing from the Open_vSwitch database, ovn-controller > > will not work. Log a warning if that happens to make it clear

Re: [ovs-dev] [PATCH v3 1/1] ovn: Add column enabled to table Logical_Router

2016-04-15 Thread Russell Bryant
On Fri, Apr 15, 2016 at 9:51 AM, Na Zhu wrote: > Hi Ben, > > How to fix the word-wrapped issue? > I've suggested this a couple of times already, but have you tried posting with git-send-email yet? https://git-scm.com/docs/git-send-email -

Re: [ovs-dev] [PATCH v2] ovn-northd: Handle IPv4 addresses with prefixes in lport port security

2016-04-15 Thread Russell Bryant
networking-ovn/+bug/1564414 > > Signed-off-by: Numan Siddique > > Thanks, applied to master. The portsecurity test case seems to be failing after this patch was applied. Numan, can you take a look? -- Russell Bryant ___ dev mailing list dev@openvsw

Re: [ovs-dev] [PATCH] python: Update Python version checks.

2016-04-15 Thread Russell Bryant
On Fri, Apr 15, 2016 at 3:49 AM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > On Thu, Apr 14, 2016 at 11:09 PM, Ben Pfaff wrote: > > On Thu, Apr 14, 2016 at 05:00:48PM -0400, Russell Bryant wrote: > >> Instead of checking the raw version, use the six.PY2 and

Re: [ovs-dev] [PATCH] ovn-tutorial: Update expected output from show commands

2016-04-15 Thread Russell Bryant
e to the project! From cb39d248b74f97c61109bfbdfc5fbe3e34ad8b55 Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Fri, 15 Apr 2016 16:58:51 -0400 Subject: [PATCH] AUTHORS: Add Flavio Fernandes. Flavio authored commit b3ecab7e5b18756524852eeaea547e040242b7f6. Signed-off-by: Russell Bryant --- AUTHORS | 1 + 1 f

Re: [ovs-dev] [PATCH RFC] ovn: distributed logical port for VM metadata access

2016-04-15 Thread Russell Bryant
he alternative, which strikes me as a > terrible idea, would be to somehow implement a TCP/IP stack and HTTP > server inside OVS. > > Does there need to be a single metadata server per hypervisor, or one > per logical switch per hypervisor? > > I think that a lot of the commit

Re: [ovs-dev] [PATCH] ovn: Fix link in tutorial

2016-04-21 Thread Russell Bryant
AUTHORS file. Thanks again! -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] ovs-dev.py: PEP-8ify.

2016-05-18 Thread Russell Bryant
On Tue, May 17, 2016 at 11:21 PM, Ben Pfaff wrote: > Do you want to add this script to FLAKE8_PYFILES so that the pep8ness > doesn't accidentally get broken later? > > I didn't read the patches. The changes look fine to me other than the issue you pointed ou

Re: [ovs-dev] ovn: is it possible to add validation on acl match

2016-05-20 Thread Russell Bryant
good to me. We can watch events in our plugin for when ACL rows get updated and check to see if the error column was set. We can at least log an error on the OpenStack side in that case. It would be asynchronous from the OpenStack API call, so we wouldn't be able to return an error in

Re: [ovs-dev] [PATCH v4 2/2] ovn: Apply ACL changes to existing connections.

2016-05-21 Thread Russell Bryant
On Sat, May 21, 2016 at 2:13 AM, Han Zhou wrote: > Russell, shall this be merged? Eventually. :-) I'm just way behind from being out. I do plan to finish this. I owe another revision of this series for Justin to review. I need to apply some doc suggestions he had. Justin

Re: [ovs-dev] [PATCH v4 2/2] ovn: Apply ACL changes to existing connections.

2016-05-25 Thread Russell Bryant
On Sun, May 22, 2016 at 2:35 AM, Justin Pettit wrote: > > > On May 21, 2016, at 6:35 AM, Russell Bryant wrote: > > > > > > On Sat, May 21, 2016 at 2:13 AM, Han Zhou wrote: > > Russell, shall this be merged? > > > > Eventually. :-) I'm just

Re: [ovs-dev] [RFC] ovs-tcpdump: Add a tcpdump wrapper utility

2016-05-27 Thread Russell Bryant
t; utilities/ovs-sim.1 \ > + utilities/ovs-tcpdump \ > + utilities/ovs-tcpdump.8 \ > utilities/ovs-tcpundump \ > utilities/ovs-tcpundump.1 \ > utilities/ovs-test \ > Can you add the new utility to FLAKE8_PYFILES, as well? I expect

Re: [ovs-dev] [RFC] ovs-tcpdump: Add a tcpdump wrapper utility

2016-05-27 Thread Russell Bryant
On Fri, May 27, 2016 at 2:02 PM, Aaron Conole wrote: > Russell Bryant writes: > > > On Tue, May 24, 2016 at 4:35 PM, Aaron Conole > wrote: > > > > > > Currently, there is some documentation which describes setting up and > > using port mirrors for br

[ovs-dev] [PATCH] INSTALL.md: Note use of "hacking" flake8 plugin.

2016-05-27 Thread Russell Bryant
The automatic flake8 check that runs against Python code has some warnings enabled that come from the "hacking" flake8 plugin. If it's not installed, the warnings just won't occur until it's run on a system with "hacking" installed. Signed-off-by: Russell Bry

Re: [ovs-dev] [PATCH] INSTALL.md: Note use of "hacking" flake8 plugin.

2016-05-31 Thread Russell Bryant
On Sat, May 28, 2016 at 1:12 PM, Ben Pfaff wrote: > On Fri, May 27, 2016 at 05:09:02PM -0400, Russell Bryant wrote: > > The automatic flake8 check that runs against Python code has some > > warnings enabled that come from the "hacking" flake8 plugin. If it's > &

[ovs-dev] [PATCH v2] INSTALL.md: Note use of "hacking" flake8 plugin.

2016-06-02 Thread Russell Bryant
The automatic flake8 check that runs against Python code has some warnings enabled that come from the "hacking" flake8 plugin. If it's not installed, the warnings just won't occur until it's run on a system with "hacking" installed. Signed-off-by: Russell Br

[ovs-dev] [PATCH v4] ovn: Add software l2 gateway.

2016-06-02 Thread Russell Bryant
port also gets bound to a chassis while a localnet port does not. This binding is not done by ovn-controller. It is left as an administrative function. In the case of OpenStack, the Neutron plugin will do this. Signed-off-by: Russell Bryant Acked-by: Ryan Moats Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH v2] ovn-northd.8.xml: fix sock path of NB and SB database.

2016-06-03 Thread Russell Bryant
N NB and SB database processes") > Signed-off-by: Li Wei > Thanks, I applied this patch to master. -- Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] netdev: Fix typo in comment.

2016-06-03 Thread Russell Bryant
On Fri, Jun 3, 2016 at 3:31 PM, Ben Pfaff wrote: > The name of the macro was wrong. > > Signed-off-by: Ben Pfaff > Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] SFC-Summary: MultiTenant

2016-07-12 Thread Russell Bryant
e do this today for containers in VMs. We can have a single VIF for a VM that is connected to multiple networks that are owned by separate tenants. Some sort of encapsulation (VLAN ID, MPLS header, whatever) would be used to differentiate the traffic for each networking in/out of

[ovs-dev] [PATCH] ovn-sbctl: Adjust formatting of lflow-list.

2016-07-13 Thread Russell Bryant
, left justify values in fields, as I find that to look a little nicer. Also update sample output in OVN-Tutorial.md to match the current state. Signed-off-by: Russell Bryant --- ovn/utilities/ovn-sbctl.c | 2 +- tutorial/OVN-Tutorial.md | 199 -- 2

Re: [ovs-dev] [PATCH] ovn-sbctl: Adjust formatting of lflow-list.

2016-07-13 Thread Russell Bryant
On Wed, Jul 13, 2016 at 2:08 PM, Ben Pfaff wrote: > On Wed, Jul 13, 2016 at 01:50:58PM -0400, Russell Bryant wrote: > > Adjust the field width for a couple of elements in the output of the > > lflow-list sub-command of ovn-sbctl. We now have a table ID of 10, so > > set

[ovs-dev] [PATCH] ovn-controller: Clean up bindings handling.

2016-07-13 Thread Russell Bryant
may be holding references to freed memory. Instead, replace it with a new global sset of logical port IDs called 'local_ids'. This is used to track when interfaces have been added or removed. Found by inspection. Signed-off-by: Russell Bryant --- ovn/c

Re: [ovs-dev] [PATCH] OVN-Tutorial: Update sample output.

2016-07-14 Thread Russell Bryant
On Wed, Jul 13, 2016 at 11:18 PM, Ryan Moats wrote: > "dev" wrote on 07/07/2016 02:16:29 PM: > > > From: Russell Bryant > > To: dev@openvswitch.org > > Date: 07/07/2016 02:16 PM > > Subject: [ovs-dev] [PATCH] OVN-Tutorial: Update sample output. > >

Re: [ovs-dev] [PATCH] ovn-controller: Clean up bindings handling.

2016-07-14 Thread Russell Bryant
On Thu, Jul 14, 2016 at 12:02 AM, Mickey Spiegel wrote: > >To: dev@openvswitch.org > >From: Russell Bryant > >Sent by: "dev" > >Date: 07/13/2016 02:53PM > >Subject: [ovs-dev] [PATCH] ovn-controller: Clean up bindings handling. > > > > >Remov

[ovs-dev] [PATCH v2] ovn-controller: Clean up bindings handling.

2016-07-14 Thread Russell Bryant
of the right interface as needed. Found by inspection. Signed-off-by: Russell Bryant --- ovn/controller/binding.c | 77 1 file changed, 32 insertions(+), 45 deletions(-) v1->v2: - Add lport_to_iface shash built each run in get_local_iface_ids

Re: [ovs-dev] [PATCH] ovn-northd: Remove extraneous ip4 mulicast logical flow.

2016-07-14 Thread Russell Bryant
; > > > Signed-off-by: Ryan Moats > > > > Acked-by: Flavio Fernandes > > Thanks, applied to master. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [patch_v1] ovs-vtep: Handle tunnel key configuration in any order.

2016-07-14 Thread Russell Bryant
= vtep_ctl("list-remote-macs %s" % self.name > ).splitlines() > for line in mac_list: > if (line.find("mcast-mac-remote") != -1): > -- > 1.9.1 > > ___ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [patch_v2] ovs-vtep: Handle tunnel key configuration in any order.

2016-07-15 Thread Russell Bryant
-controller-vtep - vtep-macs 1". > > Russell (since you commented on v1), does this look good to you? > > I'm not super familiar with ovs-vtep, either. This patch looks straight forward enough to me, though. Acked-by: Russell Bryant > Thanks, > > Daniele > > 2016-07

[ovs-dev] [PATCH] ovn-northd.8.xml: Remove outdated flow.

2016-07-15 Thread Russell Bryant
This flow was a duplicate and was removed in a previous commit. Update the docs to reflect the removal. Fixes: 6a9d35dde4a9 ("ovn-northd: Remove extraneous ip4 mulicast logical flow.") Signed-off-by: Russell Bryant --- ovn/northd/ovn-northd.8.xml | 5 - 1 file changed, 5 deletion

Re: [ovs-dev] [PATCH] ovn-northd: Remove extraneous ip4 mulicast logical flow.

2016-07-15 Thread Russell Bryant
On Thu, Jul 14, 2016 at 4:38 PM, Russell Bryant wrote: > > > On Thu, Jul 14, 2016 at 2:47 PM, Flaviof wrote: > >> On Thu, Jul 14, 2016 at 2:34 PM, Ryan Moats wrote: >> >> > IPv4 multicast is already dropped by a previous logical flow >> > written for

Re: [ovs-dev] [PATCH v2] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-15 Thread Russell Bryant
t;`vtep-ctl list physical_port p1`"]) > > # should see empty chassis column in both binding entries. > > AT_CHECK_UNQUOTED([ovn-sbctl --columns=chassis list Port_Binding | cut > -d > > ':' -f2 | tr -d ' ' | sort], [0], [dnl > > > > -- > > 2.5.5 > > > > > Acked-by: Darrell Ball Thanks! Applied to master. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ovn: Remove a completed TODO item.

2016-07-18 Thread Russell Bryant
This TODO item was implemented a while ago, so remove it from the TODO file. Fixes: 0ee8aaf658dd ("ovn: Send GARP on localnet.") Signed-off-by: Russell Bryant --- ovn/TODO | 6 -- 1 file changed, 6 deletions(-) diff --git a/ovn/TODO b/ovn/TODO index 0a6225d..2077ccd 100644 ---

Re: [ovs-dev] [PATCH v2] ovn-controller: Clean up bindings handling.

2016-07-18 Thread Russell Bryant
On Sat, Jul 16, 2016 at 10:31 PM, Ryan Moats wrote: > "dev" wrote on 07/14/2016 02:47:52 PM: > > > From: Russell Bryant > > To: dev@openvswitch.org > > Date: 07/14/2016 02:48 PM > > Subject: [ovs-dev] [PATCH v2] ovn-controller: Clean up bindings handling

[ovs-dev] [PATCH] ovn-controller: Remove local_datapaths_by_uuid.

2016-07-18 Thread Russell Bryant
binding.c included a static local_datapaths_by_uuid but it was not used for anything. In fact, the hash node used when inserting into this hmap is overwritten in another code path for a different hmap. Fixes: 263064aeaa31 ("Convert binding_run to incremental processing.") Signed-off-b

Re: [ovs-dev] [PATCH] ovn: Remove a completed TODO item.

2016-07-18 Thread Russell Bryant
On Mon, Jul 18, 2016 at 3:45 PM, Kyle Mestery wrote: > On Mon, Jul 18, 2016 at 2:32 PM, Russell Bryant wrote: > > This TODO item was implemented a while ago, so remove it from the TODO > > file. > > > > Fixes: 0ee8aaf658dd ("ovn: Send GARP on localnet.&quo

Re: [ovs-dev] [PATCH] ovn-controller: Remove local_datapaths_by_uuid.

2016-07-18 Thread Russell Bryant
On Mon, Jul 18, 2016 at 4:22 PM, Ryan Moats wrote: > Russell Bryant wrote on 07/18/2016 03:01:41 PM: > > > From: Russell Bryant > > To: dev@openvswitch.org > > Cc: Ryan Moats/Omaha/IBM@IBMUS, Russell Bryant > > Date: 07/18/2016 03:01 PM > > Sub

[ovs-dev] [PATCH] ovn-controller: Drop remove_local_datapath_by_binding().

2016-07-18 Thread Russell Bryant
ot;Convert binding_run to incremental processing.") Signed-off-by: Russell Bryant --- ovn/controller/binding.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c index adf4127..bc6df32 100644

Re: [ovs-dev] [PATCH] ovn-controller: Drop remove_local_datapath_by_binding().

2016-07-18 Thread Russell Bryant
On Mon, Jul 18, 2016 at 4:56 PM, Ryan Moats wrote: > Russell Bryant wrote on 07/18/2016 03:47:34 PM: > > > From: Russell Bryant > > To: dev@openvswitch.org > > Cc: Ryan Moats/Omaha/IBM@IBMUS, Russell Bryant > > Date: 07/18/2016 03:47 PM > > S

Re: [ovs-dev] [PATCH] ovn: Add 128-bit support for ct_label

2016-07-19 Thread Russell Bryant
alized in "Signed-off-by". I know that's > > petty but Git only properly recognizes it with the right capitalization. > > > > ​I was doing the same mistake all this time. Thanks for pointing it out. I > will take care of it from next time.​

Re: [ovs-dev] [PATCH] ovn-northd.8.xml: Remove outdated flow.

2016-07-19 Thread Russell Bryant
On Fri, Jul 15, 2016 at 1:11 PM, Ryan Moats wrote: > Russell Bryant wrote on 07/15/2016 11:38:14 AM: > > > From: Russell Bryant > > To: dev@openvswitch.org > > Cc: Ryan Moats/Omaha/IBM@IBMUS, Russell Bryant > > Date: 07/15/2016 11:38 AM > > Subject: [PATC

Re: [ovs-dev] SFC-Summary: MultiTenant

2016-07-19 Thread Russell Bryant
t to build what people will actually use. :-) On Wed, Jul 13, 2016 at 6:18 PM, Cathy Zhang wrote: > Hi Russell, > > To add on Farhad's point, with current neutron and nova, we cannot create > a multi-tenant VNF. > Currently, nova checks whether the neutron port belongs to the sa

Re: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

2016-07-19 Thread Russell Bryant
figuration later > than > + * 'nb_cfg'. This should not normally happen, because it > means > + * that 'nb_cfg' in the SB_Global table of the southbound > + * database decreased, and it should normally be > monotonically > +

Re: [ovs-dev] [PATCH v2] ovn-sbctl: eliminate a spurious test case error cause

2016-07-19 Thread Russell Bryant
ff-by: Lance Richardson > > --- > > This looks simple enough, applies clean and passes unit tests, > so. If it were a crash, I'd look for a test case, but since it isn't... > > Acked-by: Ryan Moats Thanks, applied to master. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

2016-07-19 Thread Russell Bryant
On Tue, Jul 19, 2016 at 3:45 PM, Ben Pfaff wrote: > On Tue, Jul 19, 2016 at 10:06:09AM -0400, Russell Bryant wrote: > > On Mon, Jul 18, 2016 at 2:30 PM, Ben Pfaff wrote: > > > > > Until now, there has been no reliable for the CMS (or ovn-nbctl, or > > > anyt

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

2016-07-20 Thread Russell Bryant
branch-x.y forks from master > +T + 5.5 Sep 15 Mar 15 branch-x.y released as version x.y.0 > + > +Contact > +--- > + > +Please use dev@openvswitch.org to discuss the Open vSwitch development > +and release process. > I think this is a great step forward. Thank you! One topic that could be added to this document is discussion of how long each release branch is maintained. LTS is defined in FAQ.md, but it could be defined in this document now. How an LTS branch is chosen, and the maintenance difference between LTS and non-LTS would also be good topics to cover. Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

2016-07-20 Thread Russell Bryant
On Wed, Jul 20, 2016 at 12:30 PM, Ben Pfaff wrote: > On Wed, Jul 20, 2016 at 10:00:22AM -0400, Russell Bryant wrote: > > On Tue, Jul 19, 2016 at 1:58 PM, Ben Pfaff wrote: > > > > > This document has two different kinds of text: > > > > > >- Th

Re: [ovs-dev] [PATCH] ovn: Add datapth of gateway port tolocal_datapaths

2016-07-20 Thread Russell Bryant
You might want to consider an end-to-end test that sets up this scenario and makes sure a packet makes it through. That covers more than just making sure a port binding is created. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v6 1/1] ovn: Apply ACL changes to existing connections.

2016-07-20 Thread Russell Bryant
On Thu, Jul 7, 2016 at 1:13 PM, Justin Pettit wrote: > > > On Jun 30, 2016, at 10:14 PM, Russell Bryant wrote: > > > > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml > > index 260cc14..d2bddcb 100644 > > --- a/ovn/northd/ovn-northd.8.xml

Re: [ovs-dev] [PATCH] [PATCH v1] ovs-dev: add set type for ovs.idl.data.Datum.from_python

2016-07-25 Thread Russell Bryant
the commit message. You posted this as a "v1", but it actually appears to be a v2 of an earlier patch. I included the Acked-by and Tested-by headers from v1. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] python: Send old values of the updated cols in notify for update2

2016-07-25 Thread Russell Bryant
th monitor_cond") > Signed-off-by: Numan Siddique > Is there a test case that could be updated or expanded to catch this issue? -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Compiler warnings with gcc 6.1 (On Fedora 24)

2016-07-26 Thread Russell Bryant
rnings. > > > > ​Thanks for the pointers. I will give it a try. > Hi, Numan. I'm using Fedora 24 and I don't see these warnings. I'm not sure what's different. $ gcc --version gcc (GCC) 6.1.1 20160621 (Red Hat 6.1.1-3) -- Russell Bryant __

Re: [ovs-dev] ovsdb active backup deployment

2016-07-26 Thread Russell Bryant
On Tue, Jul 26, 2016 at 2:41 PM, Andy Zhou wrote: > > > On Tue, Jul 26, 2016 at 5:37 AM, Russell Bryant wrote: > >> >> >> On Mon, Jul 25, 2016 at 8:15 PM, Andy Zhou wrote: >> >>> Hi, Rayn and Russell, >>> >> >> Can we move this

Re: [ovs-dev] [PATCH v3] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

2016-07-26 Thread Russell Bryant
up database version number. > v3: Rebase due to changes on master. > The code looks sane and seems to be working for me with some basic testing. Cool feature, thanks! Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb

2016-07-26 Thread Russell Bryant
entry in the > Port_binding table. Please correct me if my understanding is incorrect. > Thanks. > What if the Chassis column changes in some Port_Binding records while ovn-northd isn't running? -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ovn: Rename "gateway" to "l3gateway".

2016-07-26 Thread Russell Bryant
uot;. This patch renames the L3 gateway port type and option to "l3gateway" and "l3gateway-chassis" to make things a little more clear and consistent. Signed-off-by: Russell Bryant --- ovn/controller/binding.c | 2 +- ovn/controller/patch.c | 4 ++-- ovn/northd/ov

Re: [ovs-dev] [PATCH] [PATCH v1] ovn-northd: Fix {}-enclosed constants for ND responder

2016-07-26 Thread Russell Bryant
On Tue, Jul 26, 2016 at 2:02 AM, Zong Kai LI wrote: > It missed comma as constant seperator in match string for ND responder. > > Signed-off-by: Zong Kai LI Thanks! I applied this to master. -- Russell Bryant ___ dev mailing

Re: [ovs-dev] [PATCH] ovn-controller: update_ct_zone operates always on empty set

2016-07-26 Thread Russell Bryant
argc, char *argv[]) > if (chassis_id) { > chassis_run(&ctx, chassis_id); > encaps_run(&ctx, br_int, chassis_id); > -binding_run(&ctx, br_int, chassis_id, &local_datapaths); > +binding_run(&ctx, br_int, chassis_id, &

Re: [ovs-dev] ovsdb active backup deployment

2016-07-26 Thread Russell Bryant
On Tue, Jul 26, 2016 at 3:48 PM, Andy Zhou wrote: > > > On Tue, Jul 26, 2016 at 11:59 AM, Russell Bryant wrote: > >> >> >> On Tue, Jul 26, 2016 at 2:41 PM, Andy Zhou wrote: >> >>> >>> >>> On Tue, Jul 26, 2016 at 5:37 AM, Russell Br

Re: [ovs-dev] [PATCH] ovn-controller: update_ct_zone operates always on empty set

2016-07-27 Thread Russell Bryant
On Wed, Jul 27, 2016 at 8:34 AM, Ryan Moats wrote: > "dev" wrote on 07/27/2016 12:44:38 AM: > > > From: Babu Shanmugam > > To: Russell Bryant > > Cc: ovs dev > > Date: 07/27/2016 12:45 AM > > Subject: Re: [ovs-dev] [PATCH] ovn-controller: u

Re: [ovs-dev] [PATCH v2] ovn-controller: Restore all_lports for update_ct_zone

2016-07-27 Thread Russell Bryant
* a conntrack zone ID for each one, as we'll be creating > + * a patch port for each one. */ > +sset_add(all_lports, binding_rec->logical_port); > +} > +} > + > This seems to undo the benefits of the original change to do "incremental procesing" in binding.c. It seems like we weren't that far from a complete fix in Babu's first patch. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] doc: Update INSTALL.Docker.md to reflect it's focus on OVN

2016-07-27 Thread Russell Bryant
. > > This change updates the title, as well as the opening paragraphs > to more accurately reflect what the document is talking about. > > Signed-off-by: Kyle Mestery > > Seems fine to me, but I think Guru should review it. -- Russell Bryant __

Re: [ovs-dev] [PATCH] ovn: Rename "gateway" to "l3gateway".

2016-07-27 Thread Russell Bryant
On Tue, Jul 26, 2016 at 5:07 PM, Kyle Mestery wrote: > On Tue, Jul 26, 2016 at 3:49 PM, Russell Bryant wrote: > > When L3 gateway support was added, it introduced a port type called > > "gateway" and a corresponding option called "gateway-chassis". Sinc

Re: [ovs-dev] [PATCH] ovn-controller: update_ct_zone operates always on empty set

2016-07-27 Thread Russell Bryant
On Wed, Jul 27, 2016 at 1:44 AM, Babu Shanmugam wrote: > > > On Wednesday 27 July 2016 06:43 AM, Russell Bryant wrote: > > On Tue, Jul 26, 2016 at 6:46 AM, wrote: > >> From: Babu Shanmugam >> >> Commit 263064a (Convert binding_run to incremental pro

Re: [ovs-dev] [PATCH 2/2] ovs-dev.py: Update for python3.

2016-07-28 Thread Russell Bryant
On Mon, May 16, 2016 at 5:56 PM, Joe Stringer wrote: > Adapt to python-2.6+, including support for 3. > > Signed-off-by: Joe Stringer > Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://ope

Re: [ovs-dev] [PATCH] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-28 Thread Russell Bryant
ound about, but this is easiest way for us to integrate into OpenStack today. Exposing it as an external_id on the Chassis seemed like a pretty non-intrusive way to expose the info. Hopefully it's not *too* offensive. :-) -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] ovs-dev.py: Update for python3.

2016-07-28 Thread Russell Bryant
On Thu, Jul 28, 2016 at 2:11 PM, Joe Stringer wrote: > On 28 July 2016 at 11:02, Russell Bryant wrote: > > > > > > On Mon, May 16, 2016 at 5:56 PM, Joe Stringer wrote: > >> > >> Adapt to python-2.6+, including support for 3. > >> > >> S

Re: [ovs-dev] [PATCH] ovn: Rename "gateway" to "l3gateway".

2016-07-28 Thread Russell Bryant
On Thu, Jul 28, 2016 at 9:45 AM, Guru Shetty wrote: > On 26 July 2016 at 13:49, Russell Bryant wrote: > >> When L3 gateway support was added, it introduced a port type called >> "gateway" and a corresponding option called "gateway-chassis". Since >>

[ovs-dev] [PATCH] ovn-controller: Remove old values from local_ids.

2016-07-28 Thread Russell Bryant
ports was moved to another chassis. We would end up with two chassis fighting over the binding of the child ports. Signed-off-by: Russell Bryant --- ovn/controller/binding.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c index 78ebec4

Re: [ovs-dev] [PATCH] ovn-controller: Remove old values from local_ids.

2016-07-28 Thread Russell Bryant
On Thu, Jul 28, 2016 at 6:13 PM, Ryan Moats wrote: > "dev" wrote on 07/28/2016 04:22:41 PM: > > > From: Russell Bryant > > To: dev@openvswitch.org > > Date: 07/28/2016 04:23 PM > > Subject: [ovs-dev] [PATCH] ovn-controller: Remove old va

[ovs-dev] [PATCH v2] ovn-controller: Restore ct zone assignment.

2016-07-29 Thread Russell Bryant
or. Prior to this change, all_lports was always empty. Signed-off-by: Babu Shanmugam Co-authored-by: Russell Bryant Signed-off-by: Russell Bryant --- ovn/controller/binding.c| 46 +++-- ovn/controller/binding.h| 3 ++- ovn/controller/ovn-co

Re: [ovs-dev] [PATCH v2] ovn-controller: Restore ct zone assignment.

2016-07-29 Thread Russell Bryant
On Fri, Jul 29, 2016 at 11:18 AM, Russell Bryant wrote: > From: Babu Shanmugam > > Recent commits reorganizing bindings handling and also moving ct zone > assignment to ovn-controller.c caused ct zone assignment to no longer > work. The code relies on an "all_lports"

Re: [ovs-dev] [PATCH v2] ovn-controller: Restore ct zone assignment.

2016-07-29 Thread Russell Bryant
On Fri, Jul 29, 2016 at 11:59 AM, Ryan Moats wrote: > "dev" wrote on 07/29/2016 10:18:49 AM: > > > From: Russell Bryant > > To: dev@openvswitch.org > > Date: 07/29/2016 10:19 AM > > Subject: [ovs-dev] [PATCH v2] ovn-controller: Restore ct zone assignment

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-07-29 Thread Russell Bryant
ty" values are only relevant within the > context of an ACL stage. > > ACL rules that do not specify an ACL stage are applied to the > default "acl" stage. > > Signed-off-by: Mickey Spiegel Could you expand on why priorities in a single stage aren'

Re: [ovs-dev] [PATCH 5/5] ovsdb-idl: Wake up ovsdb_idl_loop when a transaction commits.

2016-07-29 Thread Russell Bryant
question of whether it > > provides a measurable change in E2E performance. Therefore, with your > > indulgence, I'm going to try and throw it into an openstack cloud > tomorrow > > and run some rally tests against it to see if indeed does result in a > > measurable change in pe

[ovs-dev] [PATCH] travis: Fix flake8 failures from flake8 3.0.

2016-07-29 Thread Russell Bryant
The "hacking" plugin for flake8 is not currently compatible with flake8 3.0. Ensure that we install flake8 2.x on travis-ci. Also update the docs to indicate this incompatibility. Signed-off-by: Russell Bryant --- .travis/linux-prepare.sh | 2 +- INSTALL.md | 12 +

Re: [ovs-dev] [PATCH] travis: Fix flake8 failures from flake8 3.0.

2016-07-29 Thread Russell Bryant
On Fri, Jul 29, 2016 at 3:30 PM, Andy Zhou wrote: > > > On Fri, Jul 29, 2016 at 12:18 PM, Russell Bryant wrote: > >> The "hacking" plugin for flake8 is not currently compatible with flake8 >> 3.0. Ensure that we install flake8 2.x on travis-ci. Also u

Re: [ovs-dev] [PATCH] travis: Fix flake8 failures from flake8 3.0.

2016-07-29 Thread Russell Bryant
On Fri, Jul 29, 2016 at 4:57 PM, Russell Bryant wrote: > > > On Fri, Jul 29, 2016 at 3:30 PM, Andy Zhou wrote: > >> >> >> On Fri, Jul 29, 2016 at 12:18 PM, Russell Bryant wrote: >> >>> The "hacking" plugin for flake8 is not currently

Re: [ovs-dev] [PATCH v2] ovn-controller: Restore ct zone assignment.

2016-07-29 Thread Russell Bryant
On Fri, Jul 29, 2016 at 3:52 PM, Ryan Moats wrote: > Acked-by: Ryan Moats Thanks, applied to master. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn-controller: if 'ovn-bridge-mappings' unconfigured, return directly.

2016-08-01 Thread Russell Bryant
nt seems to be skipping a loop over all Port_Binding records in every call to patch_run. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn-controller: if 'ovn-bridge-mappings' unconfigured, return directly.

2016-08-01 Thread Russell Bryant
On Mon, Aug 1, 2016 at 12:09 PM, Russell Bryant wrote: > > > On Mon, Aug 1, 2016 at 12:00 PM, Ben Pfaff wrote: > >> On Mon, Aug 01, 2016 at 02:55:26AM -0700, nickcooper-zhangtonghao wrote: >> > If the chassis doesn't configure the 'external-ids:ovn-bridg

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Russell Bryant
On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel wrote: > On Fri, Jul 29, 2016 at 10:28 AM, Mickey Spiegel > wrote: > > > > -"dev" wrote: - > >> To: Mickey Spiegel > >> From: Russell Bryant > >> Sent by: "dev" > >

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Russell Bryant
ke sure that the wrapper scripts > don't actually do anything when asked to perform a write operation. > > Signed-off-by: Ryan Moats > What's the motivation for all the new "read" scripts? It seems a bit confusing to install all of these. They're

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 7:56 AM, Russell Bryant wrote: > > On Tue, Aug 2, 2016 at 12:20 AM, Ryan Moats wrote: > >> This commit creates wrapper scripts for the *ctl commands to use >> --dry-run for those that have them, and to allow for log level >> setting via ovs-a

Re: [ovs-dev] [PATCH] ovn-controller: if 'ovn-bridge-mappings' unconfigured, return directly.

2016-08-02 Thread Russell Bryant
On Mon, Aug 1, 2016 at 1:30 PM, Russell Bryant wrote: > > > On Mon, Aug 1, 2016 at 12:09 PM, Russell Bryant wrote: > >> >> >> On Mon, Aug 1, 2016 at 12:00 PM, Ben Pfaff wrote: >> >>> On Mon, Aug 01, 2016 at 02:55:26AM -0700, nickcooper-zhangtonghao

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 9:37 AM, Ryan Moats wrote: > "dev" wrote on 08/02/2016 08:34:08 AM: > > > From: Ryan Moats/Omaha/IBM@IBMUS > > To: Russell Bryant > > Cc: ovs dev > > Date: 08/02/2016 08:35 AM > > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapp

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 12:03 PM, Ben Pfaff wrote: > On Tue, Aug 02, 2016 at 07:56:27AM -0400, Russell Bryant wrote: > > On Tue, Aug 2, 2016 at 12:20 AM, Ryan Moats wrote: > > > > > This commit creates wrapper scripts for the *ctl commands to use > > > --dry-run

Re: [ovs-dev] [PATCH] ovn-nbctl: fix help message for lsp-get/set-addresses

2016-08-02 Thread Russell Bryant
On Sun, Jul 31, 2016 at 2:17 AM, Han Zhou wrote: > Signed-off-by: Han Zhou > --- > ovn/utilities/ovn-nbctl.8.xml | 10 +- > ovn/utilities/ovn-nbctl.c | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > Thanks! I applied this to master.

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wrote: > The 2 ct_commit for deletion of firewall rules will likely be tricky. This > will need unit tests. > I don't think I understand the concern. Can you expand a bit on what you mean by "2 ct_commit for deletion of firewall r

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 3:02 PM, Darrell Ball wrote: > > > On Tue, Aug 2, 2016 at 10:23 AM, Mickey Spiegel > wrote: > >> On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote: >> >>> >>> >>> On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant w

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 3:17 PM, Guru Shetty wrote: > > > On 2 August 2016 at 12:01, Russell Bryant wrote: > >> >> On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wrote: >> >>> The 2 ct_commit for deletion of firewall rules will likely be tricky. >>>

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 3:35 PM, Guru Shetty wrote: > > > On 2 August 2016 at 12:27, Russell Bryant wrote: > >> >> >> On Tue, Aug 2, 2016 at 3:17 PM, Guru Shetty wrote: >> >>> >>> >>> On 2 August 2016 at 12:01, Russell Bryant w

Re: [ovs-dev] [PATCH RFC] ovn: Extend Address_Set to Macros_Set to support define port sets

2016-08-03 Thread Russell Bryant
count backwards compatibility. We won't be able to just rename the table. One option would be to at least rename the table now (before 2.6) to reflect a more broad purpose, and leave the support for other types of entries to later patches. Are you looking

Re: [ovs-dev] [PATCHv2] fedora.spec: Add OVN include files.

2016-08-03 Thread Russell Bryant
> /usr/include/ovn/actions.h > /usr/include/ovn/expr.h > /usr/include/ovn/lex.h > The patch fixes it and tested with rpmbuild 4.13.0 under Fedora 23. > > Signed-off-by: William Tu > I applied this to master, thanks! -- Russell Bryant _

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-03 Thread Russell Bryant
On Tue, Aug 2, 2016 at 1:16 PM, Kyle Mestery wrote: > On Tue, Aug 2, 2016 at 12:13 PM, Ryan Moats wrote: > > > > Russell Bryant wrote on 08/02/2016 12:00:08 PM: > > > >> From: Russell Bryant > >> To: Ben Pfaff > >> Cc: Ryan Moats/Omaha/IB

Re: [ovs-dev] RFC: two-week feature freeze on master before branching

2016-08-03 Thread Russell Bryant
ure isn't in shape to be merged on the 15th, it will just need to > > land in the next release. > > Yes, agreed. +1 to the proposal. If the community focus is on wrapping up 2.6 anyway, then branching earlier just sounds like extra work. This makes sense. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Let's talk the NB DB IDL Part I - things we've see scaling the networking-ovn to NB DB connection

2016-08-03 Thread Russell Bryant
> > > apply. > > > > > > I'm not sure I parsed this correctly, but I think we are saying the > same > > > thing: change the IDL for columns that contain sets of strong > references > > > from using

  1   2   3   4   5   6   7   8   9   10   >