On Sat, Jul 16, 2016 at 10:31 PM, Ryan Moats <rmo...@us.ibm.com> wrote:
> "dev" <dev-boun...@openvswitch.org> wrote on 07/14/2016 02:47:52 PM: > > > From: Russell Bryant <russ...@ovn.org> > > To: dev@openvswitch.org > > Date: 07/14/2016 02:48 PM > > Subject: [ovs-dev] [PATCH v2] ovn-controller: Clean up bindings handling. > > Sent by: "dev" <dev-boun...@openvswitch.org> > > > > Remove the global set of logical port IDs called 'all_lports'. This is > > no longer used for anything after conntrack ID assignment was moved out > > of binding.c. > > > > Remove the global smap of logical port IDs to ovsrec_interface records. > > We can't persist references to these records, as we may be holding > > references to freed memory. Instead, replace it with a new global sset > > of logical port IDs called 'local_ids'. This is used to track when > > interfaces have been added or removed. We also build a temporary > > shash of logical port IDs to ovs interfaces used for fast lookup > > of the right interface as needed. > > > > Found by inspection. > > > > Signed-off-by: Russell Bryant <russ...@ovn.org> > > Though I see Darrell's points, I'm comfortable enough with this to say... > > Acked-by: Ryan Moats <rmo...@us.ibm.com> > > and we can rename things in a followon patch. > Thanks, Ryan. I applied this to master. I'm happy to take a follow-up renaming things. -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
