as well.
3. Tested with pool size == 2 as well, though in this patch we set the
pool size = 1.
Signed-off-by: Nithin Raju
---
lib/dpif-netlink.c | 348 +++
1 files changed, 293 insertions(+), 55 deletions(-)
diff --git a/lib/dpif-netlink.c
On Oct 22, 2014, at 5:21 PM, Nithin Raju
wrote:
> On Oct 21, 2014, at 5:24 PM, Ankur Sharma wrote:
>
>> Refactored CreateQueue function so that packets are enqueued to correct
>> corresponding queue.
>>
>> Signed-off-by: Ankur Sharma
>
> Looks good mos
On Oct 15, 2014, at 10:08 PM, Eitan Eliahu wrote:
>
> Nithin, the DP commands are an exception. But, it does not make sense to
> check if the driver got initialized in each of the handlers.
> One simple way to handle the exception is to condition it by the Family ID
> (not DP).
>From your com
On Oct 23, 2014, at 8:51 AM, Eitan Eliahu
wrote:
> Acked-by: Eitan Eliahu
>
>
> (we check for gOvsSwitchContext in each of the handlers so this check should
> be removed and the user mode interface should be enabled only after the
> extension is activated, will be addressed soon)
Thanks Ei
On Oct 23, 2014, at 12:11 PM, Ankur Sharma
wrote:
> Refactored CreateQueue function so that packets are enqueued to correct
> corresponding queue.
>
> Signed-off-by: Ankur Sharma
LG. Thanks for incorporating the comments.
Acked-by:
between 2 VMs on 2 Hyper-Vs - one physical and another
virtual backed by VXLAN.
d) Successful uninstallation after these tests.
Nithin Raju (7):
datapath-windows: re-init the list entry in
OvsDeleteVportCmdHandler()
datapath-windows: clarify externalVport
datapath-windows: introd
In this patch, we add some explanation about the usage of
'externalVport' in the switch context. Also, we rename 'externalVport'
to 'virtualExternalVport' in alignment with the explanation. Also, we
rename 'numVports' to 'numHvVports' since ports
In this patch, we add the init functions for a Tunnel vport and a
Bridge-internal vport.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 51 +-
datapath-windows/ovsext/Vport.h |3 ++
2 files changed, 52 insertions(+), 2 deletions
Add a OvsGetTunnelVport() for convenience.
7. Update ASSERTs() while cleaning up the switch.
8. Nuke OvsGetExternalVport() and OvsGetExternalMtu().
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 138 ---
datapath-windows/ovsext/Switch.c |
Without this patch, the kernel crashes when it tries to cleanup a port
at unload time when a port has been previously deleted from userspace.
Crash is in OvsRemoveAndDeleteVport() when we call into
RemoveEntryList().
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c |5
In this patch, we provide explanation and the reasoning for
bridge-internal ports. The code to add such a port in come in later
patch in the series.
We also fix some formatting issues in PacketIO.c.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Actions.c | 13
another
virtual backed by VXLAN.
d) Successful uninstallation after these tests.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
for a VXLAN port.
6. 'numNonHvVports' increments and decrements ONLY for ports that are
added from OVS userspace but not present on the Hyper-V switch.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 236 --
datapath-windows
>
> FOLLOWUP_NAME: MachineOwner
>
>
>
> MODULE_NAME: OVSExt
>
>
>
> IMAGE_NAME: OVSExt.sys
>
>
>
> DEBUG_FLR_IMAGE_TIMESTAMP: 54498bc5
>
>
>
> BUCKET_ID_FUNC_OFFSET: 116
>
>
>
> FAILURE_BUCKET_ID: AV_OVSExt!OvsWaitEventIoctl
>
Reported-by: Gurucharan Shetty
Signed-off-by: Nithin Raju
---
lib/netlink-socket.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index 3b77b43..c9ec5d7 100644
--- a/lib/netlink-socket.c
+++ b/lib/netlink-socket.c
> -Original Message-
> From: Eitan Eliahu [mailto:elia...@vmware.com]
> Sent: Thursday, October 23, 2014 11:04 PM
> To: Nithin Raju
> Cc: Eitan Eliahu
> Subject: [PATCH] datapath-windows:Remove user mode instance from pid hash on
> process termination
>
> The
It has been observed that when userspace generates and executes that
packet, the source port of such a packet is set to the bridge-internal
port. Currently, we allow encapsulation only if the source port is a VIF
port or no port. We relax the check in this patch.
Signed-off-by: Nithin Raju
The .update_flags function in netdev-windows was dummy. But we need to
return the existing flags for link status to be shown as up in the
confdb.
There was a bug in copying the MAC address.
We fix these two issues in this patch.
Signed-off-by: Nithin Raju
Co-Authored-by: Ankur Sharma
---
lib
rt->isBridgeInternal == TRUE
>
>
> Acked-by: Ankur Sharma
>
> From: dev on behalf of Alin Serdean
>
> Sent: Friday, October 24, 2014 3:15 PM
> To: Nithin Raju; dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 3/7] datapat
Alin & Ankur,
I'd like to thank you for the prompt reviews. It really helps to make the cycle
faster!
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> Signed-off-by: Eitan Eliahu
>> Acked-by: Sorin Vinturis
>> Acked-by: Nithin Raju
>
> Applied, thanks!
Ben,
Is this patch applied? I just did a 'git pull', and don't see this patch.
Should we be sending the rebased patch?
Thanks,
-- Nithin
___
Signed-off-by: Nithin Raju
---
INSTALL.Windows |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/INSTALL.Windows b/INSTALL.Windows
index 24d0bb7..bba0710 100644
--- a/INSTALL.Windows
+++ b/INSTALL.Windows
@@ -83,14 +83,14 @@ To get SSL support for Open vSwitch on
On Oct 28, 2014, at 8:44 AM, Ben Pfaff
wrote:
>> Signed-off-by: Nithin Raju
>
> Applied, thanks.
>
> I had to apply the following hunk by hand because of a change in the
> context, please check that it is OK:
>
> diff a/datapath-windows/ovsext/Switch.c b/datap
The .update_flags function in netdev-windows was dummy. But we need to
return the existing flags for link status to be shown as up in the
confdb.
There was a bug in copying the MAC address.
We fix these two issues in this patch.
Signed-off-by: Nithin Raju
Co-Authored-by: Ankur Sharma
Signed
On Oct 28, 2014, at 9:15 AM, Ben Pfaff
wrote:
> Ankur, since you're an author of this patch (according to
> Co-authored-by), I instead need a Signed-off-by from you.
>
> Thanks,
>
> Ben.
Ben, I sent out a v2 where I folded in Ankur's signed-off and Alin's ACK.
Thanks,
-- Nithin
___
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Wednesday, October 29, 2014 2:15 PM
> To: dev@openvswitch.org
> Cc: Ben Pfaff; Nithin Raju; Gurucharan Shetty
> Subject: [PATCH] ovs-vsctl: Allow referring to rows whose names are UUIDs by
> those
integration where we use UUID as the name.
In this patch, we make the kernel code also use the same value as the
userspace.
Also updated is the OVS.psm1 powershell script which now allows friendly
names to be upto 48 bytes.
Signed-off-by: Nithin Raju
---
build-aux/extract-odp-netlink-windows-dp-h
We were using USE_NEW_VPORT_ADD_WORKFLOW while transitioning from old
workflow for adding ports. We don't need it anymore.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/datapath-wi
We were acquiring locks twice, and forgotten to release a lock in an
error case.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index
On Oct 30, 2014, at 8:27 AM, Eitan Eliahu
wrote:
> Hi Nithin,
> Can you please revisit the locking sequence for the netdev handler?
> It seems that OvsGetVportDumpNext() is called with the two locks, Dispatch
> and Control held, (can we add a comment on it in the function header?).
> But, the C
> -Original Message-
> From: Eitan Eliahu
> Sent: Thursday, October 30, 2014 10:18 AM
> To: Nithin Raju
> Cc: dev@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH 2/3] datapath-windws: fix locking code in
> OvsGetNetdevCmdHandler()
>
> Nithin,
> It seems t
We were acquiring locks twice, and forgotten to release a lock in an
error case.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
We were using USE_NEW_VPORT_ADD_WORKFLOW while transitioning from old
workflow for adding ports. We don't need it anymore.
Signed-off-by: Nithin Raju
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/Vport.c | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff
integration where we use UUID as the name.
In this patch, we make the kernel code also use the same value as the
userspace.
Also updated is the OVS.psm1 powershell script which now allows friendly
names to be upto 48 bytes.
Signed-off-by: Nithin Raju
Acked-by: Eitan Eliahu
---
build-aux/extract
Currently, if we receive an NBL with multiple NBs from NDIS, we just
ASSERT() and not do anything. The right thing to do obviously is to
process the NBL. This is a work in progress.
In the meantime, we should complete the NBL and not just leak it.
Signed-off-by: Nithin Raju
---
datapath
We were using USE_NEW_VPORT_ADD_WORKFLOW while transitioning from old
workflow for adding ports. We don't need it anymore.
Signed-off-by: Nithin Raju
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/Vport.c | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff
We were acquiring locks twice, and forgotten to release a lock in an
error case.
Signed-off-by: Nithin Raju
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/Vport.c | 14 +-
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b
integration where we use UUID as the name.
In this patch, we make the kernel code also use the same value as the
userspace.
Also updated is the OVS.psm1 powershell script which now allows friendly
names to be upto 48 bytes.
Signed-off-by: Nithin Raju
Acked-by: Eitan Eliahu
---
build-aux/extract
> -Original Message-
> From: Eitan Eliahu
> Sent: Thursday, October 30, 2014 1:52 PM
> To: Nithin Raju; dev@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH 2/3 v2] datapath-windws: fix locking code in
> OvsGetNetdevCmdHandler()
>
> Nithin,
> Just assert on
We'll have meeting on 11/11.
Thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> +function Set-VMNetworkAdapterOVSPortDirect {
> +[CmdletBinding()]
> +param
> +(
> +[parameter(Mandatory=$true)]
> +[string]$vmName,
> +
> +[parameter(Mandatory=$true)]
> +[ValidateLength(1, 48)]
> +[string]$OVSPortName
> +)
> +process
>
On Nov 3, 2014, at 2:33 PM, Eitan Eliahu wrote:
> Thank for the review.
> " Since you have declared $vmName as mandatory, is this check required?"
> As I understand the "mandatory" parameter definition of PS means that the
> parameter must be provided by the caller. If the parameter is not provi
s also not necessary. There were my
original comments.
One additional comment I had was to to rename 'vmName' to "VMName" in
accordance to Windows naming conventions of using upper case for first letter.
If you think having that checks serves a purpose. I am fine w
put_bridge[] OVS_UNUSED,
> + ovs_be32 *gw)
> {
> *gw = 0;
> -name[0] = '\0';
> return false;
> }
LG. minor comment is to put a ' ' before 'char output_bridge[]'.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> +case OID_SWITCH_PORT_UPDATED:
> +HvDeletePort(switchObject, portParam);
> +status = HvCreatePort(switchObject, portParam);
> + break;
hi Eitan,
While this change is ok in general, can you pls. comment on how this code will
work if the port is in CONNECTED state, and
On Nov 5, 2014, at 9:12 PM, Ankur Sharma
wrote:
> Signed-off-by: Ankur Sharma
> ---
> datapath-windows/ovsext/Flow.c | 2 --
> 1 file changed, 2 deletions(-)
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://ope
On Nov 5, 2014, at 11:06 PM, Eitan Eliahu
wrote:
> Hi Nithin,
> Actually ovsState will get updated from portParam->PortState in
> OvsInitVportWithPortParam() so this should not be an issue.
> But, there may be an issue with the nic parameters stored in the voprt.
> Even when the documentation r
> The original code should work even when the port is connected.
> The port structure is not being reallocated rather just marked as deleted.
> The issue is with create port function which insert the port to do the port
> list even when it is already created.
This is true only if that port has b
hi Eitan,
Thanks for the change. I had a few minor comments. I should be able to ACK a v3.
> +/* Update properties only for NETDEV ports*/
> +if (vport == NULL || vport->ovsType != OVS_VPORT_TYPE_NETDEV) {
> +status = STATUS_DATA_NOT_ACCEPTED;
> +goto update_port_done;
> +
Thanks for incorporating the review comments.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
A few fixes around locking.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 16 ++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index a46d49f..ff105b7 100644
--- a/datapath
;numHvPorts' at this point since this
vport has been counted before when it was first allocated. To account
for this, we add a new parameter to InitOvsVportCommon(). The arguments
passed by some of the callers are not 100% correct, and will be fixed in
future commit in the series.
Signed-off-by: N
In this series of patches we make a bunch of changes to be able to
re-add a Hyper-V port to OVS. Known caveats are this code does not
work if a internal or external port is deleted and re-added, since
we over-write the friendly name. The code works for VIF ports.
Nithin Raju (7):
datapath
OvsInitVxlanTunnel() need not return a NL_ERROR. In this patch, we
change it to NTSTATUS, and also update the mapping function that maps a
NTSTATUS to NL_ERROR.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c |3 ++-
datapath-windows/ovsext/Netlink
names.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c |2 +-
datapath-windows/ovsext/Vport.c| 40 +++
datapath-windows/ovsext/Vport.h| 16 ++
3 files changed, 34 insertions(+), 24 deletions(-)
diff --git a/datapath
tables.
If a port has been deleted from all the hash tables ie. has been deleted
from Hyper-V as well as OVS userspace, it gets deallocated.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 38 +-
datapath-windows/ovsext/Vport.c| 96
In this patch, we update the documentation for 'portIdHashArray' to
indicate that a vport would exist in this hash table if and only if it
also exists on the Hyper-V switch.
This functionality to implement this semantic will follow in subsequent
patches.
Signed-off-by: Nithin Raju
---
re-added it back with and
without the corresponding OVS port existing.
- uninstall was succcessful. No asserts hit.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 69 +++
1 files changed, 62 insertions(+), 7 deletions(-)
diff --git a/datapa
On Nov 12, 2014, at 2:03 AM, Eitan Eliahu wrote:
> [1] The NDIS port state should always reflect the port state maintained by
>NDIS so it should never be directly updated.
> [2] Remove the "port name" field as we use the "friendly name" instead.
>
> Signed-off-by: Eitan Eliahu
Eitan,
Nukin
| findstr ElementName
>
> Signed-off-by: Alin Gabriel Serdean
Tested-by: Nithin Raju
Acked-by: Nithin Raju
Requested-by: Nithin Raju
Reported-at: https://github.com/openvswitch/ovs-issues/issues/51
thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Nov 12, 2014, at 7:26 AM, Gurucharan Shetty
wrote:
> Also, remove the entry that talks about the need for atomic support
> on Windows as that has already been added.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Nithin Raju
___
> Signed-off-by: Gurucharan Shetty
Acked-by: Nithin Raju
Thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Nov 12, 2014, at 9:08 AM, Eitan Eliahu
wrote:
> Thanks for the review Nithin.
> We should not set the NDIS state to any state which is not what NDIS
> maintains. If the state sent by NDIS is not Teardown the OVS port state
> should not be Teardown (should probably be in error state or whate
On Nov 12, 2014, at 9:48 AM, Eitan Eliahu wrote:
> I don't see a reason why this function need to be called with gOvsCtrlLock
> held. The contention is on the Hyper-V VSwitch port when a port could be
> removed from a different thread context. But, this is taken care of by
> dispatch lock.
Su
On Nov 12, 2014, at 9:30 AM, Eitan Eliahu wrote:
> Hi Nithin,
> For all port add/delete functionality we need to validate in three major port
> states:
> [1] The port exists on the Hyper-V Virtual Switch but there is not
> corresponding port in OVS.
> [2] The port exists in OVS user-mode but
.
Signed-off-by: Nithin Raju
---
datapath-windows/DESIGN | 180 --
1 files changed, 125 insertions(+), 55 deletions(-)
diff --git a/datapath-windows/DESIGN b/datapath-windows/DESIGN
index b438c44..f81dad0 100644
--- a/datapath-windows/DESIGN
+++ b
In this patch, we update the design document to reflect the netlink
based kernel-userspace interface implementation and a few other changes.
I have covered at a high level.
Please feel free to extend the document with more details that you think
got missed out.
Signed-off-by: Nithin Raju
hi Ankur,
Thanks for the review. I'll send out a v2 once all the patches get reviewed.
On Nov 17, 2014, at 5:38 PM, Ankur Sharma
wrote:
> Minor comments inline.
>
> Acked-by: Ankur Sharma
> +static POVS_VPORT_ENTRY OvsFindVportByHvNameW(
> + POVS_SWITCH_CONTEXT switchContext, PWST
Sorin,
Thanks for this patch. Even though it is committed, I had the following
comments.
It is nice to get rid of the checks to gOvsSwitchContext in multiple places. On
thing though is that while a netlink command handler is being executed, we
could get the detach handler from NDIS, and that mi
hi Sorin,
_FlowNlGetCmdHandler() is used for a Flow command sent down as a transaction as
shown in the following code:
NTSTATUS
OvsFlowNlGetCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
UINT32 *replyLen)
hi Sorin,
Like I mentioned in another review, pls. don't combine unrelated changes into
one patch. Here I see a fix to buffer management code, and the other one is
related to device handle cleanup.
Can you pls. split them into separate reviews and send it as a series?
For now, I've reviewed the
On Nov 17, 2014, at 9:39 AM, Sorin Vinturis
wrote:
> I came around a BSOD that happened when trying to access pidHashLock
> from the gOvsSwitchContext, which was NULL. The stop happened in
> OvsAcquirePidHashLock function.
>
> To reproduce this BSOD, make sure the extension is enabled and runni
hi Sorin,
Pls. see my explanations inline.
>>/* Concurrent netlink operations are not supported. */
>>if (InterlockedCompareExchange((LONG volatile *)&instance->inUse, 1, 0)) {
>>status = STATUS_RESOURCE_IN_USE; @@ -891,7 +895,7 @@
>> ValidateNetlinkCmd(UINT32 devOp,
>>
ay:
"Handler for dump-based OVS_FLOW_CMD_GET command" :) But, it does not matter.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
ere's any
> * previous state, clear it up so as to set it up afresh.
> */
> -if (instance->dumpState.ovsMsg != NULL) {
> -FreeUserDumpState(instance);
> -}
> +FreeUserDumpState(instance);
Thanks for the cleanup.
Acked-by: Nithin Raju
_openvswitch_ovs-2Dissues_issues_53&d=AAIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=vEsNeZnOUkZPbwbim_jaLF_M8X7XlDz7j7Cx6l9QqVY&s=9hmcwbIGTv6ar4IXXMTXnUSb-bvlM9T_s_RFHceIYek&e=
>
> Acked-by: Eitan Eliahu
>
A few fixes around locking.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Vport.c | 16 ++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index 2dc5f0a..33aa95e
In this patch, we update the documentation for 'portIdHashArray' to
indicate that a vport would exist in this hash table if and only if it
also exists on the Hyper-V switch.
This functionality to implement this semantic will follow in subsequent
patches.
Signed-off-by: Nithin Raju
---
names.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c |2 +-
datapath-windows/ovsext/Vport.c| 40 +++
datapath-windows/ovsext/Vport.h| 16 ++
3 files changed, 34 insertions(+), 24 deletions
tables.
If a port has been deleted from all the hash tables ie. has been deleted
from Hyper-V as well as OVS userspace, it gets deallocated.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c | 38 +-
datapath-windows/ovsext/Vport.c| 96
;numHvPorts' at this point since this
vport has been counted before when it was first allocated. To account
for this, we add a new parameter to InitOvsVportCommon(). The arguments
passed by some of the callers are not 100% correct, and will be fixed in
future commit in the series.
Signed-off-
re-added it back with and
without the corresponding OVS port existing.
- uninstall was succcessful. No asserts hit.
Signed-off-by: Nithin Raju
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 69 +++
1 files changed, 62 insertions(+), 7 deletions(
OvsInitVxlanTunnel() need not return a NL_ERROR. In this patch, we
change it to NTSTATUS, and also update the mapping function that maps a
NTSTATUS to NL_ERROR.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c |3 ++-
datapath-windows
In this patch, we update the documentation for 'portIdHashArray' to
indicate that a vport would exist in this hash table if and only if it
also exists on the Hyper-V switch.
This functionality to implement this semantic will follow in subsequent
patches.
Signed-off-by: Nithin Raju
---
;numHvPorts' at this point since this
vport has been counted before when it was first allocated. To account
for this, we add a new parameter to InitOvsVportCommon(). The arguments
passed by some of the callers are not 100% correct, and will be fixed in
future commit in the series.
Signed-off-
tables.
If a port has been deleted from all the hash tables ie. has been deleted
from Hyper-V as well as OVS userspace, it gets deallocated.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c | 38 +-
datapath-windows/ovsext/Vport.c| 96
OvsInitVxlanTunnel() need not return a NL_ERROR. In this patch, we
change it to NTSTATUS, and also update the mapping function that maps a
NTSTATUS to NL_ERROR.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c |3 ++-
datapath-windows
A few fixes around locking.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Vport.c | 16 ++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index 2dc5f0a..33aa95e
re-added it back with and
without the corresponding OVS port existing.
- uninstall was succcessful. No asserts hit.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Vport.c | 69 +++
1 files changed, 62 insertions(+), 7 deletions(
names.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c |2 +-
datapath-windows/ovsext/Vport.c| 40 +++
datapath-windows/ovsext/Vport.h| 16 ++
3 files changed, 34 insertions(+), 24 deletions
On Nov 18, 2014, at 4:49 PM, Saurabh Shah
wrote:
> The breakage was introduced by commit: a36de779
> ("openvswitch: Userspace tunneling.").
>
> Reported-by: Edwin Chiu
> Signed-off-by: Saurabh Shah
Acked-by: Nithin
Signed-off-by: Nithin Raju
---
datapath-windows/automake.mk |2 -
datapath-windows/ovsext/Datapath.c |3 -
datapath-windows/ovsext/Datapath.h |6 -
datapath-windows/ovsext/Event.c| 88
datapath-windows/ovsext/Ioctl.c| 773
OvsPub.h is not longer the interface file that published the interface
of the kernel datapath to userspace. Nevertheless it is still being used
internal to the kernel datapath.
We rename the file for this reason.
Signed-off-by: Nithin Raju
---
datapath-windows/automake.mk
Getting rid of unused definitions in DpInternal.h.
This is only the first round. There's scope for more cleanup.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/DpInternal.h | 171 +-
datapath-windows/ovsext/IpHelper.c | 10 +-
datapath-wi
t the previous check
to ASSERTs.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 31 +++
1 files changed, 15 insertions(+), 16 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index b67ba44..1440480 1
ore appropriate.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c |2 +-
datapath-windows/ovsext/Vport.c| 14 +++---
datapath-windows/ovsext/Vport.h|3 ++-
3 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/datapath-windows/ovsext/Datapat
t the previous check
to ASSERTs.
Signed-off-by: Nithin Raju
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 38 ++-
1 files changed, 20 insertions(+), 18 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datap
t the previous check
to ASSERTs.
Signed-off-by: Nithin Raju
Acked-by: Sorin Vinturis
---
datapath-windows/ovsext/Datapath.c | 38 ++-
1 files changed, 20 insertions(+), 18 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datap
t the previous check
to ASSERTs.
Signed-off-by: Nithin Raju
Acked-by: Sorin Vinturis
---
datapath-windows/ovsext/Datapath.c | 38 ++-
1 files changed, 20 insertions(+), 18 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datap
Getting rid of unused definitions in DpInternal.h.
This is only the first round. There's scope for more cleanup.
Signed-off-by: Nithin Raju
Acked-by: Sorin Vinturis
---
datapath-windows/ovsext/DpInternal.h | 171 +-
datapath-windows/ovsext/IpHelper.c |
601 - 700 of 936 matches
Mail list logo
