Columns indexing is different in ovsdb_row then in ovsdb_monitor_row.
We need mapping between the 2 for condition evaluation.
signed-off-by: Liran Schour
---
ovsdb/monitor.c | 29 +++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/ovsdb/monitor.c b
) man page for details of monitor_cond_update.
Signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 152 +++--
ovsdb/monitor.c| 254 +++--
ovsdb/monitor.h| 23 +++--
3 files changed, 368 insertions(+), 61
condition update for code simplicity.
Signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 23 +++
ovsdb/monitor.c| 42 --
ovsdb/monitor.h| 2 +-
3 files changed, 44 insertions(+), 23 deletions(-)
diff --git a/ovsdb
Add API that allows the user to create condition iteratively
and send condition_update to the server.
Signed-off-by: Liran Schour
---
lib/ovsdb-idl-provider.h | 13 ++
lib/ovsdb-idl.c | 205 -
lib/ovsdb-idl.h | 38 ++
ovsdb/ovsdb-idlc.in
Change ovsdb_condition to be a 3-element json array or a boolean value.
Conditions utilities will be used later for conditional monitoring.
Signed-off-by: Liran Schour
---
ovsdb/condition.c| 186 ---
ovsdb/condition.h| 41
Hold session's conditions in ovsdb_monitor_session_condition. Pass it
to ovsdb_monitor for generating "update2" notifications.
Add functions that can generate "update2" notification for a
"monitor_cond" session.
JSON cache is enabled only for session's with true condition only.
"monitor_cond" and "
46321 | 80130285454 | 6.1%
Liran Schour (11):
ovsdb: create column index mapping between ovsdb row to monitor row
ovsdb: add conditions utilities to support monitor_cond
ovsdb: allow unmonitored columns in condition evaluation
ovsdb: generate update notifications for monitor_cond se
Add tests for conditional monitoring to IDL.
Signed-off-by: Liran Schour
---
tests/ovsdb-idl.at | 136
tests/test-ovsdb.c | 193 +++-
tests/test-ovsdb.py | 27
3 files changed, 355 insertions(+), 1
be created on local bridge if there is no port binded to the logical datapath on
the local host.
Signed-off-by: Liran Schour
---
ovn/controller/binding.c| 114 +++-
ovn/controller/binding.h| 4 +-
ovn/controller/lport.c | 124
Add monitor_cond method to ovsdb-client. Add unit tests.
See ovsdb-client(1) man page for details.
Replace monitor2 with monitor_cond.
Signed-off-by: Liran Schour
---
NEWS| 3 +-
lib/ovsdb-idl.c | 28 +++
ovsdb/jsonrpc-server.c | 14 ++--
ovsdb/jsonrpc
IDL uses now a uuid to specify a monitoring session that is being
sent to the server on "monitor_cond" request.
This uuid will be used to issue ongoing "monitor_cond_change" requests
for this monitoring session.
Signed-off-by: Liran Schour
---
lib/ovsdb-idl.c | 17
Python idl works now with "monitor_cond" method. Add test
for backward compatibility with old "monitor" method.
Signed-off-by: Liran Schour
---
python/ovs/db/data.py | 16 -
python/ovs/db/idl.py | 172 --
tests/o
Darrell Ball wrote on 18/05/2016 03:56:30 AM:
> On Tue, May 17, 2016 at 7:27 AM, Liran Schour wrote:
> Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group
> MAC_Binding tables. As a result ovn-controller will be notified only
about
> records belongs to a datapath t
Liran Schour/Haifa/IBM@IBMIL wrote on 17/05/2016 05:22:33 PM:
> Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group
> MAC_Binding tables. As a result ovn-controller will be notified only
about
> records belongs to a datapath that is being served by this hypervisor.
Ryan Moats/Omaha/IBM wrote on 23/05/2016 04:53:00 PM:
> "dev" wrote on 05/23/2016 03:48:39 AM:
>
> > From: "Liran Schour"
> > To: "Ben Pfaff"
> > Cc: ovs-dev
> > Date: 05/23/2016 03:49 AM
> > Subject: Re: [ovs-dev] [
Ben Pfaff wrote on 01/06/2016 09:18:46 PM:
> On Tue, May 17, 2016 at 05:26:59PM +0300, Liran Schour wrote:
> > Columns indexing is different in ovsdb_row then in ovsdb_monitor_row.
> > We need mapping between the 2 for condition evaluation.
> >
> > signed-of
Ben Pfaff wrote on 01/06/2016 09:36:37 PM:
> On Tue, May 17, 2016 at 05:27:00PM +0300, Liran Schour wrote:
> > Change ovsdb_condition to be a 3-element json array or a boolean
value.
> > Conditions utilities will be used later for conditional monitoring.
> >
> >
Ben Pfaff wrote on 02/06/2016 08:38:10 PM:
> On Tue, May 17, 2016 at 05:27:09PM +0300, Liran Schour wrote:
> > Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group
> > MAC_Binding tables. As a result ovn-controller will be notified only
about
> > records
Ben Pfaff wrote on 02/06/2016 03:07:08 AM:
> On Tue, May 17, 2016 at 05:27:02PM +0300, Liran Schour wrote:
> > Hold session's conditions in ovsdb_monitor_session_condition. Pass it
> > to ovsdb_monitor for generating "update2" notifications.
> > Add
Ben Pfaff wrote on 02/06/2016 03:15:57 AM:
> On Tue, May 17, 2016 at 05:27:03PM +0300, Liran Schour wrote:
> > Add monitor_cond method to ovsdb-client. Add unit tests.
> > See ovsdb-client(1) man page for details.
> > Replace monitor2 with monitor_cond.
> >
>
Ben Pfaff wrote on 02/06/2016 07:47:20 PM:
Seems like I review for 06/11 patch is missing...
> On Tue, May 17, 2016 at 05:27:05PM +0300, Liran Schour wrote:
> > IDL uses now a uuid to specify a monitoring session that is being
> > sent to the server on "monitor_cond" re
Ben Pfaff wrote on 02/06/2016 08:04:39 PM:
> On Tue, May 17, 2016 at 05:27:06PM +0300, Liran Schour wrote:
> > Add API that allows the user to create condition iteratively
> > and send condition_update to the server.
> >
> > Signed-off-by: Liran Schour
>
>
Ben Pfaff wrote on 02/06/2016 08:08:14 PM:
> On Tue, May 17, 2016 at 05:27:08PM +0300, Liran Schour wrote:
> > Add tests for conditional monitoring to IDL.
> >
> > Signed-off-by: Liran Schour
>
> Thanks for adding tests.
>
> Usually we squash tests for n
Ben Pfaff wrote on 06/06/2016 06:24:09 PM:
> On Mon, Jun 06, 2016 at 01:05:19PM +0300, Liran Schour wrote:
> > Ben Pfaff wrote on 02/06/2016 08:38:10 PM:
> > > Looking at how all this fits together, it seems a little awkward to
have
> > > condition objects separa
condition update for code simplicity.
Signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 23 +++
ovsdb/monitor.c| 34 --
ovsdb/monitor.h| 2 +-
3 files changed, 36 insertions(+), 23 deletions(-)
diff --git a/ovsdb/jsonrpc
IDL uses now a uuid to specify a monitoring session that is being
sent to the server on "monitor_cond" request.
This uuid will be used to issue ongoing "monitor_cond_change" requests
for this monitoring session.
Signed-off-by: Liran Schour
---
lib/ovsdb-idl.c | 17
details of monitor_cond_change.
Signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 147 +++-
ovsdb/monitor.c | 254 +++-
ovsdb/monitor.h | 32 +++---
ovsdb/ovsdb-server.1.in | 72 ++
4 files ch
.
* Split added documentation according to patches.
* Add to testing for monitor_cond_change method in ovsdb-client via unixctl
command.
* An update, if any, as a result of a condition change, will be sent to the
client before the reply to the "monitor_cond_update" request.
* Minor
Hold session's conditions in ovsdb_monitor_session_condition. Pass it
to ovsdb_monitor for generating "update2" notifications.
Add functions that can generate "update2" notification for a
"monitor_cond" session.
JSON cache is enabled only for session's with true condition only.
"monitor_cond" and "
Change ovsdb_condition to be a 3-element json array or a boolean value (see
ovsdb-server
man page).
Conditions utilities will be used later for conditional monitoring.
Signed-off-by: Liran Schour
---
ovsdb/condition.c| 186 +++
ovsdb
Optimize ovsdb_condition_match_any_clause() to be in O(#columns in condition)
and not O(#clauses) in case condition's caluses function is boolean or "==".
Signed-off-by: Liran Schour
---
ovsdb/condition.c | 114 +++-
ovsdb/cond
This will allow ovn-controller to conditionally monitor MAC_Binding table
according to datapath column.
Signed-off-by: Liran Schour
---
ovn/controller/pinctrl.c | 1 +
ovn/ovn-sb.ovsschema | 6 --
ovn/ovn-sb.xml | 3 +++
3 files changed, 8 insertions(+), 2 deletions(-)
diff
| 37898342465 | 38647139083 | -1.9%
48 | 41637996229 | 41846616306 | -0.5%
50 | 41679995357 | 43455565977 | -4.2%
Signed-off-by: Liran Schour
---
ovn/controller/automake.mk | 4 +-
ovn/controller/binding.c| 38 ++--
ovn/controller
Add monitor_cond method to ovsdb-client. Enable testing of monitor_cond_change
via unixctl command.Add unit tests for monitor_cond and monitor_cond_change.
See ovsdb-client(1) man page for details.
Replace monitor2 with monitor_cond.
Signed-off-by: Liran Schour
---
NEWS| 3
Columns indexing is different in ovsdb_row then in ovsdb_monitor_row.
We need mapping between the 2 for condition evaluation.
signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 26 ++--
ovsdb/monitor.c| 65 +++---
ovsdb
Python idl works now with "monitor_cond" method. Add test
for backward compatibility with old "monitor" method.
Signed-off-by: Liran Schour
---
python/ovs/db/data.py | 16 -
python/ovs/db/idl.py | 172 --
tests/o
Add to IDL API that allows the user to add and remove clauses on a table's
condition
iteratively. IDL maintain tables condition and send monitor_cond_change to the
server
upon condition change.
Add tests for conditional monitoring to IDL.
Signed-off-by: Liran Schour
---
lib/automa
| 41846616306 | -0.5%
50 | 41679995357 | 43455565977 | -4.2%
Signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 39 ++-
ovsdb/monitor.c | 285 +++-
ovsdb/monitor.h | 30 -
ovsdb/ovsdb-server.1.in | 1
| 37898342465 | 38647139083 | -1.9%
48 | 41637996229 | 41846616306 | -0.5%
50 | 41679995357 | 43455565977 | -4.2%
Signed-off-by: Liran Schour
---
ovn/controller/automake.mk | 4 +-
ovn/controller/binding.c| 48 +++---
ovn/controller
Mickey Spiegel/San Jose/IBM wrote on 20/07/2016 08:53:42 AM:
> From: Mickey Spiegel/San Jose/IBM
> To: Liran Schour/Haifa/IBM@IBMIL
> Cc: Ben Pfaff , dev@openvswitch.org
> Date: 20/07/2016 08:53 AM
> Subject: Re: [ovs-dev] [PATCH monitor_cond V10] RFC OVN:
> Implementat
William Tu wrote on 23/07/2016 04:20:10 AM:
> From: William Tu
> To: ""
> Cc: Liran Schour/Haifa/IBM@IBMIL
> Date: 23/07/2016 04:20 AM
> Subject: Valgrind memory leak at ovsdb_monitor_table_condition_create
>
> Hi,
>
> Testcases which exercises this c
Ryan Moats/Omaha/IBM wrote on 24/07/2016 11:03:21 PM:
> From: Ryan Moats/Omaha/IBM
> To: Liran Schour
> Cc: Ben Pfaff , dev@openvswitch.org
> Date: 24/07/2016 11:03 PM
> Subject: Re: [ovs-dev] [PATCH monitor_cond V10] RFC OVN:
> Implementation of conditional monitoring usage
"dev" wrote on 25/07/2016 09:03:55 AM:
> From: Liran Schour/Haifa/IBM@IBMIL
> To: "Ryan Moats"
> Cc: dev@openvswitch.org
> Date: 25/07/2016 09:04 AM
> Subject: Re: [ovs-dev] [PATCH monitor_cond V10] RFC OVN:
> Implementation of conditional monitoring u
> From: Ryan Moats
> To: dev@openvswitch.org
> Date: 23/07/2016 12:57 AM
> Subject: [ovs-dev] [PATCH] ovn-controller: Handle physical changes
correctly
> Sent by: "dev"
>
> [1] reported increased failure rates in certain tests
> with incremental processing (the numbers are the number of failure
Destroy shash on destroy of session's condition structure.
Reported here: http://openvswitch.org/pipermail/dev/2016-July/075968.html
Signed-off-by: Liran Schour
---
ovsdb/monitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c
index 99083e1..9a
t-ovn-nodes/blob/master/README.md
>
>
> > [1] http://openvswitch.org/pipermail/dev/2016-July/076058.html
> >
> > Signed-off-by: Ryan Moats
>
> Acked-by: Flavio Fernandes
> Tested-by: Flavio Fernandes
>
Tested this fix with a cluster of 50 hosts
%
42 | 37898342465 | 38647139083 | -1.9%
48 | 41637996229 | 41846616306 | -0.5%
50 | 41679995357 | 43455565977 | -4.2%
Signed-off-by: Liran Schour
---
ovn/controller/automake.mk | 4 +-
ovn/controller/binding.c| 45
"dev" wrote on 29/07/2016 11:46:09 AM:
> From: Darrell Ball
> To: dlu...@gmail.com, d...@openvswitch.com, b...@ovn.org
> Date: 29/07/2016 11:46 AM
> Subject: [ovs-dev] [patch_v1] ovn: Add datapaths of interest filtering
(RFC).
> Sent by: "dev"
>
> This patch adds datapaths of interest support
Mickey Spiegel/San Jose/IBM wrote on 31/07/2016 08:59:29 PM:
>
> Comments inline with
>
> -"dev" wrote: -
> To: Ben Pfaff
> From: Liran Schour
> Sent by: "dev"
> Date: 07/28/2016 04:49AM
> Cc: dev@openvswitch.org
> Subject: [ovs-de
Call for poll_immediate_wake() when condition is changed.
Signed-off-by: Liran Schour
---
lib/ovsdb-idl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index d70fb10..7f4167c 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -811,6 +811,7 @@ void
table to reduce the number
of hops that is required to retrieve all datapaths.
Signed-off-by: Liran Schour
---
ovn/controller/automake.mk | 4 +-
ovn/controller/binding.c| 35 +--
ovn/controller/binding.h| 4 +-
ovn/controller/filter.c | 207
"dev" wrote on 03/08/2016 09:09:48 AM:
> From: Darrell Ball
> To: dlu...@gmail.com, d...@openvswitch.com, b...@ovn.org
> Date: 03/08/2016 09:10 AM
> Subject: [ovs-dev] [patch_v3] ovn: Add datapaths of interest filtering.
> Sent by: "dev"
>
> This patch adds datapaths of interest support where
Hi,
Do we plan to include the ovn conditional monitoring usage in 2.6.0?
Performance evaluation shows up to 75% reduction of computation at the
ovn-controller and also a reduction of computation at the server side,
depending at the spread of the logical networks over the physical hosts.
(number
Darrell Ball wrote on 09/08/2016 08:02:06 PM:
> On Thu, Aug 4, 2016 at 3:26 AM, Liran Schour wrote:
> "dev" wrote on 03/08/2016 09:09:48 AM:
>
> > From: Darrell Ball
> > To: dlu...@gmail.com, d...@openvswitch.com, b...@ovn.org
> > Date: 03/08/2016 09:1
Ben Pfaff wrote on 06/06/2016 06:13:44 PM:
> On Mon, Jun 06, 2016 at 01:11:44PM +0300, Liran Schour wrote:
> > Ben Pfaff wrote on 01/06/2016 09:18:46 PM:
> > > This new columns_index_map means that it's no longer necessary to
work
> > > so hard to find d
Add monitor_cond method to ovsdb-client. Enable testing of monitor_cond_change
via unixctl command.Add unit tests for monitor_cond and monitor_cond_change.
See ovsdb-client(1) man page for details.
Replace monitor2 with monitor_cond.
Signed-off-by: Liran Schour
---
NEWS| 3
by that conditions should be composed only from logical datapath IDs.
In the meantime we first add the logical port to the conditions and on retrieval
of port binding record, we add the logical datapath to the conditions.
Signed-off-by: Liran Schour
---
ovn/controller/binding.c| 108
Hold session's conditions in ovsdb_monitor_session_condition. Pass it
to ovsdb_monitor for generating "update2" notifications.
Add functions that can generate "update2" notification for a
"monitor_cond" session.
JSON cache is enabled only for session's with true condition only.
"monitor_cond" and "
before the reply to the "monitor_cond_update" request.
* Minor fixes due to review.
Liran Schour (10):
ovsdb: create column index mapping between ovsdb row to monitor row
ovsdb: add conditions utilities to support monitor_cond
ovsdb: allow unmonitored columns in condition evaluation
ovsdb:
condition update for code simplicity.
Signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 23 +++
ovsdb/monitor.c| 34 --
ovsdb/monitor.h| 2 +-
3 files changed, 36 insertions(+), 23 deletions(-)
diff --git a/ovsdb/jsonrpc
by that conditions should be composed only from logical datapath IDs.
In the meantime we first add the logical port to the conditions and on retrieval
of port binding record, we add the logical datapath to the conditions.
Signed-off-by: Liran Schour
---
ovn/controller/binding.c| 108
Change ovsdb_condition to be a 3-element json array or a boolean value (see
ovsdb-server
man page).
Conditions utilities will be used later for conditional monitoring.
Signed-off-by: Liran Schour
---
ovsdb/condition.c| 188 +++
ovsdb
Add monitor_cond method to ovsdb-client. Enable testing of monitor_cond_change
via unixctl command.Add unit tests for monitor_cond and monitor_cond_change.
See ovsdb-client(1) man page for details.
Replace monitor2 with monitor_cond.
Signed-off-by: Liran Schour
---
NEWS| 3
Python idl works now with "monitor_cond" method. Add test
for backward compatibility with old "monitor" method.
Signed-off-by: Liran Schour
---
python/ovs/db/data.py | 16 -
python/ovs/db/idl.py | 172 --
tests/o
Columns indexing is different in ovsdb_row then in ovsdb_monitor_row.
We need mapping between the 2 for condition evaluation.
signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 26 ++--
ovsdb/monitor.c| 65 +++---
ovsdb
details of monitor_cond_change.
Signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 147 +++-
ovsdb/monitor.c | 254 +++-
ovsdb/monitor.h | 32 +++---
ovsdb/ovsdb-server.1.in | 72 ++
4 files ch
Add to IDL API that allows the user to add and remove clauses on a table's
condition
iteratively. IDL maintain tables condition and send monitor_cond_change to the
server
upon condition change.
Add tests for conditional monitoring to IDL.
Signed-off-by: Liran Schour
---
lib/automa
IDL uses now a uuid to specify a monitoring session that is being
sent to the server on "monitor_cond" request.
This uuid will be used to issue ongoing "monitor_cond_change" requests
for this monitoring session.
Signed-off-by: Liran Schour
---
lib/ovsdb-idl.c | 17
Hold session's conditions in ovsdb_monitor_session_condition. Pass it
to ovsdb_monitor for generating "update2" notifications.
Add functions that can generate "update2" notification for a
"monitor_cond" session.
JSON cache is enabled only for session's with true condition only.
"monitor_cond" and "
Add to IDL API that allows the user to add and remove clauses on a table's
condition
iteratively. IDL maintain tables condition and send monitor_cond_change to the
server
upon condition change.
Add tests for conditional monitoring to IDL.
Signed-off-by: Liran Schour
---
lib/automa
before the reply to the "monitor_cond_update" request.
* Minor fixes due to review.
Liran Schour (10):
ovsdb: create column index mapping between ovsdb row to monitor row
ovsdb: add conditions utilities to support monitor_cond
ovsdb: allow unmonitored columns in condition evaluation
ovsdb:
IDL uses now a uuid to specify a monitoring session that is being
sent to the server on "monitor_cond" request.
This uuid will be used to issue ongoing "monitor_cond_change" requests
for this monitoring session.
Signed-off-by: Liran Schour
---
lib/ovsdb-idl.c | 17
Python idl works now with "monitor_cond" method. Add test
for backward compatibility with old "monitor" method.
Signed-off-by: Liran Schour
---
python/ovs/db/data.py | 16 -
python/ovs/db/idl.py | 172 --
tests/o
Change ovsdb_condition to be a 3-element json array or a boolean value (see
ovsdb-server
man page).
Conditions utilities will be used later for conditional monitoring.
Signed-off-by: Liran Schour
---
ovsdb/condition.c| 188 +++
ovsdb
condition update for code simplicity.
Signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 23 +++
ovsdb/monitor.c| 34 --
ovsdb/monitor.h| 2 +-
3 files changed, 36 insertions(+), 23 deletions(-)
diff --git a/ovsdb/jsonrpc
details of monitor_cond_change.
Signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 147 +++-
ovsdb/monitor.c | 254 +++-
ovsdb/monitor.h | 32 +++---
ovsdb/ovsdb-server.1.in | 72 ++
4 files ch
Columns indexing is different in ovsdb_row then in ovsdb_monitor_row.
We need mapping between the 2 for condition evaluation.
signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 26 ++--
ovsdb/monitor.c| 65 +++---
ovsdb
Hui Kang/Watson/IBM wrote on 13/06/2016 07:58:41 PM:
> "dev" wrote on 06/13/2016 07:19:25 AM:
>
> > From: Liran Schour
> > To: b...@ovn.org
> > Cc: d...@openvswitch.com
> > Date: 06/13/2016 08:29 AM
> > Subject: [ovs-dev] [PATCH monitor_cond V7
details of monitor_cond_change.
Signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 147 +++-
ovsdb/monitor.c | 254 +++-
ovsdb/monitor.h | 32 +++---
ovsdb/ovsdb-server.1.in | 72 ++
4 files ch
IDL uses now a uuid to specify a monitoring session that is being
sent to the server on "monitor_cond" request.
This uuid will be used to issue ongoing "monitor_cond_change" requests
for this monitoring session.
Signed-off-by: Liran Schour
---
lib/ovsdb-idl.c | 17
condition update for code simplicity.
Signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 23 +++
ovsdb/monitor.c| 34 --
ovsdb/monitor.h| 2 +-
3 files changed, 36 insertions(+), 23 deletions(-)
diff --git a/ovsdb/jsonrpc
Columns indexing is different in ovsdb_row then in ovsdb_monitor_row.
We need mapping between the 2 for condition evaluation.
signed-off-by: Liran Schour
---
ovsdb/jsonrpc-server.c | 26 ++--
ovsdb/monitor.c| 65 +++---
ovsdb
dd_column().
* Split added documentation according to patches.
* Add to testing for monitor_cond_change method in ovsdb-client via unixctl
command.
* An update, if any, as a result of a condition change, will be sent to the
client before the reply to the "monitor_cond_update" request.
* Minor fi
Add monitor_cond method to ovsdb-client. Enable testing of monitor_cond_change
via unixctl command.Add unit tests for monitor_cond and monitor_cond_change.
See ovsdb-client(1) man page for details.
Replace monitor2 with monitor_cond.
Signed-off-by: Liran Schour
---
NEWS| 3
Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group
MAC_Binding tables. As a result ovn-controller will be notified only about
records belongs to a datapath that is being served by this hypervisor.
Evaluation on simulated environment of 50 hosts and 1000 logical ports shows
the fol
Change ovsdb_condition to be a 3-element json array or a boolean value (see
ovsdb-server
man page).
Conditions utilities will be used later for conditional monitoring.
Signed-off-by: Liran Schour
---
ovsdb/condition.c| 186 +++
ovsdb
Python idl works now with "monitor_cond" method. Add test
for backward compatibility with old "monitor" method.
Signed-off-by: Liran Schour
---
python/ovs/db/data.py | 16 -
python/ovs/db/idl.py | 172 --
tests/o
Hold session's conditions in ovsdb_monitor_session_condition. Pass it
to ovsdb_monitor for generating "update2" notifications.
Add functions that can generate "update2" notification for a
"monitor_cond" session.
JSON cache is enabled only for session's with true condition only.
"monitor_cond" and "
This will allow ovn-controller to conditionally monitor MAC_Binding table
according to datapath column.
Signed-off-by: Liran Schour
---
ovn/controller/pinctrl.c | 1 +
ovn/ovn-sb.ovsschema | 6 --
ovn/ovn-sb.xml | 3 +++
3 files changed, 8 insertions(+), 2 deletions(-)
diff
Add to IDL API that allows the user to add and remove clauses on a table's
condition
iteratively. IDL maintain tables condition and send monitor_cond_change to the
server
upon condition change.
Add tests for conditional monitoring to IDL.
Signed-off-by: Liran Schour
---
lib/automa
Hashing will not be consistent as long as we use for hashing the index of the
bucket in the list (for remove/insert of buckets not from/to the end of the
bucket list).
Use bucket_id for hashing instead.
Signed-off-by: Liran Schour
---
ofproto/ofproto-dpif-xlate.c | 5 ++---
1 file changed, 2
In case that we flushed everything already, we can immeidately return NULL.
Signed-off-by: Liran Schour
---
ovsdb/monitor.c | 4
1 file changed, 4 insertions(+)
diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c
index 5ae9cdb..1a07f19 100644
--- a/ovsdb/monitor.c
+++ b/ovsdb/monitor.c
In case of delete only: !initial,!insert,!modify. We can not be sure that we
will see X if we have: insert X, delete X.
In case of modify only: !initial,!insert,!delete. We can not be sure that we
will see X modified if we have: insert X, modify X, delete X.
Signed-off-by: Liran Schour
hmap_remove(&changes->rows, &change->hmap_node);
free(change);
-> Here we remove the entire change and the client
never been notified about that
}
}
}
}
Otherwise this patch series looks good and
gt; change->new = NULL;
>
> if (!change->old) {
> /* This row was added then deleted. Forget about it. */
> hmap_remove(&changes->rows, &change->hmap_node);
> free(change);
>
Ben Pfaff wrote on 25/02/2016 02:25:32 AM:
> On Thu, Feb 18, 2016 at 11:46:40AM +0000, Liran Schour wrote:
> > Change ovsdb_condition to be a 3-element json array or a boolean
value.
> > Conditions utilities will be used later for conditional monitoring.
> >
> >
Ben Pfaff wrote on 25/02/2016 06:47:36 PM:
> On Thu, Feb 18, 2016 at 11:46:39AM +0000, Liran Schour wrote:
> > Columns indexing is different in ovsdb_row then in ovsdb_monitor_row.
> > We need mapping between the 2 for condition evaluation.
> >
> >
Ben Pfaff wrote on 25/02/2016 09:16:39 PM:
> On Thu, Feb 18, 2016 at 11:46:41AM +0000, Liran Schour wrote:
> > This commit allows to add none monitored columns to a monitored table
> > due to condition update.
> > It will be used to evaluate conditions on non-monitore
result of monitor_cond_update
command.
* Clarifications in ovsdb-server(1) man page.
* Bug fix in ovsdb_monitor_get_all_rows()
* Fix style issues
Liran Schour (18):
ovsdb: create column index mapping between ovsdb row to monitor row
ovsdb: add conditions utilities to support monitor_cond
condition update to keep the code simple.
Signed-off-by: Liran Schour
---
v4->v5:
* None monitored --> unmonitored
v3->v4:
* Do not add duplicated none-monitored column
---
ovsdb/jsonrpc-server.c | 23 +++
ovsdb/monitor.c
1 - 100 of 267 matches
Mail list logo
