Ben Pfaff <b...@ovn.org> wrote on 02/06/2016 03:15:57 AM:

> On Tue, May 17, 2016 at 05:27:03PM +0300, Liran Schour wrote:
> > Add monitor_cond method to ovsdb-client. Add unit tests.
> > See ovsdb-client(1) man page for details.
> > Replace monitor2 with monitor_cond.
> > 
> > Signed-off-by: Liran Schour <lir...@il.ibm.com>
> 
> Thanks for the updated patch.
> 
> In the documentation, s/emtpy/empty/, s/mointor/monitor/.
> 

Will fix that.

> Please write some tests for update_cond_update (possibly add a unixctl
> command for ovsdb-client to update the conditions?).
> 

Will add tests for monitor_cond_update using unixctl command.

> There are some references in comments to OVS before 2.5 not supporting
> monitor_cond.  I think that these should be updated to 2.6?
> 

Right. Will fix that.

Thanks for the review.
- Liran

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to