Darrell Ball <dlu...@gmail.com> wrote on 09/08/2016 08:02:06 PM: > On Thu, Aug 4, 2016 at 3:26 AM, Liran Schour <lir...@il.ibm.com> wrote: > "dev" <dev-boun...@openvswitch.org> wrote on 03/08/2016 09:09:48 AM: > > > From: Darrell Ball <dlu...@gmail.com> > > To: dlu...@gmail.com, d...@openvswitch.com, b...@ovn.org > > Date: 03/08/2016 09:10 AM > > Subject: [ovs-dev] [patch_v3] ovn: Add datapaths of interest filtering. > > Sent by: "dev" <dev-boun...@openvswitch.org> > > > > This patch adds datapaths of interest support where only datapaths of > > local interest are monitored by the ovn-controller ovsdb client. The > > idea is to do a flood fill in ovn-controller of datapath associations > > calculated by northd. A new column is added to the SB database > > datapath_binding table - related_datapaths to facilitate this so all > > datapaths associations are known quickly in ovn-controller. This > > allows monitoring to adapt quickly with a single new monitor setting > > for all datapaths of interest locally. > > > > Signed-off-by: Darrell Ball <dlu...@gmail.com> > > --- > > > > I still think this work is mainly based on top of the conditional > monitor work. However it introduces a flood fill in the ovn- > controller using the new added column, related_datapaths, in the > datapath_bindning table which is important optimization to the origin work. > > Since the origin patch has went through 12 iterations and it is much > more stable and mature (http://openvswitch.org/pipermail/dev/2016- > August/077008.html). > I propose to combine the 2 patches. > > What do you think? > > I just got back from 5 days vacation yesterday. > > The patches are significantly different in design and implementation aspects. > They both call some conditional monitoring APIs. > However, I would like to find a way to share in some way. >
OK, so I will propose a plan to integrate the 2 works. Both works have a very similar usage of the conditional monitoring API, conditioning the same tables in the SB DB on the same places in the code (in most cases). Since my patch has gone through 12 iterations and has been tested already, I propose to use it as the implementation of the conditional monitoring usage and use it's exposed API filter_port() and filter_datapath() later. On top of it we can integrate your flood fill work with the changes in files: ovn-sb.ovsschema, ovn-sb.xml, ovn-norhtd.c, and code in binding.c and patch.c to call the above API to filter the related datapaths. What do you think? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
