On Feb 14, 2013, at 12:33 PM, Ben Pfaff wrote:
> On Thu, Feb 14, 2013 at 09:37:30AM -0500, Kyle Mestery wrote:
>> Garbage collect tnl_backers during type_run(). Add new
>> tnl_backers if a VXLAN ports UDP port changes.
>>
>> Signed-off-by: Kyle Mestery
>
> Th
On Feb 14, 2013, at 12:49 PM, Ben Pfaff wrote:
> On Thu, Feb 14, 2013 at 06:47:56PM +0000, Kyle Mestery (kmestery) wrote:
>> On Feb 14, 2013, at 12:33 PM, Ben Pfaff wrote:
>>> On Thu, Feb 14, 2013 at 09:37:30AM -0500, Kyle Mestery wrote:
>>>> Garbage collect tnl_
On Feb 15, 2013, at 10:58 AM, Jesse Gross wrote:
> On Thu, Feb 14, 2013 at 6:37 AM, Kyle Mestery wrote:
>> In tnl_set_config(), when determining if a tunnel port
>> already exists, make sure to also check the destination port. For VXLAN, this
>> can be different and allows
On Feb 15, 2013, at 2:49 PM, Ethan Jackson wrote:
> I think the main loop of this version still has some bugs. It doesn't
> properly
> update 'iter''s odp_port, nor do a tnl_port_reconfigure() when 'iter''s backer
> changes (in some cases). What about something like the following? I think
> it
On Feb 15, 2013, at 3:51 PM, Ben Pfaff wrote:
> On Fri, Feb 15, 2013 at 12:49:47PM -0800, Ethan Jackson wrote:
>> I think the main loop of this version still has some bugs. It doesn't
>> properly
>> update 'iter''s odp_port, nor do a tnl_port_reconfigure() when 'iter''s
>> backer
>> changes (in
On Feb 15, 2013, at 3:56 PM, Kyle Mestery (kmestery) wrote:
> On Feb 15, 2013, at 3:51 PM, Ben Pfaff wrote:
>> On Fri, Feb 15, 2013 at 12:49:47PM -0800, Ethan Jackson wrote:
>>> I think the main loop of this version still has some bugs. It doesn't
>>> properly
&
Ignore this one, I had some issues on my end with sending it.
On Feb 15, 2013, at 4:01 PM, Kyle Mestery
wrote:
> v3 Changes to main loop from Ethan.
> v2 fixes error handling noticed by Ben.
> ---
> Garbage collect tnl_backers during type_run(). Add new
> tnl_backers if a VXLAN
On Feb 15, 2013, at 4:04 PM, Ben Pfaff wrote:
> On Fri, Feb 15, 2013 at 02:00:59PM -0800, Ethan Jackson wrote:
>>> I don't think so. If you look, the code which is assigning iter->odp_port
>>> first
>>> checks if node is NULL.
>>
>> Actually no I think he's right. In the condition where the nod
ommit 3b6f2889400fd340b851c2d36356457559ae6e81
Author: Kyle Mestery
Date: Wed Jan 9 14:47:41 2013 -0500
datapath: Fix a kernel crash when adding a 2nd VXLAN port with existing UDP
port
When creating a second VXLAN tunnel port with the same UDP
port as an existing VXLAN tunnel
On Feb 19, 2013, at 7:35 PM, Pravin B Shelar wrote:
> Since userspace flow based tunneling code is checked in, the kernel
> port based tunneling code can be removed. Following patch removes
> this tunnel compatibility code and simplifies it.
>
> Signed-off-by: Pravin B Shelar
>
> Bug #15078
I
On Feb 20, 2013, at 10:15 AM, "Rajahalme, Jarno (NSN - FI/Espoo)"
wrote:
>
> On Feb 20, 2013, at 18:00 , ext Kyle Mestery (kmestery) wrote:
>
>> On Feb 19, 2013, at 7:35 PM, Pravin B Shelar wrote:
>>> Since userspace flow based tunneling code is checked in, t
On Feb 20, 2013, at 12:44 PM, Jesse Gross wrote:
> Here are a couple of small comments that I'd already written. I
> haven't gone through the main part of the patch yet but I figured that
> I might as well send them if you are going to respin the patch.
>
> On Tue, Feb 19, 2013 at 5:35 PM, Pravi
On Feb 20, 2013, at 1:56 PM, Kyle Mestery (kmestery) wrote:
> On Feb 20, 2013, at 12:44 PM, Jesse Gross wrote:
>> Here are a couple of small comments that I'd already written. I
>> haven't gone through the main part of the patch yet but I figured that
>> I mig
On Feb 21, 2013, at 10:52 AM, Pravin B Shelar wrote:
> Since userspace flow based tunneling code is checked in, the kernel
> port based tunneling code can be removed.
>
> Patch removes following components:
> - tunnel ports hash table and moved tunnel ports list to individual
> vports.
> - Clea
On Feb 15, 2013, at 4:12 PM, Kyle Mestery wrote:
> v3 Changes to main loop from Ethan along with comments from Ben.
> v2 fixes error handling noticed by Ben.
Ethan:
Any chance you can review this and possibly push it up? This, combined with
Pravin's latest tunnel cleanup patch s
On Feb 24, 2013, at 8:58 PM, Lorand Jakab wrote:
> The VXLAN draft just got updated from -02 to -03, with no major changes.
> Update documentation to reflect the change.
>
> Signed-off-by: Lorand Jakab
Looks good to me.
Acked-by:
On Feb 25, 2013, at 12:05 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Feb 25, 2013, at 8:40 PM, Changbin Liu
wrote:
> Hi folks,
>
> I have been using OpenvSwtich for a while and the VXLAN feature is awesome.
> We are able to run OpenStack on top of it now. During deployment, I have one
> question: how to set the VNI (VXLAN Network ID) of VXLAN tunnels? I have
you mean does VXLAN encapsulate STP packets? Or
are you looking for how VXLAN interacts with STP?
> Changbin
>
>
> On Mon, Feb 25, 2013 at 9:53 PM, Kyle Mestery (kmestery)
> wrote:
> On Feb 25, 2013, at 8:40 PM, Changbin Liu
> wrote:
> > Hi folks,
> >
> >
On Feb 26, 2013, at 9:21 AM, Changbin Liu wrote:
>
>
> On Tue, Feb 26, 2013 at 9:54 AM, Kyle Mestery (kmestery)
> wrote:
> On Feb 25, 2013, at 10:00 PM, Changbin Liu wrote:
> >
> > Hi Kyle,
> >
> > Thanks so much for your reply!
> >
> > To
Thanks for the review Ethan, one question on this below.
On Feb 26, 2013, at 1:10 PM, Ethan Jackson
wrote:
> Looks good to me with the following incremental which I've applied. I'll
> merge
> shortly. Thanks for doing this work Kyle.
>
> Ethan
>
> ---
> ofproto/ofproto-dpif.c |4 +---
>
On Feb 26, 2013, at 1:19 PM, Jesse Gross wrote:
> On Tue, Feb 26, 2013 at 11:10 AM, Ethan Jackson wrote:
>> Looks good to me with the following incremental which I've applied. I'll
>> merge
>> shortly. Thanks for doing this work Kyle.
>
> We should make sure that whatever patches are necessar
On Feb 26, 2013, at 1:21 PM, Ethan Jackson wrote:
>
>
> Ah yes, I think you're right. This interface is confusing, I assumed that
> assignment was just unnecessary. I'll send out a patch.
>
>
> Ah nevermind, I haven't merged it yet. Good catch, thanks.
>
> Ethan
Cool, glad we caught it
On Feb 26, 2013, at 1:16 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Looks good to me.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
el infrastructure.
> Ethan
>
>
> On Tue, Feb 26, 2013 at 11:27 AM, Kyle Mestery (kmestery)
> wrote:
> On Feb 26, 2013, at 1:19 PM, Jesse Gross wrote:
> > On Tue, Feb 26, 2013 at 11:10 AM, Ethan Jackson wrote:
> >> Looks good to me with the following incremental
26, 2013 at 11:36 AM, Ethan Jackson wrote:
>> I'm doing the backport now. Whats the name of Pravin's patch you're
>> referring to? Is that on master, or still in review?
>>
>> Ethan
>>
>>
>> On Tue, Feb 26, 2013 at 11:27 AM, Kyle Mestery (kmes
On Feb 27, 2013, at 10:47 AM, Jesse Gross wrote:
> On Wed, Feb 27, 2013 at 7:49 AM, Kyle Mestery wrote:
>> This adds unit tests for VXLAN and LISP. I'd like some feedback on this in
>> the
>> following areas:
>>
>> 1. Should I rename the existing t
On Feb 27, 2013, at 11:26 AM, Ben Pfaff wrote:
> On Wed, Feb 27, 2013 at 11:08:49AM -0500, Kyle Mestery wrote:
>> Signed-off-by: Kyle Mestery
>
> How's this version? I did a lot of editing so I added myself as a
> Co-authored-by:, but I'll remove that if you o
On Feb 27, 2013, at 6:31 PM, Jesse Gross wrote:
> On Wed, Feb 27, 2013 at 10:43 AM, Kyle Mestery wrote:
>> Signed-off-by: Kyle Mestery
>> ---
>> tests/tunnel.at | 69
>> +
>> 1 file changed, 69 insertions(
On Feb 28, 2013, at 11:21 AM, Jesse Gross
wrote:
> On Thu, Feb 28, 2013 at 6:30 AM, Kyle Mestery wrote:
>> In get_tunnel_config(), distinguish between VXLAN and LISP when deciding
>> whether or not to print UDP destination port. Only add the UDP
>> destination port for eit
On Mar 14, 2013, at 5:21 PM, Ben Pfaff wrote:
> On other platforms there is no benefit to linking against libpcap, because
> it is not used.
>
> Signed-off-by: Ben Pfaff
> CC: Ed Maste
Looks fine to me.
___
dev mailing list
dev@openvswitch.org
http:
On Mar 20, 2013, at 6:44 PM, Jesse Gross wrote:
> Allocation of the Netlink notification skb can potentially fail
> after changing vport configuration. In general, we try to avoid
> this by undoing any change we made but that is difficult for existing
> objects. This avoids the problem by preall
ou are trying to access in the
> + external network are not on VLAN 9 and that the Internet is not
> + available on VLAN 9.
> +
Maybe add this after what you have:
Ensure VLAN 9 is setup on the upstream switch port which eth0
is connected to, either as an access VLAN or as an allowed
ic.
> Following patch set flow before calling tnl_ops->build_header() and fixes
> OVS_CB(skb)->tun_key access.
>
> Signed-off-by: Pravin B Shelar
Looks good to me.
Acked-by: Kyle Mestery
___
dev mailing list
dev@openvswitch.org
http:/
On Apr 22, 2013, at 11:15 PM, Ben Pfaff wrote:
> This question keeps coming up.
>
> Signed-off-by: Ben Pfaff
Looks good to me Ben.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Apr 23, 2013, at 11:30 AM, Ben Pfaff wrote:
> I keep seeing this question.
>
> Signed-off-by: Ben Pfaff
Looks good to me Ben, very succinct explanation.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Apr 26, 2013, at 11:12 AM, Jesse Gross wrote:
> On Fri, Apr 26, 2013 at 6:53 AM, Kyle Mestery wrote:
>> VXLAN was recently assigned UDP port 4789 by IANA. This updates the OVS VXLAN
>> implementation to reflect the new UDP port number. It also updates the unit
>> test f
On Apr 26, 2013, at 11:48 AM, Jesse Gross wrote:
> On Fri, Apr 26, 2013 at 9:36 AM, Kyle Mestery (kmestery)
> wrote:
>> On Apr 26, 2013, at 11:12 AM, Jesse Gross wrote:
>>> On Fri, Apr 26, 2013 at 6:53 AM, Kyle Mestery wrote:
>>>> VXLAN was recently assigned UD
On Apr 26, 2013, at 12:42 PM, Ben Pfaff wrote:
> On Fri, Apr 26, 2013 at 01:40:55PM -0400, Kyle Mestery wrote:
>> VXLAN was recently assigned UDP port 4789 by IANA. This
>> comit updates the OVS VXLAN implementation to reflect the new UDP port
>> number.
>>
>> C
On Apr 26, 2013, at 12:57 PM, Justin Pettit wrote:
> On Apr 26, 2013, at 10:40 AM, Kyle Mestery wrote:
>
>> +Q: How much of the VXLAN protocol does Open vSwitch currently support?
>> +
>> +A: Open vSwitch currently supports the framing format for packets on the
>>
On Apr 26, 2013, at 1:40 PM, Jesse Gross wrote:
> On Fri, Apr 26, 2013 at 11:30 AM, Kyle Mestery wrote:
>> VXLAN was recently assigned UDP port 4789 by IANA. This
>> comit updates the OVS VXLAN implementation to reflect the new UDP port
>> number.
>>
>> Cc: Ken
On May 3, 2013, at 7:52 PM, Jesse Gross wrote:
> The get_config vport op is left over from old compatibility code,
> it is neither used nor implemented any more.
>
> Signed-off-by: Jesse Gross
Looks good Jesse.
___
dev mailing list
dev@openvswitch.or
On May 7, 2013, at 1:13 PM, Jarno Rajahalme wrote:
> This reduces repeated code and makes it easier to add new UDP tunneling
> protocols.
>
I haven't reviewed this in detail yet, but when I tried to compile it on
Fedora, it
failed. The small incremental below fixes this on Fedora. I'll continu
Just one minor nit, otherwise this is a nice cleanup Jarno! See below.
On May 7, 2013, at 1:13 PM, Jarno Rajahalme wrote:
> This reduces repeated code and makes it easier to add new UDP tunneling
> protocols.
>
> Signed-off-by: Jarno Rajahalme
> ---
> datapath/tunnel.c | 126
ats and leak memory on failure.
>
> Introduced by commit be7cd27e44258bdb3c4e7dd8fd7389b5db56d55a (datapath:
> Unify vport error stats handling.).
>
> CC: Pravin B Shelar
> Signed-off-by: Jesse Gross
Nice catch.
Acked-by: Kyle Mestery
__
On May 13, 2013, at 4:07 PM, Pravin B Shelar wrote:
> __sum16 and __wsum are defined in types.h from kernel 3.7.
>
> Signed-off-by: Pravin B Shelar
Looks good.
Acked-by: Kyle Mestery
___
dev mailing list
dev@openvswitch.org
http://openvs
On May 16, 2013, at 12:36 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks good Ben.
Acked-by: Kyle Mestery
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On May 21, 2013, at 10:44 AM, Ben Pfaff wrote:
> As an organizational tool for developers who might be interested in
> reviewing my code, I've now posted all my outstanding unreviewed (or
> review in progress) code as branches in the github repository visible on
> the web at:
>https://gith
On May 21, 2013, at 11:58 AM, Ben Pfaff wrote:
> On Tue, May 21, 2013 at 04:05:50PM +0000, Kyle Mestery (kmestery) wrote:
>> On May 21, 2013, at 10:44 AM, Ben Pfaff wrote:
>>> As an organizational tool for developers who might be interested in
>>> reviewing my c
On May 22, 2013, at 11:33 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On May 23, 2013, at 5:51 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks fine to me Ben, the wording is quite clear here.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On May 23, 2013, at 6:08 PM, Ben Pfaff wrote:
> OpenFlow 1.2 and later define a value of 65535 (OFPCML_NO_BUFFER) for
> the max_len field in an output action to mean that the switch should send
> the entire packet without buffering it. Open vSwitch never buffers packets
> sent via an output actio
On May 30, 2013, at 6:13 PM, Jesse Gross wrote:
> On Wed, May 29, 2013 at 11:16 PM, James Page wrote:
>> Hi OpenvSwitch Devs
>>
>> Ubuntu Saucy development has been open for a while and the Ubuntu kernel
>> team are currently targeting either Linux 3.9 or 3.10 for this release.
>>
>> Currently
On Jul 18, 2013, at 5:22 PM, Pravin B Shelar wrote:
> Following patch restructures vxlan tunneling so that it is more
> in sync with upstream vxlan tunneling code.
>
> Signed-off-by: Pravin Shelar
> ---
> v3-v2:
> - Moved kernel version in flow_dissector check to top.
> v1-v2:
> - Added create
On Jul 19, 2013, at 3:31 PM, Pravin Shelar wrote:
> On Fri, Jul 19, 2013 at 6:28 AM, Kyle Mestery (kmestery)
> wrote:
>>
>> On Jul 18, 2013, at 5:22 PM, Pravin B Shelar wrote:
>>
>>> Following patch restructures vxlan tunneling so that it is more
>>>
I'm hoping to get this done today, but had a question (was on PTO yesterday):
I see in Jesse's reply to Pravin's patch [1] a mention of putting the new code
into the main path, and the compatibility code should be for older kernels.
My question to Jesse is this: When you made this comment, did you
On Jul 30, 2013, at 7:17 PM, Jesse Gross wrote:
> On Fri, Jul 26, 2013 at 2:21 PM, Kyle Mestery wrote:
>> Add support for Linux kernel 3.9.
>>
>> Signed-off-by: Kyle Mestery
>> CC: Pravin B Shelar
>
> I think it's not strictly required to do the res
On Jul 31, 2013, at 3:41 PM, Jesse Gross wrote:
> On Tue, Jul 30, 2013 at 7:17 PM, Kyle Mestery wrote:
>> Ensure that in tunnel.c:handle_offloads() we save off skb->cb before
>> calling __skb_gso_segment() and restore it after the return.
>>
>> Signed-off-by: Pra
-dhcp-64-245.kmestery.cisco.com 3.10.4-300.fc19.x86_64 #1 SMP Tue Jul
30 11:29:05 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
[kmestery@km-dhcp-64-245 ~]$
Maybe add FAQ and NEWS items as well indicating the new
support.
Acked-by: Kyle Mestery
___
dev mail
On Aug 2, 2013, at 1:38 PM, Pravin B Shelar
wrote:
> Changes are mostly related API changes in vlan, GRE
> restructuring.
>
> Signed-off-by: Pravin B Shelar
Testing this one now. Mental to always read all the unread
email in a list before testing and replying. :)
_
On Aug 2, 2013, at 1:38 PM, Pravin B Shelar
wrote:
> Changes are mostly related API changes in vlan, GRE
> restructuring.
>
> Signed-off-by: Pravin B Shelar
Looks good and works with this kernel. Only nit is to add FAQ
and NEWS items for this.
Acked-by: Kyle Mestery
[kmester
be no effect.
>
> Signed-off-by: Jesse Gross
Acked-by: Kyle Mestery
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
rather than rx_handler. This was
> introduced by commit "3e35fe3 datapath: rhel: Move RHEL OVS hook
> registration to netdev_rx_handler_register() backport".
>
> Reported-by: Andrei Andone
> Signed-off-by: Chris Wright
> Cc: Thomas Graf
> Cc: Pravin Shelar
Loo
On Aug 21, 2013, at 4:15 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
_GET_CONFIG_REQUEST and QUEUE_GET_CONFIG_REPLY messages.
> OVS has never implemented these at all, which is more or less a
> bug. We should implement at least stubs for these.
>
> Kyle Mestery and Pritesh have expressed interest in the following but
> I do not yet have a conf
On Oct 1, 2013, at 4:44 PM, Jarno Rajahalme wrote:
>
> On Sep 20, 2013, at 1:04 AM, pritesh wrote:
>
>> This patch adds support for Network Service Headers (nsh) over VXLAN
>> as mentioned in [1]. Here changes are made to datapath to add nsh
>> headers whenever a vxlan port with destination po
On Oct 3, 2013, at 2:31 PM, Jesse Gross wrote:
> On Thu, Oct 3, 2013 at 9:46 AM, Kyle Mestery (kmestery)
> wrote:
>> So, we realize the need to add the NSH code upstream into the kernel.
>> But in parallel to this work, we're wondering if it would be ok to add a new
>&g
On Oct 4, 2013, at 6:07 AM, Lorand Jakab wrote:
> Signed-off-by: Lorand Jakab
Looks fine to me Lori.
Acked-by: Kyle Mestery
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
I'm seeing the following error on *one* of my Fedora test VMs.
It's strange because on the other two, I don't see the GRE errors
below. Any ideas as to what might be going wrong?
[kmestery@km-dhcp-64-197 ~]$ dmesg|grep gre
[0.175404] ACPI: Added _OSI(Processor Aggregator Device)
[8.365982]
doc /usr/share/man/man8/ovs-ofctl.8.gz
> %doc /usr/share/man/man8/ovs-parse-backtrace.8.gz
> %doc /usr/share/man/man8/ovs-vsctl.8.gz
> --
> 1.7.9.5
>
Acked-by: Kyle Mestery
> ___
> dev mailing list
> dev@openvswitch.org
>
2013 at 2:05 PM, Gurucharan Shetty wrote:
>> This looks good to me.
>> I verified that the Fedora rpm gets built fine after applying your patch.
>>
>> I applied it to master.
>>
>> Thanks.
>>
>> On Thu, Oct 24, 2013 at 12:35 PM, Kyle Mestery wrot
On Nov 30, 2013, at 12:46 AM, jerry wrote:
> Hi all,
>
> Does anyone have a plan to support for VEPA in OVS?
>
> In my opinion, we can achieve such function using two methods:
> 1) Add flow rules on each VM port to lead traffic to physical port.
> 2) Add a port type for physical port and do MAC-
ach.
Thanks,
Kyle
>
> > From: qianhui...@huawei.com
> > To: jerry.lili...@huawei.com
> > Date: Mon, 2 Dec 2013 06:07:20 +
> > CC: dev@openvswitch.org; zh...@huawei.com
> > Subject: [ovs-dev] $)A4p84: VEPA support in OVS
> >
> > $)AUb8vHKJGK >
On Dec 2, 2013, at 11:58 AM, Ben Pfaff wrote:
> On Mon, Dec 02, 2013 at 05:42:58PM +0000, Kyle Mestery (kmestery) wrote:
>> My only curiosity here was what would the advantages of implementing
>> VEPA in OVS be over using the existing lldpad approach. I'd also be
>> i
On Dec 14, 2013, at 11:27 AM, Gurucharan Shetty wrote:
> On Fri, Dec 13, 2013 at 6:53 PM, Kyle Mestery wrote:
>> Fixes the OVS builds on Fedora, which are currently broken upstream.
>>
>> Signed-off-by: Kyle Mestery
> Thanks for fixing.
> I applied this to maste
On Aug 7, 2012, at 1:50 PM, Ben Pfaff wrote:
> It's documented to return -1 if the version isn't yet known, but in fact
> it returned 0.
>
> Signed-off-by: Ben Pfaff
Looks good to me.
Thanks,
Kyle
___
dev mailing list
dev@openvswitch.org
http://openv
On Aug 7, 2012, at 1:50 PM, Ben Pfaff wrote:
> Until now, it seems that all vconn users have immediately started reading
> messages from the connection. Today, however, I added a new user that
> only wants to read packets after the OpenFlow version is negotiated, so
> it never called vconn_recv()
On Aug 7, 2012, at 1:50 PM, Ben Pfaff wrote:
> Until now, ovs-controller and the learning-switch code split responsibility
> for the OpenFlow connection. This commit moves all the responsibility into
> the learning-switch code.
>
> The rationale here is twofold. First, the split itself seems odd
On Aug 7, 2012, at 1:50 PM, Ben Pfaff wrote:
> The learning-switch implementation needs to know the OpenFlow version in
> use to send the initial handshake messages (e.g. the feature request), but
> the version is not always available at the time that the code currently
> sends the handshake. This
On Aug 7, 2012, at 1:50 PM, Ben Pfaff wrote:
> OVS has all kinds of odd fields, e.g. registers, and it doesn't make sense
> to try to match on all of them. This commit changes learning-switch to
> only try to match on the fields defined by OpenFlow 1.0. That's still not
> minimal, but it's more
On Aug 7, 2012, at 1:50 PM, Ben Pfaff wrote:
> This suppresses a long-standing warning from ovs-vswitchd about
> non-normalized flows.
>
> Signed-off-by: Ben Pfaff
Looks good to me.
Thanks,
Kyle
___
dev mailing list
dev@openvswitch.org
http://openvsw
On Aug 8, 2012, at 1:08 PM, Jesse Gross wrote:
> On Tue, Aug 7, 2012 at 3:48 PM, Kyle Mestery wrote:
>> Signed-off-by: Kyle Mestery
>> ---
>> datapath/datapath.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Applied, thanks Kyle.
Thanks Jesse.
On Aug 8, 2012, at 1:34 PM, Jesse Gross wrote:
> On Wed, Aug 8, 2012 at 11:13 AM, Kyle Mestery (kmestery)
> wrote:
>> On Aug 8, 2012, at 1:08 PM, Jesse Gross wrote:
>>> On Tue, Aug 7, 2012 at 3:48 PM, Kyle Mestery wrote:
>>>> Signed-off-by: Kyle Mestery
>
On Aug 13, 2012, at 5:40 PM, Jesse Gross wrote:
> On Mon, Aug 13, 2012 at 9:23 AM, Kyle Mestery wrote:
>> This patch builds on the first two patches which Simon Horman sent out in
>> May to move Open vSwitch towards flow-based tunneling. This patch simply
>> adds a tun_key, d
This looks good to me. I didn't scan to ensure you caught all instances of
daemon startup, though I assume you did.
Acked-by: Kyle Mestery
On Aug 16, 2012, at 6:55 PM, Ben Pfaff wrote:
> The OVS daemons "cd" to / as a normal part of their startup, since this is
> traditio
Much more readable.
Acked-by: Kyle Mestery
On Aug 16, 2012, at 6:59 PM, Ben Pfaff wrote:
> This is a harmless typo, but the file is more readable with AT_CAPTURE_FILE
> on its own line.
>
> Signed-off-by: Ben Pfaff
> ---
> tests/ofproto-dpif.at |3 ++-
> 1 files
On Aug 21, 2012, at 2:05 AM, Simon Horman wrote:
> On Mon, Aug 13, 2012 at 12:23:51PM -0400, Kyle Mestery wrote:
>> This is a first pass at providing a tun_key which can be
>> used as the basis for flow-based tunnelling. The tun_key
>> includes and replaces the tun_id in b
On Aug 28, 2012, at 9:08 PM, Jesse Gross wrote:
> On Sun, Aug 26, 2012 at 6:55 PM, Kyle Mestery (kmestery)
> wrote:
>>
>> On Aug 21, 2012, at 2:05 AM, Simon Horman wrote:
>>
>>> On Mon, Aug 13, 2012 at 12:23:51PM -0400, Kyle Mestery wrote:
>>>> This
Looks good to me.
Acked-by: Kyle Mestery
On Aug 29, 2012, at 7:09 PM, Ben Pfaff wrote:
> OVSDB has always had the ability to mark a column as "immutable", so that
> its value cannot be changed in a given row after that row is initially
> inserted. However, we discovered
place, before
moving on to the rest of the series?
Thanks!
Kyle
On Aug 29, 2012, at 8:17 PM, Simon Horman wrote:
> On Wed, Aug 29, 2012 at 10:00:45AM -0400, Kyle Mestery wrote:
>> This is a first pass at providing a tun_key which can be
>> used as the basis for flow-based tun
patch for tomorrow. Once we get the initial set
of patches up, I'll proceed to the userspace portions of the changes.
Thanks,
Kyle
> On Fri, Aug 31, 2012 at 7:02 PM, Kyle Mestery (kmestery)
> wrote:
>> Jesse:
>>
>> Are you going to have a chance to review these next wee
On Sep 3, 2012, at 7:19 PM, Jesse Gross wrote:
> The datapath list of ports was removed when we switched to using a
> hash-based port lookup so the list node is no longer used.
>
> Signed-off-by: Jesse Gross
Looks good to me.
Acked-by:
combination of flow and packet size could result in a kernel
> panic.
>
> Signed-off-by: Jesse Gross
Looks good.
Acked-by: Kyle Mestery
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sep 3, 2012, at 3:43 PM, Jesse Gross wrote:
> On Wed, Aug 29, 2012 at 7:00 AM, Kyle Mestery wrote:
>> This is a first pass at providing a tun_key which can be
>> used as the basis for flow-based tunnelling. The tun_key
>> includes and replaces the tun_id in both str
On Sep 4, 2012, at 8:40 PM, Jesse Gross wrote:
> On Tue, Sep 4, 2012 at 12:24 PM, Kyle Mestery (kmestery)
> wrote:
>> On Sep 3, 2012, at 3:43 PM, Jesse Gross wrote:
>>> On Wed, Aug 29, 2012 at 7:00 AM, Kyle Mestery wrote:
>>>> diff --git a/datapath/actions.
On Sep 4, 2012, at 8:40 PM, Jesse Gross wrote:
> On Tue, Sep 4, 2012 at 12:24 PM, Kyle Mestery (kmestery)
> wrote:
>> On Sep 3, 2012, at 3:43 PM, Jesse Gross wrote:
>>> On Wed, Aug 29, 2012 at 7:00 AM, Kyle Mestery wrote:
>>>> diff --git a/datapath/actions.
On Sep 5, 2012, at 1:03 PM, Jesse Gross wrote:
> On Wed, Sep 5, 2012 at 10:17 AM, Kyle Mestery (kmestery)
> wrote:
>> On Sep 4, 2012, at 8:40 PM, Jesse Gross wrote:
>>> On Tue, Sep 4, 2012 at 12:24 PM, Kyle Mestery (kmestery)
>>> wrote:
>>>> On
On Sep 6, 2012, at 10:24 PM, Jesse Gross wrote:
> On Wed, Sep 5, 2012 at 2:58 PM, Kyle Mestery wrote:
>> This is a first pass at providing a tun_key which can be
>> used as the basis for flow-based tunnelling. The tun_key
>> includes and replaces the tun_id in both struct ovs
On Sep 10, 2012, at 11:56 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Looks good to me Ben. Were people hitting this recently which
makes this doc mod necessary?
Acked-byy: Kyle Mestery
___
dev mailing list
dev@openvswitch.org
h
fo for
> the on-disk version or from /sys/module/openvswitch/version for the currently
> loaded module.
>
> Suggested-by: Duffie Cooley
> Signed-off-by: Jesse Gross
Looks good to me.
Acked-by: Kyle Mestery
___
dev mailing li
201 - 300 of 422 matches
Mail list logo
