Hi,
I'm attempting to install ovs 2.3.1 on FreeBSD and it appears to be broken
after the commit 666afb55e84e9118812de81a75655ec9567b7a5b.
Since FreeBSD uses two short integers to represent interface flags,
we have to apply mask 0x to flags.
Signed-off-by: Kevin Lo
---
diff --git
On Fri, Apr 03, 2015 at 08:16:18AM -0700, Ben Pfaff wrote:
>
> On Fri, Apr 03, 2015 at 10:02:16PM +0800, Kevin Lo wrote:
> > I'm attempting to install ovs 2.3.1 on FreeBSD and it appears to be broken
> > after the commit 666afb55e84e9118812de81a75655ec9567b7a5b.
> >
On Fri, Apr 03, 2015 at 02:46:11PM -0400, Ed Maste wrote:
>
> On 3 April 2015 at 13:46, Ben Pfaff wrote:
> >
> >> > Also, the commit you name was in 2013, and we've had other
> >> > contributions from FreeBSD contributors since then
> >> > (namely Ed Maste ) and it seems like he
> >> > would have
ff-by: Kevin Lo
---
PATCH -> V2:
- refine the commit message.
---
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index f97a5c3..9ed2823 100644
--- a/lib/netdev-bsd.c
+++ b/lib/netdev-bsd.c
@@ -1785,7 +1785,7 @@ static int
ifr_get_flags(const struct ifreq *ifr)
{
#ifdef HAVE_STRUCT_IFREQ_IFR_F
On Fri, Apr 03, 2015 at 03:15:00PM -0700, Ben Pfaff wrote:
>
> On Fri, Apr 03, 2015 at 02:46:11PM -0400, Ed Maste wrote:
> > On 3 April 2015 at 13:46, Ben Pfaff wrote:
> > >
> > >> > Also, the commit you name was in 2013, and we've had other
> > >> > contributions from FreeBSD contributors since
On Sat, Apr 04, 2015 at 10:35:07PM -0400, Ed Maste wrote:
>
> On 4 April 2015 at 12:56, Kevin Lo wrote:
> >> Kevin, what failure mode did you observe?
> >
> > On FreeBSD, multicast is enabled on the interface by default, the value of
> > ifr_flags could be
On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the
linker flags for linking with a pthread library.
Add macro ax_pthread.m4 from GNU autoconf macro archive and use
macro AX_PTHREAD.
Signed-off-by: Kevin Lo
---
diff --git a/configure.ac b/configure.ac
index 8d47eb9..531a1f0
We have to specify -w to set tunable sysctls on NetBSD.
Signed-off-by: Kevin Lo
---
diff --git a/INSTALL.userspace.md b/INSTALL.userspace.md
index 300d6c1..04c02cd 100644
--- a/INSTALL.userspace.md
+++ b/INSTALL.userspace.md
@@ -76,7 +76,7 @@ Other settings
On NetBSD, depending on your network
On Tue, Apr 14, 2015 at 08:43:42PM -0700, Ben Pfaff wrote:
>
> [Guru: please see final paragraph]
>
> On Tue, Apr 07, 2015 at 03:54:30PM +0800, Kevin Lo wrote:
> > On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the
> > linker flags for linking with a
Add macro ax_pthread.m4 from GNU autoconf macro archive and use
> > > macro AX_PTHREAD.
> > >
> > > Signed-off-by: Kevin Lo
> > > ---
> > >
> > > diff --git a/configure.ac b/configure.ac
> > > index 8d47eb9..531a1f0 100644
> &g
Hi,
This patch removes duplicate header inclusion of .
Signed-off-by: Kevin Lo
---
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index 9ed2823..541e5ec 100644
--- a/lib/netdev-bsd.c
+++ b/lib/netdev-bsd.c
@@ -42,7 +42,6 @@
#include
#if defined(__NetBSD__)
#include
-#include
#include
This patch removes dead stores found by llvm checker in dpctl_set_if().
Signed-off-by: Kevin Lo
---
diff --git a/lib/dpctl.c b/lib/dpctl.c
index 4c4d1c3..a5696a7 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -381,13 +381,11 @@ dpctl_set_if(int argc, const char *argv[], struct
dpctl_params
Hi,
For those that are interested, I've run the LLVM scan-build tool to
perform static analysis of the OVS code on FreeBSD and make the results
availalble at http://people.freebsd.org/~kevlo/ovs-scan/scan-build-2015-04-15/
Kevin
___
dev mailing
On Wed, Apr 15, 2015 at 11:21:06AM -0700, Ben Pfaff wrote:
>
> On Wed, Apr 15, 2015 at 03:16:50PM +0800, Kevin Lo wrote:
> > This patch removes dead stores found by llvm checker in dpctl_set_if().
> >
> > Signed-off-by: Kevin Lo
>
> Thank you for the patch.
>
On Wed, Apr 15, 2015 at 07:38:51AM -0700, Ben Pfaff wrote:
>
> On Wed, Apr 15, 2015 at 10:35:44PM +0800, Kevin Lo wrote:
> > For those that are interested, I've run the LLVM scan-build tool to
> > perform static analysis of the OVS code on FreeBSD and make the
> > r
This one I should take care of it. :-)
Acked-by: Kevin Lo
On Thu, Apr 16, 2015 at 03:08:17PM -0700, Jarno Rajahalme wrote:
>
> Subject should be corrected, otherwise:
>
> Acked-by: Jarno Rajahalme
>
> > On Apr 16, 2015, at 2:19 PM, Ben Pfaff wrote:
> >
> >
Thanks for fixing it.
Acked-by: Kevin Lo
On Thu, Apr 16, 2015 at 01:44:53PM -0700, Ben Pfaff wrote:
>
> Doesn't seem to be good for anything.
>
> Found by LLVM scan-build.
>
> Reported-by: Kevin Lo
> Signed-off-by: Ben Pfaff
> ---
> lib/ovs-lldp.c | 6 +
On Wed, Apr 15, 2015 at 05:50:42PM -0700, Ben Pfaff wrote:
>
> On Wed, Apr 15, 2015 at 07:52:24AM -0700, Gurucharan Shetty wrote:
> > >
> > > I am also concerned that it this will break the Windows build.
> > > Currently Windows uses some Windows-only code in m4/openvswitch.m4,
> > > which require
On Fri, Apr 17, 2015 at 09:17:46AM -0700, Ben Pfaff wrote:
>
> On Fri, Apr 17, 2015 at 02:45:32PM +0800, Kevin Lo wrote:
> > On Wed, Apr 15, 2015 at 05:50:42PM -0700, Ben Pfaff wrote:
> > >
> > > On Wed, Apr 15, 2015 at 07:52:24AM -0700, Gurucharan Shetty wrote:
On Thu, Apr 16, 2015 at 08:53:15AM -0700, Ben Pfaff wrote:
>
> On Thu, Apr 16, 2015 at 10:47:13AM +0800, Kevin Lo wrote:
> > On Wed, Apr 15, 2015 at 07:38:51AM -0700, Ben Pfaff wrote:
> > >
> > > On Wed, Apr 15, 2015 at 10:35:44PM +0800, Kevin Lo wrote:
> &g
s to check
pthread_create.
Signed-off-by: Kevin Lo
---
PATCH -> V2:
- refine the commit message.
diff --git a/configure.ac b/configure.ac
index d1b48ca..2d893eb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -81,7 +81,7 @@ AC_SUBST([LT_AGE])
AC_SEARCH_LIBS([pow], [m])
AC_SEARCH_LIBS([clock_
On Fri, Apr 17, 2015 at 09:41:19PM -0700, Ben Pfaff wrote:
>
> On Sat, Apr 18, 2015 at 01:28:21AM +0800, Kevin Lo wrote:
> > On Fri, Apr 17, 2015 at 09:17:46AM -0700, Ben Pfaff wrote:
> > >
> > > On Fri, Apr 17, 2015 at 02:45:32PM +0800, Kevin Lo wrote:
> > &g
On Fri, Apr 17, 2015 at 08:02:28AM -0700, Gurucharan Shetty wrote:
>
> >
> > I know some of you are concerned about it will break build on Windows.
> > The diff below fixes pthread linking on FreeBSD.
> > Tested on Linux, NetBSD, and FreeBSD.
> You can also check whether it builds successfully on
On Fri, Apr 17, 2015 at 10:49:07AM -0700, Ben Pfaff wrote:
>
> On Sat, Apr 18, 2015 at 01:44:00AM +0800, Kevin Lo wrote:
> > On Thu, Apr 16, 2015 at 08:53:15AM -0700, Ben Pfaff wrote:
> > >
> > > On Thu, Apr 16, 2015 at 10:47:13AM +0800, Kevin Lo wrote:
> > &g
Acked-by: Kevin Lo
On Sun, Apr 26, 2015 at 10:17:33AM -0700, Ben Pfaff wrote:
>
> Found by LLVM scan-build.
>
> Reported-by: Kevin Lo
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-parse.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/ofp-par
Hi,
Missing a include file caused compile error:
http://dpaste.com/22E4MHK
FreeBSD (and NetBSD?) needs to include netinet/in.h to define
struct in6_addr.
Signed-off-by: Kevin Lo
---
diff --git a/lib/util.h b/lib/util.h
index 340ef65..9db65c5 100644
--- a/lib/util.h
+++ b/lib/util.h
On Wed, Dec 02, 2015 at 03:47:57PM +0900, Takashi Yamamoto wrote:
>
> On Wed, Dec 2, 2015 at 3:21 PM, Kevin Lo wrote:
> > Hi,
> >
> > Missing a include file caused compile error:
> > http://dpaste.com/22E4MHK
>
> why to add it to lib/util.h, rather than ovs
On Wed, Dec 02, 2015 at 04:15:48PM +0900, Takashi Yamamoto wrote:
> On Wed, Dec 2, 2015 at 4:12 PM, Kevin Lo wrote:
> > On Wed, Dec 02, 2015 at 03:47:57PM +0900, Takashi Yamamoto wrote:
> >>
> >> On Wed, Dec 2, 2015 at 3:21 PM, Kevin Lo wrote:
> >> > H
On Thu, Dec 03, 2015 at 03:01:38PM -0200, Thadeu Lima de Souza Cascardo wrote:
>
> On Wed, Dec 02, 2015 at 03:32:50PM +0800, Kevin Lo wrote:
> > On Wed, Dec 02, 2015 at 04:15:48PM +0900, Takashi Yamamoto wrote:
> > > On Wed, Dec 2, 2015 at 4:12 PM, Kevin Lo wrote:
> >
FreeBSD needs to include netinet/in.h to define struct in6_addr.
Signed-off-by: Kevin Lo
---
diff --git a/lib/ovs-router.h b/lib/ovs-router.h
index 315702c..c23d554 100644
--- a/lib/ovs-router.h
+++ b/lib/ovs-router.h
@@ -17,6 +17,8 @@
#ifndef OVS_TNL_ROUTER_H
#define OVS_TNL_ROUTER_H 1
On Thu, Dec 03, 2015 at 11:42:34PM -0800, Joe Stringer wrote:
>
> On 3 December 2015 at 22:11, Kevin Lo wrote:
> > On Thu, Dec 03, 2015 at 03:01:38PM -0200, Thadeu Lima de Souza Cascardo
> > wrote:
> >>
> >> On Wed, Dec 02, 2015 at 03:32:50PM +0800, Kevin L
31 matches
Mail list logo
