On Thu, Dec 03, 2015 at 11:42:34PM -0800, Joe Stringer wrote:
>
> On 3 December 2015 at 22:11, Kevin Lo <ke...@freebsd.org> wrote:
> > On Thu, Dec 03, 2015 at 03:01:38PM -0200, Thadeu Lima de Souza Cascardo
> > wrote:
> >>
> >> On Wed, Dec 02, 2015 at 03:32:50PM +0800, Kevin Lo wrote:
> >> > On Wed, Dec 02, 2015 at 04:15:48PM +0900, Takashi Yamamoto wrote:
> >> > > On Wed, Dec 2, 2015 at 4:12 PM, Kevin Lo <ke...@freebsd.org> wrote:
> >> > > > On Wed, Dec 02, 2015 at 03:47:57PM +0900, Takashi Yamamoto wrote:
> >> > > >>
> >> > > >> On Wed, Dec 2, 2015 at 3:21 PM, Kevin Lo <ke...@freebsd.org> wrote:
> >> > > >> > Hi,
> >> > > >> >
> >> > > >> > Missing a include file caused compile error:
> >> > > >> > http://dpaste.com/22E4MHK
> >> > > >>
> >> > > >> why to add it to lib/util.h, rather than ovs-router.c?
> >> > > >
> >> > > > Because the declarations for ovs_router_lookup() and
> >> > > > ovs_router_insert() are
> >> > > > in ovs-router.h, adding netinet/in.h to ovs-router.c won't help.
> >> > > > please see the log, thanks.
> >> > >
> >> > > well, i can understand if it's ovs-router.h.
> >> > > (although a forward decl seems enough there.)
> >> > > my question is why lib/util.h.
> >> >
> >> > There is no particular reason for this. I think it’s a matter of style.
> >> >
> >>
> >> I don't think it's just a matter of style. Every module that includes
> >> lib/util.h
> >> will need to compile netinet/in.h, even if that's not needed. Adding it to
> >> lib/ovs-router.h should be enough. Does that work for you?
> >
> > Yes, thanks.
>
> Will someone resend? This looks like it should be applied to
> branch-2.5 too, when it gets to that point.
Done, thanks.
Kevin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
