This one I should take care of it. :-)

Acked-by: Kevin Lo <ke...@freebsd.org>

On Thu, Apr 16, 2015 at 03:08:17PM -0700, Jarno Rajahalme wrote:
> 
> Subject should be corrected, otherwise:
> 
> Acked-by: Jarno Rajahalme <jrajaha...@nicira.com>
> 
> > On Apr 16, 2015, at 2:19 PM, Ben Pfaff <b...@nicira.com> wrote:
> > 
> > When netdev_bsd_get_mtu() failed, it didn't report the error to the caller,
> > so the caller couldn't work around not knowing the MTU.
> > 
> > Found by LLVM scan-build.
> > 
> > Reported-by: Kevin Lo <ke...@freebsd.org>
> > Signed-off-by: Ben Pfaff <b...@nicira.com>
> > ---
> > lib/netdev-bsd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
> > index 541e5ec..cc01470 100644
> > --- a/lib/netdev-bsd.c
> > +++ b/lib/netdev-bsd.c
> > @@ -843,7 +843,7 @@ netdev_bsd_get_mtu(const struct netdev *netdev_, int 
> > *mtup)
> >     }
> >     ovs_mutex_unlock(&netdev->mutex);
> > 
> > -    return 0;
> > +    return error;
> > }
> > 
> > static int
> > -- 
> > 2.1.3
> > 
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> 
> 
> 
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to