On 8 September 2016 at 12:34, Guru Shetty wrote:
> On 29 August 2016 at 12:11, Paul Boca wrote:
>
>> In user mode the flags are interpreted as little endian.
>> This fix makes the kernel mode compatible with user mode.
>>
>> Signed-off-by: Paul-Daniel Boca
>>
> Applied, thank you.
Does this nee
On 9 September 2016 at 08:55, Ben Pfaff wrote:
> Our previously announced plan for OVS 2.6 is to release on Sept. 15, in
> less than a week. In the OVN meeting in IRC yesterday, we already
> discussed a few OVN bugs that should be fixed before the release. All
> of them seem like they can be fix
On 19 July 2016 at 20:08, Ben Pfaff wrote:
> On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Cascardo wrote:
>> FreeBSD returns a socklen of sockaddr_storage when doing an accept on an unix
>> STREAM socket. The current code will assume it means a sun_path larger than
>> 0.
>>
>> T
ighted a segfault, a memory
leak and some other warnings about "possibly lost" memory. This series
addresses these particular issues.
There's a couple of "possible loss" warnings for this test that I didn't
address here, because they look less likely to cause problems in
ain (ovsdb-server.c:429)
Fixes: 60e0cd041958 ("ovsdb: Replication usability improvements")
Signed-off-by: Joe Stringer
---
This addresses the crash, but I don't understand the deeper reasoning
why we get into this state in the first place so I welcome any counter
proposals.
Th
0x44FFB6: unixctl_server_run (unixctl.c:400)
==18725==by 0x4081AC: main_loop (ovsdb-server.c:182)
==18725==by 0x406432: main (ovsdb-server.c:429)
Fixes: 60e0cd041958 ("ovsdb: Replication usability improvements")
Signed-off-by: Joe Stringer
---
This also affects branch-2.6.
By placing these nodes at the start of their respective structures,
several "possibly lost" warnings from valgrind are silenced.
Fixes: 60e0cd041958 ("ovsdb: Replication usability improvements")
Signed-off-by: Joe Stringer
---
Also affects branch-2.6.
---
ovsdb/jsonrpc-se
On 8 September 2016 at 21:23, Ben Pfaff wrote:
> On Tue, Sep 06, 2016 at 10:59:19AM -0700, Joe Stringer wrote:
>> In the new test I'm seeing OVSDB segfault:
>>
>> #0 0x004313ad in ovsdb_datum_compare_3way (a=0x10ebaa0, b=0x0,
>>type=0x10c29e8) at
On 9 September 2016 at 14:05, Ben Pfaff wrote:
> On Fri, Sep 09, 2016 at 01:47:01PM -0700, Joe Stringer wrote:
>> On 19 July 2016 at 20:08, Ben Pfaff wrote:
>> > On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Cascardo
>> > wrote:
>>
On 8 September 2016 at 08:49, Jesse Gross wrote:
> On Wed, Sep 7, 2016 at 5:18 PM, Joe Stringer wrote:
>> On 1 September 2016 at 18:08, Jesse Gross wrote:
>>> On Thu, Sep 1, 2016 at 5:01 PM, Joe Stringer wrote:
>>>> The upstream code uses NF_INET_PRE_ROUTIN
On 9 September 2016 at 14:09, Thadeu Lima de Souza Cascardo
wrote:
> Now, vagrant up will test both Fedora 23 and Debian Jessie (8.0), which uses
> Linux 3.16.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo
> ---
> Vagrantfile | 44 ++--
> 1 file changed
On 12 September 2016 at 03:57, Thadeu Lima de Souza Cascardo
wrote:
> On Fri, Sep 09, 2016 at 06:44:21PM -0700, Joe Stringer wrote:
>> On 9 September 2016 at 14:09, Thadeu Lima de Souza Cascardo
>> wrote:
>> > Now, vagrant up will test both Fedora 23 and Debian Jessie
ut this new implementation
> leaves me more confident due to its simplicity.
>
> Reported-by: Joe Stringer
> Reported-at: http://openvswitch.org/pipermail/dev/2016-September/079315.html
> Fixes: 60e0cd041958 ("ovsdb: Replication usability i
On 10 September 2016 at 21:24, Ben Pfaff wrote:
> On Fri, Sep 09, 2016 at 01:48:52PM -0700, Joe Stringer wrote:
>> By placing these nodes at the start of their respective structures,
>> several "possibly lost" warnings from valgrind are silenced.
>>
>> Fix
On 10 September 2016 at 21:26, Ben Pfaff wrote:
> On Fri, Sep 09, 2016 at 01:48:53PM -0700, Joe Stringer wrote:
>> Valgrind reports:
>>
>> ==18725== 32 bytes in 1 blocks are definitely lost in loss record 339 of 497
>> ==18725==at 0x4C29BBE: malloc (in
>> /us
On 12 September 2016 at 14:55, Jesse Gross wrote:
> On Mon, Sep 12, 2016 at 2:48 PM, Pravin B Shelar wrote:
>> This allows openvswitch and geneve module co-exist kernel on newer
>> kernels.
>>
>> Reported-by: Joe Stringer
>> Signed-off-by: Pravin B Shelar
&
On 13 September 2016 at 08:46, Thadeu Lima de Souza Cascardo
wrote:
> Now, vagrant up will test both Fedora 23 and Debian Jessie (8.0), which uses
> Linux 3.16.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo
Thanks. It was also missing uuid-runtime which stopped the install_deb
target from wor
On 14 September 2016 at 20:39, Ben Pfaff wrote:
> If the socket length does not include any of the bytes of the path, then
> the code should not read even the first byte of the path.
>
> Found by valgrind.
>
> CC: Thadeu Lima de Souza Cascardo
> Reported-by: Joe Stringer
ting bits of using sparse, but on the whole I
> think it saves us pretty often.
>
> CC: Jarno Rajahalme
> Fixes: 6dd3c787f591 ("ofproto: Support packet_outs in bundles.")
> Signed-off-by: Ben Pfaff
Acked-by: Joe Stringer
__
Signed-off-by: Joe Stringer
---
Pravin, does the GRE note look correct?
---
NEWS | 19 +++
1 file changed, 19 insertions(+)
diff --git a/NEWS b/NEWS
index 8c78b3676cf3..19570b96816f 100644
--- a/NEWS
+++ b/NEWS
@@ -124,6 +124,25 @@ v2.6.0 - xx xxx
- Add 'mtu_re
On 16 September 2016 at 07:41, David Hill wrote:
> Hello guys,
>
>Our preliminary tests seems to indicate this solves the issue with the
> ixgbe driver. My fear is now that other drivers might show the same
> behavior. Patching ovs to fallback to ethtool is a good way to avoid this
> imho.
0,
> is_backup=0xffefff2de) at ovsdb/ovsdb-server.c:198
> #12 0x000000406edb in main (argc=1, argv=0xffefff550)
> at ovsdb/ovsdb-server.c:429
>
> Reported-by: Joe Stringer
> Reported-at: http://openvswitch.org/pipermail/dev/2016-September/079315.
This patch shifts the code that directly calls xlate into a separate
function, xlate_ukey().
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 110 --
1 file changed, 73 insertions(+), 37 deletions(-)
diff --git a/ofproto/ofproto-dpif
Refactor the newly introduced xlate_ukey() function to just perform the
translation, not modify the ukey.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 32 +++-
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/ofproto/ofproto-dpif
de from the delete path is now shared with the dump path. The
code is longer overall, but hopefully it's a bit easier to follow.
Joe Stringer (6):
revalidator: Refactor ukey->xout translation.
revalidator: Don't modify ukey from xlate_ukey().
revalidator: Refactor revalidation
This code was already very similar to the actual revalidation code, but
previously it wasn't structured quite closely enough to share it. Do so.
xlate_actions_for_side_effects() is now unused, so remove it.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c
Shift the early-exit conditions for revalidation into a separate
function.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 136 --
1 file changed, 78 insertions(+), 58 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto
prepared and
attached to the ukey, but the actual execution will be skipped since it
will be executed on flow_delete very soon anyway with final stats.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 56 ---
1 file changed, 42 insertions
Simplify the remaining bits of the original revalidation codepath to
only handle the "full-revalidation" case. Make the 'ukey' parameter
purely const by pushing the only piece that gets changed into a separate
argument.
Signed-off-by: Joe Stringer
---
ofproto/ofprot
On 30 August 2016 at 18:47, Daniele Di Proietto wrote:
> Sometimes the ofproto layer creates a flow which is not liked by the
> revalidation for various reasons. This behavior, while not critical
> might impact the performance. This commit adds a facility to detect
> this issue early and log a w
Signed-off-by: Joe Stringer
---
.travis/osx-prepare.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.travis/osx-prepare.sh b/.travis/osx-prepare.sh
index cf46d872edfa..611c0709d760 100755
--- a/.travis/osx-prepare.sh
+++ b/.travis/osx-prepare.sh
@@ -1,3 +1,5 @@
#!/bin/bash
set -ev
On 21 September 2016 at 11:44, Lance Richardson wrote:
>> From: "Joe Stringer"
>> To: dev@openvswitch.org
>> Sent: Wednesday, September 21, 2016 2:36:42 PM
>> Subject: [ovs-dev] [PATCH] travis: Work around glibtoolize error.
>>
>> Signed-off-by: J
On 19 September 2016 at 11:18, Ben Pfaff wrote:
> On Thu, Sep 15, 2016 at 04:26:05PM -0700, Joe Stringer wrote:
>> Signed-off-by: Joe Stringer
>
> ...
>
>> + * When using the openvswitch module distributed with OVS against kernel
>> + versions 4.4-4.6, th
actice, many of these should otherwise be
handled by packaging scripts but if they exist then we should ensure the
correct SELinux context is set.
On systems where 'restorecon' is unavailable, this should be a no-op.
VMware-BZ: #1732672
Signed-off-by: Joe Stringer
---
Fortunately, th
actice, many of these should otherwise be
handled by packaging scripts but if they exist then we should ensure the
correct SELinux context is set.
On systems where 'restorecon' is unavailable, this should be a no-op.
VMware-BZ: #1732672
Signed-off-by: Joe Stringer
Acked-by: Ansis Att
On 22 September 2016 at 12:55, Ansis Atteka wrote:
> On Thu, Sep 22, 2016 at 3:54 AM, Joe Stringer wrote:
>> ovs-lib creates several directories directly from the script, but
>> doesn't make any attempt to ensure that the correct SELinux context is
>> applied to thes
On 14 September 2016 at 17:26, Eric Garver wrote:
> Signed-off-by: Eric Garver
Hi Eric,
I tried this series again on a variety of kernels and these initial
ping over cvlan tests are failing for check-system-userspace on older
kernels (3.10,3.13) due to reasons we had discussed a bit on the
prev
On 23 September 2016 at 05:51, Eric Garver wrote:
> On Thu, Sep 22, 2016 at 06:48:09PM -0700, Joe Stringer wrote:
>> On 14 September 2016 at 17:26, Eric Garver wrote:
>> > Signed-off-by: Eric Garver
>>
>> Hi Eric,
>>
>> I tried this series again on a va
On 23 September 2016 at 01:53, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
> NEWS | 1 +
> debian/changelog | 10 ++
> include/openflow/nicira-ext.h | 9 +
> include/openvswitch/ofp-msgs.h | 4
> lib/dpif.c
On 23 September 2016 at 06:25, Ansis Atteka wrote:
>
>
> On 23 September 2016 at 03:25, Joe Stringer wrote:
>>
>> ovs-lib creates several directories directly from the script, but
>> doesn't make any attempt to ensure that the correct SELinux context is
>&
On 23 September 2016 at 12:13, Justin Pettit wrote:
>
>> On Sep 23, 2016, at 10:10 AM, Joe Stringer wrote:
>>
>> On 23 September 2016 at 01:53, Justin Pettit wrote:
>>>
>>> diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
>
On 26 September 2016 at 13:24, Pravin B Shelar wrote:
> Fixes test failure seen due to the IPsec tunnel deprecation
> messages in test logs.
>
> Fixes: 9e9d0384910e ("openvswitch: deprecates support for IPsec tunnel
> port.").
> Reported-by: Joe Stringer
> Signed-
On 26 September 2016 at 07:13, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
> ---
> INSTALL.md | 22 +-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/INSTALL.md b/INSTALL.md
> index bb40e4a..a9b70db 100644
> --- a/INSTALL.md
> +++ b/INSTALL
On 26 September 2016 at 18:46, Jarno Rajahalme wrote:
> Setting up a datapath flow that has a conntrack action with 'alg=ftp',
> but does not match on 'nw_proto=tcp' fails with 'WARN' in
> ovs-vswitchd.log. It is better to flag such inconsistencies during
> OpenFlow rule set-up time. Also, connt
Hi David,
Thanks for the submission. Since this is a bugfix for a long-running
behaviour, I reduced the patch to just the functional changes and
applied it to master, branch-2.6 and branch-2.5.
Here's the final change, please let me know if it is still missing something:
https://github.com/openvs
On 21 September 2016 at 14:01, Joe Stringer wrote:
> On 21 September 2016 at 11:44, Lance Richardson wrote:
>>> From: "Joe Stringer"
>>> To: dev@openvswitch.org
>>> Sent: Wednesday, September 21, 2016 2:36:42 PM
>>> Subject: [ovs-d
On 27 September 2016 at 14:32, Jarno Rajahalme wrote:
> Replace a tab by a space and remove an unnecessary variable.
>
> Signed-off-by: Jarno Rajahalme
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.or
On 27 September 2016 at 14:32, Jarno Rajahalme wrote:
> Datapath flow setup fails when setting the FTP helper on an
> unsupported IP protocol. It is better to fail at the OpenFlow rule
> set-up time instead.
>
> Signed-off-by: Jarno Rajahalme
Acked-b
ahalme
LGTM, minor spelling below. Thanks.
Acked-by: Joe Stringer
> ---
> lib/ofp-actions.c | 7 +--
> tests/ofproto-dpif.at | 40
> tests/ovs-ofctl.at| 46 +++---
> 3 files chan
On 8 June 2016 at 13:49, Daniele Di Proietto wrote:
>
>
>
>
>
> On 08/06/2016 13:30, "Ben Pfaff" wrote:
>
>>On Wed, Jun 08, 2016 at 01:07:32PM -0700, Ben Pfaff wrote:
>>> On Wed, Jun 01, 2016 at 07:23:29PM -0700, Daniele Di Proietto wrote:
>>> > linux/in.h (from linux uapi headers) carries many o
On 27 September 2016 at 14:40, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
Thanks, applied to master. It doesn't apply cleanly to branch-2.6, so
I don't plan to backport it unless you feel strongly about that.
___
dev mailing list
dev@openvswitc
On 28 September 2016 at 14:22, Daniele Di Proietto wrote:
> Is there any reason not to squash this with the previous patch?
It was an attempt at separating functional changes from cosmetic.
> If you want to keep two commits for clarity I would split it like:
>
> commit1) move the block above odp
On 28 September 2016 at 14:22, Daniele Di Proietto wrote:
>
>
> 2016-09-20 18:47 GMT-07:00 Joe Stringer :
>>
>> To make more of the core revalidate() functions do just one thing and
>> not modify state on the way, refactor them to prepare the xcache then
>> defe
On 28 September 2016 at 14:22, Daniele Di Proietto wrote:
> Thanks for doing this cleanup, my instant revalidation series should be much
> simpler after this.
>
> It looks like this needs rebasing, but it is pretty trivial
>
> I've gone through the code, I only have a couple minor of comments abou
On 28 September 2016 at 16:21, Joe Stringer wrote:
> On 28 September 2016 at 14:22, Daniele Di Proietto
> wrote:
>> Thanks for doing this cleanup, my instant revalidation series should be much
>> simpler after this.
>>
>> It looks like this needs rebasing, but i
On 2 October 2016 at 04:01, Stephen Finucane wrote:
> This is essentially the output of 'sphinx-quickstart' but with parts of
> the Makefile merged into the existing Makefile.am and a license added
> to the index.rst file.
>
> Signed-off-by: Stephen Finucane
> ---
> I need to know who to assign c
On 27 September 2016 at 21:45, Paul Blakey wrote:
> Openvswitch currently configures the kerenel datapath via netlink over an
> internal ovs protocol.
>
> This patch series offers a new provider: dpif-netlink-tc that uses the tc
> flower protocol
> to offload ovs rules into HW data-path through
a lookup table")
Signed-off-by: Joe Stringer
---
lib/json.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/json.c b/lib/json.c
index e052a6a0af0d..40c8f718db72 100644
--- a/lib/json.c
+++ b/lib/json.c
@@ -1624,7 +1624,7 @@ json_serialize_array(const struct json_a
On 6 October 2016 at 11:51, Ben Pfaff wrote:
> On Thu, Oct 06, 2016 at 11:33:39AM +0900, Joe Stringer wrote:
>> This warning breaks the build on travis:
>> lib/json.c:1627:12: error: symbol 'chars_escaping' was not declared.
>> Should it be static?
>>
On 23 September 2016 at 12:16, Eric Garver wrote:
> This series adds 802.1ad test cases for the check-* make targets. It is
> meant as a counterpart to the 802.1ad work currently going on and being
> discussed on the dev list.
>
> User space support for 802.1ad is being worked on by Xiao Liang (ba
On 23 September 2016 at 12:16, Eric Garver wrote:
> Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN().
>
> Signed-off-by: Eric Garver
> # ADD_OVS_TUNNEL([type], [bridge], [port], [remote-addr], [overlay-addr])
> #
> # Add an ovs-based tunnel device in the root namespace, with name
On 18 October 2016 at 05:31, Eric Garver wrote:
> On Mon, Oct 17, 2016 at 05:17:44PM -0700, Joe Stringer wrote:
>> On 23 September 2016 at 12:16, Eric Garver wrote:
>> > This series adds 802.1ad test cases for the check-* make targets. It is
>> > meant as a coun
On 14 October 2016 at 07:37, Bhanuprakash Bodireddy
wrote:
> Aligning the 'keys' array seems to have positive performance impact.
>
> Signed-off-by: Bhanuprakash Bodireddy
> Co-authored-by: Antonio Fischetti
> Signed-off-by: Antonio Fischetti
> Acked-by: Daniele Di Proietto
It looks like the
On 19 October 2016 at 11:27, Pravin B Shelar wrote:
> On upstream kernel datapath OVS make use of networking devices
> where networking stack does check if device is UP. following
> patch adds same check in case of compat tunneling implementation.
> This check also fixes kernel crash in case vxlan
until output and
proceeds past this check before the reconfiguration thread clears it.
Probably the type of test to check this would be running heavy traffic
through a vxlan port, then toggle the port up and down.
Will you also check upstream?
Anyway, this LGTM so:
Acked-by: Joe Stringer
On 21 October 2016 at 11:37, Joe Stringer wrote:
> On 21 October 2016 at 10:55, Pravin B Shelar wrote:
>> On upstream kernel datapath OVS make use of networking devices
>> where networking stack does check if device is UP. following
>> patch adds same check in cas
On 29 October 2016 at 21:33, Pravin B Shelar wrote:
> Upstream commit:
> commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca
> Author: pravin shelar
> Date: Fri Oct 28 09:59:15 2016 -0700
>
> vxlan: avoid using stale vxlan socket.
>
> When vxlan device is closed vxlan socket is
B Shelar
> Acked-by: John W. Linville
> Signed-off-by: David S. Miller
>
> Signed-off-by: Pravin B Shelar
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
this situation.
>
> Signed-off-by: Pravin B Shelar
Thanks, one style comment below. Otherwise:
Acked-by: Joe Stringer
> @@ -442,11 +449,13 @@ static int lisp_open(struct net_device *dev)
> struct lisp_dev *lisp = netdev_priv(dev);
> struct udp_tunnel_sock_cfg tunnel_
t it's more clear than just OpenFlow hexdumps
telling you "OFPBAC". Maybe it should either say this, or this should
be mentioned in the FAQ.
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 31 October 2016 at 14:33, Ben Pfaff wrote:
> On Mon, Oct 31, 2016 at 02:16:05PM -0700, Joe Stringer wrote:
>> On 31 October 2016 at 13:23, Ben Pfaff wrote:
>> > Some datapaths do not support the ct action, and others support only a
>> > subset of its featur
s closed vxlan socket is freed. This
> operation can race with vxlan-xmit function which
> dereferences vxlan socket. Following patch uses RCU
> mechanism to avoid this situation.
>
> Signed-off-by: Pravin B Shelar
> Signed-off-by: David S. Miller
>
>
On 31 October 2016 at 22:00, Pravin B Shelar wrote:
> The compat vlan code ignores vlan tag for inner packet
> on egress path. Following patch fixes this by inserting the
> tag for inner packet before tunnel encapsulation.
>
> Signed-off-by: Pravin B Shelar
Is this a problem upstream and for oth
On 1 November 2016 at 10:48, Pravin Shelar wrote:
> On Tue, Nov 1, 2016 at 10:30 AM, Joe Stringer wrote:
>> On 31 October 2016 at 22:00, Pravin B Shelar wrote:
>>> The compat vlan code ignores vlan tag for inner packet
>>> on egress path. Following patch fixes this b
On 1 November 2016 at 11:35, Pravin B Shelar wrote:
> The compat vlan code ignores vlan tag for inner packet
> on egress path. Following patch fixes this by inserting the
> tag for inner packet before tunnel encapsulation.
>
> Signed-off-by: Pravin B Shelar
Acked-b
On 30 October 2016 at 06:29, Stephen Finucane wrote:
> This is the third conversion series. This one is larger yet again,
> though many of the docs are rather small. After this series, only the
> two tutorial docs in 'tutorial' require conversion (along with any
> unsuffixed files I may have misse
On 3 November 2016 at 03:33, Stephen Finucane wrote:
> On 2016-11-02 17:57, Joe Stringer wrote:
>>
>> On 30 October 2016 at 06:29, Stephen Finucane wrote:
>>>
>>> This is the third conversion series. This one is larger yet again,
>>> though many of th
Both the ofproto layer and the odp-util layer have recently added
notions about fields supported by the datapath. This commit merges the
two into the same structure.
Signed-off-by: Joe Stringer
---
lib/dpif-netdev.c | 14 +++---
lib/odp-util.c| 4 ++--
lib
Both the ofproto layer and the odp-util layer have recently added
notions about fields supported by the datapath. This commit merges the
two into the same structure.
Signed-off-by: Joe Stringer
---
v2: Rebase against master.
---
lib/dpif-netdev.c | 14 +++---
lib/odp-util.c
On 30 June 2015 at 17:42, Andy Zhou wrote:
> On Tue, Jun 30, 2015 at 4:52 PM, Joe Stringer wrote:
>> Both the ofproto layer and the odp-util layer have recently added
>> notions about fields supported by the datapath. This commit merges the
>> two into the same structure
Datapath support for some flow key fields is used inside ofproto-dpif as
well as odp-util. Share these fields using the same structure.
Signed-off-by: Joe Stringer
---
v3: Reduce shared fields, as suggested by Andy.
v2: Rebase against master.
---
lib/dpif-netdev.c | 10
On 1 July 2015 at 15:52, Andy Zhou wrote:
> LGTM. Thanks joe!
>
> Acked-by: Andy Zhou
Thanks Andy, applied to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 6 July 2015 at 22:20, Ben Pfaff wrote:
> When process_upcall() passes a miss upcall to upcall_xlate(), the new
> ukey's dump_seq member is initialized from the current dump_seq. Later,
> when udpif_revalidator() calls revalidate(), any dumped flow for which
> ukey->dump_seq equals the current
On 7 July 2015 at 21:42, Ben Pfaff wrote:
> On Tue, Jul 07, 2015 at 08:13:58PM -0700, Joe Stringer wrote:
>> On 6 July 2015 at 22:20, Ben Pfaff wrote:
>> > When process_upcall() passes a miss upcall to upcall_xlate(), the new
>> > ukey's dump_seq member is initi
On 8 July 2015 at 17:10, Ben Pfaff wrote:
> On Wed, Jul 08, 2015 at 01:12:26PM -0700, Joe Stringer wrote:
>> On 7 July 2015 at 21:42, Ben Pfaff wrote:
>> > On Tue, Jul 07, 2015 at 08:13:58PM -0700, Joe Stringer wrote:
>> >> On 6 July 2015 at 22:20, Ben Pfaff wrot
Hi Thomas,
On 10 July 2015 at 07:19, Thomas Graf wrote:
> diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
> index ecfa530..05fe46b 100644
> --- a/net/openvswitch/flow_netlink.c
> +++ b/net/openvswitch/flow_netlink.c
> @@ -1548,11 +1548,45 @@ static struct sw_flow_acti
On 15 July 2015 at 15:53, Jesse Gross wrote:
> On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote:
>> On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote:
>>> There are several implementations of functions that parse/format
>>> flags and their binary representation. This factors them out i
checks the pointer rather than the value.
In practice, this seems to only come up for fields which are used
internally in OVS and not exposed for matching from the controller, like
tunnel flags or skb_priority.
Found by MIT STACK analyzer.
Signed-off-by: Joe Stringer
---
lib/ofp-parse.c| 2 +-
OVS will exit if the allocations in this function fail, so this check is
pointless.
Found by MIT STACK analyzer.
Signed-off-by: Joe Stringer
---
vtep/vtep-ctl.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/vtep/vtep-ctl.c b/vtep/vtep-ctl.c
index f065fc9..8dfd3ad
false.
Furthermore, this behaviour may be optimised out by modern compilers
due to the prior dereference in expr_parse(). Fix this to check the
actual value of *errorp.
Found by MIT STACK analyzer.
Signed-off-by: Joe Stringer
---
ovn/lib/expr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
In several places, "br" is dereferenced just before a check such as
"if (br ...)". These checks may be optimised out, and they provide no
additional safety, so this patch removes them.
Found by MIT STACK analyzer.
Signed-off-by: Joe Stringer
---
utilities/ovs-vsctl.c |
out files, re-compiled and re-analysed the
codebase to verify that the fix has removed the problem.
[1]: https://github.com/xiw/stack
Joe Stringer (4):
ofp-parse: Fix typo in consistency check.
vtep-ctl: Remove extraneous NULL pointer check.
ovs-vsctl: Remove redundant checks.
ovn: Fix extr
On 15 July 2015 at 17:41, Jesse Gross wrote:
> On Wed, Jul 15, 2015 at 5:31 PM, Joe Stringer wrote:
>> On 15 July 2015 at 15:53, Jesse Gross wrote:
>>> On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote:
>>>> On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross
On 16 July 2015 at 13:52, Ben Pfaff wrote:
> On Wed, Jul 15, 2015 at 10:18:29PM -0700, Joe Stringer wrote:
>> This code attempts to first check whether another error was detected for
>> the string it is parsing, then if it's not at the end of the tokens,
>> report an e
Signed-off-by: Joe Stringer
---
acinclude.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 14907ab..4f1e66c 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -271,7 +271,7 @@ dnl translated to uppercase.
AC_DEFUN([OVS_FIND_FIELD_IFELSE
On 17 July 2015 at 12:58, Ben Pfaff wrote:
> On Fri, Jul 17, 2015 at 11:23:31AM -0700, Joe Stringer wrote:
>> Signed-off-by: Joe Stringer
>> ---
>> acinclude.m4 | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/acinclude.m4 b
On 20 July 2015 at 10:51, Ben Pfaff wrote:
> On Mon, Jul 20, 2015 at 10:12:31AM -0700, Joe Stringer wrote:
>> On 17 July 2015 at 12:58, Ben Pfaff wrote:
>> > On Fri, Jul 17, 2015 at 11:23:31AM -0700, Joe Stringer wrote:
>> >> Signed-off-by: Joe Stringer
>
On 23 July 2015 at 16:19, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 23 July 2015 at 16:19, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Joe Stringer
---
datapath/actions.c | 6 +-
datapath/datapath.c | 2 ++
datapath/flow.h | 1 -
datapath/flow_netlink.c | 7 ---
datapath/vport.c| 3 +--
datapath/vport.h| 1 -
6 files changed, 8 insertions(+), 12 deletions(-)
diff --git a
501 - 600 of 2028 matches
Mail list logo
