Provide better documentation of the requirements for kernel module
testing, and more thorough examples on how to invoke and use it.
Give the Vagrantfile a bit of love, allowing for more tests to run,
more reliably, on a wider range of hypervisors.
Joe Stringer (6):
INSTALL.md: Document system
Signed-off-by: Joe Stringer
---
Vagrantfile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Vagrantfile b/Vagrantfile
index dab03de56fac..a3d444d366ba 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -65,5 +65,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config
ora project box
if trying to use the libvirt provider.
Signed-off-by: Joe Stringer
---
Vagrantfile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Vagrantfile b/Vagrantfile
index 4f2e0fdb7c48..dab03de56fac 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -56,6 +56,9 @@ SCRIPT
Va
This brings a newer kernel (4.2) and newer iproute2, allowing more of
the tests to run by default.
Signed-off-by: Joe Stringer
---
INSTALL.md | 2 +-
Vagrantfile | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/INSTALL.md b/INSTALL.md
index 82f5188eacb8..25e042544b49
-off-by: Joe Stringer
---
Vagrantfile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Vagrantfile b/Vagrantfile
index a3d444d366ba..d7cf73738e75 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -20,7 +20,7 @@ SCRIPT
$configure_ovs = <
Signed-off-by: Joe Stringer
---
Vagrantfile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Vagrantfile b/Vagrantfile
index 102a17dee310..38553cd2d8ad 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -10,6 +10,7 @@ dnf -y update
dnf -y install autoconf automake openssl-devel libtool
Translate commandline calls to UTF-8, appease flake8 and use six's
integer types. This allows the testsuite to pass when using python3 as
your default system python version.
Signed-off-by: Joe Stringer
---
CC: Darrell Ball
---
vtep/ovs-vtep | 25 -
1 file change
er scripts just enough to allow the
interface-reconfigure tests to run and pass on both python2.7 and python3,
without attempting to fully satisfy PEP-8 or flake8. This should assist
developers beginning to use python3 as the default python interpreter on
their development systems.
Joe Stringer (6):
Signed-off-by: Joe Stringer
---
.../opt_xensource_libexec_InterfaceReconfigure.py | 41 +++---
.../opt_xensource_libexec_interface-reconfigure| 16 -
2 files changed, 28 insertions(+), 29 deletions(-)
diff --git a/xenserver
In python3, dictionaries are less likely to be sorted consistently from
one run to the next, so sort port options when outputting to provide
reliable test results.
Signed-off-by: Joe Stringer
---
tests/interface-reconfigure.at | 4 ++--
xenserver
PEP 3120 made UTF-8 the default source encoding for python3 strings;
ensure that the output for strings are consistent between python2.7 and
python3.
Signed-off-by: Joe Stringer
---
tests/interface-reconfigure.at | 16
xenserver
PEP 3105 removed the print statement in favour of a print function.
Replace usage of the old statement with equivalent functionality that
works in both python2.7 and python3.
Signed-off-by: Joe Stringer
---
xenserver/opt_xensource_libexec_InterfaceReconfigure.py | 3 ++-
xenserver
This syntax is usable with both python2.7 and python3, so use it instead
of the outdated syntax.
Signed-off-by: Joe Stringer
---
xenserver/opt_xensource_libexec_InterfaceReconfigure.py | 4 ++--
.../opt_xensource_libexec_InterfaceReconfigureVswitch.py | 2 +-
xenserver
PEP 3113 removed the use of tuple parameter unpacking in conjunction
with lambdas, replace this code with something that works in python2.7
and python3.
Signed-off-by: Joe Stringer
---
xenserver/opt_xensource_libexec_InterfaceReconfigure.py | 16
On 19 May 2016 at 08:52, Ben Pfaff wrote:
> On Mon, May 16, 2016 at 08:08:01PM -0700, Joe Stringer wrote:
>> During udpif_create(), we register callbacks for handling upcalls and
>> purging the datapath; however, in the corresponding udpif_destroy() we
>> never did this. T
On 23 May 2016 at 16:25, Andy Zhou wrote:
>
>
> On Fri, May 20, 2016 at 11:49 AM, Joe Stringer wrote:
>>
>> Signed-off-by: Joe Stringer
>> ---
>> Vagrantfile | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Vagrantfile b/Vag
On 24 May 2016 at 07:19, Fischetti, Antonio wrote:
> Hi Daniele, just a comment below.
> Apart from that, it looks good to me, thanks.
>
> Acked-by: Antonio Fischetti
>
>> -Original Message-
>> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele
>> Di Proietto
>> Sent: Tue
On 17 May 2016 at 11:04, Sairam Venugopal wrote:
> Acked-by: Sairam Venugopal
>
>
> On 5/17/16, 10:15 AM, "Nithin Raju" wrote:
>
>>We'll need this for parsing nested attributes.
>>
>>Signed-off-by: Nithin Raju
Thanks, applied.
___
dev mailing list
de
On 17 May 2016 at 11:05, Sairam Venugopal wrote:
> Acked-by: Sairam Venugopal
>
>
> On 5/17/16, 10:15 AM, "Nithin Raju" wrote:
>
>>Move this function out from file scope.
>>
>>Signed-off-by: Nithin Raju
Thanks, applied.
___
dev mailing list
dev@openv
On 25 May 2016 at 10:31, Alin Serdean wrote:
> Acked-by: Alin Gabriel Serdean
I just pushed the series, sorry I missed your Ack.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 17 May 2016 at 11:05, Sairam Venugopal wrote:
> Acked-by: Sairam Venugopal
>
>
> On 5/17/16, 10:15 AM, "Nithin Raju" wrote:
>
>>While testing DFW and recirc code it was found that userspace
>>was calling into packet execute with the tunnel key and the
>>vport added as part of the execute stru
On 19 May 2016 at 23:48, Paul Boca wrote:
> Acked-by: Paul-Daniel Boca
>
>> -Original Message-
>> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
>> Sent: Friday, May 20, 2016 1:32 AM
>> To: dev@openvswitch.org
>> Subject: [ovs-dev] [PATCH 1/2] datapath-windows: do
On 19 May 2016 at 23:56, Paul Boca wrote:
> Acked-by: Paul-Daniel Boca
>
>> -Original Message-
>> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
>> Sent: Friday, May 20, 2016 1:32 AM
>> To: dev@openvswitch.org
>> Subject: [ovs-dev] [PATCH 2/2] datapath-windows: o/
Thanks all, applied.
On 22 May 2016 at 23:02, Paul Boca wrote:
> Looks good to me.
>
> Acked-by: Paul-Daniel Boca
>
>> -Original Message-
>> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam
>> Venugopal
>> Sent: Tuesday, May 17, 2016 9:06 PM
>> To: Nithin Raju; dev@open
Thanks for the review,
On 23 May 2016 at 12:49, Andy Zhou wrote:
>> @@ -101,6 +101,14 @@ To run the unit tests, you also need:
>>- Perl. Version 5.10.1 is known to work. Earlier versions should
>> also work.
>>
>> +The "system" tests for userspace and Linux datapaths also rely upon:
>
On 23 May 2016 at 13:07, Andy Zhou wrote:
>
>
> On Fri, May 20, 2016 at 11:49 AM, Joe Stringer wrote:
>>
>> Signed-off-by: Joe Stringer
>
> Acked-by: Andy Zhou
Thanks, applied.
___
dev mailing list
dev@openvswitch.org
htt
On 23 May 2016 at 16:31, Andy Zhou wrote:
>
>
> On Fri, May 20, 2016 at 11:49 AM, Joe Stringer wrote:
>>
>> This brings a newer kernel (4.2) and newer iproute2, allowing more of
>> the tests to run by default.
>>
>> Signed-off-by: Joe Stringer
>
On 25 May 2016 at 09:25, Ryan Moats wrote:
> "dev" wrote on 05/23/2016 03:04:15 PM:
>
>> From: Andy Zhou
>> To: Joe Stringer
>> Cc: ""
>> Date: 05/23/2016 03:05 PM
>> Subject: Re: [ovs-dev] [PATCH 6/6] vagrant: Enable silent-rules f
This test has been failing since IGMP megaflow matching was fixed.
Update the test to fix the build.
Fixes: aeb14ab7f6cd ("ofproto-dpif-xlate: Fix IGMP megaflow matching.")
Signed-off-by: Joe Stringer
---
tests/classifier.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
On 26 May 2016 at 10:36, Ben Pfaff wrote:
> On Thu, May 26, 2016 at 10:27:09AM -0700, Joe Stringer wrote:
>> This test has been failing since IGMP megaflow matching was fixed.
>> Update the test to fix the build.
>>
>> Fixes: aeb14ab7f6cd ("ofproto-dpif-x
On 27 May 2016 at 00:34, Darrell Ball wrote:
>
>
> On Mon, May 23, 2016 at 6:11 PM, Joe Stringer wrote:
>>
>> Translate commandline calls to UTF-8, appease flake8 and use six's
>> integer types. This allows the testsuite to pass when using python3 as
>&
On 31 May 2016 at 15:54, Lance Richardson wrote:
> With a recent kernel (4.6-ish) and current OVS master, I'm seeing failures
> in several system-traffic.at test cases under "make check-kernel".
>
> For the "conntrack - FTP" test failure, all seems to be well up to the
> last test case, which is a
On 23 May 2016 at 17:57, Thadeu Lima de Souza Cascardo
wrote:
> Currently, cleanup files for system tests will look like this:
>
> modprobe -q -r vport_vxlan
> modprobe -q -r vport_sttmodprobe
> modprobe -q -r vport_lispmodprobe
> modprobe -q -r vport_gremodprobe
> modprobe -q -r vport_genevemodpr
On 1 June 2016 at 04:46, Paul Boca wrote:
> The problem is that on some cases it gets called with the socket
> name instead of the service name.
>
> Signed-off-by: Paul-Daniel Boca
Looking at commit 0c473314294930a47a18d380e0bbcdf7b02a16f2 which
introduced this macro, it seems like simply skippi
On 1 June 2016 at 04:45, Paul Boca wrote:
> On Windows trying to overwrite the opened ovs-vswitchd.log
> fails with access denied. Closing it before trying to overwrite it
> solves the problem
>
> Signed-off-by: Paul-Daniel Boca
Ideally we don't introduce platform differences into the tests; the
On 2 June 2016 at 01:28, Paul Boca wrote:
> Hi!
>
> Thanks for review!
> Please see my comments inline.
Thanks for looking into the windows testsuite failures :-)
More below.
>> -Original Message-
>> From: Joe Stringer [mailto:j...@ovn.org]
>> Sent: Thursd
On 2 June 2016 at 15:01, Ben Pfaff wrote:
>> +Datapath traffic testing
>> +
>> +
>> +Open vSwitch also includes a suite of tests specifically for datapath
>> +functionality, which can be run against the userspace or kernel datapaths.
>> +If you are developing datapath featu
On 23 May 2016 at 18:33, Joe Stringer wrote:
> On 23 May 2016 at 16:25, Andy Zhou wrote:
>>
>>
>> On Fri, May 20, 2016 at 11:49 AM, Joe Stringer wrote:
>>>
>>> Signed-off-by: Joe Stringer
>>> ---
>>> Vagrantfile | 2 ++
>>>
On 23 May 2016 at 16:30, Andy Zhou wrote:
>
>
> On Fri, May 20, 2016 at 11:49 AM, Joe Stringer wrote:
>>
>> The default vagrant box for fedora23 uses the images provided by Chef's
>> "bento" project, which has support for 3 backend providers: parallels,
h conntrack features.
These bugs likely affect the branch-2.5 kernel module, although the kernel
testsuite at that release did not include tests which would trigger the bugs so
the issues are less obvious there. Once this has settled down I would like to
consider patches 1-3 for backport.
Joe St
3bd8c1bbc4478fe2 ]---
Kernel panic - not syncing: Fatal exception in interrupt
Fixes: 73b09aff14c7 ("compat: Backport IPv6 reassembly.")
Reported-by: Jarno Rajahalme
Signed-off-by: Joe Stringer
---
datapath/linux/compat/nf_conntrack_reasm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
This was previously backported to fix issues with our inet_fragment
backport; with that largely gone, we can get rid of this too.
Signed-off-by: Joe Stringer
---
This is effectively a revert of commit bf1f0d35ceb9 ("datapath: Fix IPv6
fragment expiry crash."). It should be paire
Remove a couple of functions that are available on all supported kernel
versions.
Signed-off-by: Joe Stringer
---
datapath/linux/compat/nf_conntrack_reasm.c | 39 +++---
1 file changed, 3 insertions(+), 36 deletions(-)
diff --git a/datapath/linux/compat
c5/0x290
[] start_secondary+0x21d/0x2d0
Code: Bad RIP value.
RIP [] 0xa0177480
RSP
CR2: a0177480
---[ end trace eb98ca80ba07bd9c ]---
Kernel panic - not syncing: Fatal exception in interrupt
Signed-off-by: Joe Stringer
---
I've tested this on CentOS kernel 3.10.0-327 and Ubuntu kern
This function is just a dummy to ensure that the corresponding netfilter
fragment module is loaded, to initialize the shared structures. But it
doesn't need to be invoked once per namespace; one call per protocol
should do the trick.
Signed-off-by: Joe Stringer
---
datapath/linux/c
Kernel 3.7 and lower are now unsupported, remove this fragment.
Signed-off-by: Joe Stringer
---
datapath/linux/compat/include/net/inet_frag.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/datapath/linux/compat/include/net/inet_frag.h
b/datapath/linux/compat/include/net
On 11 July 2016 at 23:35, Gurucharan Shetty wrote:
> It is useful to set the mac address and gateway while using ADD_VETH
> to connect a namespace to a OVN logical topology. Upcoming commits
> use this enhancement.
>
> Signed-off-by: Gurucharan Shetty
Acked-b
.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 11 July 2016 at 23:35, Gurucharan Shetty wrote:
> This unit test adds a basic OVN NAT test that tests north-south
> DNAT, south-north SNAT and east-west DNAT and SNAT. It uses network
> namespaces connected to br-int using veth pairs to act as logical
> ports. This test does not cover multi-hos
On 11 July 2016 at 23:35, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
> ---
Looks good, thanks. Only comment is if you add this file to
check-system-userspace then it should also get a CHECK_CONNTRACK() at
the start.
Acked-by: Joe St
On 11 July 2016 at 23:35, Gurucharan Shetty wrote:
> This unit test adds a basic OVN NAT test that tests north-south
> DNAT, south-north SNAT and east-west DNAT and SNAT. It uses network
> namespaces connected to br-int using veth pairs to act as logical
> ports. This test does not cover multi-hos
On 1 July 2016 at 09:45, William Tu wrote:
> We generally try to keep the testsuite independent of the underlying
> datapath. This patch removes the datapath-specific tests and macros.
>
> Tested-at: https://travis-ci.org/williamtu/ovs-travis/builds/141642065
> Signed-off-by: William Tu
Thanks f
This doesn't seem to have been necessary since ovsdbmonitor was removed
in commit 7868fbc6c97c ("ovsdbmonitor: Remove."). Drop the dependency.
Signed-off-by: Joe Stringer
---
INSTALL.Fedora.md | 2 +-
Vagrantfile | 2 +-
debian/control
is check is kind of redundant. Please remove this line.
> Thank you~
>
> William
>
>
> On Wed, Jul 13, 2016 at 4:57 PM, Joe Stringer wrote:
>> On 1 July 2016 at 09:45, William Tu wrote:
>>> We generally try to keep the testsuite independent of the underlying
>>&
pe=AVC msg=audit(1468519445.890:16833): avc: denied { execute } for
pid=13849 comm="ovs-ctl" name="tmp.jdEGHntG3Z" dev="dm-1" ino=106876762
scontext=unconfined_u:system_r:openvswitch_t:s0
tcontext=unconfined_u:object_r:openvswitch_tmp_t:s0 tclass=file
Signed-off-by:
On 15 July 2016 at 08:29, Ben Pfaff wrote:
> On Thu, Jul 14, 2016 at 05:53:46PM -0700, Joe Stringer wrote:
>> This doesn't seem to have been necessary since ovsdbmonitor was removed
>> in commit 7868fbc6c97c ("ovsdbmonitor: Remove."). Drop the dependency.
>>
&
On 13 July 2016 at 00:04, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
Looks good, thanks.
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
be it's just from reviewing it the first time ;) ), thanks.
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 17 July 2016 at 19:24, Pravin B Shelar wrote:
> This series contains patches to advance kernel datapath
> support for kernel upto 4.6.
When I try to load the kernel module on Ubuntu's kernel-4.4, I get
complaints about GRE:
[ 784.836361] openvswitch: Open vSwitch switching datapath 2.5.90
[
On 18 July 2016 at 14:42, pravin shelar wrote:
> On Mon, Jul 18, 2016 at 2:32 PM, Joe Stringer wrote:
>> On 17 July 2016 at 19:24, Pravin B Shelar wrote:
>>> This series contains patches to advance kernel datapath
>>> support for kernel upto 4.6.
>>
>>
On 15 July 2016 at 00:32, wrote:
> From: Deepanshu Saxena
>
> This commit implements ovs meters in kernel space using the traffic
> control (tc) module of Linux kernel. TC is used to configure Traffic
> Control features like Policing, Shaping etc. Ovs meters are analogous to
> traffic control
On 24 June 2016 at 19:06, Ben Pfaff wrote:
> On Wed, Jun 22, 2016 at 11:30:16AM -0700, Guru Shetty wrote:
>> On 17 June 2016 at 12:42, Joe Stringer wrote:
>>
>> > Commit 0dcc739e7a28 ("debian: Move ovs-lib to openvswitch-common.")
>> > shifted a file
A few of the earlier tests were written with all flows in a single flat
table. While this is a possible way to write your flows to use
connection tracking, it's easier to understand if the processing
proceeds forward from one table to the next. Update these tests.
Signed-off-by: Joe Str
still
have related connections work correctly. Also, the ALG should only be
specified when committing the connection. Update the rules.
Signed-off-by: Joe Stringer
---
tests/system-kmod-macros.at | 1 +
tests/system-traffic.at | 8
2 files changed, 5 insertions(+), 4 deletions(-)
diff --g
Signed-off-by: Joe Stringer
---
tests/system-traffic.at | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index bd2cea11bff0..14a75b68fe7e 100644
--- a/tests/system-traffic.at
+++ b/tests
Thanks, I applied this series to master.
On 21 July 2016 at 04:19, Jarno Rajahalme wrote:
> For the series:
>
> Acked-by: Jarno Rajahalme
>
>> On Jul 19, 2016, at 12:54 PM, Joe Stringer wrote:
>>
>> Prior to commit b87a5aacefe2 ("datapath: Fix cached ct wi
On 19 July 2016 at 11:15, Joe Stringer wrote:
> On 24 June 2016 at 19:06, Ben Pfaff wrote:
>> On Wed, Jun 22, 2016 at 11:30:16AM -0700, Guru Shetty wrote:
>>> On 17 June 2016 at 12:42, Joe Stringer wrote:
>>>
>>> > Commit 0dcc739e7a28 (&quo
ovs-vswitchd. Get git of the sleeps and explicitly wait for
>> the transaction on ovsdb1 to become visible on ovsdb2.
>>
>> Also fix the name of the test.
>>
>> Signed-off-by: Jarno Rajahalme
Based on 5 travis run I launched with this commit, it seems like it
addresses t
ctl invocation, however
this doesn't prevent the final OVS_VSWITCHD_STOP from detecting this
log and complaining.
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
pe=AVC msg=audit(1468519445.890:16833): avc: denied { execute } for
pid=13849 comm="ovs-ctl" name="tmp.jdEGHntG3Z" dev="dm-1" ino=106876762
scontext=unconfined_u:system_r:openvswitch_t:s0
tcontext=unconfined_u:object_r:openvswitch_tmp_t:s0 tclass=file
Signed-off-by:
having to build all of the fedora
packages.
Signed-off-by: Joe Stringer
---
As per the reasoning in the link below, I've just duplicated the
subpackage lines from the fedora specfile rather than refactoring these
lines into a separate specfile.
http://openvswitch.org/pipermail/dev/2016-Janu
python-openvswitch uses the python "six" library, add a dependency for
this to the debian package.
VMware-BZ: #1700259
Reported-by: Devang Doshi
Signed-off-by: Joe Stringer
---
debian/control | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/control b/debi
On 25 July 2016 at 16:57, Flavio Leitner wrote:
> On Fri, Jul 22, 2016 at 02:10:51PM -0700, Joe Stringer wrote:
>> When invoking ovs-ctl force-reload-kmod via '/etc/init.d/openvswitch
>> force-reload-kmod', spurious errors would output related to 'hostname'
&g
On 25 July 2016 at 17:34, Flavio Leitner wrote:
> On Mon, Jul 25, 2016 at 02:09:26PM -0700, Joe Stringer wrote:
>> Commit 9b897c9125ef ("rhel: provide our own SELinux custom policy
>> package") added the SELinux policy to the fedora packaging as a
>> subpackage. Thi
On 25 July 2016 at 18:16, Flavio Leitner wrote:
> Updates SELinux to allow ovs-vsctl to get parent process
> information and log that to the database:
>
> record 241: 2016-07-26 00:59:47.418 "ovs-vsctl (invoked by /bin/bash
> (pid 1589)): ovs-vsctl -t 10 -- --if-exist ...
>
> Jul 25 12:57:35 local
On 26 July 2016 at 13:00, Flavio Leitner wrote:
> On Tue, Jul 26, 2016 at 12:41:01PM -0700, Joe Stringer wrote:
>> On 25 July 2016 at 16:57, Flavio Leitner wrote:
>> > On Fri, Jul 22, 2016 at 02:10:51PM -0700, Joe Stringer wrote:
>> >> When invoking ovs-ctl forc
e datapath pads all frames with 0, to make them at
> least 64 bytes.
>
> Finally, the userspace datapath checks for the IPv4 header checksum, so
> fix those in the hardcoded packets.
>
> Signed-off-by: Daniele Di Proietto
> Acked-by: Joe Stringer
> Acked-by: Flavio Leitner
On 26 July 2016 at 14:10, Flavio Leitner wrote:
> On Tue, Jul 26, 2016 at 12:57:07PM -0700, Joe Stringer wrote:
>> On 25 July 2016 at 18:16, Flavio Leitner wrote:
>> > Updates SELinux to allow ovs-vsctl to get parent process
>> > information and log that to the dat
On 27 July 2016 at 14:50, Ben Pfaff wrote:
> On Tue, Jul 26, 2016 at 12:34:16PM -0700, Joe Stringer wrote:
>> python-openvswitch uses the python "six" library, add a dependency for
>> this to the debian package.
>>
>> VMware-BZ: #1700259
>> Repor
expired
> connections, it can stop at the first non expired connection.
>
> Suggested-by: Joe Stringer
> Signed-off-by: Daniele Di Proietto
Acked-by: Joe Stringer
Minor comments on comments below. Thanks!
> +/* Cleanup:
> + *
Extra line.
> + * We must call conntrack_clean(
On 27 July 2016 at 19:01, Daniele Di Proietto wrote:
>
>
>
>
>
> On 27/07/2016 17:14, "Joe Stringer" wrote:
>
>>On 26 July 2016 at 17:58, Daniele Di Proietto wrote:
>>> This commit adds a thread that periodically removes expired connections.
>
Recent changes to the dump-conntrack command provide more info
(type,code), but the system-ovn tests weren't updated for this.
Update the tests.
Signed-off-by: Joe Stringer
---
tests/system-ovn.at | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/system-o
Congrats! This has been a while coming:)
On 27 July 2016 at 23:17, Daniele Di Proietto wrote:
> Thanks for the reviews, I pushed this to master except for the system tests
> part.
>
>
>
> On 26/07/2016 17:58, "Daniele Di Proietto" wrote:
>
>>This series aims to implement the ct() action for the
On 27 July 2016 at 23:27, Ilya Maximets wrote:
> I guess, you pushed some development version of this patch set.
>
> There is strange commit there:
>
> commit 6c54734ed27bc22975d7035a6bd5f32a412335a0
> Author: Daniele Di Proietto
> Date: Wed Jul 27 18:32:15 2016 -0700
>
> XXX Improve commen
On 28 July 2016 at 10:48, Joe Stringer wrote:
> Recent changes to the dump-conntrack command provide more info
> (type,code), but the system-ovn tests weren't updated for this.
> Update the tests.
>
> Signed-off-by: Joe Stringer
I'm aware of two other failures in the
On 28 July 2016 at 11:02, Russell Bryant wrote:
>
>
> On Mon, May 16, 2016 at 5:56 PM, Joe Stringer wrote:
>>
>> Adapt to python-2.6+, including support for 3.
>>
>> Signed-off-by: Joe Stringer
>
>
> Acked-by: Russell Bryant
Thanks for the review,
On 28 July 2016 at 11:19, Guru Shetty wrote:
>
>
> On 28 July 2016 at 10:48, Joe Stringer wrote:
>>
>> Recent changes to the dump-conntrack command provide more info
>> (type,code), but the system-ovn tests weren't updated for this.
>> Update the te
On 28 July 2016 at 06:43, Flavio Leitner wrote:
>
> Adding William since he is the author of commit 484371776e
>
> On Wed, Jul 27, 2016 at 01:54:45PM -0700, Joe Stringer wrote:
>> On 26 July 2016 at 14:10, Flavio Leitner wrote:
>> > On Tue, Jul 26, 2016 at 12:57:07P
On 25 July 2016 at 18:16, Flavio Leitner wrote:
> When ifdown isn't executed (system didn't shut down properly),
> ports remain in the openvswitch's database. In that case, an
> inconsitency is left behind when the ifcfg was modified because
> ovs-vsctl won't do anything to update existing port's
le at runtime).
VMware-BZ: #1700293
Signed-off-by: Joe Stringer
---
rhel/openvswitch-kmod-rhel6.spec.in | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/rhel/openvswitch-kmod-rhel6.spec.in
b/rhel/openvswitch-kmod-rhel6.spec.in
index 5d46838a9ed5..82a3312b100f 100644
to ensure that the out-of-tree module is always used when
it is installed, regardless of kernel upgrades.
Signed-off-by: Joe Stringer
---
rhel/openvswitch-kmod-fedora.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/rhel/openvswitch-kmod-fedora.spec.in
b/rhel/openvswitch-kmod-fedora.s
On 28 July 2016 at 10:54, Eric Garver wrote:
> This series adds 6 test cases to the "check-kernel" make target for
> 802.1ad. It is meant as a counterpart to the 802.1ad work currently
> going on and being discussed on the dev list.
>
> User space support for 802.1ad is being worked on by Xiao Lia
On 28 July 2016 at 10:54, Eric Garver wrote:
> Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN().
>
> Signed-off-by: Eric Garver
> ---
> tests/system-common-macros.at | 29 -
> 1 file changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/tests/system-comm
On 28 July 2016 at 10:54, Eric Garver wrote:
> Signed-off-by: Eric Garver
Hmm, on my Ubuntu 14.04 setup these tests fail with kernel 3.13.0-91,
bupass with kernel 3.19.0-58, but not 3.13.0-91. I guess the 3.13
kernel didn't support 802.1ad? Is there an easy way to figure this out
to skip the tes
On 28 July 2016 at 10:54, Eric Garver wrote:
> Signed-off-by: Eric Garver
Can you describe your setup? (distro, kernel)
This particular test seems to fail for me with kernel 3.19.0-58
(ubuntu) and the out-of-tree module from OVS repo. It'd be nice to
narrow down to find out why. If you get some
On 29 July 2016 at 11:30, Joe Stringer wrote:
> On 28 July 2016 at 10:54, Eric Garver wrote:
>> Signed-off-by: Eric Garver
>
> Can you describe your setup? (distro, kernel)
>
> This particular test seems to fail for me with kernel 3.19.0-58
> (ubuntu) and the out-of-t
On 29 July 2016 at 11:38, pravin shelar wrote:
> On Thu, Jul 28, 2016 at 5:09 PM, Joe Stringer wrote:
>> We've done the same for openvswitch.ko previously, but we really should
>> be doing this for vport modules as well; otherwise, depmod may try to
>> pair upstream vpo
On 29 July 2016 at 11:41, pravin shelar wrote:
> On Thu, Jul 28, 2016 at 5:09 PM, Joe Stringer wrote:
>> Out-of-tree modules are installed into the kernel's "extra" modules
>> directory for the version that kmod-openvswitch is compiled against. For
>> all ot
Thanks for the reviews all, I pushed this to master.
On 29 July 2016 at 11:46, Flavio Leitner wrote:
> On Thu, Jul 28, 2016 at 05:09:37PM -0700, Joe Stringer wrote:
>> We've done the same for openvswitch.ko previously, but we really should
>> be doing this for vport module
Thanks for the reviews all, I pushed this to master.
On 29 July 2016 at 11:53, Flavio Leitner wrote:
> On Thu, Jul 28, 2016 at 05:09:38PM -0700, Joe Stringer wrote:
>> Out-of-tree modules are installed into the kernel's "extra" modules
>> directory for the ve
201 - 300 of 2028 matches
Mail list logo
