On 26 July 2016 at 17:58, Daniele Di Proietto <diproiet...@vmware.com> wrote: > The userspace connection tracker doesn't support ALGs, frag reassembly > or NAT yet, so skip those tests. > > Also, connection tracking state input from a local port is not possible > in userspace. > > The userspace datapath pads all frames with 0, to make them at > least 64 bytes. > > Finally, the userspace datapath checks for the IPv4 header checksum, so > fix those in the hardcoded packets. > > Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> > Acked-by: Joe Stringer <j...@ovn.org> > Acked-by: Flavio Leitner <f...@sysclose.org> > ---
<snip> > @@ -1324,11 +1327,11 @@ dnl UDP packets from ns0->ns1 should solicit > "destination unreachable" response. > NS_CHECK_EXEC([at_ns0], [bash -c "echo a | nc $NC_EOF_OPT -u 10.1.1.2 > 10000"]) > > AT_CHECK([ovs-appctl revalidator/purge], [0]) > -AT_CHECK([ovs-ofctl dump-flows br0 | ofctl_strip | sort | grep -v drop], > [0], [dnl > - n_packets=1, n_bytes=44, priority=100,udp,in_port=1 > actions=ct(commit,exec(load:0x1->NXM_NX_CT_MARK[[]])),output:2 > - n_packets=1, n_bytes=72, > priority=100,ct_state=+rel+trk,ct_mark=0x1,icmp,in_port=2 actions=output:1 > - n_packets=1, n_bytes=72, priority=100,ct_state=-trk,icmp,in_port=2 > actions=ct(table=0) > - n_packets=2, n_bytes=84, priority=10,arp actions=NORMAL > +AT_CHECK([ovs-ofctl dump-flows br0 | ofctl_strip | sort | grep -v drop | sed > -e 's/n_bytes=[[0-9]]*/n_bytes=<cleared>/g'], [0], [dnl > + n_packets=1, n_bytes=<cleared>, priority=100,udp,in_port=1 > actions=ct(commit,exec(load:0x1->NXM_NX_CT_MARK[[]])),output:2 > + n_packets=1, n_bytes=<cleared>, > priority=100,ct_state=+rel+trk,ct_mark=0x1,icmp,in_port=2 actions=output:1 > + n_packets=1, n_bytes=<cleared>, priority=100,ct_state=-trk,icmp,in_port=2 > actions=ct(table=0) > + n_packets=2, n_bytes=<cleared>, priority=10,arp actions=NORMAL > NXST_FLOW reply: > ]) I think this is a completely orthogonal point, but it's still a bit surprising to me that the n_bytes would differ when receiving short packets in kernel vs. userspace datapaths. I follow that userspace pads shorter packets on receive, but shouldn't we be able to attribute these stats consistently, regardless of the datapath? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
