On 25 May 2016 at 09:25, Ryan Moats <rmo...@us.ibm.com> wrote:
> "dev" <dev-boun...@openvswitch.org> wrote on 05/23/2016 03:04:15 PM:
>
>> From: Andy Zhou <az...@ovn.org>
>> To: Joe Stringer <j...@ovn.org>
>> Cc: "<dev@openvswitch.org>" <dev@openvswitch.org>
>> Date: 05/23/2016 03:05 PM
>> Subject: Re: [ovs-dev] [PATCH 6/6] vagrant: Enable silent-rules for
>> configure.
>> Sent by: "dev" <dev-boun...@openvswitch.org>
>>
>> On Fri, May 20, 2016 at 11:49 AM, Joe Stringer <j...@ovn.org> wrote:
>>
>> > In the majority of cases, developers debugging their code using vagrant
>> > will be more interested in compiler errors/warnings than the exact
>> > invocation of the compiler. By enabling silent-rules, the verbosity of
>> > compilation is lowered and it is easier to identify these pieces of
>> > information.
>> >
>> > Signed-off-by: Joe Stringer <j...@ovn.org>
>> >
>> Acked-by: Andy Zhou <az...@ovn.org>
>>
>> On a separate note, Should we consider using ovs-dev.py for Vagrant?
>> For example, it may be useful to build with --with-debug flag also,
>> ovs-dev.py also
>> supports this.  Another advantage is that we can also test ovs-dev.py
>> (currently
>> there is no unit test for it).
>
> I like the idea for the original patch, so ...
>
> Acked-by: Ryan Moats <rmo...@us.ibm.com>
>
> P.S. I'm thinking I like the idea of using ovs-dev.py for Vagrant as well...
>

Thanks all, applied to master.

I think it's not a bad idea to use ovs-dev.py for vagrant. The only
caveat is that it's a common case (at least for me!) that the vagrant
VM is a different platform from my host machine, so I'd probably want
to keep the compile directories separate. This way I could build&run
on-demand on my localhost (eg testsuite), but also try it in the VM
without wiping out my local build copy. Maybe it would make sense to
hold the vagrant version inside a "_build-vagrant" directory.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to