On Sun, May 25, 2014 at 5:22 PM, Simon Horman wrote:
> diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
> index 803a94c..8ce596c 100644
> --- a/datapath/flow_netlink.c
> +++ b/datapath/flow_netlink.c
> + case OVS_ACTION_ATTR_POP_MPLS:
> + if (!eth_
On Mon, Jun 2, 2014 at 6:37 PM, Changbin Liu wrote:
> Hi Folks,
>
> Using Open vSwitch I am setting up VXLAN tunnels between hosts. I intend to
> make VXLAN tunnels "highly available" via Keepalived. Specifically, there
> are one master node and one backup node for each host, and they share a
> Vi
On Mon, Jun 2, 2014 at 9:04 PM, Simon Horman wrote:
> Hi Jesse,
>
> thanks for your feedback.
>
> On Mon, Jun 02, 2014 at 05:58:10PM -0700, Jesse Gross wrote:
>> On Sun, May 25, 2014 at 5:22 PM, Simon Horman wrote:
>> > diff --git a/datapath/flow_netlink.c b/data
On Tue, Jun 3, 2014 at 2:51 AM, Wenyu Zhang wrote:
>
> I am trying to simulate traffic in test cases to test IPFIX feature.
>
> For normal traffic, I can use "ovs-appctl netdev-dummy/receive " to simulate
> it, just refer to the netflow and sflow cases in tests/ofproto-dpif.at
> And I can capture
bout ovs-vswitchd says that it can generate a packet with "-generate"
> option.
> Can it fit my requirement?
>
> Bests,
> Wenyu
> - Original Message -
> From: "Jesse Gross" >
> To: "Wenyu Zhang" >
> Cc: dev@openvswitch.org
> S
On Tue, Jun 3, 2014 at 6:01 PM, Simon Horman wrote:
> On Tue, Jun 03, 2014 at 03:40:27PM -0700, Jesse Gross wrote:
>> On Mon, Jun 2, 2014 at 9:04 PM, Simon Horman wrote:
>> > Hi Jesse,
>> >
>> > thanks for your feedback.
>> >
>> > On Mo
On Tue, May 20, 2014 at 4:31 AM, Pravin B Shelar wrote:
> diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c
> index 637d712..eb36d33 100644
> --- a/datapath/vport-internal_dev.c
> +++ b/datapath/vport-internal_dev.c
> @@ -155,7 +155,10 @@ static void do_setup(struct net_de
In some cases, the names of tunnel protocols are longer than the
maximum allowed after concatenating port numbers. This truncates
names to the correct size rather than assert-failing on the assumption
that collisions between names of protocols are rather rate.
Signed-off-by: Jesse Gross
---
lib
-off-by: Jesse Gross
---
datapath/datapath.c | 38 ++
1 file changed, 26 insertions(+), 12 deletions(-)
diff --git a/datapath/datapath.c b/datapath/datapath.c
index 81ecc0f..305936a 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -952,11 +952,34
on a 10G link.
Suggested-by: Pravin Shelar
Signed-off-by: Jesse Gross
---
datapath/flow.c | 49 -
1 file changed, 44 insertions(+), 5 deletions(-)
diff --git a/datapath/flow.c b/datapath/flow.c
index c52081b..2a839ff 100644
--- a/datapath/flow.c
fully take advantage of all the features of
Geneve, particularly options. However, the kernel is fully
flexible and can support even unknown options. Additional
capabilities are planned to be added shortly but this provides
a solid starting point.
Jesse Gross (7):
lisp: Use IP
that all fields, including those
not used, are zeroed out which will soon not be the case.
This switches to using a hash of the IP addresses instead, which
solves both problems. These should always be present since LISP
encapsulates L3 packets.
Signed-off-by: Jesse Gross
---
datapath/vport
support any
particular option definitions. Over time, the intention is to
allow options to be matched through OpenFlow without requiring
explicit support in OVS userspace.
Signed-off-by: Jesse Gross
---
datapath/Modules.mk| 1 +
datapath/flow.c
Some tunnel formats have mechanisms for indicating that packets are
OAM frames that should be handled specially (either as high priority or
not forwarded beyond an endpoint). This provides support for allowing
those types of packets to be matched.
Signed-off-by: Jesse Gross
---
datapath
only the existing struct. This change is purely internal to the kernel
since the current OVS_KEY_ATTR_IPV4_TUNNEL is simply a compressed version
of OVS_KEY_ATTR_TUNNEL that is translated at flow setup.
Signed-off-by: Jesse Gross
---
datapath/actions.c | 6 +++---
datapath/datapath.h
On Wed, Jun 11, 2014 at 7:26 AM, Avinash wrote:
> On 6/10/14, Thomas Graf wrote:
>> On 06/10/14 at 07:03pm, Avinash wrote:
>>> @@ -471,10 +497,14 @@ int ovs_flow_extract(struct sk_buff *skb, u16
>>> in_port, struct sw_flow_key *key)
>>>
>>> if (vlan_tx_tag_present(skb))
>>>
On Wed, Jun 11, 2014 at 1:50 AM, Thomas Graf wrote:
> On 06/10/14 at 04:47pm, Jesse Gross wrote:
>> diff --git a/datapath/vport-lisp.c b/datapath/vport-lisp.c
>> index a1e2b2b..af9a71e 100644
>> --- a/datapath/vport-lisp.c
>> +++ b/datapath/vport-lisp.c
>>
On Wed, Jun 11, 2014 at 3:00 AM, Thomas Graf wrote:
> On 06/10/14 at 04:47pm, Jesse Gross wrote:
>> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
>> index 33423ad..57d40e3 100644
>> --- a/include/linux/openvswitch.h
>> +++ b/include/linux/openvs
On Wed, Jun 11, 2014 at 3:04 AM, Thomas Graf wrote:
> On 06/10/14 at 04:47pm, Jesse Gross wrote:
>> In some cases, the names of tunnel protocols are longer than the
>> maximum allowed after concatenating port numbers. This truncates
>> names to the correct size rather than
On Wed, Jun 11, 2014 at 4:58 AM, Thomas Graf wrote:
> On 06/10/14 at 04:47pm, Jesse Gross wrote:
>> diff --git a/datapath/flow.h b/datapath/flow.h
>> index 0ecf78b..5d8383c 100644
>> --- a/datapath/flow.h
>> +++ b/datapath/flow.h
>> @@ -53,11 +53,20 @@ struct ov
On Wed, Jun 11, 2014 at 1:52 PM, Thomas Graf wrote:
> On 06/11/14 at 11:11am, Jesse Gross wrote:
>> On Wed, Jun 11, 2014 at 3:04 AM, Thomas Graf wrote:
>> > On 06/10/14 at 04:47pm, Jesse Gross wrote:
>> >> In some cases, the names of tunnel protocols are longer
On Wed, Jun 11, 2014 at 1:58 PM, Thomas Graf wrote:
> On 06/11/14 at 11:23am, Jesse Gross wrote:
>> These two pieces are actually related.
>>
>> All of the operations during flow lookup (flow extraction, masking,
>> hashing, and comparison) are now variable length to th
On Wed, Jun 11, 2014 at 11:06 PM, Avinash wrote:
> On 6/11/14, Jesse Gross wrote:
>> On Wed, Jun 11, 2014 at 7:26 AM, Avinash wrote:
>>> On 6/10/14, Thomas Graf wrote:
>>>> On 06/10/14 at 07:03pm, Avinash wrote:
>>>>> @@ -471,10 +497,14 @@
On Thu, Jun 12, 2014 at 9:08 AM, Thomas Graf wrote:
> On 06/12/14 at 09:04am, Jesse Gross wrote:
>> On Wed, Jun 11, 2014 at 11:06 PM, Avinash wrote:
>> > On 6/11/14, Jesse Gross wrote:
>> >> On Wed, Jun 11, 2014 at 7:26 AM, Avinash wrote:
>> >>> On
I think we also have a similar problem in lib/odp-util.h.
On Thu, Jun 12, 2014 at 5:15 PM, Andy Zhou wrote:
> Thanks for the view. Pushed to master and branch 2.3 with the vmware
> bug ID added to the commit message.
>
> On Thu, Jun 12, 2014 at 4:38 PM, Pravin Shelar wrote:
>> On Thu, Jun 12, 20
Yes, that's what I meant.
On Thu, Jun 12, 2014 at 9:17 PM, Andy Zhou wrote:
> Are you talking about ODPUTIL_FLOW_KEY_BYTES? Luckily, we pad it to
> 256 bytes, so only the comment
> above it needs updating. I will send out a patch.
>
> On Thu, Jun 12, 2014 at 5:28 PM, Jess
igned-off-by: Jesse Gross
---
lib/netdev-vport.c | 36 +---
lib/netdev.c | 2 +-
tests/ovs-vsctl.at | 16
3 files changed, 30 insertions(+), 24 deletions(-)
diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
index c214bf7..6e427a1 100644
On Wed, Jun 11, 2014 at 1:50 AM, Thomas Graf wrote:
> On 06/10/14 at 04:47pm, Jesse Gross wrote:
>> When calculating the source port for the UDP header, LISP primarily
>> uses skb_get_hash() but needs a backup in case this fails. The
>> current backup is a hash of the ent
On Fri, Jun 13, 2014 at 4:13 PM, Ben Pfaff wrote:
> On Fri, Jun 13, 2014 at 12:08:40PM -0700, Jesse Gross wrote:
>> In most cases, tunnel ports specify a dpif name to act as the backing
>> port in the datapath. However, in the case of UDP tunnels the type is
>> used with the
On Tue, Jun 17, 2014 at 12:21 PM, Lori Jakab wrote:
> Hi Jesse,
>
>
> On 5/23/14, 2:07 AM, Jesse Gross wrote:
>>
>> On Tue, May 20, 2014 at 9:27 PM, Lori Jakab wrote:
>>>
>>> On 5/21/14, 4:10 AM, Jesse Gross wrote:
>>>>
>
On Thu, Jun 19, 2014 at 1:30 PM, Pravin Shelar wrote:
> On Tue, Jun 10, 2014 at 4:47 PM, Jesse Gross wrote:
>> As new protocols are added, the size of the flow key tends to
>> increase although few protocols care about all of the fields. In
>> order to optimize this for hash
On Thu, Jun 19, 2014 at 1:30 PM, Pravin Shelar wrote:
> On Tue, Jun 10, 2014 at 4:47 PM, Jesse Gross wrote:
>> Some tunnel formats have mechanisms for indicating that packets are
>> OAM frames that should be handled specially (either as high priority or
>> not forwarded beyo
n Tue, Jun 10, 2014 at 4:47 PM, Jesse Gross wrote:
>> As the size of the flow key grows, it can put some pressure on the
>> stack. This is particularly true in ovs_flow_cmd_set(), which needs several
>> copies of the key on the stack. One of those uses is logically separate,
>&
On Thu, Jun 19, 2014 at 2:01 PM, Pravin Shelar wrote:
> On Thu, Jun 19, 2014 at 1:46 PM, Jesse Gross wrote:
>> On Thu, Jun 19, 2014 at 1:30 PM, Pravin Shelar wrote:
>>> On Tue, Jun 10, 2014 at 4:47 PM, Jesse Gross wrote:
>>>> @@ -520,18 +534,24 @@ int ovs_flow_ex
On Thu, Jun 19, 2014 at 1:33 PM, Pravin Shelar wrote:
> git am warning:
> /home/pravin/ovs/w7/.git/rebase-apply/patch:53: trailing whitespace.
>
> }
>
> warning: 1 line adds whitespace errors.
Fixed.
> ---
> compiler warning:
>
> lib/odp-ut
On Thu, Jun 19, 2014 at 4:30 PM, Pravin Shelar wrote:
> On Thu, Jun 19, 2014 at 4:07 PM, Jesse Gross wrote:
>> On Thu, Jun 19, 2014 at 1:33 PM, Pravin Shelar wrote:
>>>> diff --git a/datapath/flow.c b/datapath/flow.c
>>>> index f1bb95d..7b108ed 100644
>
On Tue, Jun 10, 2014 at 4:47 PM, Jesse Gross wrote:
> This series implements support for Geneve
> (http://tools.ietf.org/html/draft-gross-geneve-00) in OVS.
>
> It has two caveats:
> * It is not integrated with upstream yet. The intention is to
>upstream this but it require
On Mon, Jun 23, 2014 at 3:48 AM, Lorand Jakab wrote:
> Signed-off-by: Lorand Jakab
> ---
> datapath/linux/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listi
On Fri, Jun 13, 2014 at 3:28 PM, Ben Pfaff wrote:
> Until now, the OVS source tree has had a whole maze of header files that
> make "#include " work OK regardless of platform, but
> this confuses everyone new to the tree, at first glance, and is difficult
> to understand at second glance too.
>
>
On Tue, Jun 24, 2014 at 4:56 AM, Simon Horman wrote:
> Allow datapath to recognize and extract MPLS labels into flow keys
> and execute actions which push, pop, and set labels on packets.
>
> Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe
> Stringer.
>
> Cc: Ravi K
> Cc: L
t;
> action, because the Linux kernel datapath throws away tunnel information
> supplied in the OVS_PACKET_CMD_EXECUTE metadata argument.
>
> VMware-BZ: #1270110
> Reported-by: Srinivas Neginhal
> Signed-off-by: Ben Pfaff
> CC: Jesse Gross
Acked-by: Jesse Gross
Maybe we al
lve this problem while
still taking advantage of the procomputed hash, this rehashes the
hash so that the entropy is spread throughout 32 bits.
Signed-off-by: Jesse Gross
---
acinclude.m4 | 2 ++
datapath/linux/compat/include/linux/skbuff.h | 5 +
2 files changed
On Wed, Jun 18, 2014 at 9:45 PM, Jesse Gross wrote:
> On Tue, Jun 17, 2014 at 12:21 PM, Lori Jakab wrote:
>> Hi Jesse,
>>
>>
>> On 5/23/14, 2:07 AM, Jesse Gross wrote:
>>>
>>> On Tue, May 20, 2014 at 9:27 PM, Lori Jakab wrote:
>>>>
>&g
On Wed, Jun 25, 2014 at 1:30 AM, Thomas Graf wrote:
> On 06/24/14 at 06:46pm, Jesse Gross wrote:
>> Currently, if the network stack provides skb->rxhash then we use it,
>> otherwise we compute our own. However, on at least some versions of
>> RHEL/CentOS, the stack prov
On Wed, Jun 25, 2014 at 11:02 AM, Ben Pfaff wrote:
> Only dpif_execute() was checking for oversized actions but dpif_operate()
> should do so also. This fixes the problem.
>
> Found by inspection.
>
> Signed-off-by: Ben Pfaff
Ack
On Wed, Jun 25, 2014 at 11:02 AM, Ben Pfaff wrote:
> This should make it easier to identify problems that result from bugs in
> the execution helper.
>
> Suggested-by: Jesse Gross
> Signed-off-by: Ben Pfaff
Acked-by: Jesse Gross
___
d
On Wed, Jun 25, 2014 at 11:02 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/dpif.c | 17 +
> 1 file changed, 17 insertions(+)
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://ope
On Tue, Jun 10, 2014 at 5:07 PM, Pravin B Shelar wrote:
> On packet recv OVS CB is initialized in multiple function.
> Following patch moves all these initialization to
> ovs_vport_receive().
> This patch also save a check in execute actions.
>
> Signed-off-by: Pravin B Shelar
On Fri, Jun 27, 2014 at 5:55 PM, Simon Horman wrote:
> On Wed, Jun 25, 2014 at 10:51:52AM +0900, Simon Horman wrote:
>> On Tue, Jun 24, 2014 at 04:24:37PM -0700, Jesse Gross wrote:
>> > * Maybe you can refresh my memory - in the case of a push_mpls after
>> > pop_vlan,
On Mon, Jun 30, 2014 at 1:37 PM, Ben Pfaff wrote:
> Found by inspection.
>
> Signed-off-by: Ben Pfaff
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Yes, it worked fine for me (using git am).
On Mon, Jun 30, 2014 at 1:52 PM, Ben Pfaff wrote:
> That's odd. Jesse, did this apply for you?
>
> On Mon, Jun 30, 2014 at 08:47:08PM +, Pritesh Kothari (pritkoth) wrote:
>> LGTM but give error on master:
>> error: patch failed: datapath/flow_netlin
ce it doesn't support netpoll. However, this
change has been backported to older kernels so OVS needs to use the
new API to compile.
Signed-off-by: Jesse Gross
---
acinclude.m4 | 2 ++
datapath/datapath.c| 4 +--
.../li
On Tue, Jul 1, 2014 at 4:26 AM, Lori Jakab wrote:
> On 6/27/14, 4:25 PM, Lori Jakab wrote:
>>
>> On 6/25/14, 6:58 PM, Lori Jakab wrote:
>>>
>>> On 6/25/14, 5:19 AM, Jesse Gross wrote:
>>>>
>>>> On Wed, Jun 18, 2014 at 9:45 PM, Jesse Gross
On Tue, Jul 1, 2014 at 11:33 AM, Pritesh Kothari (pritkoth)
wrote:
>
> On Jul 1, 2014, at 11:18 AM, Pravin Shelar wrote:
>
>> why not just check for HAVE_U64_STATS_FETCH_BEGIN_IRQ?
>
> because of this which was added in 3.13, i guess:
>
> -#if LINUX_VERSION_CODE < KERNEL_VERSION(3,13,0)
> -
> -#i
On Tue, Jul 1, 2014 at 12:26 PM, Pravin Shelar wrote:
> On Tue, Jul 1, 2014 at 12:22 PM, Jesse Gross wrote:
>> On Tue, Jul 1, 2014 at 11:33 AM, Pritesh Kothari (pritkoth)
>> wrote:
>>>
>>> On Jul 1, 2014, at 11:18 AM, Pravin Shelar wrote
low push and pop MPLS on packets with multiple VLAN
> tags, regardless of if they are all remove using POP VLAN, as there
> is no mechanism to expose the inner ethernet type beyond that of
> the outermost VLAN tag.
>
> Suggested-by: Jesse Gross
> Signed-off-by: Simon Ho
On Tue, Jul 1, 2014 at 3:49 PM, Ben Pfaff wrote:
> I found when reconfiguring my kernel that if I turned on NET_IPGRE, GRE
> tunnels no longer worked. (I might not understand this issue.)
>
> Signed-off-by: Ben Pfaff
> ---
> INSTALL |5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-
There are many possible ways that a flow can be invalid so we've
added logging for most of them. This adds logs for the remaining
possible cases so there isn't any ambiguity while debugging.
CC: Federico Iezzi
Signed-off-by: Jesse Gross
---
datapath/datapath.c | 12 +---
On Tue, Jul 1, 2014 at 5:10 PM, Ben Pfaff wrote:
> On Tue, Jul 01, 2014 at 05:00:45PM -0700, Jesse Gross wrote:
>> On Tue, Jul 1, 2014 at 3:49 PM, Ben Pfaff wrote:
>> > I found when reconfiguring my kernel that if I turned on NET_IPGRE, GRE
>> > tunnels no longer worke
On Wed, Jul 2, 2014 at 11:53 AM, Ben Pfaff wrote:
> On Tue, Jul 01, 2014 at 05:52:23PM -0700, Jesse Gross wrote:
>> On Tue, Jul 1, 2014 at 5:10 PM, Ben Pfaff wrote:
>> > On Tue, Jul 01, 2014 at 05:00:45PM -0700, Jesse Gross wrote:
>> >> On Tue, Jul 1, 2014 at 3:49 P
On Wed, Jul 2, 2014 at 4:46 PM, Thomas Graf wrote:
> On 07/01/14 at 05:43pm, Jesse Gross wrote:
>> There are many possible ways that a flow can be invalid so we've
>> added logging for most of them. This adds logs for the remaining
>> possible cases so there isn'
On Thu, Jul 17, 2014 at 3:46 PM, Ansis Atteka wrote:
> diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
> index 5f975a1..a4108c0 100644
> --- a/datapath/flow_netlink.c
> +++ b/datapath/flow_netlink.c
> @@ -1034,7 +1034,7 @@ int ovs_nla_put_flow(struct datapath *dp, const struct
> sw
On Thu, Jul 17, 2014 at 3:53 PM, Joe Stringer wrote:
> On 18 July 2014 05:19, Ben Pfaff wrote:
>> - If the userspace flow key includes more fields than the
>> > kernel's, for example if userspace decoded an IPv6 header but
>> > the kernel stopped at the Ethernet type, then userspa
You will likely have better luck posting this on a mailing list and
also asking Red Hat people.
On Sun, Jul 13, 2014 at 9:27 PM, JIANGANG Zhang wrote:
> Hey Jesse,
>
> I am trying to build openvswitch 2.1.2 on RHEL/CentOS 7.0, but getting
> similar problem as in
> http://openvswitch.org/pipermail
On Mon, Jul 21, 2014 at 5:11 PM, Ansis Atteka wrote:
> On Thu, Jul 17, 2014 at 4:08 PM, Jesse Gross wrote:
>> One thing that I worry about is that this has the possibility to
>> change how the flow is reported - before the flow deletion it has
>> Geneve options but immed
On Wed, Sep 17, 2014 at 1:34 AM, Jiri Pirko wrote:
> Thu, Sep 04, 2014 at 10:46:28PM CEST, pshe...@nicira.com wrote:
>>On the other hand if vswitchd uses common interface (switchdev) there
>>is no need to extend ovs kernel interface. For example specifying
>>extra metadata, like (sw only, hw olny,
On Fri, Sep 5, 2014 at 4:05 PM, Jarno Rajahalme wrote:
> When userspace inserts masked flows, it is not necessary to demand
> that flows matching in a known ethertype also must have the
> corresponding key, as a missing key will be automatically wildcarded.
>
> For example, if a drop flow dropping
On Mon, Sep 22, 2014 at 3:49 PM, Jarno Rajahalme wrote:
>
> On Sep 22, 2014, at 2:26 PM, Jesse Gross wrote:
>
>> On Fri, Sep 5, 2014 at 4:05 PM, Jarno Rajahalme
>> wrote:
>>> When userspace inserts masked flows, it is not necessary to demand
>>> that f
On Wed, Oct 1, 2014 at 1:02 AM, Andy Zhou wrote:
> Route entry will be free on error by vport when freeing skb.
> additional error check and free after xmit() will cause double free.
>
> Signed-off-by: Andy Zhou
I'm not sure that the route entry is attached to the skb in all cases.
If it's not t
API. May be it will be better for
> vxlan_xmit_skb always
> attach the route skb at the very beginning?
>
> Should we also make iptunnel_xmit() return type as unsigned int?
>
> On Wed, Oct 1, 2014 at 10:42 AM, Jesse Gross wrote:
>> On Wed, Oct 1, 2014 at 1:02 AM, Andy Z
On Wed, Oct 1, 2014 at 1:02 AM, Andy Zhou wrote:
> TUNNEL_OPTIONS_PRESENT should always be checked against the tun_flgs
> bits in a flow key, for both flow and mask serialization.
>
> Signed-off-by: Andy Zhou
I'm not sure that this is the right thing to do. In the case where you
want to match on
ldorf
Attendees:
Johann Tönsing (Netronome), Simon Horman (Netronome), Rob Truesdell
(Netronome), John Fastabend (Intel), Or Gerlitz (Mellanox)
Lori Jakab (Cisco), Jiri Pirko (Red Hat), Alexei Starovoitov
(Plumgrid), Zoltan Lajos Kis (Ericsson), Justin Pettit (VMware), Jesse
Gross (VMware)
Thomas
On Thu, Oct 9, 2014 at 3:34 AM, Lori Jakab wrote:
> On 9/12/14 12:26 AM, Jesse Gross wrote:
>> On Mon, Sep 8, 2014 at 5:43 AM, Lori Jakab wrote:
>>> --- a/datapath/flow_netlink.c
>>> +++ b/datapath/flow_netlink.c
>>> @@ -1831,6 +1831,8 @@ static int __ovs_nla_
On Fri, Oct 31, 2014 at 4:29 PM, Ben Pfaff wrote:
> packets.h uses a LITTLE_ENDIAN macro for Geneve:
>
> struct geneve_opt {
> ovs_be16 opt_class;
> uint8_t type;
> #ifdef LITTLE_ENDIAN
> uint8_t length:5;
> uint8_t r3:1;
> uint8_t r2:1;
>
WORDS_BIGENDIAN is defined by configure so it is a more portable
way to test for endianness.
Reported-by: Ben Pfaff
Signed-off-by: Jesse Gross
---
lib/packets.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/packets.h b/lib/packets.h
index fc7e602..f45ddde
On Fri, Oct 31, 2014 at 5:46 PM, Ben Pfaff wrote:
> On Fri, Oct 31, 2014 at 04:53:00PM -0700, Jesse Gross wrote:
>> WORDS_BIGENDIAN is defined by configure so it is a more portable
>> way to test for endianness.
>>
>> Reported-by: Ben Pfaff
>> Signed-off-by: Jes
On Mon, Nov 3, 2014 at 6:31 AM, Lorand Jakab wrote:
> diff --git a/datapath/flow.c b/datapath/flow.c
> index a3c5d2f..fea26ae 100644
> --- a/datapath/flow.c
> +++ b/datapath/flow.c
> @@ -458,28 +458,31 @@ static int key_extract(struct sk_buff *skb, struct
> sw_flow_key *key)
> + /* Link lay
ll let him take a look
at the current version and if he is happy with it, apply the whole
series.
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Nov 5, 2014 at 6:06 PM, Pravin Shelar wrote:
> On Wed, Nov 5, 2014 at 10:19 AM, Lori Jakab wrote:
>> On 11/5/14 12:16 AM, Pravin Shelar wrote:
>>> On Mon, Nov 3, 2014 at 1:36 PM, Lorand Jakab wrote:
+static int pop_eth(struct sk_buff *skb)
+{
+ skb_pull_rcsum(skb, ET
On Tue, Nov 11, 2014 at 1:13 PM, Pravin Shelar wrote:
> On Mon, Nov 10, 2014 at 4:00 AM, Lori Jakab wrote:
>>
>> On 11/7/14 8:50 AM, Pravin Shelar wrote:
>>>
>>> On Thu, Nov 6, 2014 at 12:21 PM, Lori Jakab wrote:
On 11/6/14 4:06 AM, Pravin Shelar wrote:
>>>
>>> Have you tried r
On Wed, Nov 12, 2014 at 5:15 AM, Michio Honda wrote:
> OpenFlow 1.1 and later allow for this.
>
> Signed-off-by: Michio Honda
This patch does not add support for wildcarded MAC addresses as that
is already possible.
What it actually does is allow for packets without an Ethernet header,
which do
On Tue, Nov 11, 2014 at 5:03 PM, Pravin Shelar wrote:
> On Tue, Nov 11, 2014 at 6:50 PM, Jesse Gross wrote:
>> On Tue, Nov 11, 2014 at 1:13 PM, Pravin Shelar wrote:
>>> On Mon, Nov 10, 2014 at 4:00 AM, Lori Jakab wrote:
>>>>
>>>> On 11/7/14 8:50 AM, Pr
ommand? I cannot find any such example from Google...
>
> Cheers,
> - Michio
> ____
> From: Jesse Gross [je...@nicira.com]
> Sent: Wednesday, November 12, 2014 10:05 PM
> To: Michio Honda
> Cc: dev@openvswitch.org; Roberto Bifulco; Joao Martins
On Fri, Nov 14, 2014 at 3:51 AM, Lorand Jakab wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index 3607170..3ecb3cc 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -570,6 +558,23 @@ static int ovs_packet_cmd_execute(struct sk_buff *skb,
> struct genl_info *i
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
> diff --git a/datapath/flow.c b/datapath/flow.c
> index b01f7bd..3caa364 100644
> --- a/datapath/flow.c
> +++ b/datapath/flow.c
> @@ -462,7 +462,6 @@ static int key_extract(struct sk_buff *skb, struct
> sw_flow_key *key)
> /* Link laye
On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
> diff --git a/datapath/flow.c b/datapath/flow.c
> index 69b13b3..b01f7bd 100644
> --- a/datapath/flow.c
> +++ b/datapath/flow.c
> @@ -459,28 +459,31 @@ static int key_extract(struct sk_buff *skb, struct
> sw_flow_key *key)
>
> skb_rese
On Mon, Nov 17, 2014 at 10:46 AM, Lori Jakab wrote:
> On 11/17/14 8:28 PM, Jesse Gross wrote:
>>
>> On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
>>>
>>> diff --git a/datapath/flow.c b/datapath/flow.c
>>> index 69b13b3..b01f7bd 100644
>>&
On Mon, Nov 17, 2014 at 10:53 AM, Lori Jakab wrote:
> On 11/17/14 8:48 PM, Jesse Gross wrote:
>>
>> On Mon, Nov 17, 2014 at 10:46 AM, Lori Jakab wrote:
>>>
>>> On 11/17/14 8:28 PM, Jesse Gross wrote:
>>>>
>>>> On Mon, Nov 17, 2014
On Mon, Nov 17, 2014 at 1:50 PM, Lori Jakab wrote:
> On 11/17/14 8:03 PM, Jesse Gross wrote:
>> On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab wrote:
>>> diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
>>> index 54510c8..8ca3469 100644
>>> ---
On Mon, Nov 17, 2014 at 2:37 PM, Lori Jakab wrote:
> On 11/18/14 12:33 AM, Jesse Gross wrote:
>>
>> On Mon, Nov 17, 2014 at 1:50 PM, Lori Jakab wrote:
>>>
>>> On 11/17/14 8:03 PM, Jesse Gross wrote:
>>>>
>>>> On Mon, Nov 17, 2014 at 9:24 A
On Wed, Nov 19, 2014 at 8:47 AM, Lori Jakab wrote:
> Jesse, Jarno,
>
>
> On 11/18/14 1:36 AM, Jesse Gross wrote:
>>
>> On Mon, Nov 17, 2014 at 2:37 PM, Lori Jakab wrote:
>>>
>>> On 11/18/14 12:33 AM, Jesse Gross wrote:
>>>>
>>>>
On Wed, Nov 19, 2014 at 12:51 PM, Jarno Rajahalme wrote:
>
> On Nov 17, 2014, at 2:33 PM, Jesse Gross wrote:
>
>> On Mon, Nov 17, 2014 at 1:50 PM, Lori Jakab wrote:
>>> On 11/17/14 8:03 PM, Jesse Gross wrote:
>>>> On Mon, Nov 17, 2014 at 9:24 AM, Lorand Jakab
On Wed, Nov 19, 2014 at 3:33 PM, Jarno Rajahalme wrote:
>
>
>
> Jarno
>
>
>> On Nov 19, 2014, at 2:21 PM, Jesse Gross wrote:
>>
>>> On Wed, Nov 19, 2014 at 12:51 PM, Jarno Rajahalme
>>> wrote:
>>>
>>>> On Nov 17, 2014, at
On Thu, Nov 20, 2014 at 10:35 AM, Jarno Rajahalme wrote:
>
> On Nov 19, 2014, at 6:44 PM, Jesse Gross wrote:
>
> On Wed, Nov 19, 2014 at 3:33 PM, Jarno Rajahalme
> wrote:
>
>
>
>
> Jarno
>
>
> On Nov 19, 2014, at 2:21 PM, Jesse Gross wrote:
>
On Thu, Nov 20, 2014 at 4:06 PM, Jarno Rajahalme wrote:
> On Nov 20, 2014, at 12:18 PM, Jesse Gross wrote:
>
> On Thu, Nov 20, 2014 at 10:35 AM, Jarno Rajahalme
> wrote:
>
> The netlink key for flow put is serialized from struct flow, so even in the
> case of L3 t
On Tue, Dec 15, 2015 at 10:47 AM, Mengke Liu wrote:
> This patch renames the command name related with geneve-map to a more generic
> name as following:
> add-geneve-map -> add-tlv-map
> del-geneve-map -> del-tlv-map
> dump-geneve-map -> dump-tlv-map
>
> It also renames the Geneve_table to tlv_tab
On Thu, Dec 17, 2015 at 4:55 AM, Ben Pfaff wrote:
> Found by valgrind.
>
> CC: Jesse Gross
> Reported-by: William Tu
> Signed-off-by: Ben Pfaff
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/m
On Thu, Dec 17, 2015 at 5:28 PM, Cheng-Chun Tu wrote:
> Hi Ben,
>
> I've applied your patch and valgrind no longer complain about
> tun_metadata_add_entry. However, another issue found (reported by testcase
> 643), patch below provided the fix and testcase 643 passes.
>
> valgrind message
> ==2049
k+0x1c/0x30
>
> Reported-by: Joe Stringer
> Signed-off-by: Pravin B Shelar
It's hard to tell whether this will fix the problem but either way, it
definitely is a bug in the current code.
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
do have some options but not the particular one
that was matched on. This brings the same behavior for this case and
avoids the possibility of accessing uninitialized memory.
Reported-by: Daniele Di Proietto
Signed-off-by: Jesse Gross
---
lib/dpif-netdev.c | 14 +-
1 file changed
601 - 700 of 3414 matches
Mail list logo
