On Tue, Jun 24, 2014 at 4:56 AM, Simon Horman <ho...@verge.net.au> wrote: > Allow datapath to recognize and extract MPLS labels into flow keys > and execute actions which push, pop, and set labels on packets. > > Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe > Stringer. > > Cc: Ravi K <rke...@gmail.com> > Cc: Leo Alterman <lalter...@nicira.com> > Cc: Isaku Yamahata <yamah...@valinux.co.jp> > Cc: Joe Stringer <j...@wand.net.nz> > Signed-off-by: Simon Horman <ho...@verge.net.au>
Applied, thanks for all your work. Time to break out the champagne :) That being said, I do have a couple of comments for follow up discussion: * I removed the addition of MPLS to key_attr_size. This is trying to calculate the maximum key size and since MPLS will never show up in conjunction with IPv6 (the current longest key) and isn't longer than it, MPLS shouldn't increase the maximum size. * I think there is a potential for MPLS packets to be incorrectly offloaded on kernels 3.12-3.15 when encapsulated inside a tunnel. This is because it won't hit either the OVS GSO code or your enhanced MPLS feature check. I don't want to lose GSO for tunnels on those kernels but maybe there is a way to avoid this potential problem without too much work. * Maybe you can refresh my memory - in the case of a push_mpls after pop_vlan, why can't we do this check correctly for at least one level of vlan? It seems like we could use the inner EtherType to tell whether an additional vlan tag is present. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
