c6e3afab2923 Mon Sep 17 00:00:00 2001
Message-Id:
<1e06d7a4dc75f2bbabca4f904747c6e3afab2923.1357530055.git.yamah...@valinux.co.jp>
In-Reply-To:
<0639ad6e831c28768eceef30fc1325b30eddfa84.1357530055.git.yamah...@valinux.co.jp>
References:
<0639ad6e831c28768eceef30fc1325b30eddfa84.1357530055.git.yamah...@valinux.co.jp>
On Sat, Jan 05, 2013 at 11:25:57AM -0800, Justin Pettit wrote:
> Userspace-kernel communication is a possible bottleneck when OVS is
> receiving a large number of flow set up requests. To help prevent a bad
> actor from consuming too much of this resource, we introduced channels
> to segegrate tra
| V
OVS_ACTION_ATTR_OUTPUT
ovs-switchd
Signed-off-by: Isaku Yamahata
---
datapath/tunnel.c |1 +
1 file changed, 1 insertion(+)
diff --git a/datapath/tunnel.c b/datap
I think the upstream kernel has a similar issue with tunneling.
I'm preparing a patch.
thanks,
On Tue, Jun 25, 2013 at 05:11:47PM +0900, Isaku Yamahata wrote:
> Reset skb->pkt_type when sending tunneled packets.
> Packet can have pkt_type of PACKET_OTHERHOST when coming to ovs bri
10.0.0.3 vetha
^CSent 2 probes (2 broadcast(s))
Received 0 response(s)
Cc: Pravin B Shelar
Cc: Jesse Gross
Cc: dev@openvswitch.org
Signed-off-by: Isaku Yamahata
---
drivers/net/loopback.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/loopback.c b/drivers/net/loop
On Wed, Jun 26, 2013 at 01:40:22AM -0700, Eric Dumazet wrote:
> On Wed, 2013-06-26 at 16:34 +0900, Isaku Yamahata wrote:
> > Reset pkt_type to PACKET_HOST when loopback device receives packet
> > before calling eth_type_trans()
> >
> > ip-encapsulated packets can be ha
On Wed, Jun 26, 2013 at 03:29:30PM -0700, David Miller wrote:
> From: Isaku Yamahata
> Date: Wed, 26 Jun 2013 18:37:51 +0900
>
> > veth does. vethb-peer in the above example.
> > (veth_xmit() -> dev_forward_skb() -> eth_type_trans())
> > The destination mac addre
Cong Wang
Cc: Pravin B Shelar
Cc: Jesse Gross
Cc: dev@openvswitch.org
Signed-off-by: Isaku Yamahata
---
net/core/dev.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 722f633..b179b8a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
| |upcall
| V
OVS_ACTION_ATTR_OUTPUT
ovs-switchd
Cc: Murphy McCauley
Cc: Jesse Gros
On Tue, Jul 09, 2013 at 02:08:03PM -0700, Jesse Gross wrote:
> On Tue, Jul 9, 2013 at 4:07 AM, Isaku Yamahata wrote:
> > The upstream has the fix for dev_forward_skb() to reset pkt_type to
> > PACKET_HOST. the change set of 06a23fe31ca3992863721f21bdb0307af93da807
> &g
On Tue, Jul 09, 2013 at 10:23:42PM -0700, Jesse Gross wrote:
> On Tue, Jul 9, 2013 at 7:48 PM, Isaku Yamahata wrote:
> > On Tue, Jul 09, 2013 at 02:08:03PM -0700, Jesse Gross wrote:
> >> On Tue, Jul 9, 2013 at 4:07 AM, Isaku Yamahata
> >> wrote:
> >
ovs-switchd
Cc: Murphy McCauley
Cc: Jesse Gross
Signed-off-by: Isaku Yamahata
---
datapath/tunnel.c|1 +
datapath/vport-gre.c |1 +
2 files changed, 2 insertions(+)
diff --git a/datapath/tunnel.c b/datapath/tunnel.c
index ef46a69..b955384
On Thu, Jul 18, 2013 at 10:02:52AM -0700, Jesse Gross wrote:
> On Tue, Jul 16, 2013 at 8:20 PM, Isaku Yamahata
> wrote:
> > diff --git a/datapath/vport-gre.c b/datapath/vport-gre.c
> > index c74f5fc..604fe94 100644
> > --- a/datapath/vport-gre.c
> > +++ b/data
-> v2:
- introduce ofpact_instruction to represent instruction delimiter
thanks,
Isaku Yamahata (10):
ofp-actions: allow ofpacts_put_openflow10() return error
ofp-actions: allow ofpacts_to_openflow11_{actions, instructions}
return error
ofp-actions: export OVSINST_OFPIT11_xxx
of
This order is used by parser from text string to check if the instruction
is given in this order.
Signed-off-by: Isaku Yamahata
---
v4
- improve commit message/comment to clarify it's for parser from text string
v3
- newly introduced
---
lib/ofp-actions.h |
When OF1.2+ only actions are introduced,
ofpacts_put_openflow11_{actions, instructions}() will be unable to handle all
ofp-actions. For such cases, allow it return error.
Signed-off-by: Isaku Yamahata
---
v4
- newly introduced
---
lib/ofp-actions.c | 17 -
lib/ofp
They will be used by ofp-parser.c.
Signed-off-by: Isaku Yamahata
---
v4
- no change
v3
- no change
v2
- newly introduced
---
lib/ofp-actions.c | 33 -
lib/ofp-actions.h | 35 +++
2 files changed, 35 insertions(+), 33
When OF11+ only actions is introduced, ofpacts_put_openflow10() will be
unable to handle all ofp-actions. So allow it return error in that case.
Signed-off-by: Isaku Yamahata
---
v4
- newly introduced
---
lib/learning-switch.c | 35 +
lib/ofp-actions.c | 11
The refactored function, rule_dpif_miss_rule(), will be used for
handling table miss whose table_id > 0 by goto-table instruction.
Signed-off-by: Isaku Yamahata
---
v4
- commit message
v3
- no change
v2
- no chnage
---
ofproto/ofproto-dpif.c | 31 ---
1 fi
Signed-off-by: Isaku Yamahata
---
v4
- clear-actions part is split outed.
- check zero padding
- man page
---
lib/ofp-actions.c| 33 ++---
lib/ofp-actions.h| 14 +-
lib/ofp-parse.c |5 +
ofproto/ofproto-dpif.c |8
Signed-off-by: Isaku Yamahata
---
v4
- write-action part is split out
- man page
---
lib/ofp-actions.c| 55 +
lib/ofp-actions.h| 10 +---
lib/ofp-parse.c |6 +---
ofproto/ofproto-dpif.c | 10
tests/ofp
When goto-table instruction results in table miss, generate packet-in event
Signed-off-by: Isaku Yamahata
---
v4
- manual rebase
v3
- changed for OFPACT_GOTO_ABLE
v2
- minor change to compile
Conflicts:
ofproto/ofproto-dpif.c
---
ofproto/ofproto-dpif.c | 29
This patch introduces helper functions
- to cast
- to convert from/to text
Signed-off-by: Isaku Yamahata
---
v4
- newly introduced
---
lib/ofp-actions.c | 42 ++
lib/ofp-actions.h |3 +++
2 files changed, 45 insertions(+), 0 deletions(-)
diff --git
Signed-off-by: Isaku Yamahata
---
v4
- squashed goto-table instruction part into single patch
- only introduce goto-table. Other instruction will be addressed
by other patches.
- check zero padding
- man page
- unit test
v3
- introduce OFPACT_{CLEAR_ACTIONS, WRITE_ACTIONS, GOTO_TABLE}
v2
On Tue, Aug 14, 2012 at 10:02:24AM -0700, Ben Pfaff wrote:
> On Thu, Aug 02, 2012 at 12:24:10AM +0900, Isaku Yamahata wrote:
> > This patch introduces helper functions
> > - to cast
> > - to convert from/to text
> >
> > Signed-off-by:
On Tue, Aug 14, 2012 at 09:43:16AM -0700, Ben Pfaff wrote:
> On Thu, Aug 02, 2012 at 12:24:06AM +0900, Isaku Yamahata wrote:
> > When OF11+ only actions is introduced, ofpacts_put_openflow10() will be
> > unable to handle all ofp-actions. So allow it return error in that case.
>
On Tue, Aug 14, 2012 at 09:46:05AM -0700, Ben Pfaff wrote:
> On Thu, Aug 02, 2012 at 12:24:07AM +0900, Isaku Yamahata wrote:
> > When OF1.2+ only actions are introduced,
> > ofpacts_put_openflow11_{actions, instructions}() will be unable to handle
> > all
> > ofp-action
Basically it looks good. One minor comment inline.
On Wed, Aug 15, 2012 at 12:28:47AM +1200, Joe Stringer wrote:
> diff --git a/lib/ofp-actions.h b/lib/ofp-actions.h
> index 272b8e8..a16c04a 100644
> --- a/lib/ofp-actions.h
> +++ b/lib/ofp-actions.h
...
> @@ -311,6 +311,15 @@ struct ofpact_fin_tim
Hi. Right now OVS tells a controller that 256 tables available
as SWITCH_FEATURES response.
(i.e. ofp_switch_features->n_tables = 256 = N_TABLES)
But the table whose id is TBL_INTERNAL = N_TABLES - 1 is used for ovs
internal use so can't be available to a controller.
Addition to the above, the doc
Oops, I meant n_tables = 255, table_id = 254.
So we will report that table_id=254 isn't usable for controllers with OF1.1+.
Thank you for clarification.
thanks,
On Thu, Aug 16, 2012 at 09:18:31AM -0700, Ben Pfaff wrote:
> On Thu, Aug 16, 2012 at 05:16:53PM +0900, Isaku Yamahata wrote
This patch series add tcp socket support to python ovs binding in addition
to unix socket.
Isaku Yamahata (2):
python/ovs/socket_util: add tcp related helper functions which will
be used by tcp
python/ovs/stream: teach stream.py tcp socket
python/ovs/socket_util.py | 40
Signed-off-by: Isaku Yamahata
---
python/ovs/socket_util.py | 40
1 files changed, 40 insertions(+), 0 deletions(-)
diff --git a/python/ovs/socket_util.py b/python/ovs/socket_util.py
index a8e8d92..d05f165 100644
--- a/python/ovs/socket_util.py
+++ b
Signed-off-by: Isaku Yamahata
---
python/ovs/stream.py | 62 +++--
1 files changed, 54 insertions(+), 8 deletions(-)
diff --git a/python/ovs/stream.py b/python/ovs/stream.py
index 9c10612..b8dfe6a 100644
--- a/python/ovs/stream.py
+++ b/python/ovs
eventlet/gevent doesn't work well with select.poll because it blocks.
So ovsdb python binding can't be used with eventlet/gevent.
So monkey patch to select.poll with a function that emulate select.poll
with select.select.
Signed-off-by: Isaku Yamahata
---
python/ovs/poller
On Sun, Aug 26, 2012 at 05:27:24PM -0700, Ben Pfaff wrote:
> On Wed, Aug 22, 2012 at 07:05:39PM +0900, Isaku Yamahata wrote:
> > This patch series add tcp socket support to python ovs binding in addition
> > to unix socket.
>
> At first glance these seem reasonable but I di
On Mon, Aug 27, 2012 at 10:10:13PM -0700, Ben Pfaff wrote:
> On Wed, Aug 22, 2012 at 07:07:05PM +0900, Isaku Yamahata wrote:
> > eventlet/gevent doesn't work well with select.poll because it blocks.
> > So ovsdb python binding can't be used with eventlet/gevent.
> >
on delimiter
thanks,
Isaku Yamahata (6):
lib/ofp-actions: improve ofpact_instruction_name_from_type()
instruction: support goto-table action
ofproto-dpif: refactor rule_dpif_lookup() for table miss whose id > 0
ofproto-dpif: teach goto-table instruction packet-in
instruction/clear-actions
Signed-off-by: Isaku Yamahata
---
v5
- manual rebase
v4
- squashed goto-table instruction part into single patch
- only introduce goto-table. Other instruction will be addressed
by other patches.
- check zero padding
- man page
- unit test
v3
- introduce OFPACT_{CLEAR_ACTIONS, WRITE_ACTIONS
When goto-table instruction results in table miss, generate packet-in event
Signed-off-by: Isaku Yamahata
---
v5
- no change
v4
- manual rebase
v3
- changed for OFPACT_GOTO_ABLE
v2
- minor change to compile
Conflicts:
ofproto/ofproto-dpif.c
---
ofproto/ofproto-dpif.c | 29
Signed-off-by: Isaku Yamahata
---
v5
- manual rebase
v4
- write-action part is split out
- man page
---
lib/ofp-actions.c| 55 +
lib/ofp-actions.h| 11 ++---
lib/ofp-parse.c |6 +---
ofproto/ofproto-dpif.c | 10
eliminate unnecessary loop.
Signed-off-by: Isaku Yamahata
---
v5
- newly introduced
---
lib/ofp-actions.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 0e8b9da..baa6fdd 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp
The refactored function, rule_dpif_miss_rule(), will be used for
handling table miss whose table_id > 0 by goto-table instruction.
Signed-off-by: Isaku Yamahata
---
v5
- no change
v4
- commit message
v3
- no change
v2
- no chnage
---
ofproto/ofproto-dpif.c |
Signed-off-by: Isaku Yamahata
---
v5
- manual rebase
v4
- clear-actions part is split outed.
- check zero padding
- man page
---
lib/ofp-actions.c| 33 ++---
lib/ofp-actions.h| 13 -
lib/ofp-parse.c |5 +
ofproto
On Wed, Aug 29, 2012 at 10:18:59AM -0700, Ben Pfaff wrote:
> On Tue, Aug 28, 2012 at 05:37:06PM +0900, Isaku Yamahata wrote:
> > On Mon, Aug 27, 2012 at 10:10:13PM -0700, Ben Pfaff wrote:
> > > On Wed, Aug 22, 2012 at 07:07:05PM +0900, Isaku Yamahata wrote:
> > > >
On Thu, Aug 30, 2012 at 11:25:25AM -0700, Ben Pfaff wrote:
> On Fri, Aug 31, 2012 at 03:19:57AM +0900, Isaku Yamahata wrote:
> > On Wed, Aug 29, 2012 at 10:18:59AM -0700, Ben Pfaff wrote:
> > > On Tue, Aug 28, 2012 at 05:37:06PM +0900, Isaku Yamahata wrote:
> > > >
On Wed, Aug 29, 2012 at 01:16:55PM -0700, Ben Pfaff wrote:
> On Wed, Aug 29, 2012 at 02:19:05AM +0900, Isaku Yamahata wrote:
> > Signed-off-by: Isaku Yamahata
>
> I don't fully understand the purpose of this patch. Can you say a few
> more words?
If this patch confused
Thank you for review. I'll try to simplify the logic.
Since I don't have strong opinion for textual form, I'll change its
syntax as you suggest.
thanks,
On Tue, Aug 28, 2012 at 09:05:33PM -0700, Ben Pfaff wrote:
> On Wed, Aug 29, 2012 at 02:19:01AM +0900, Isaku Yamahata wrote:
On Thu, Aug 30, 2012 at 12:53:50PM -0700, Ben Pfaff wrote:
> On Fri, Aug 31, 2012 at 03:39:26AM +0900, Isaku Yamahata wrote:
> > On Thu, Aug 30, 2012 at 11:25:25AM -0700, Ben Pfaff wrote:
> > > But I think you might have implied that just switching from "poll" to
&
.poll with select.select because using python means that
performance isn't so important.
Signed-off-by: Isaku Yamahata
---
change v1 -> v2:
- replace select.poll with select.select for simplicity instead of
monkey patching
---
python/ovs/poller.py | 71
.poll with select.select because using python means that
performance isn't so important.
Signed-off-by: Isaku Yamahata
---
changes v2 -> v3:
- minor nit picks
change v1 -> v2:
- replace select.poll with select.select for simplicity instead of
monkey patching
---
python
On Tue, Sep 04, 2012 at 11:04:52PM -0700, Reid Price wrote:
> Seems reasonable. Some notes inline, mostly nits and questions.
Thank you for review.
> +class _SelectSelect(object):
> +""" select.poll emulation by using select.select.
> +Only register and poll are needed at th
This patch series addresses various random issues in ovs python binding.
Please see commit log in each patches for details.
Isaku Yamahata (5):
python/ovs: socket_util uses select.poll
python/ovs/db/idl: counter part of ovsdb_idl_add_table() to
SchemaHelper
python/ovs/db/idl: make
",
"20c2a046-ae7e-4453-a576-11034db24985"]]]}
In the above case, uuid in "row" aren't replaced by "named-uuid" because
the function doesn't look into elements of lists.
When list/tuple is found, look into elements recursively.
Si
This is needed when using schema that was retrieved from ovsdb by get_schema
method.
Signed-off-by: Isaku Yamahata
---
python/ovs/db/idl.py | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py
index c2278ba..7fed0cf
The changeset of ed815d9bd28422a490fe370d7804d24bcd676806 eliminated
the use of select.poll for eventlet/gevent.
It forgot to select.poll in socket_util.
Signed-off-by: Isaku Yamahata
---
python/ovs/poller.py |4 ++--
python/ovs/socket_util.py |3 ++-
2 files changed, 4 insertions
add register_table method to SchemaHelper as counter part of
ovsdb_idl_add_table().
Signed-off-by: Isaku Yamahata
---
python/ovs/db/idl.py |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py
index e4b98e8..c2278ba 100644
etattr(Row instance, attrname, default value) doesn't work.
This occurs when row._changes doesn't include attrname and row._data is None.
So teach Row.__getattr__ _data=None case.
Signed-off-by: Isaku Yamahata
---
python/ovs/db/idl.py |3 +++
tests/ovsdb-idl.at |9 +
tes
On Wed, Sep 12, 2012 at 11:45:12AM -0700, Ben Pfaff wrote:
> On Wed, Sep 12, 2012 at 03:17:22PM +0900, Isaku Yamahata wrote:
> > add register_table method to SchemaHelper as counter part of
> > ovsdb_idl_add_table().
> >
> > Signed-off-by: Isaku Yamahata
>
>
e. for example,
The size of vswitch.ovsschema is 16988 bytes.
Here is the updated one.
>From b26ede3940487d631ed1f2fff296e2bf0120e918 Mon Sep 17 00:00:00 2001
Message-Id:
In-Reply-To:
References:
From: Isaku Yamahata
Date: Wed, 12 Sep 2012 14:35:11 +0900
Subject: [PATCH] python/ovs/db/idl: m
On Wed, Sep 12, 2012 at 08:32:15AM -0700, Reid Price wrote:
> One note inline
>
> On Sep 11, 2555 BE, at 23:17, Isaku Yamahata wrote:
>
> > Since Transaction._substitute doesn't substitute elements of list/tuple,
> > setting list references results in transact
On Wed, Sep 12, 2012 at 08:56:41PM -0700, Ben Pfaff wrote:
> On Thu, Sep 13, 2012 at 11:30:23AM +0900, Isaku Yamahata wrote:
> > From: Isaku Yamahata
> > Date: Mon, 10 Sep 2012 18:21:20 +0900
> > Subject: [PATCH] python/ovs/db/idl.py: Transaction._substitute doesn
need to restart DB / OVS on changing dscp value.
- f125905cdd3dc0339ad968c0a70128807884b400
Allow configuring DSCP on controller and manager connections. 5
Signed-off-by: Isaku Yamahata
---
There still remains an issue of ovsdb-server and vswitchd. When the
setting of dscp is dynamicall
issue by reconnection.
Comments inlined below.
> On Fri, Sep 14, 2012 at 1:56 AM, Isaku Yamahata
> wrote:
>
> Thus ovsdb-client aborts as follows.
>
> > # ovs-vsctl set-manager ptcp:6634
> > # ovsdb-client get-schema tcp:127.0.0.1:6634
> > 2012-
On Fri, Sep 21, 2012 at 01:20:52PM -0700, Mehak Mahajan wrote:
> Hey Isaku,
>
> I apologize. I seem to have misunderstood the intent earlier.
> The patch looks good to me.
>
> Regarding the issue of ovsdb-server and vswitchd, I am more inclined towards
> your second option
> "setsockopt(new dsc
nd
resolves disconnection issues.
Isaku Yamahata (5):
stream-provider: remove stale declaration of stream_set_dscp()
lib/socket-util: export set_dscp()
ovsdb: initialize struct ovsdb_jsonrpc_options::dscp uniformly
lib/pstream: add set_dscp method
ovsdb/jsonrpc-server: ovsdb-server cl
It isn't defined anywhere.
Signed-off-by: Isaku Yamahata
---
lib/stream-provider.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/lib/stream-provider.h b/lib/stream-provider.h
index 0708c72..9e91d61 100644
--- a/lib/stream-provider.h
+++ b/lib/stream-provi
dscp member of struct ovsdb_jsonrpc_options isn't initialized uniformly.
Initialize the member by ovsdb_jsonrpc_default_options uniformly.
Signed-off-by: Isaku Yamahata
---
ovsdb/jsonrpc-server.c |1 +
ovsdb/ovsdb-server.c |1 -
2 files changed, 1 insertions(+), 1 deletions(-)
It will be used later for dynamic dscp change to listening socket.
Signed-off-by: Isaku Yamahata
---
lib/socket-util.c |2 +-
lib/socket-util.h |1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/lib/socket-util.c b/lib/socket-util.c
index 7c40ab8..e32c03d 100644
--- a
Introduce set_dscp method to pstream.
This will be used by dynamic dscp change of listening socket.
Signed-off-by: Isaku Yamahata
---
lib/stream-fd.c | 16 +++-
lib/stream-fd.h |1 +
lib/stream-provider.h |3 +++
lib/stream-ssl.c |8
lib
Allow configuring DSCP on controller and manager connections. 5
Signed-off-by: Isaku Yamahata
---
Changes v1 -> v2:
- addressed listening socket
---
lib/jsonrpc.c | 17 ++-
lib/jsonrpc.h |3 +-
ovsdb/jsonrpc-server.c | 20 ++-
t
On Wed, Sep 26, 2012 at 10:12:29AM -0700, Ben Pfaff wrote:
> On Wed, Sep 26, 2012 at 04:12:07PM +0900, Isaku Yamahata wrote:
> > dscp member of struct ovsdb_jsonrpc_options isn't initialized uniformly.
> > Initialize the member by ovsdb_jsonrpc_default_options uniformly.
&g
27.0.0.1:6634: receive error:
> Connection reset by peer
> ovsdb-client: transaction failed (Connection reset by peer)
This patch series addresses passive method case with DSCP dynamic change and
resolves disconnection issues.
Isaku Yamahata (2):
lib/pstream: add set_dscp method
ovsdb/
Introduce set_dscp method to pstream.
This will be used by dynamic dscp change of listening socket.
Signed-off-by: Isaku Yamahata
---
Changes v2 -> v3:
- eliminated warning
> cc1: warnings being treated as errors
> ../lib/stream.c: In function ��pstream_set_dscp��:
> ../lib/
Allow configuring DSCP on controller and manager connections. 5
Signed-off-by: Isaku Yamahata
---
Changes v2 -> v3:
- bisectability with ovsdb_jsonrpc_default_options()
Changes v1 -> v2:
- addressed listening socket
---
lib/jsonrpc.c | 17 ++-
lib/jsonrpc.h
This patch series add tcp socket support to python ovs binding in addition
to unix socket.
Changes v1 -> v2:
- unit test
Isaku Yamahata (2):
python/ovs/socket_util: add tcp related helper functions which will
be used by tcp
python/ovs/stream: teach stream.py tcp socket
python/
Signed-off-by: Isaku Yamahata
---
Change v1 -> v2:
- typo
---
python/ovs/socket_util.py | 42 ++
1 file changed, 42 insertions(+)
diff --git a/python/ovs/socket_util.py b/python/ovs/socket_util.py
index a978707..845511e 100644
--- a/python/
Signed-off-by: Isaku Yamahata
---
changes v1 -> v2:
- unit test
---
python/ovs/stream.py | 66 ++
tests/ovsdb-idl.at | 22 -
2 files changed, 77 insertions(+), 11 deletions(-)
diff --git a/python/ovs/stream.py b/python/
etattr(Row instance, attrname, default value) doesn't work.
This occurs when row._changes doesn't include attrname and row._data is None.
So teach Row.__getattr__ _data=None case.
Signed-off-by: Isaku Yamahata
---
python/ovs/db/idl.py |3 +++
tests/ovsdb-idl.at |9 +
tes
For stable bridge configuration, sometimes it is desirable to be able to
add-port with port number specified.
This patch implements it and it can be done by setting ofport column of
Interface
table like
ovs-vsctl add-port s1 eth2 -- set Interface eth2 ofport=10
Signed-off-by: Isaku Yamahata
On Mon, Oct 01, 2012 at 11:42:36PM -0700, Justin Pettit wrote:
> On Oct 1, 2012, at 10:08 AM, Ben Pfaff wrote:
>
> > But there's another issue too. As part of the ongoing effort to
> > upstream tunneling to the Linux kernel, Justin is currently reworking
> > how ports are assigned to datapaths.
erate the event when OFPC_LINK_DOWN flag is changed.
Signed-off-by: Isaku Yamahata
---
I can't find any explicit description in the spec about whether to generate
port_status event when OFPC_ flags are changed.
So which way do we like? generate port_status event or not?
Anyway I think port_status even
ction delimiter
thanks,
Isaku Yamahata (2):
instruction: support goto-table action
instruction/clear-actions: string parser/formater, of packet
decoder/encoder
lib/ofp-actions.c| 109 ++-
lib/ofp-actions.h| 28 --
lib/ofp-parse.c
Signed-off-by: Isaku Yamahata
---
v5
- manual rebase
- remove check of zero padding
v4
- clear-actions part is split outed.
- check zero padding
- man page
---
lib/ofp-actions.c| 28 ++--
lib/ofp-actions.h| 13 -
lib/ofp-parse.c
Signed-off-by: Isaku Yamahata
---
v6
- manual rebase
- simplify logic
- remove all zero check
- update unit tests
v5
- manual rebase
v4
- squashed goto-table instruction part into single patch
- only introduce goto-table. Other instruction will be addressed
by other patches.
- check zero
h.org/pipermail/dev/2012-September/021477.html
thanks,
On Thu, Oct 04, 2012 at 11:51:55PM -0700, Mehak Mahajan wrote:
> Hey Isaku,
>
> Thanks for the patch.
> I have applied it to master.
>
> thanx!
> mehak
>
> On Wed, Sep 26, 2012 at 12:12 AM, Isaku Yamahata
> wrote:
&
On Tue, Oct 09, 2012 at 04:08:32PM +0900, Simon Horman wrote:
> +static int push_mpls(struct sk_buff *skb, const struct ovs_action_push_mpls
> *mpls)
> +{
> + u32 l2_size;
> + __be32 *new_mpls_label;
> +
> + if (skb_cow_head(skb, MPLS_HLEN) < 0) {
> + kfree_skb(skb);
> +
On Tue, Oct 09, 2012 at 04:08:33PM +0900, Simon Horman wrote:
> This is to match the kernel implementation in the
> patch "datapath: Add basic MPLS support to kernel"
> by Leo Alterman.
>
> Cc: Leo Alterman
> Signed-off-by: Simon Horman
>
> ---
>
> v2.2
> * No change
>
> v2.1
> * Initial post
On Tue, Oct 09, 2012 at 04:08:35PM +0900, Simon Horman wrote:
> @@ -938,6 +990,15 @@ mf_is_value_valid(const struct mf_field *mf, const union
> mf_value *value)
> case MFF_IPV6_LABEL:
> return !(value->be32 & ~htonl(IPV6_LABEL_MASK));
>
> +case MFF_MPLS_LABEL:
> +return
On Wed, Oct 10, 2012 at 07:31:25PM +0900, Simon Horman wrote:
> On Wed, Oct 10, 2012 at 11:57:15AM +0900, Isaku Yamahata wrote:
> > On Tue, Oct 09, 2012 at 04:08:32PM +0900, Simon Horman wrote:
> > > +static int push_mpls(struct sk_buff *skb, const struct
> > >
On Thu, Oct 11, 2012 at 11:14:40AM +0900, Simon Horman wrote:
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index 5a1d31c..5ffbaef 100644
> --- a/lib/odp-util.c
> +++ b/lib/odp-util.c
...
> @@ -1911,6 +2045,33 @@ commit_vlan_action(const struct flow *flow, struct
> flow *base,
> }
>
> stati
On Fri, Oct 12, 2012 at 09:04:09AM +0900, Simon Horman wrote:
> On Thu, Oct 11, 2012 at 10:10:39PM +0900, Isaku Yamahata wrote:
> > On Thu, Oct 11, 2012 at 11:14:40AM +0900, Simon Horman wrote:
> > > diff --git a/lib/odp-util.c b/lib/odp-util.c
> > > index 5a1d31c..5ff
On Fri, Oct 12, 2012 at 10:24:24AM +0900, Isaku Yamahata wrote:
> On Fri, Oct 12, 2012 at 09:04:09AM +0900, Simon Horman wrote:
> > On Thu, Oct 11, 2012 at 10:10:39PM +0900, Isaku Yamahata wrote:
> > > On Thu, Oct 11, 2012 at 11:14:40AM +0900, Simon Horman wrote:
> >
On Fri, Oct 12, 2012 at 09:26:28AM +0900, Simon Horman wrote:
> Internally a new_cookie value UINT64_MAX is used for
> an OpenFlow 1.2 flow mod whose command is not Add.
> Open Flow 1.2 does not permit adding flows for such commands.
> Also, UINT64_MAX is a prohibited cookie value, and the
> existi
Ping?
What can I do to make progress?
On Fri, Oct 05, 2012 at 03:56:55PM +0900, Isaku Yamahata wrote:
> This patch adds instruction OF11 apply-actions/goto-table supports.
> Write-actions support is on my TODO.
>
> Change v5 -> v6:
> - revised syntax
> - eliminated
Ping? What's the blocker?
If the use of decorator is the issue, I'll rewrite it without decorator.
On Thu, Sep 27, 2012 at 09:20:53AM -0700, Ben Pfaff wrote:
> On Thu, Sep 27, 2012 at 06:28:06PM +0900, Isaku Yamahata wrote:
> > This patch series add tcp socket support to py
0ce1a6b26cf3 Mon Sep 17 00:00:00 2001
Message-Id:
From: Isaku Yamahata
Date: Tue, 16 Oct 2012 06:46:07 +0900
Subject: [PATCH] python/ovs/socket_util: don't use Exception, but ValueError
67656b9ff297f305b3bfcca2868e8e870e108283
used Exception, but it should be more specific error as R
On Mon, Oct 15, 2012 at 02:42:27PM +0900, Simon Horman wrote:
> On Fri, Oct 12, 2012 at 01:05:05PM +0900, Simon Horman wrote:
> > On Fri, Oct 12, 2012 at 10:24:24AM +0900, Isaku Yamahata wrote:
> > > On Fri, Oct 12, 2012 at 09:04:09AM +0900, Simon Horman wrote:
> > > &
On Tue, Oct 16, 2012 at 10:23:05AM -0700, Ben Pfaff wrote:
> On Tue, Oct 02, 2012 at 07:42:12PM +0900, Isaku Yamahata wrote:
> > The following OF packets may produce the wrong result as follows.
> > It depends on how ovs-vswitchd serves OF packets. Sending the OF packets
> >
On Tue, Oct 16, 2012 at 11:08:15AM -0700, Ben Pfaff wrote:
> Do you have any patches out for review right now? I think that I am
> caught up.
No. Thanks.
--
yamahata
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Hi. The patch looks reasonable.
If it isn't used as decorator, returning class is not necessary.
I'll send a patch to fix it.
On Wed, Oct 17, 2012 at 10:04:49AM -0700, Justin Pettit wrote:
> I went ahead and pushed the change, since it was blocking our internal
> testing. Please let me know if
1 - 100 of 215 matches
Mail list logo
