Basically it looks good. One minor comment inline.

On Wed, Aug 15, 2012 at 12:28:47AM +1200, Joe Stringer wrote:
> diff --git a/lib/ofp-actions.h b/lib/ofp-actions.h
> index 272b8e8..a16c04a 100644
> --- a/lib/ofp-actions.h
> +++ b/lib/ofp-actions.h
...
> @@ -311,6 +311,15 @@ struct ofpact_fin_timeout {
>      uint16_t fin_hard_timeout;
>  };
>  
> +/* OFPACT_WRITE_METADATA.
> + *
> + * Used for NXAST_WRITE_METADATA. */
> +struct ofpact_metadata {
> +    struct ofpact ofpact;
> +    uint64_t metadata;
> +    uint64_t mask;
> +};
> +

How about ovs_be64 instead of host endian?
Most other part converts it into network endian.
-- 
yamahata
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to