Re: [ovs-dev] [PATCH 1/2] netdev-windows: fix ofpbuf initialization

2016-11-04 Thread Guru Shetty
On 3 November 2016 at 16:25, Sairam Venugopal wrote: > Guru, > > Any reason why the acked-by doesn’t show up on Patchwork - > https://patchwork.ozlabs.org/patch/687913/ Not sure. Just flaky maybe. I applied this series. Thanks. > > > Thanks, > Sairam > > On 10/27/16, 1:49 PM, "Sairam Venugopa

Re: [ovs-dev] [PATCH 4/5 v2] datapath-windows: clean code in geneve

2016-11-04 Thread Guru Shetty
On 3 November 2016 at 16:27, Sairam Venugopal wrote: > Acked-by: Sairam Venugopal > Applied the first 4 patches of the series. Thanks! > > > On 10/27/16, 11:57 AM, "Alin Serdean" > wrote: > > >The purpose of this patch is to make the code more readable and > >fix a static analyzer warning. >

Re: [ovs-dev] [PATCH 3/3] ovn-northd: SNAT in either direction of gateway router.

2016-11-04 Thread Guru Shetty
On 3 November 2016 at 20:42, Mickey Spiegel wrote: > On Thu, Nov 3, 2016 at 6:06 PM, Guru Shetty wrote: > > > > >> > 2. If a stateful action such as DNAT or LB is taken on a >> > gateway router, such that it is necessary for the reverse >> > pa

Re: [ovs-dev] [PATCH 4/5] debian: Add a package for OVN central components.

2015-12-15 Thread Guru Shetty
On 15 December 2015 at 10:50, Russell Bryant wrote: > On 12/15/2015 12:52 PM, Gurucharan Shetty wrote: > > Signed-off-by: Gurucharan Shetty > > --- > > debian/.gitignore |1 + > > debian/automake.mk |7 > > debian/control

Re: [ovs-dev] [PATCH 1/5] ovn-ctl: Add daemon status functions.

2015-12-16 Thread Guru Shetty
> > > Do you think it's worth breaking out individual statuses this way? > "ovs-ctl status" shows all OVS daemons' status; maybe "ovn-ctl status" > should follow the same pattern. > The reason I chose to break it was because I was splitting ovn-northd and ovn-controller into separate packages with

Re: [ovs-dev] [PATCH 2/5] debian: Add a package for OVN common components.

2015-12-16 Thread Guru Shetty
> > I'm not sure about the dependency on openvswitch-switch. One could run > northd and the nb and sb database on a machine that does not have an > openvswitch switch running; it might even be preferred in a large > deployment. What do you think? > openvswitch-switch has ovs-lib and ovn-ctl depe

Re: [ovs-dev] [PATCH 5/5] debian: Add a package for OVN docker drivers.

2015-12-16 Thread Guru Shetty
On 16 December 2015 at 01:55, Ben Pfaff wrote: > On Tue, Dec 15, 2015 at 09:52:06AM -0800, Gurucharan Shetty wrote: > > Signed-off-by: Gurucharan Shetty > > I think that this is architecture-independent (there's no actual > binaries in it, just Python source), so that it should be Architecture:

Re: [ovs-dev] [PATCH 3/5] debian: Add a package for ovn-controller.

2015-12-16 Thread Guru Shetty
On 16 December 2015 at 01:39, Ben Pfaff wrote: > On Tue, Dec 15, 2015 at 09:52:04AM -0800, Gurucharan Shetty wrote: > > Signed-off-by: Gurucharan Shetty > > I wonder whether the name of this package is well chosen. I know that > the program that it starts is ovn-controller, and I know that that

Re: [ovs-dev] [PATCH 2/5] debian: Add a package for OVN common components.

2015-12-16 Thread Guru Shetty
> > > ovn-ctl assumes ovsdb-server is running locally for ovn-northd right > now. Is ovsdb-server in the -switch package? > > Yes. > -- > Russell Bryant > ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovs-vtep: Clean up local mac entries on startup.

2015-12-21 Thread Guru Shetty
On 21 December 2015 at 12:20, Anupam Chanda wrote: > This change handles a corner case where local mac entries are not cleared > if a > vlan binding is deleted while the emulator is not running. The fix is to > clean > up the local mac entries once on restart. > > Reported-by: Hsin-Yi Shen > Si

Re: [ovs-dev] [PATCH 2/5] debian: Add a package for OVN common components.

2015-12-23 Thread Guru Shetty
On 23 December 2015 at 09:28, Ben Pfaff wrote: > On Wed, Dec 16, 2015 at 07:30:48AM -0800, Guru Shetty wrote: > > > I'm not sure about the dependency on openvswitch-switch. One could run > > > northd and the nb and sb database on a machine that does not have an > &

[ovs-dev] VTEP gateway and OVN workflow

2015-12-23 Thread Guru Shetty
Hello All, I just looked at the OVN workflow for implementing VTEP schema (L2 only) and at first glance it feels wrong. There is possibly a reason for the way it has been implemented, but this is how I see it. The current workflow (from a test case in ovn-controller-vtep.at): 1. In the VTEP GW d

Re: [ovs-dev] VTEP gateway and OVN workflow

2015-12-23 Thread Guru Shetty
On 23 December 2015 at 13:40, Ben Pfaff wrote: > On Wed, Dec 23, 2015 at 01:34:32PM -0800, Guru Shetty wrote: > > I just looked at the OVN workflow for implementing VTEP schema (L2 only) > > and at first glance it feels wrong. There is possibly a reason for the > way > >

Re: [ovs-dev] [PATCH 2/2] support L3 logical router in vtep emulator

2015-12-29 Thread Guru Shetty
I did spend quite some time looking at this code and VTEP schema. The goal for me has been not only to review this piece only for VTEP emulator but also to see the future viability of using this in a L3 edge device for OVN. I feel that it may make sense to step back a bit and rethink the whole arch

Re: [ovs-dev] [PATCH] Update appveyor OpenSSL link

2016-01-04 Thread Guru Shetty
On 4 January 2016 at 05:29, Alin Serdean wrote: > The link of OpenSSL 1_0_2d is no longer available update it to the current > version. > > Signed-off-by: Alin Gabriel Serdean > Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswi

Re: [ovs-dev] [PATCH v2 2/5] debian: Add a package for OVN common components.

2016-01-05 Thread Guru Shetty
> > > > I still think we'll want to get rid of the dependency on > openvswitch-switch, but we can do that later. > > Acked-by: Ben Pfaff > Thanks. I pushed the series. I sent a patch which atleast removes openswitch-switch dependency from ovn-common ___

Re: [ovs-dev] OVS/OVN: Interface with NAT

2016-01-05 Thread Guru Shetty
Amitabha, I am looking at integrating NAT with OVN. I have a use case of Kubernetes. But the modeling should also work with OpenStack. So I would like to know a little bit about your plans around OpenStack + NAT with OVN. So if you are around, ping me at "shettyg" (openvswitch or openstack-neutron

Re: [ovs-dev] [PATCH] debian: Move ovs-lib to openvswitch-common.

2016-01-05 Thread Guru Shetty
On 5 January 2016 at 09:39, Ben Pfaff wrote: > On Tue, Jan 05, 2016 at 09:10:35AM -0800, Gurucharan Shetty wrote: > > ovs-lib is used by both ovs-ctl and ovn-ctl. So it > > is useful to move it to openvswitch-common > > > > Signed-off-by: Gurucharan Shetty > > Acked-by: Ben Pfaff > Applied. th

Re: [ovs-dev] [PATCH] openvswitch-switch.init: Redirect error to /dev/null.

2016-01-05 Thread Guru Shetty
On 5 January 2016 at 11:28, Ben Pfaff wrote: > On Tue, Jan 05, 2016 at 10:18:41AM -0800, Gurucharan Shetty wrote: > > The latest Open vSwitch kernel module from Upstream linux does not > > list "version". During debian package installation, we would see > > a non-harmful error in the log. This pa

Re: [ovs-dev] [PATCH 2/2] bugtool: remove dir path prefix

2016-01-13 Thread Guru Shetty
On 13 January 2016 at 11:36, William Tu wrote: > Remove the hard-coded /usr/share/openvswitch/scripts/ and fetch the path > from @pkgdatadir@. > > Signed-off-by: William Tu > --- > utilities/bugtool/ovs-bugtool.in | 3 ++- > .../bugtool/plugins/network-status/openvswitch.xml

Re: [ovs-dev] [PATCH v2] ovs-bugtool: Add conntrack output

2016-01-14 Thread Guru Shetty
On 13 January 2016 at 15:51, William Tu wrote: > Add a script to show all the connection entries in the tracker. > > Signed-off-by: William Tu > Thank you, applied! > --- > utilities/bugtool/automake.mk | 4 +++- > utilities/bugtool/ovs-bugtool-conntrack-dump

Re: [ovs-dev] [PATCH v2] ovs-bugtool: Add conntrack output

2016-01-14 Thread Guru Shetty
On 14 January 2016 at 09:45, Joe Stringer wrote: > On 14 January 2016 at 09:06, Guru Shetty wrote: > > On 13 January 2016 at 15:51, William Tu wrote: > > > >> Add a script to show all the connection entries in the tracker. > >> > >> Signed-off-by: W

Re: [ovs-dev] Software vtep gw

2016-01-22 Thread Guru Shetty
https://github.com/openvswitch/ovs/blob/master/vtep/README.ovs-vtep.md On 22 January 2016 at 05:06, Na Zhu wrote: > Dear, > > I need to do some experiment about ovn "vtep" schema, does anyone know > software TOR which supports "vtep" schema? > > > > BR > Juno > __

Re: [ovs-dev] [PATCH 1/1] Openvswitch: RHEL: Fix RHEL Spec file for kmod RPM install.

2016-01-28 Thread Guru Shetty
On 28 January 2016 at 05:48, Thomas F Herbert wrote: > Signed-off-by: Thomas F Herbert > The changes that this commit reverts were initially added as part of commit 9c12d2ec7569a12d9. So this commit will break the original fix. > --- > rhel/openvswitch-kmod-rhel6.spec.in | 2 -- > rhel/open

Re: [ovs-dev] [PATCH 1/1] Openvswitch: RHEL: Fix RHEL Spec file for kmod RPM install.

2016-01-28 Thread Guru Shetty
the RPM sources directory and run: """ On 28 January 2016 at 07:58, Thomas F Herbert wrote: > On 1/28/16 10:27 AM, Guru Shetty wrote: > > > > On 28 January 2016 at 05:48, Thomas F Herbert > wrote: > >> Signed-off-by: Thomas F Herbert >> > >

Re: [ovs-dev] [PATCH] rhel: Clarify instructions for RHEL 7.

2016-01-28 Thread Guru Shetty
On 28 January 2016 at 08:46, Russell Bryant wrote: > The rpm build instructions did not clarify what spec files were to be > used for RHEL 7 and its derivatives. Clarify that you're actually > supposed to use the spec files called "fedora" for RHEL 7 right now. > > Update references to Fedora ve

Re: [ovs-dev] [PATCH v2 1/2] vtep: make vtep-ctl support L3 tables.

2016-01-28 Thread Guru Shetty
The code looks fine. But you have removed a page break (^L character). I will re-add it and push it after sometime. On 26 January 2016 at 02:34, Wenyu Zhang wrote: > Add supporting for tables necessary for L3 usage: > Logical_Router > Arp_Sources_Local > Arp_Sources_Remote > > Signed-off-by: We

Re: [ovs-dev] [PATCH v2 2/2] vtep: add logical router related commands.

2016-01-28 Thread Guru Shetty
On 26 January 2016 at 02:35, Wenyu Zhang wrote: > Add logical router related vtep-ctl commands: > vtep-ctl add-lr LR > vtep-ctl del-lr LR > vtep-ctl list-lr > vtep-ctl lr-exists LR > --- > You will need to add your Signed-off-by. You will also need to update the man page: vtep/vtep-ctl.8.in

Re: [ovs-dev] [PATCH] OVN: Support bcast/mcast/unknown from gateway towards HV

2016-01-28 Thread Guru Shetty
You will need to add a commit message to this commit. You will need to add your Signed-off-by. You should also add yourself to the AUTHORS file. Since ovs-vtep is already supposed to work for L2 related things, and has been tested well before, I suggest splitting the change for ovs-vtep into a sep

Re: [ovs-dev] [PATCH] rhel: Make openvswitch-kmod-fedora.spec build.

2016-01-29 Thread Guru Shetty
On 28 January 2016 at 12:46, Russell Bryant wrote: > I tried building this package on Fedora 23 and it failed for a couple of > different reasons. > > This package tried to install modules without specifying the rpm build > root as an install prefix. The result was just attempting to install > t

Re: [ovs-dev] [PATCH] rhel: Clarify instructions for RHEL 7.

2016-01-29 Thread Guru Shetty
> > @@ -74,9 +75,9 @@ $HOME/rpmbuild/SOURCES. > > ``` > rpmbuild -bb \ > - -D "kversion 2.6.32-131.6.1.el6.x86_64" \ > + -D "kversion 4.3.3-300.fc23.x86_64” \ > -D "kflavors default debug kdump" \ > - rhel/openvswitch-kmod-rh

Re: [ovs-dev] [PATCH] rhel: Make openvswitch-kmod-fedora.spec build.

2016-01-29 Thread Guru Shetty
On 29 January 2016 at 11:12, Flavio Leitner wrote: > On Thu, 28 Jan 2016 15:46:03 -0500 > Russell Bryant wrote: > > > I tried building this package on Fedora 23 and it failed for a couple > > of different reasons. > > > > This package tried to install modules without specifying the rpm build > >

Re: [ovs-dev] Revert "ovs-lib: Try to call exit before killing."

2016-02-01 Thread Guru Shetty
On 31 January 2016 at 23:24, Ilya Maximets wrote: > On 29.01.2016 22:02, Guru Shetty wrote: > > This reverts commit 9b5422a98f817b9f2a1f8224cab7e1a8d0bbba1f. > > > > Reason: > > Calling 'ovs-appctl exit' on ovs-vswitchd will cause ovs-vswitchd > > to de

Re: [ovs-dev] [PATCH] datapath-windows: Updated FAQ regarding Hyper-V MPLS.

2016-02-02 Thread Guru Shetty
On 2 February 2016 at 02:43, Sorin Vinturis < svintu...@cloudbasesolutions.com> wrote: > Updated FAQ document to reflect MPLS support for Hyper-V. > > Signed-off-by: Sorin Vinturis > Applied, thanks! > --- > FAQ.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/FAQ.md

Re: [ovs-dev] [PATCH v3 0/2] datapath-windows: MPLS support

2016-02-02 Thread Guru Shetty
On 2 February 2016 at 02:41, Sorin Vinturis < svintu...@cloudbasesolutions.com> wrote: > This patch series adds support for MPLS to the OVS extension. > > Sorin Vinturis (2): > [PATCH v3 1/2] datapath-windows: Support for OVS_KEY_ATTR_MPLS attribute > [PATCH v3 2/2] datapath-windows: Accept MP

Re: [ovs-dev] [PATCH v3] vtep: add logical router related commands.

2016-02-02 Thread Guru Shetty
On 29 January 2016 at 02:22, Wenyu Zhang wrote: > Add logical router related vtep-ctl commands: > vtep-ctl add-lr LR > vtep-ctl del-lr LR > vtep-ctl list-lr > vtep-ctl lr-exists LR > > Signed-off-by: Wenyu Zhang > You will need the following incremental diff --git a/vtep/vtep-ctl.c b/vtep/vtep

Re: [ovs-dev] [PATCH] datapath-windows: fix endless loop on reboot

2016-02-03 Thread Guru Shetty
On 12 January 2016 at 10:00, Alin Serdean wrote: > Testing under 2012 gave some more inisight on an old bug. > > If a PNP event with the value of NetEventSwitchActivate was triggered > we were calling OvsQuerySwitchActivationComplete which does an OID request > to the underlying drivers, however

Re: [ovs-dev] [PATCH] ovs-vswitchd: Preserve datapath ports across graceful shutdown.

2016-02-04 Thread Guru Shetty
On 4 February 2016 at 09:49, Ben Pfaff wrote: > Until now, asking ovs-vswitchd to shut down gracefully, e.g. with > "ovs-appctl exit", would cause it to first remove all the ports from > kernel-based datapaths. This has the unfortunate side effect that IP > addresses on any removed "internal" po

Re: [ovs-dev] [PATCH] build windows: Update OpenSSL download link

2016-02-12 Thread Guru Shetty
On 10 February 2016 at 17:12, Alin Serdean wrote: > This patch updates the appveyor dowload link for OpenSSL prebuilt binaries. > > Signed-off-by: Alin Gabriel Serdean > Applied, thanks! > --- > appveyor.yml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/appve

Re: [ovs-dev] [PATCH 6/6 v3] datapath-windows: Fix HvUpdateNic() to handle name changes

2015-11-25 Thread Guru Shetty
On 25 November 2015 at 12:00, Nithin Raju wrote: > If the name of an internal or external NIC changes, we need to > disconnect the NIC from OVS since the name is the key. In this > change, we generate a link down event. It is as though we got a > call to HvDisconnectNic() for the old name and got

Re: [ovs-dev] [PATCH] docs: Document that --detach disables logging to the console.

2015-12-01 Thread Guru Shetty
On 1 December 2015 at 09:55, Ben Pfaff wrote: > Reported-by: "P.R.Dinesh" > Reported-at: > http://openvswitch.org/pipermail/discuss/2015-December/019567.html > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty > --- > lib/daemon.man | 11 +++ > lib/vlog.man | 4 +++- > 2 file

Re: [ovs-dev] [PATCH] debian: Skip systemctl redirect.

2015-12-01 Thread Guru Shetty
> > > Does this fix #1 or #2 or both? > It fixes #2. It will fix #1 too as long as upstream Ubuntu does not change the sysv script that we provide. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] debian: Skip systemctl redirect.

2015-12-02 Thread Guru Shetty
On 1 December 2015 at 12:00, Ben Pfaff wrote: > On Tue, Dec 01, 2015 at 11:51:34AM -0800, Guru Shetty wrote: > > > > > > > > > Does this fix #1 or #2 or both? > > > > > It fixes #2. It will fix #1 too as long as upstream Ubuntu does not > chang

Re: [ovs-dev] [PATCH] vtep: support L3 logical router E-W traffic in Hardware vtep emulator

2015-12-07 Thread Guru Shetty
On 6 December 2015 at 23:23, Shuangmin Zhang wrote: > Signed-off-by: Shuangmin Zhang > How did you send this patch? Are you able to download this mail and apply it with 'git am'? If not, try sending a mail to yourself with 'git send-email' and then download that mail (if destination is gmail, y

Re: [ovs-dev] [PATCH RFC] ovs-lib: try to call exit before killing

2015-12-15 Thread Guru Shetty
fatal_signal_add_hook() in lib/fatal-signal.c is usually called if you need some function to be called after a signal is received.( I do not have any opinion with the proposed patch itself) On 15 December 2015 at 05:58, Ilya Maximets wrote: > Yes. Tested with last master > 398e182 ("datapath-win

<    1   2   3   4