On 28 January 2016 at 12:46, Russell Bryant <russ...@ovn.org> wrote:
> I tried building this package on Fedora 23 and it failed for a couple of
> different reasons.
>
> This package tried to install modules without specifying the rpm build
> root as an install prefix. The result was just attempting to install
> the modules on the system, which luckily failed since I wasn't running
> rpmbuild as root.
>
> The package also then tried to manually install the modules into the rpm
> build root, which is unnecessary once modules_install is pointed to the
> right place.
>
> Finally, the package build failed with a completely unhelpful error
> which turned out to be because it didn't know how to generate
> a debuginfo pacakge. I turned off the debug package for now. At least
> it builds now, which is an improvement.
>
> Signed-off-by: Russell Bryant <russ...@ovn.org>
>
Acked-by: Gurucharan Shetty <g...@ovn.org>
> ---
> rhel/openvswitch-kmod-fedora.spec.in | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/rhel/openvswitch-kmod-fedora.spec.in b/rhel/
> openvswitch-kmod-fedora.spec.in
> index ecea16c..62e5ce7 100644
> --- a/rhel/openvswitch-kmod-fedora.spec.in
> +++ b/rhel/openvswitch-kmod-fedora.spec.in
> @@ -7,6 +7,8 @@
> # notice and this notice are preserved. This file is offered as-is,
> # without warranty of any kind.
>
> +%global debug_package %{nil}
> +
> #%define kernel 3.1.5-1.fc16.x86_64
> #define kernel %{kernel_source}
> %{?kversion:%define kernel %kversion}
> @@ -39,23 +41,19 @@ make %{_smp_mflags} -C datapath/linux
>
> %install
> rm -rf $RPM_BUILD_ROOT
> -make -C datapath/linux modules_install
> -
> -install -d -m 755
> $RPM_BUILD_ROOT/lib/modules/%{kernel}/kernel/extra/openvswitch
> -find datapath/linux -name *.ko -exec install -m 755 \{\}
> $RPM_BUILD_ROOT/lib/modules/%{kernel}/kernel/extra/openvswitch \;
> +make INSTALL_MOD_PATH=$RPM_BUILD_ROOT -C datapath/linux modules_install
>
> %clean
> rm -rf $RPM_BUILD_ROOT
>
> -%preun
> -
> %post
> # Ensure that modprobe will find our modules.
> depmod %{kernel}
>
> %files
> %defattr(-,root,root)
> -/lib/modules/%{kernel}/kernel/extra/openvswitch/*.ko
> +/lib/modules/%{kernel}/extra/*.ko
> +/lib/modules/%{kernel}/*
>
> %changelog
> * Wed Sep 21 2011 Kyle Mestery <kmest...@cisco.com>
> --
> 2.5.0
>
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
