Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Guru Shetty
On 17 June 2016 at 09:06, Paul Boca wrote: > This series of patches ports the python damons to Windows and > fixes the tests to work on Windows. > There are still some python tests that fail on Windows, from which > some are failing on Linux too. > Are you saying that after applying this patch s

Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Guru Shetty
On 17 June 2016 at 10:07, Paul Boca wrote: > Hi! > > > > *From:* Guru Shetty [mailto:g...@ovn.org] > *Sent:* Friday, June 17, 2016 7:59 PM > *To:* Paul Boca > *Cc:* dev@openvswitch.org > *Subject:* Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on > Wind

Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Guru Shetty
> > *[Paul Boca] openSUSE 13.2 (x86_64)* > > *VERSION = 13.2* > > * CODENAME = Harlequin* > > * I will try also on Ubuntu to see if are ok.* > I haven't heard many people doing development on openSUSE for Open vSwitch. I would suggest installing Ubuntu 14.04 and then installing the following pac

Re: [ovs-dev] [PATCH 00/16] Fix and enable Python tests on Windows

2016-06-17 Thread Guru Shetty
> > > > > Also, we cannot add or enable tests on Windows that we know fails. Is it > hard to get all the python unit tests working in one series? > > *[Paul Boca] I could disable those tests until they are fixed but wanted > to keep them failing and to fix them with a subsequent patch.* > > > Let

Re: [ovs-dev] [PATCH v4] datapath-windows: use ip proto for tunnel port lookup

2016-06-17 Thread Guru Shetty
On 17 June 2016 at 13:16, Alin Serdean wrote: > Thanks for incorporating the comments: > Acked-by: Alin Gabriel Serdean > Applied, thanks guys! > > > -Mesaj original- > > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > > Trimis: Friday, June 17, 2016 8:52 PM > >

Re: [ovs-dev] [PATCH] datapath-windows: comment cleanup and indentation

2016-06-20 Thread Guru Shetty
On 16 June 2016 at 10:17, Nithin Raju wrote: > Signed-off-by: Nithin Raju > Applied. > --- > datapath-windows/ovsext/Flow.c | 20 ++-- > datapath-windows/ovsext/Vxlan.c | 5 - > 2 files changed, 10 insertions(+), 15 deletions(-) > > diff --git a/datapath-windows/ovsext/

Re: [ovs-dev] [PATCH] utilities/ovs-docker: Add support for specifying vlan tag on add-port cal

2016-06-20 Thread Guru Shetty
GATEWAY, MACADDRESS > -and MTU. e.g.: > +prefix length. Optionally, sets a GATEWAY, MACADDRESS, > +MTU, and VLAN. e.g.: > ${UTIL} add-port br-int eth1 c474a0e2830e > --ipaddress=192

Re: [ovs-dev] [PATCH v4] ovn: DNAT and SNAT on a gateway router.

2016-06-21 Thread Guru Shetty
On 20 June 2016 at 19:36, Flaviof wrote: > On Mon, Jun 13, 2016 at 6:45 AM, Gurucharan Shetty wrote: > > > For traffic from physical space to virtual space we need DNAT. > > The DNAT happens in the gateway router and reaches the logical > > port. The return traffic should be unDNATed. > > > > Tr

Re: [ovs-dev] [PATCH v4] ovn: DNAT and SNAT on a gateway router.

2016-06-21 Thread Guru Shetty
On 21 June 2016 at 10:29, Flaviof wrote: > On Tue, Jun 21, 2016 at 10:46 AM, Guru Shetty wrote: > > > > > > > On 20 June 2016 at 19:36, Flaviof wrote: > > > >> On Mon, Jun 13, 2016 at 6:45 AM, Gurucharan Shetty > wrote: > >> > >> >

Re: [ovs-dev] [PATCH] datapath-windows: Remove unused headers from Datapath.c

2016-06-21 Thread Guru Shetty
On 21 June 2016 at 11:09, Sairam Venugopal wrote: > Clean up unused headers in Datapath.c. Found by inspection. > > Signed-off-by: Sairam Venugopal > Applied, thank you! > --- > datapath-windows/ovsext/Datapath.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/datapath-windows/o

Re: [ovs-dev] [PATCH v2] ovs-lib: Keep internal interface ip during upgrade.

2016-06-22 Thread Guru Shetty
On 21 June 2016 at 19:27, Daniele Di Proietto wrote: > Commit 9b5422a98f81("ovs-lib: Try to call exit before killing.") > introduced a problem where internal interfaces are destroyed and > recreated, losing their IP address. > > Commit 9aad5a5a96ba("ovs-vswitchd: Preserve datapath ports across >

Re: [ovs-dev] [PATCH] ovn: Allow IP packets destined to router ip for SNAT

2016-06-22 Thread Guru Shetty
On 21 June 2016 at 18:36, Chandra S Vejendla wrote: > By default all the ip traffic destined to router ip is dropped in > lr_in_ip_input stage. When the router ip is used as snat ip, allow > reverse snat traffic destined to the router ip. > > Signed-off-by: Chandra Sekhar Vejendla > Thank you f

Re: [ovs-dev] [PATCH] ovn: Allow IP packets destined to router ip for SNAT

2016-06-22 Thread Guru Shetty
On 22 June 2016 at 10:15, Chandra Sekhar Vejendla wrote: > > Hi Guru, > > I am fine with the changes. You can go ahead and apply them. > Thank you, applied! > > Thanks, > Chandra > > Guru Shetty wrote on 06/22/2016 09:39:17 AM: > > > From: Guru Shet

Re: [ovs-dev] [PATCH] debian: Fix upgrade from OVS-2.5 to newer OVS.

2016-06-22 Thread Guru Shetty
On 17 June 2016 at 12:42, Joe Stringer wrote: > Commit 0dcc739e7a28 ("debian: Move ovs-lib to openvswitch-common.") > shifted a file between debian packages, but didn't update the > destination package annotations to indicate that it replaces a file > from earlier versions of the source package.

Re: [ovs-dev] [PATCH v1] Add new column compute_types to OVN_Southbound

2016-06-22 Thread Guru Shetty
On 21 June 2016 at 12:20, Amitabha Biswas wrote: > This patch allows a OVN hypervisor administator to specify the > type(s) of non-distributed logical port, the hypervisor would > prefer to support. > > In some cloud deployments such as OpenStack, the operator may want > to dedicate certain hyper

Re: [ovs-dev] [PATCH] datapath-windows: Rename local variable in Vport.c

2016-06-23 Thread Guru Shetty
On 22 June 2016 at 13:50, Sairam Venugopal wrote: > Declaration of 'event' hides previous local declaration. Rename this to > evt. The other variable wasn't being used. > > Signed-off-by: Sairam Venugopal > Applied, thanks! > --- > datapath-windows/ovsext/Vport.c | 14 +++--- > 1 file

Re: [ovs-dev] [PATCH v2] ovn-northd, tests: Adding IPAM to ovn-northd.

2016-06-24 Thread Guru Shetty
On 23 June 2016 at 14:55, Nimay Desai wrote: > Added an IPv4 and MAC addresses management system to ovn-northd. When a > logical > switch's options:subnet field is set, logical ports attached to that switch > that do not have a MAC/IPv4 address will automatically be allocated a > globally > uniqu

Re: [ovs-dev] [PATCH v4] datapath-windows: Add GRE checksum

2016-06-24 Thread Guru Shetty
On 24 June 2016 at 10:55, Nithin Raju wrote: > -Original Message- > From: dev on behalf of Alin Serdean > > Date: Friday, June 17, 2016 at 1:00 PM > To: "dev@openvswitch.org" > Subject: [ovs-dev] [PATCH v4] datapath-windows: Add GRE checksum > > >This patch introduces GRE checksum comp

Re: [ovs-dev] [PATCH] tests: Fixed ovsdb-monitor tests

2016-06-24 Thread Guru Shetty
On 24 June 2016 at 09:51, Paul Boca wrote: > Redirect ovsdb-client stderr to /dev/null. > This fixes the series of tests:1770 1771 1772 1773 1774 1775 1776 1777 > 1778 1779 1780 > > Signed-off-by: Paul-Daniel Boca > --- > tests/ovsdb-monitor.at | 5 +++-- > 1 file changed, 3 insertions(+), 2 de

Re: [ovs-dev] [PATCH v8][PATCH 1/2] datapath-windows: Add Geneve support

2016-06-24 Thread Guru Shetty
On 24 June 2016 at 11:49, Yin Lin wrote: > Signed-off-by: Yin Lin > is this just a rebase for the patch that Nithin Acked? > --- > datapath-windows/automake.mk | 2 + > datapath-windows/ovsext/Actions.c | 72 ++- > datapath-windows/ovsext/Debug.h| 1 + > datapa

Re: [ovs-dev] [PATCH] datapath-windows: Remove double semi-colon(; ) in Tunnel.c

2016-06-24 Thread Guru Shetty
On 24 June 2016 at 14:19, Sairam Venugopal wrote: > Found by inspection. > > Signed-off-by: Sairam Venugopal > Applied, thanks! > --- > datapath-windows/ovsext/Tunnel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/datapath-windows/ovsext/Tunnel.c > b/datapath-windo

Re: [ovs-dev] [PATCH v10][PATCH 1/2] datapath-windows: Add Geneve support

2016-06-24 Thread Guru Shetty
On 24 June 2016 at 14:44, Yin Lin wrote: > Signed-off-by: Yin Lin > Thank you. I added Nithin's Ack and applied it. Is the second patch of this series reviewed? > --- > datapath-windows/automake.mk | 2 + > datapath-windows/ovsext/Actions.c | 72 ++- > datapath-windows/o

Re: [ovs-dev] [PATCH 2/2] datapath-windows: Address minor alignment issues in Stt code.

2016-06-24 Thread Guru Shetty
On 24 June 2016 at 14:57, Nithin Raju wrote: > Acked-by: Nithin Raju > Thank you, applied! > > -Original Message- > From: dev on behalf of Yin Lin > > Date: Friday, June 24, 2016 at 2:44 PM > To: "dev@openvswitch.org" > Cc: Yin Lin > Subject: [ovs-dev] [PATCH 2/2] datapath-windows:

Re: [ovs-dev] [PATCH V5] datapath-windows: Handle possible NULL pointer dereference in STT

2016-06-27 Thread Guru Shetty
On 23 June 2016 at 02:16, Paul Boca wrote: > Check if OvsAllocatememoryWithTag succeeded or not. > In case of failure propagate cleanup and return. > > Signed-off-by: Paul-Daniel Boca > Acked-by: Sairam Venugopal > v5 does not apply on master. Can you please rebase. > --- > V2: Checked also

Re: [ovs-dev] [PATCH] tests: Fixed ovsdb-monitor tests

2016-06-27 Thread Guru Shetty
On 24 June 2016 at 09:51, Paul Boca wrote: > Redirect ovsdb-client stderr to /dev/null. > This fixes the series of tests:1770 1771 1772 1773 1774 1775 1776 1777 > 1778 1779 1780 > Please don't mention the test numbers in the commit messages. The test numbers change when new tests are added. So i

Re: [ovs-dev] [PATCH V6] datapath-windows: Handle possible NULL pointer dereference in STT

2016-06-27 Thread Guru Shetty
On 27 June 2016 at 13:44, Paul Boca wrote: > Check if OvsAllocatememoryWithTag succeeded or not. > In case of failure propagate cleanup and return. > > Signed-off-by: Paul-Daniel Boca > Acked-by: Sairam Venugopal > Applied, thank you! > --- > V2: Checked also NdisGetDataBuffer and MmGetSystem

Re: [ovs-dev] [PATCH] datapath-windows: Conntrack - Fix variable initialization

2016-06-27 Thread Guru Shetty
On 27 June 2016 at 11:26, Nithin Raju wrote: > >>-Original Message- > >>From: dev on behalf of Sairam Venugopal > >> > >>Date: Friday, June 24, 2016 at 6:16 PM > >>To: "dev@openvswitch.org" > >>Subject: [ovs-dev] [PATCH] datapath-windows: Conntrack - Fix > >>variable initialization

Re: [ovs-dev] [PATCH V4 17/20] ovs-ofctl.at: Prevent msys from getting confused with ipv6 address.

2016-06-28 Thread Guru Shetty
On 26 June 2016 at 05:12, Paul Boca wrote: > msys converts ::0/0 into ;c:\MinGW\msys\1.0\1. > > To prevent this, use fullform ipv6 address of the form 0:0:0:0:0:0:0:1 > instead. > Isn't the fullform of ::0/0 0:0:0:0:0:0:0:0/0 and not 0:0:0:0:0:0:0:1/0 ? > > Signed-off-by: Paul-Daniel Boca > -

Re: [ovs-dev] [PATCH V4 01/20] tests: Fixed PMD tests on Windows

2016-06-28 Thread Guru Shetty
On 26 June 2016 at 05:12, Paul Boca wrote: > CHECK_CPU_DISCOVERED check the log file now, not the stderr. > On Windows the ovs-vswitchd output is logged only in log file, not to > stderr. > Tested both on Windows and Linux > > Signed-off-by: Paul-Daniel Boca > Thank you, applied. The tests the i

Re: [ovs-dev] [PATCH V4 17/20] ovs-ofctl.at: Prevent msys from getting confused with ipv6 address.

2016-06-28 Thread Guru Shetty
ot worry about sending new versions. If you keep them in a different series as the python ones, it will catch more attention. > > > Thanks, > > Paul > > > > *From:* Guru Shetty [mailto:g...@ovn.org] > *Sent:* Tuesday, June 28, 2016 5:48 PM > *To:* Paul Boca > *Cc:* d

[ovs-dev] ovsdb-server replication bug?

2016-06-28 Thread Guru Shetty
Paul was trying to track down a unit test failure on Windows wherein ovsdb-server was not responding to 'ovs-appctl exit' calls. The second ovsdb-server was stuck in the following loop: http://paste.openstack.org/show/EZOHoRAEsjMCFNFZQIgB/ Thanks, Guru ___

Re: [ovs-dev] [PATCH] dpctl test: Ignore vlog rate limit warning

2016-06-28 Thread Guru Shetty
On 28 June 2016 at 13:16, Paul Boca wrote: > The message "Dropped 1 log messages in the last ..." makes this test fail. > > Signed-off-by: Paul-Daniel Boca > This looks reasonable. I applied this. > --- > tests/dpctl.at | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --gi

Re: [ovs-dev] [PATCH v3] ovn-northd, tests: Adding IPAM to ovn-northd.

2016-06-29 Thread Guru Shetty
On 29 June 2016 at 13:53, Nimay Desai wrote: > Added an IPv4 and MAC addresses management system to ovn-northd. When a > logical > switch's options:subnet field is set, logical ports attached to that switch > that do not have a MAC/IPv4 address will automatically be allocated a > globally > uniqu

Re: [ovs-dev] [PATCH 2/7] ovn-northd.8: Update documentation.

2016-06-30 Thread Guru Shetty
On 29 June 2016 at 21:08, Zong Kai LI wrote: > > > > - Ingress table 3 prepares flows for possible stateful ACL > processing > > - in table 4. It contains a priority-0 flow that simply moves > > - traffic to table 4. If stateful ACLs are used in the logical > > - datapath, a

Re: [ovs-dev] [PATCH 3/7] ovn-northd: Introduce pre-stateful table.

2016-06-30 Thread Guru Shetty
On 30 June 2016 at 01:33, Zong Kai LI wrote: > > > > @@ -1377,13 +1381,34 @@ build_pre_acls(struct ovn_datapath *od, struct > > hmap *lflows, > > * > > * Regardless of whether the ACL is "from-lport" or "to-lport", > > * we need rules in both the ingress and egress t

Re: [ovs-dev] [PATCH 4/7] ovn-northd: Introduce stateful table.

2016-06-30 Thread Guru Shetty
On 30 June 2016 at 01:41, Zong Kai LI wrote: > > > > @@ -1429,9 +1432,9 @@ build_acls(struct ovn_datapath *od, struct hmap > > *lflows) > > * and then its return traffic would not have an associated > > * conntrack entry and would return "+invalid". */ > > ovn_lflow_a

Re: [ovs-dev] [PATCH 7/7] ovn-northd: Logical flows for load balancers.

2016-07-01 Thread Guru Shetty
> > > So the only case to make pre_lb tables are necessary is, logical switch > doesn't contain an "allow-related" action ACL rule. It seems possible, but > I cannot figure out why people choose to not using "allow-related" action, > that will make ACL table hard to maintain. > That is a bad assum

Re: [ovs-dev] [PATCH 5/7] ovn-nb: Add Load-balancer table to schema.

2016-07-01 Thread Guru Shetty
On 1 July 2016 at 01:21, Zong Kai LI wrote: > Hi, Guru. > > > > + > > + > > + Each row represents one load balancer. > > + > > + > > + > > + > > +A map of virtual IPv4 addresses (and an optional port number > > separated > > +by :) associated with this loa

Re: [ovs-dev] [PATCH] datapath-windows: Cleanup conntrack-tcp.c

2016-07-01 Thread Guru Shetty
On 30 June 2016 at 16:18, Nithin Raju wrote: > >>On 6/24/16, 6:14 PM, "Sairam Venugopal" wrote: > >> > >>>Update the code to use tcp->flags. This keeps the kernel conntrack-tcp.c > >>>file in sync with userspace version. > >>> > >>>This patch also addresses an warning - 'Comparison of a boolean

Re: [ovs-dev] [PATCH 1/2] ovn-nbctl: Ability to update a route's output port.

2016-07-01 Thread Guru Shetty
On 1 July 2016 at 14:19, Ben Pfaff wrote: > On Fri, Jul 01, 2016 at 03:23:38AM -0700, Gurucharan Shetty wrote: > > The command 'lr-route-add' currently cannot update the output > > port. > > > > Signed-off-by: Gurucharan Shetty > > Our other "add" commands that take "--may-exist" insist that the

Re: [ovs-dev] [PATCH 2/2] ovn: Add a case of policy based routing.

2016-07-01 Thread Guru Shetty
On 1 July 2016 at 14:36, Ben Pfaff wrote: > On Fri, Jul 01, 2016 at 03:23:39AM -0700, Gurucharan Shetty wrote: > > OVN currently supports multiple gateway routers (residing on > > different chassis) connected to the same logical topology. > > > > When external traffic enters the logical topology,

Re: [ovs-dev] [PATCH v5 00/11] Windows: Add support for debugging conntrack from userspace

2016-07-01 Thread Guru Shetty
On 1 July 2016 at 13:54, Nithin Raju wrote: > Good job with all the patches! I believe I have acked all of them. Thanks > for addressing all the comments. > > I applied the series, thank you! > -Original Message- > From: dev on behalf of Sairam Venugopal > > Date: Friday, July 1, 201

Re: [ovs-dev] [PATCH 2/2] ovn: Add a case of policy based routing.

2016-07-02 Thread Guru Shetty
On 1 July 2016 at 14:36, Ben Pfaff wrote: > On Fri, Jul 01, 2016 at 03:23:39AM -0700, Gurucharan Shetty wrote: > > OVN currently supports multiple gateway routers (residing on > > different chassis) connected to the same logical topology. > > > > When external traffic enters the logical topology,

Re: [ovs-dev] [PATCH 4/7] ovn-northd: Introduce stateful table.

2016-07-03 Thread Guru Shetty
On 2 July 2016 at 21:42, Ben Pfaff wrote: > On Wed, Jun 29, 2016 at 01:17:08AM -0700, Gurucharan Shetty wrote: > > Currently, the only use of stateful services in conntrack is > > OVN ACLs. In table ACL, we commit the packet to conntrack > > via ct_commit action. > > > > As we introduce more stat

Re: [ovs-dev] [PATCH 6/7] ovn-controller: Add support for load balancing.

2016-07-03 Thread Guru Shetty
On 3 July 2016 at 10:23, Ben Pfaff wrote: > On Wed, Jun 29, 2016 at 01:17:10AM -0700, Gurucharan Shetty wrote: > > ovn-controller now supports 2 new logical actions. > > > > 1. ct_lb; > > Sends the packet through the conntrack zone to NAT > > packets. Packets that are part of established connecti

Re: [ovs-dev] [PATCH 7/7] ovn-northd: Logical flows for load balancers.

2016-07-03 Thread Guru Shetty
On 3 July 2016 at 10:24, Ben Pfaff wrote: > On Wed, Jun 29, 2016 at 01:17:11AM -0700, Gurucharan Shetty wrote: > > This commit adds a 'pre_lb' table that sits before 'pre_stateful' table. > > For packets that need to be load balanced, this table sets reg0[0] > > to act as a hint for the pre-state

Re: [ovs-dev] [PATCH 7/7] ovn-northd: Logical flows for load balancers.

2016-07-05 Thread Guru Shetty
On 5 July 2016 at 07:31, Zong Kai LI wrote: > Hi, Ben and Guru. I tried to test lb feature on my OpenStack env, but > failed. > The simplest topology, three VMs(cirros) and VIP are on the same switch. > VM2 and VM3 are endpoints for the VIP. > I tried to use ping and ssh to test VIP, but things d

Re: [ovs-dev] [PATCH 7/7] ovn-northd: Logical flows for load balancers.

2016-07-05 Thread Guru Shetty
On 5 July 2016 at 07:31, Zong Kai LI wrote: > Hi, Ben and Guru. I tried to test lb feature on my OpenStack env, but > failed. > The simplest topology, three VMs(cirros) and VIP are on the same switch. > VM2 and VM3 are endpoints for the VIP. > I tried to use ping and ssh to test VIP, but things d

Re: [ovs-dev] [PATCH] OVN: Fix ARP request flow in router ingress table

2016-07-05 Thread Guru Shetty
On 4 July 2016 at 06:53, Chandra S Vejendla wrote: > TPA in arp requests generated for unknown MAC-to-IP bindings is currently > set > to DST_IP of the original packet. These arps will not be resolved when the > DST_IP is rechable via the default gateway. This patch fixes the issue by > setting t

Re: [ovs-dev] [PATCH] OVN: Fix ARP request flow in router ingress table

2016-07-05 Thread Guru Shetty
> > >> > The documentation explains where 'reg0' comes from. I think it makes sense > to also say where 'reg0' is populated. > > Sorry, I meant "The documentation explains where 'reg1' comes from." > > > >> diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c >> index f4b4435..afcd7fd 1

Re: [ovs-dev] [PATCH V6 17/17] vlog test: Disable default syslog logger

2016-07-06 Thread Guru Shetty
On 6 July 2016 at 05:38, Paul Boca wrote: > Disable the syslog logger in case on Windows, '/dev/log' doesn't exist. > Seems like on Python34 a default handler is added to the logger and it > prints > even if no handler is set by us. > > Signed-off-by: Paul-Daniel Boca > --- > V3: Initial commit

Re: [ovs-dev] [PATCH] vlog.py: Remove redundant setLevel() if "/dev/log" doesn't exist

2016-07-06 Thread Guru Shetty
On 6 July 2016 at 16:41, Daniele Di Proietto wrote: > Also update a comment. > > Signed-off-by: Daniele Di Proietto > Acked-by: Gurucharan Shetty > --- > python/ovs/vlog.py | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/python/ovs/vlog.py b/python/ovs/vlog.py >

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

2016-07-07 Thread Guru Shetty
On 6 July 2016 at 18:37, Darrell Ball wrote: > Patched datapaths that are no longer referenced should be removed from > the patched_datapaths map; otherwise incorrect state references for a > patched datapath may be used and also datapaths that are absent will be > interpreted as present. > > Sig

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

2016-07-07 Thread Guru Shetty
On 7 July 2016 at 14:15, Darrell Ball wrote: > On Thu, Jul 7, 2016 at 1:17 PM, Russell Bryant wrote: > > > > > > > On Wed, Jul 6, 2016 at 8:37 PM, Darrell Ball wrote: > > > >> Patched datapaths that are no longer referenced should be removed from > >> the patched_datapaths map; otherwise incorr

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

2016-07-07 Thread Guru Shetty
> > > > I don't testcases for OVN NAT at all - did I miss them ? > How can a feature be committed without testcases ? > We currently do not have NAT in userspace datapath to test OVN NAT. I think this is the same case with OVN firewall. Both of them are currently dependent on OpenStack testing. We

Re: [ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back in a router.

2016-07-07 Thread Guru Shetty
On 7 July 2016 at 20:30, Mickey Spiegel wrote: > >To: dev@openvswitch.org > >From: Gurucharan Shetty > >Sent by: "dev" > >Date: 07/05/2016 11:15AM > >Subject: [ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back in a > router. > > > >Currently, when a client looks at a load balancer VIP, > >it

Re: [ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back in a router.

2016-07-07 Thread Guru Shetty
On 7 July 2016 at 21:28, Guru Shetty wrote: > > > On 7 July 2016 at 20:30, Mickey Spiegel wrote: > >> >To: dev@openvswitch.org >> >From: Gurucharan Shetty >> >Sent by: "dev" >> >Date: 07/05/2016 11:15AM >> >Subject: [o

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

2016-07-07 Thread Guru Shetty
> > > > Its worrisome to have features that cannot be properly tested. > I suggest to prioritize the test support. > No testability -> No feature > That is fair. I am working on adding OVN tests to system-traffic.at so that I can add NAT related tests. > > > > > > > > > >> > >> > >> > >> > > >> >

Re: [ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back in a router.

2016-07-08 Thread Guru Shetty
> On Jul 7, 2016, at 10:36 PM, Mickey Spiegel wrote: > > -Guru Shetty wrote: - > >> To: Mickey Spiegel/San Jose/IBM@IBMUS >> From: Guru Shetty >> Date: 07/07/2016 09:34PM >> Cc: ovs dev >> Subject: Re: [ovs-dev] [PATCH 1/2] ovn-n

Re: [ovs-dev] [PATCH 2/2] ovn-controller: Change strategy for gateway conntrack zone allocation.

2016-07-08 Thread Guru Shetty
On 8 July 2016 at 10:51, Ryan Moats wrote: > "dev" wrote on 07/08/2016 02:38:06 AM: > > > From: Gurucharan Shetty > > To: dev@openvswitch.org > > Date: 07/08/2016 12:36 PM > > Subject: [ovs-dev] [PATCH 2/2] ovn-controller: Change strategy for > > gateway conntrack zone allocation. > > Sent by:

Re: [ovs-dev] Stateful Conntrack & NAT Requirements

2016-07-08 Thread Guru Shetty
On 8 July 2016 at 13:46, Arvinderpal Wander wrote: > Hi guys, > > I wanted to get started with the new CT and NAT functionality. I followed > the following discussion that was posted earlier: > > http://openvswitch.org/pipermail/dev/2016-May/070576.html > > I had a couple of questions: > 1. Is it

Re: [ovs-dev] [PATCH v2] ovn-controller: Change strategy for gateway conntrack zone allocation.

2016-07-09 Thread Guru Shetty
On 8 July 2016 at 16:10, Ryan Moats wrote: > "dev" wrote on 07/08/2016 06:27:03 AM: > > > From: Gurucharan Shetty > > To: dev@openvswitch.org > > Date: 07/08/2016 04:25 PM > > Subject: [ovs-dev] [PATCH v2] ovn-controller: Change strategy for > > gateway conntrack zone allocation. > > Sent by: "

Re: [ovs-dev] [patch_v3] ovn: Remove unreferenced patched datapaths.

2016-07-09 Thread Guru Shetty
On 8 July 2016 at 16:09, Ryan Moats wrote: > "dev" wrote on 07/07/2016 09:26:06 PM: > > > From: Darrell Ball > > To: dlu...@gmail.com, d...@openvswitch.com > > Date: 07/07/2016 09:14 PM > > Subject: [ovs-dev] [patch_v3] ovn: Remove unreferenced patched datapaths. > > Sent by: "dev" > > > > Pat

Re: [ovs-dev] [PATCH] system-traffic: Use NC_EOF_OPT in truncate tests.

2016-07-11 Thread Guru Shetty
On 11 July 2016 at 10:29, Joe Stringer wrote: > NC_EOF_OPT should always be passed to netcat in system-traffic tests > when invoking netcat to send a single packet that does not expect a > response. While on typical fedora/RH based distributions the default > behaviour is to send the packet then

Re: [ovs-dev] [PATCH] system-traffic: Use NC_EOF_OPT in truncate tests.

2016-07-11 Thread Guru Shetty
On 11 July 2016 at 11:41, Andy Zhou wrote: > > > On Mon, Jul 11, 2016 at 11:28 AM, Guru Shetty wrote: > >> On 11 July 2016 at 10:29, Joe Stringer wrote: >> >> > NC_EOF_OPT should always be passed to netcat in system-traffic tests >> > when invoking ne

Re: [ovs-dev] [PATCH] system-traffic: Use NC_EOF_OPT in truncate tests.

2016-07-11 Thread Guru Shetty
On 11 July 2016 at 11:50, Andy Zhou wrote: > On Mon, Jul 11, 2016 at 11:44 AM, Guru Shetty wrote: > > > > > > > On 11 July 2016 at 11:41, Andy Zhou wrote: > > > >> > >> > >> On Mon, Jul 11, 2016 at 11:28 AM, Guru Shetty wrote:

Re: [ovs-dev] Can logical router be configured in vtep?

2016-02-26 Thread Guru Shetty
On 26 February 2016 at 05:25, Na Zhu wrote: > Hi all, > > I see there is patch about configure logical router in vtep ( > http://openvswitch.org/pipermail/dev/2016-February/065473.html), can > anyone tell me what it is used for and how to use it? Does is used for > routing between physical netwo

Re: [ovs-dev] [RFC 0/8] OVN east-west loadbalancing.

2016-02-29 Thread Guru Shetty
On 28 February 2016 at 22:33, Gurucharan Shetty wrote: > This series adds support for OVN loadbalancing. This is very > lightly tested (with a very simple OVN topology of 1 router > and 2 lswitches), but the patches are far enough to get any > early feedback. > > The patches were tested on Linux

Re: [ovs-dev] [PATCH 3/3] Handle tunnel set changes for BUM traffic in the vtep emulator

2016-03-02 Thread Guru Shetty
On 12 February 2016 at 17:12, Darrell Ball wrote: > Signed-off-by: Darrell Ball > Other than Russell's comments: Please add a descriptive comment on the problem and your solution. I was looking at a p0 bug with ovs-vtep recently and I couldn't understand why something was changed (by myself).

Re: [ovs-dev] [PATCH 1/3] VTEP Schema - Support mcast macs remote table updates

2016-03-04 Thread Guru Shetty
On 12 February 2016 at 17:12, Darrell Ball wrote: > Signed-off-by: Darrell Ball > --- > AUTHORS| 1 + > ovn/controller-vtep/vtep.c | 207 > - > 2 files changed, 186 insertions(+), 22 deletions(-) > > diff --git a/AUTHORS b/AUTHOR

Re: [ovs-dev] [PATCH 2/3] Enable some existing OVN BUM tests

2016-03-04 Thread Guru Shetty
On 3 March 2016 at 11:08, Darrell Ball wrote: > Resending, as patches are visible in the mailing list archive, but not > actually received by all > > > > > > > > On 2/12/16, 5:12 PM, "Darrell Ball" wrote: > > >Signed-off-by: Darrell Ball > Acked-by: Gurucharan Shetty > >--- > > tests/ovn.at

Re: [ovs-dev] [RFC 8/8] ovn-controller: Handle logical flows of loadbalancers.

2016-03-15 Thread Guru Shetty
On 15 March 2016 at 11:32, Ben Pfaff wrote: > On Sun, Feb 28, 2016 at 10:33:24PM -0800, Gurucharan Shetty wrote: > > Signed-off-by: Gurucharan Shetty > Thank you for looking through the series. I agree with all your comments so far in the series and I will get them right in the non-RFC series.

Re: [ovs-dev] Update on OVN east-west loadbalancing.

2016-03-19 Thread Guru Shetty
> > > I gave this patch series a test drive this morning, but I'm seeing a > failure on > the 3HVs, 1LS, 3 lports/HV end to end OVN test case. I *think* it's > coming from this rule: > A Loadbalancer VIP is usually in a subnet different than the logical switch. Since I do not see a router in your

Re: [ovs-dev] Update on OVN east-west loadbalancing.

2016-03-19 Thread Guru Shetty
On 17 March 2016 at 08:56, Ryan Moats wrote: > Guru Shetty wrote on 03/17/2016 09:56:08 AM: > > > From: Guru Shetty > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: ovs dev > > Date: 03/17/2016 09:56 AM > > Subject: Re: [ovs-dev] Update on OVN east-west loadbala

Re: [ovs-dev] [PATCH] ovs-vtep: Delete flows with untagged vlan carefully.

2016-03-20 Thread Guru Shetty
On 15 March 2016 at 07:13, Ryan Moats wrote: > > Original Message > > A (physical port + vlan) or (physical port + no tag) can be bound to a > > logical switch. When one unbinds (physical port + no tag) from a logical > > switch, the emulator inadvertantly deletes flows for (physical po

Re: [ovs-dev] [PATCH v3 2/3] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-03-21 Thread Guru Shetty
On 21 March 2016 at 07:54, Russell Bryant wrote: > Update the "ct_commit;" logical flow action to optionally take > one or two parameters, setting the value of "ct_mark" or "ct_label". > Supported ct_commit syntax now includes: > > ct_commit; > ct_commit(); > ct_commit(ct_mark=1); >

Re: [ovs-dev] [PATCH v3 2/3] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-03-22 Thread Guru Shetty
On 21 March 2016 at 16:40, Russell Bryant wrote: > On Mon, Mar 21, 2016 at 11:23 AM, Russell Bryant wrote: > >> >> >> On Mon, Mar 21, 2016 at 11:16 AM, Guru Shetty wrote: >> >>> >>> >>> On 21 March 2016 at 07:54, Russell Bryant wrote

Re: [ovs-dev] [PATCH v3 2/3] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-03-22 Thread Guru Shetty
On 22 March 2016 at 08:33, Russell Bryant wrote: > On Tue, Mar 22, 2016 at 11:22 AM, Guru Shetty wrote: > > > > > > > On 21 March 2016 at 16:40, Russell Bryant wrote: > > > >> On Mon, Mar 21, 2016 at 11:23 AM, Russell Bryant > wrote: > >>

Re: [ovs-dev] [PATCH v3 2/3] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-03-22 Thread Guru Shetty
On 22 March 2016 at 12:55, Russell Bryant wrote: > > > On Tue, Mar 22, 2016 at 11:49 AM, Guru Shetty wrote: >> >> Macro was probably wrong use of word. I mean to say, something like (very >> crude): ct_commit(ct_label=MARK_FOR_DELETION) >> >> And you ar

Re: [ovs-dev] [PATCH v3 2/3] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-03-22 Thread Guru Shetty
> > >> >> So with the LB series, I need to store the value of ct_label and ct_mark >> in a register and then load it from there when I finally do ct_commit. >> ct_label is 32 bits or one register and ct_mark is 128 bits or 4 registers >> for a total of 5 registers. We do not have that many register

Re: [ovs-dev] [PATCH v3 2/3] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-03-23 Thread Guru Shetty
On 23 March 2016 at 12:32, Russell Bryant wrote: > > > On Tue, Mar 22, 2016 at 5:57 PM, Guru Shetty wrote: > >> >>>> >>>> So with the LB series, I need to store the value of ct_label and >>>> ct_mark in a register and then load it from there

Re: [ovs-dev] [PATCH] rhel: Packaging for OVN is split as per functionality

2016-03-24 Thread Guru Shetty
On 16 March 2016 at 19:17, Russell Bryant wrote: > > > On Wed, Mar 9, 2016 at 10:23 PM, wrote: > >> rhel packaging for OVN is split to host(controller), central(northd), >> common(command line utilities) and docker(docker network plugin). This is >> similar to OVN packaging for Debian. >> >> Sig

Re: [ovs-dev] [PATCH v11 1/1] Separating OVN NB and SB database processes

2016-03-24 Thread Guru Shetty
I saw the following 3 issues when I did a git pull today. It is possible that I am not doing something the "new" way. 1. root@ovn1:~/git/routes# /usr/share/openvswitch/scripts/ovn-ctl restart_northd * Exiting ovn-northd (30705) 2016-03-24T10:56:44Z|1|unixctl|WARN|failed to connect to /var/run

Re: [ovs-dev] [PATCH v11 1/1] Separating OVN NB and SB database processes

2016-03-24 Thread Guru Shetty
On 24 March 2016 at 14:16, Russell Bryant wrote: > > > On Thu, Mar 24, 2016 at 4:56 PM, Guru Shetty wrote: > >> I saw the following 3 issues when I did a git pull today. It is possible >> that I am not doing something the "new" way. >> > > Sorry

Re: [ovs-dev] [PATCH] ovn: Fix some split db issues in ovn-ctl.

2016-03-24 Thread Guru Shetty
On 24 March 2016 at 14:49, Russell Bryant wrote: > The default location for databases should be $dbdir, not $rundir. > > The default location for log files comes from $logdir, not $OVS_LOGDIR. > > Fix ovs-appctl commands. The code assumed that passing > --unixctl=ovnnb_db was sufficient to allow

Re: [ovs-dev] [PATCH RFC] OVN: Openstack floating ip support

2016-03-25 Thread Guru Shetty
It would really help if you give packet walkthrough when following 2 simultaneous connections happen at the same time. 1. east-west without NAT between the private IP addresses 2 east-west with floating IP. You also mentioned in the meeting (if I remember correctly) on how you have to keep a part

Re: [ovs-dev] [PATCH] datapath-windows: Add Windows thread atomic APIs for x64 binaries.

2016-03-25 Thread Guru Shetty
On 25 March 2016 at 10:41, Sorin Vinturis wrote: > This patch modifies atomic operations library export header to > include Windows thread atomic APIs, ovs-atomic-msvc.h instead of > ovs-atomic-pthreads.h, for both x86 and x64 binaries. > > Signed-off-by: Sorin Vinturis > Have you gone through

Re: [ovs-dev] [PATCH] datapath-windows: Add Windows thread atomic APIs for x64 binaries.

2016-03-28 Thread Guru Shetty
tleast one reason, where was I a little confused on how the behavior will be on 64 bit builds and to be be safe, I excluded it. If you have gone through this carefully, I am okay. > > > Thanks, > > Sorin > > > > *From:* Guru Shetty [mailto:g...@ovn.org] > *Sent:* Friday,

Re: [ovs-dev] [PATCH] debian: Ship ovn-[ns]b man pages in ovn-common.

2016-03-29 Thread Guru Shetty
On 24 March 2016 at 17:04, Russell Bryant wrote: > Move ovn-nb and ovn-sb man pages to ovn-common so that the man pages for > these DB schemas are always available with the corresponding command > line utilities, ovn-nbctl and ovn-sbctl. > > Signed-off-by: Russell Bryant > Acked-by: Gurucharan S

Re: [ovs-dev] [PATCH] INSTALL.md: Explain the effect of using different configure options.

2016-03-30 Thread Guru Shetty
On 30 March 2016 at 08:41, Ben Pfaff wrote: > On Wed, Mar 30, 2016 at 08:23:46AM -0700, Gurucharan Shetty wrote: > > Over the years, I have seen multiple users inadvertantly end up with 2 > copies > > of OVS executables in their filesystem. In all the cases, it was because > of > > using differen

Re: [ovs-dev] [PATCH 1/1] Add Static route to logical router

2016-03-31 Thread Guru Shetty
On 30 March 2016 at 19:36, Shi Xin Ruan wrote: > > This patch add static route to logical router which are required in many > scenarios, such as VPNaas service, l3 gateway. > For VPNaas, OVN logical router SHOULD be able to route the VPN remote > subnet to the > VPN VM, static route is the best c

Re: [ovs-dev] [PATCH] ovn-northd: Fix peering of routers.

2016-04-01 Thread Guru Shetty
On 30 March 2016 at 16:18, Ben Pfaff wrote: > On Mon, Mar 28, 2016 at 02:31:41PM -0700, Gurucharan Shetty wrote: > > 1. Currently, the ovn-nb man page says that the 'peer' > > in a logical_router_port table should point to the name > > of the peer's logical router port. But the schema had declare

Re: [ovs-dev] [PATCH 1/1] Add Static route to logical router

2016-04-04 Thread Guru Shetty
On 31 March 2016 at 19:11, Shi Xin Ruan wrote: > Thanks Guru. > > The column "valid" will indicate whether the routes has been transfer into > logical flow. > Thinking about this case, deleting the logical router port which is out > going interface of some static routes. > The first possible way

Re: [ovs-dev] [PATCH 1/1] Add Static route to logical router

2016-04-06 Thread Guru Shetty
t. The static_route I have in mind need not recursively look through routers. All they need is to see whether the router peer has the next hop IP address and the packet is just sent to that router. From there on it is a fresh start. > > For these reasons, I prefer to keep a separate table f

Re: [ovs-dev] [PATCH 1/1] Add Static route to logical router

2016-04-06 Thread Guru Shetty
> > > > Steve My understanding of last point, > 1. How to static routes? > format: "10.0.0.0/24 nexthop 10.1.1.1" or "10.0.0.0/24 nexthop 10.1.1.1 > dev port1" > For the latter format, it need the networking-ovn to lookup logical router > port table. > It will do what this patch did in ovn-nort

Re: [ovs-dev] [PATCH] ovn-docker: Update overlay mode for new tcp ports.

2016-04-07 Thread Guru Shetty
On 7 April 2016 at 08:48, Russell Bryant wrote: > > On Wed, Apr 6, 2016 at 8:27 PM, Gurucharan Shetty wrote: > >> There were changes made recently wherein 2 ovsdb-server is >> started for northbound and southbound databases with tcp ports >> 6641 and 6642. This breaks Docker integration. This co

Re: [ovs-dev] [PATCH 1/1] Add Static route to logical router

2016-04-07 Thread Guru Shetty
On 7 April 2016 at 01:43, Mickey Spiegel wrote: > See comments inline > > Mickey > > > -Guru Shetty wrote: - > >To: Mickey Spiegel/San Jose/IBM@IBMUS > >From: Guru Shetty > >Date: 04/06/2016 05:58PM > >Cc: ovs dev , Shi Xin Ruan > >Sub

Re: [ovs-dev] [PATCH] ovs-save: Handle MTU changes correctly.

2016-04-11 Thread Guru Shetty
> > > > LGTM, Thanks for fixing this. > Thanks. I updated the commit message to the following and pushed this to master, 2.5, 2.4 and 2.3 ovs-save: Handle MTU changes correctly. The following command on ubuntu 12.04, 14.04 and CentOS 7.x returns null: expr "mtu 1500" : '.*mtu \([0-9]+\)' But th

Re: [ovs-dev] [PATCH] ovn-northd: Add support for static_routes.

2016-04-11 Thread Guru Shetty
On 11 April 2016 at 16:52, Mickey Spiegel wrote: > -Gurucharan Shetty wrote: - > > >To: dev@openvswitch.org > >From: Gurucharan Shetty > >Sent by: "dev" > >Date: 04/11/2016 07:46AM > >Cc: Gurucharan Shetty > >Subject: [ovs-dev] [PATCH] ovn-northd: Add support for static_routes. > > > >s

Re: [ovs-dev] [PATCH RFC] ovn-controller: Optimize processing for non-local datapath without patch ports.

2016-04-13 Thread Guru Shetty
On 28 March 2016 at 00:10, Han Zhou wrote: > For non-local datapaths, if there are no patch ports attached, it > means the lflows and port bindings would never be needed on the > Chassis. Skipping the processing for such lflows and port bindings > can save significant amount of CPU, at the same t

<    1   2   3   4   >