[ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-04-21 Thread Ciara Loftus
ilarly, there is now some overlap between dpdk and vhost-user port code. Signed-off-by: Ciara Loftus --- INSTALL.DPDK.md | 12 ++ NEWS | 2 + lib/netdev-dpdk.c | 515 +- 3 files changed, 254 insertions(+), 275 deletions(-)

[ovs-dev] [PATCH] netdev-dpdk: print default vhost-sock-dir if none provided

2016-05-05 Thread Ciara Loftus
Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index b488c60..67b9e0d 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -2982,7 +2982,7 @@ dpdk_init__(const struct smap

[ovs-dev] [PATCH v2] netdev-dpdk: Print default vhost-sock-dir value & update documentation

2016-05-06 Thread Ciara Loftus
When no vhost-sock-dir value is provided, print the default location. Update the documentation to reflect the fact that vhost-sock-dir values are now subdirectory loctions rather than full paths. Fixes: d8a8f353c23e ("netdev-dpdk: Restrict vhost_sock_dir") Signed-off-by: Ci

[ovs-dev] [PATCH v2 1/3] netdev-dpdk: Remove dpdk watchdog thread

2016-05-10 Thread Ciara Loftus
Instead of continuously polling for link status changes on 'dpdk' ports, register a callback function that will be triggered when DPDK detects that the link status of that port has changed. Signed-off-by: Ciara Loftus Suggested-by: Kevin Traynor --- lib/netdev-d

[ovs-dev] [PATCH v2 0/3] vHost PMD

2016-05-10 Thread Ciara Loftus
This series integrates the vHost User PMD. Previous: http://openvswitch.org/pipermail/dev/2016-April/069901.html v2: * rebase * split into 3-part series * remove dpdk watchdog - use link status change interrupt calllbacks instead * fix del-port problems - only set vhost_pmd_id once * vhost user f

[ovs-dev] [PATCH v2 3/3] netdev-dpdk: Add vhost-user 'get_features' & 'get_status' functions

2016-05-10 Thread Ciara Loftus
Implementations for the netdev functions 'get_features' and 'get_status' are now available for vhost-user thanks to the addition of the vHost PMD. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(

[ovs-dev] [PATCH v2 2/3] netdev-dpdk: Add vHost User PMD

2016-05-10 Thread Ciara Loftus
ilarly, there is now some overlap between dpdk and vhost-user port code. Signed-off-by: Ciara Loftus --- INSTALL.DPDK.md | 12 ++ NEWS | 2 + lib/netdev-dpdk.c | 493 ++ 3 files changed, 248 insertions(+), 259 deleti

[ovs-dev] [PATCH v3 3/3] netdev-dpdk: Add vhost-user 'get_features' & 'get_status' functions

2016-05-11 Thread Ciara Loftus
Implementations for the netdev functions 'get_features' and 'get_status' are now available for vhost-user thanks to the addition of the vHost PMD. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(

[ovs-dev] [PATCH v3 0/3] vHost PMD

2016-05-11 Thread Ciara Loftus
This series adds the vHost User PMD. Previous: http://openvswitch.org/pipermail/dev/2016-May/070745.html v3: * keep vhost user txq mapping * refactored locking logic around dpdk, dpdkr and vhost send functions v2: * rebase * split into 3-part series * remove dpdk watchdog - use link status chang

[ovs-dev] [PATCH v3 2/3] netdev-dpdk: Add vHost User PMD

2016-05-11 Thread Ciara Loftus
ilarly, there is now some overlap between dpdk and vhost-user port code. Signed-off-by: Ciara Loftus --- INSTALL.DPDK.md | 12 ++ NEWS | 2 + lib/netdev-dpdk.c | 628 +- 3 files changed, 396 insertions(+), 246 deleti

[ovs-dev] [PATCH v3 1/3] netdev-dpdk: Remove dpdk watchdog thread

2016-05-11 Thread Ciara Loftus
Instead of continuously polling for link status changes on 'dpdk' ports, register a callback function that will be triggered when DPDK detects that the link status of that port has changed. Signed-off-by: Ciara Loftus Suggested-by: Kevin Traynor --- lib/netdev-d

[ovs-dev] [PATCH 1/2] netdev: Initialise DPDK netdev classes only once

2016-05-17 Thread Ciara Loftus
DPDK netdev classes were being initialised twice, resulting in warning logs like so: netdev|WARN|attempted to register duplicate netdev provider: dpdk This commit removes one of the initialisation calls. Fixes: 0692257923fe ("netdev: Fix potential deadlock.") Signed-off-by: Ci

[ovs-dev] [PATCH 2/2] dpif-netlink: Only warn when OVS module unloaded when using DPDK netdev

2016-05-17 Thread Ciara Loftus
Change the log level from error to warning when reporting that the openvswitch module is not loaded but the DPDK netdev is initialised. OVS using DPDK can still function correctly without the module loaded. Signed-off-by: Ciara Loftus --- lib/dpif-netlink.c | 6 ++ 1 file changed, 6

[ovs-dev] [PATCH] netdev-dpdk: NUMA Aware vHost User

2016-05-24 Thread Ciara Loftus
CONFIG_RTE_LIBRTE_VHOST_NUMA DPDK configuration option. Signed-off-by: Ciara Loftus --- .travis.yml | 3 +++ INSTALL.DPDK.md | 8 ++-- NEWS| 3 +++ acinclude.m4| 2 +- lib/netdev-dpdk.c | 37

[ovs-dev] [PATCH] INSTALL.DPDK: Replace tabs with spaces

2016-05-24 Thread Ciara Loftus
Signed-off-by: Ciara Loftus --- INSTALL.DPDK.md | 342 1 file changed, 173 insertions(+), 169 deletions(-) diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md index 93f92e4..010d9f8 100644 --- a/INSTALL.DPDK.md +++ b/INSTALL.DPDK.md

[ovs-dev] [RFC PATCH 1/1] netdev-dpdk: vHost client mode and reconnect

2016-07-12 Thread Ciara Loftus
ll act as the vHost client and connect to sockets created and managed by QEMU which acts as the server. This mode allows for reconnect capability, which allows vHost ports to resume normal connectivity in event of switch reset. QEMU v2.7.0+ is required when using OVS in client mode and QEMU in serv

[ovs-dev] [RFC PATCH 0/1] netdev-dpdk: vHost client mode and reconnect

2016-07-12 Thread Ciara Loftus
This RFC patch enables vHost 'client' mode in OVS and reconnect capability, both of which are features which will be available in DPDK 16.07 due later this month. To use this patch, first apply the patch for 16.07 support: http://openvswitch.org/pipermail/dev/2016-July/074921.html Then apply this

[ovs-dev] [PATCH 2/4] netdev-dpdk: Consistent naming for vhost functions

2016-07-15 Thread Ciara Loftus
A mix of vhost_user_ and vhost_ is used when naming vhost functions. The 'user_' has been dropped for consistency. Also remove empty 'vhost_user_class_init' function. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 20 +++- 1 file changed, 7 inserti

[ovs-dev] [PATCH 0/4] Remove vHost Cuse and Add vHost User PMD

2016-07-15 Thread Ciara Loftus
cs for the vHost PMD so we can expect support for this to be re-added in OVS at a later date. Ciara Loftus (4): netdev-dpdk: Remove dpdkvhostcuse ports netdev-dpdk: Consistent naming for vhost functions netdev-dpdk: Add vHost User PMD netdev-dpdk: Add vhost-user 'get_features'

[ovs-dev] [PATCH 1/4] netdev-dpdk: Remove dpdkvhostcuse ports

2016-07-15 Thread Ciara Loftus
two years old this should however be a low impact change. Signed-off-by: Ciara Loftus Acked-by: Flavio Leitner --- INSTALL.DPDK-ADVANCED.md | 241 - NEWS | 1 + acinclude.m4 | 12 -- lib/netdev-dpdk.c| 101 +---

[ovs-dev] [PATCH 4/4] netdev-dpdk: Add vhost-user 'get_features' & 'get_status' functions

2016-07-15 Thread Ciara Loftus
Implementations for the netdev functions 'get_features' and 'get_status' are now available for vhost-user thanks to the addition of the vHost PMD. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(

[ovs-dev] [PATCH 3/4] netdev-dpdk: Add vHost User PMD

2016-07-15 Thread Ciara Loftus
This commit removes extended statistics support for vHost User ports until such a time that this becomes available in the vHost PMD in a DPDK release supported by OVS. Signed-off-by: Ciara Loftus --- INSTALL.DPDK.md | 10 + NEWS |

[ovs-dev] [PATCH RFC v3 0/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-15 Thread Ciara Loftus
This RFC patch addresses the restrictions placed on dpdk port names. Currently dpdk ports must be named dpdkX where X is the dpdk port-id. This patch removes this restriction and introduces the requirement to specify the pci address of the device in the other_config db. eg. ovs-vsctl add-port br0

[ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-15 Thread Ciara Loftus
et Interface my-port options:dpdk-pci=:06:00.3 Signed-off-by: Ciara Loftus v2: - remove global pci list - remove unnecessary parenthesis - remove return from void fn - print pci like dpdk - fix port ranges --- INSTALL.DPDK-ADVANCED.md | 2 +- INSTALL.DPDK.md | 10 ++-- NEWS

[ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-22 Thread Ciara Loftus
7;vid' Signed-off-by: Ciara Loftus Tested-by: Maxime Coquelin v3: - fixed style issues - fixed & simplified xstats frees - use xcalloc & free instead of rte_mzalloc & rte_free for stats - remove libnuma include - fixed & simplified vHost NUMA set - added flag to indicate de

[ovs-dev] [PATCH RFC v3 0/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-22 Thread Ciara Loftus
This RFC patch provides initial support for DPDK 16.07-rc3 (release candidate 3) which was tagged July 16th. I plan to submit a full patch once the 16.07 release is final, hopefully later this month. This RFC patch can be used in meantime to test with the DPDK master branch or 16.07-rc3 tag. The m

[ovs-dev] [PATCH v2 2/4] netdev-dpdk: Consistent naming for vhost functions

2016-07-26 Thread Ciara Loftus
A mix of vhost_user_ and vhost_ is used when naming vhost functions. The 'user_' has been dropped for consistency. Also remove empty 'vhost_user_class_init' function. Signed-off-by: Ciara Loftus Acked-by: Daniele Di Proietto --- lib/netdev-dpdk.c | 25 -

[ovs-dev] [PATCH v2 4/4] netdev-dpdk: Add vhost-user 'get_features' & 'get_status' functions

2016-07-26 Thread Ciara Loftus
Implementations for the netdev functions 'get_features' and 'get_status' are now available for vhost-user thanks to the addition of the vHost PMD. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(

[ovs-dev] [PATCH v2 1/4] netdev-dpdk: Remove dpdkvhostcuse ports

2016-07-26 Thread Ciara Loftus
two years old this should however be a low impact change. Signed-off-by: Ciara Loftus Acked-by: Flavio Leitner Acked-by: Daniele Di Proietto --- INSTALL.DPDK-ADVANCED.md | 241 - NEWS | 1 + acinclude.m4 | 12 -- lib/net

[ovs-dev] [PATCH v2 0/4] Remove vHost Cuse and Add vHost User PMD

2016-07-26 Thread Ciara Loftus
e callback functions to static - remove void cast when registering callbacks - remove unnecessary spinlock in send - mutex nesting consistent with rest of code - use MIN(OVS_VHOST_MAX_QUEUE_NUM, RTE_MAX_QUEUES_PER_PORT) instead of OVS_VHOST_MAX_QUEUE_NUM - style fixes Ciara Loftus (4): netdev-dp

[ovs-dev] [PATCH v2 3/4] netdev-dpdk: Add vHost User PMD

2016-07-26 Thread Ciara Loftus
This commit removes extended statistics support for vHost User ports until such a time that this becomes available in the vHost PMD in a DPDK release supported by OVS. Signed-off-by: Ciara Loftus --- INSTALL.DPDK.md | 10 + NEWS |

[ovs-dev] [PATCH v3 1/5] netdev-dpdk: Remove dpdkvhostcuse ports

2016-07-28 Thread Ciara Loftus
two years old this should however be a low impact change. Signed-off-by: Ciara Loftus Acked-by: Flavio Leitner Acked-by: Daniele Di Proietto --- INSTALL.DPDK-ADVANCED.md | 241 - NEWS | 1 + acinclude.m4 | 12 -- lib/net

[ovs-dev] [PATCH v3 4/5] netdev-dpdk: Add vhost-user 'get_features' & 'get_status' functions

2016-07-28 Thread Ciara Loftus
Implementations for the netdev functions 'get_features' and 'get_status' are now available for vhost-user thanks to the addition of the vHost PMD. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(

[ovs-dev] [PATCH v3 3/5] netdev-dpdk: Add vHost User PMD

2016-07-28 Thread Ciara Loftus
This commit removes extended statistics support for vHost User ports until such a time that this becomes available in the vHost PMD in a DPDK release supported by OVS. Signed-off-by: Ciara Loftus --- INSTALL.DPDK.md | 10 + NEWS |

[ovs-dev] [PATCH v3 0/5] Remove vHost Cuse and Add vHost User PMD

2016-07-28 Thread Ciara Loftus
Previous: http://openvswitch.org/pipermail/dev/2016-July/076245.html The patchset combines two previously independent sets: 1. netdev-dpdk: Remove dpdkvhostcuse ports (v1) http://openvswitch.org/pipermail/dev/2016-July/074696.html 2. vHost PMD (v3) http://openvswitch.org/pipermail/dev/2016-May/070

[ovs-dev] [PATCH v3 2/5] netdev-dpdk: Consistent naming for vhost functions

2016-07-28 Thread Ciara Loftus
A mix of vhost_user_ and vhost_ is used when naming vhost functions. The 'user_' has been dropped for consistency. Also remove empty 'vhost_user_class_init' function. Signed-off-by: Ciara Loftus Acked-by: Daniele Di Proietto --- lib/netdev-dpdk.c | 25 -

[ovs-dev] [PATCH v3 5/5] netdev-dpdk: Make libnuma dependencies optional

2016-07-28 Thread Ciara Loftus
Prior to this patch, OVS with DPDK required the libnuma packages to build. This patch removes this dependency, making it only a requirement when the CONFIG_RTE_LIBRTE_VHOST_NUMA option is detected as enabled in the DPDK build. Signed-off-by: Ciara Loftus --- .travis.yml | 1

[ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add DPDK pdump capability

2016-07-29 Thread Ciara Loftus
nd in INSTALL.DPDK-ADVANCED.md The pdump feature is optional. Should you wish to use it, pcap libraries must to be installed on the system and the CONFIG_RTE_LIBRTE_PMD_PCAP=y and CONFIG_RTE_LIBRTE_PDUMP=y options set in DPDK. Additionally you must set the 'dpdk-pdump' ovs other_config D

[ovs-dev] [PATCH RFC 0/1] netdev-dpdk: add DPDK pdump capability

2016-07-29 Thread Ciara Loftus
This patch enables optional DPDK pdump support in OVS. Pdump allows you to capture packets on DPDK devices. The pdump feature is enabled in DPDK 16.07 which isn't supported in OVS yet so the patch for this needs to be applied first before using this patch: http://openvswitch.org/pipermail/dev/2016

[ovs-dev] [PATCH v4 5/5] netdev-dpdk: Make libnuma dependencies optional

2016-07-29 Thread Ciara Loftus
Prior to this patch, OVS with DPDK required the libnuma packages to build. This patch removes this dependency, making it only a requirement when the CONFIG_RTE_LIBRTE_VHOST_NUMA option is detected as enabled in the DPDK build. Signed-off-by: Ciara Loftus --- .travis.yml | 1

[ovs-dev] [PATCH v4 1/5] netdev-dpdk: Remove dpdkvhostcuse ports

2016-07-29 Thread Ciara Loftus
two years old this should however be a low impact change. Signed-off-by: Ciara Loftus Acked-by: Flavio Leitner Acked-by: Daniele Di Proietto --- INSTALL.DPDK-ADVANCED.md| 241 - NEWS| 1 + ac

[ovs-dev] [PATCH v4 0/5] Remove vHost Cuse and Add vHost User PMD

2016-07-29 Thread Ciara Loftus
inlock in send - mutex nesting consistent with rest of code - use MIN(OVS_VHOST_MAX_QUEUE_NUM, RTE_MAX_QUEUES_PER_PORT) instead of OVS_VHOST_MAX_QUEUE_NUM - style fixes Ciara Loftus (5): netdev-dpdk: Remove dpdkvhostcuse ports netdev-dpdk: Consistent naming for vhost functions netdev-dpdk: Ad

[ovs-dev] [PATCH RFC v4 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-29 Thread Ciara Loftus
This commit introduces support for DPDK 16.07 and consequently breaks compatibility with DPDK 16.04. DPDK 16.07 introduces some changes to the xstats API. OVS has been modified to comply with the changes. Signed-off-by: Ciara Loftus Tested-by: Maxime Coquelin Tested-by: Robert Wojciechowicz

[ovs-dev] [PATCH RFC v4 0/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-29 Thread Ciara Loftus
Previous: http://openvswitch.org/pipermail/dev/2016-July/075891.html This RFC patch provides support for the DPDK 16.07 release which was released 28th July. The reason for the RFC is that this patch depends on support for the vHost User PMD found in the following patch-set: http://openvswitch.or

[ovs-dev] [PATCH v4 4/5] netdev-dpdk: Add vhost-user 'get_features' & 'get_status' functions

2016-07-29 Thread Ciara Loftus
Implementations for the netdev functions 'get_features' and 'get_status' are now available for vhost-user thanks to the addition of the vHost PMD. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(

[ovs-dev] [PATCH v4 2/5] netdev-dpdk: Consistent naming for vhost functions

2016-07-29 Thread Ciara Loftus
A mix of vhost_user_ and vhost_ is used when naming vhost functions. The 'user_' has been dropped for consistency. Also remove empty 'vhost_user_class_init' function. Signed-off-by: Ciara Loftus Acked-by: Daniele Di Proietto Acked-by: Flavio Leitner --- li

[ovs-dev] [PATCH v4 3/5] netdev-dpdk: Add vHost User PMD

2016-07-29 Thread Ciara Loftus
This commit removes extended statistics support for vHost User ports until such a time that this becomes available in the vHost PMD in a DPDK release supported by OVS. Signed-off-by: Ciara Loftus --- INSTALL.DPDK.md | 10 + NEWS |

[ovs-dev] [PATCH RFC v2 0/1] netdev-dpdk: vHost client mode and reconnect

2016-07-29 Thread Ciara Loftus
Previous: http://openvswitch.org/pipermail/dev/2016-July/074972.html This RFC patch enables vHost 'client' mode in OVS and reconnect capability, both of which are features which are available in the new DPDK 16.07 release. To use this patch, first apply the vHost User PMD patch: http://openvswitc

[ovs-dev] [PATCH RFC v2 1/1] netdev-dpdk: vHost client mode and reconnect

2016-07-29 Thread Ciara Loftus
ll act as the vHost client and connect to sockets created and managed by QEMU which acts as the server. This mode allows for reconnect capability, which allows vHost ports to resume normal connectivity in event of switch reset. QEMU v2.7.0+ is required when using OVS in client mode and QEMU in serv

[ovs-dev] [PATCH RFC v5 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-08-03 Thread Ciara Loftus
7;vid' Signed-off-by: Ciara Loftus Tested-by: Maxime Coquelin Tested-by: Robert Wojciechowicz v5: - rebase with OVS master - un-rebase(?) with vHost User PMD patch - use new RCU index mechanism on vid v4: - rebased with DPDK v16.07 - rebased with OVS master - rebased with vHost User PMD

[ovs-dev] [PATCH RFC v5 0/1] netdev-dpdk: Add support for DPDK 16.07

2016-08-03 Thread Ciara Loftus
ice reconfigured at least once - re-add call to rcu synchronise in destroy_device - define IF_NAME_SZ and use instead of PATH_MAX - added NEWS entry v2: - rebase with DPDK rc2 - rebase with OVS master - fix vhost cuse compilation Ciara Loftus (1): netdev-dpdk: Add support for DPDK 16.07 .travi

[ovs-dev] [PATCH 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-04 Thread Ciara Loftus
ll act as the vHost client and connect to sockets created and managed by QEMU which acts as the server. This mode allows for reconnect capability, which allows vHost ports to resume normal connectivity in event of switch reset. QEMU v2.7.0+ is required when using OVS in client mode and QEMU in serv

[ovs-dev] [PATCH 2/3] netdev-dpdk: Remove empty init function

2016-08-04 Thread Ciara Loftus
DPDK type ports no longer implement the netdev class 'init' function. Set the function to NULL in NETDEV_DPDK_CLASS. Suggested-by: Daniele Di Proietto Acked-by: Daniele Di Proietto Acked-by: Flavio Leitner Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 13 ++--- 1 fi

[ovs-dev] [PATCH 1/3] netdev-dpdk: Remove dpdkvhostcuse ports

2016-08-04 Thread Ciara Loftus
two years old this should however be a low impact change. Signed-off-by: Ciara Loftus Acked-by: Flavio Leitner Acked-by: Daniele Di Proietto --- INSTALL.DPDK-ADVANCED.md| 242 - NEWS| 1 + ac

[ovs-dev] [PATCH] netdev-dpdk: Make libnuma dependencies optional

2016-08-04 Thread Ciara Loftus
Prior to this patch, OVS with DPDK required the libnuma packages to build. This patch removes this dependency, making it only a requirement when the CONFIG_RTE_LIBRTE_VHOST_NUMA option is detected as enabled in the DPDK build. Signed-off-by: Ciara Loftus --- .travis.yml | 1

[ovs-dev] [PATCH] netdev-dpdk: add DPDK pdump capability

2016-08-04 Thread Ciara Loftus
nd in INSTALL.DPDK-ADVANCED.md The pdump feature is optional. Should you wish to use it, pcap libraries must to be installed on the system and the CONFIG_RTE_LIBRTE_PMD_PCAP=y and CONFIG_RTE_LIBRTE_PDUMP=y options set in DPDK. Additionally you must set the 'dpdk-pdump' ovs other_config D

[ovs-dev] [PATCH v2 2/3] netdev-dpdk: Remove empty init function

2016-08-04 Thread Ciara Loftus
DPDK type ports no longer implement the netdev class 'init' function. Set the function to NULL in NETDEV_DPDK_CLASS. Suggested-by: Daniele Di Proietto Acked-by: Daniele Di Proietto Acked-by: Flavio Leitner Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 13 ++--- 1 fi

[ovs-dev] [PATCH v2 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-04 Thread Ciara Loftus
ll act as the vHost client and connect to sockets created and managed by QEMU which acts as the server. This mode allows for reconnect capability, which allows vHost ports to resume normal connectivity in event of switch reset. QEMU v2.7.0+ is required when using OVS in client mode and QEMU in serv

[ovs-dev] [PATCH v2 1/3] netdev-dpdk: Remove dpdkvhostcuse ports

2016-08-04 Thread Ciara Loftus
two years old this should however be a low impact change. Signed-off-by: Ciara Loftus Acked-by: Flavio Leitner Acked-by: Daniele Di Proietto --- INSTALL.DPDK-ADVANCED.md| 242 - NEWS| 1 + ac

[ovs-dev] [PATCH v3 2/3] netdev-dpdk: Remove empty init function

2016-08-08 Thread Ciara Loftus
DPDK type ports no longer implement the netdev class 'init' function. Set the function to NULL in NETDEV_DPDK_CLASS. Suggested-by: Daniele Di Proietto Acked-by: Daniele Di Proietto Acked-by: Flavio Leitner Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 13 ++--- 1 fi

[ovs-dev] [PATCH v3 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-08 Thread Ciara Loftus
ll act as the vHost client and connect to sockets created and managed by QEMU which acts as the server. This mode allows for reconnect capability, which allows vHost ports to resume normal connectivity in event of switch reset. QEMU v2.7.0+ is required when using OVS in client mode and QEMU in serv

[ovs-dev] [PATCH v3 1/3] netdev-dpdk: Remove dpdkvhostcuse ports

2016-08-08 Thread Ciara Loftus
two years old this should however be a low impact change. Signed-off-by: Ciara Loftus Acked-by: Flavio Leitner Acked-by: Daniele Di Proietto Acked-by: Ilya Maximets --- INSTALL.DPDK-ADVANCED.md| 242 - NEWS| 1 + ac

[ovs-dev] [PATCH v2] netdev-dpdk: add DPDK pdump capability

2016-08-10 Thread Ciara Loftus
nd in INSTALL.DPDK-ADVANCED.md Pdump capability in OVS with DPDK will only be initialised if the CONFIG_RTE_LIBRTE_PMD_PCAP=y and CONFIG_RTE_LIBRTE_PDUMP=y options are set in DPDK. libpcap is required if the above configuration is used. Signed-off-by: Ciara Loftus --- v2: - specify ovs_run

[ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-11 Thread Ciara Loftus
server' mode. That is unless a valid 'vhost-server-path' is specified for that device like so: ovs-vsctl set Interface options:vhost-server-path= Once specified, the port stays in 'client' mode for the remainder of its lifetime. QEMU v2.7.0+ is required when using OVS

[ovs-dev] [PATCH v4 2/3] netdev-dpdk: Consistent naming for vhost

2016-08-11 Thread Ciara Loftus
A mix of vhost_user_ and vhost_ is used when naming vhost functions. The 'user_' has been dropped for consistency. Also remove empty init functions for netdev dpdk classes. Suggested-by: Daniele Di Proietto Acked-by: Daniele Di Proietto Acked-by: Flavio Leitner Signed-off-by: Ci

[ovs-dev] [PATCH v4 1/3] netdev-dpdk: Remove dpdkvhostcuse ports

2016-08-11 Thread Ciara Loftus
two years old this should however be a low impact change. Signed-off-by: Ciara Loftus Acked-by: Flavio Leitner Acked-by: Daniele Di Proietto Acked-by: Ilya Maximets --- INSTALL.DPDK-ADVANCED.md| 242 - NEWS| 1 + ac

[ovs-dev] [PATCH v2 1/1] netdev-dpdk: NUMA Aware vHost User

2016-06-13 Thread Ciara Loftus
CONFIG_RTE_LIBRTE_VHOST_NUMA DPDK configuration option. Signed-off-by: Ciara Loftus --- v2: - Remove numactl dependencies from travis & fedora spec files - Updated log message .travis.yml | 1 + INSTALL.DPDK.md | 8 ++-- NEWS

[ovs-dev] [PATCH RFC 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-06-14 Thread Ciara Loftus
et Interface my-port options:dpdk-pci=:06:00.3 Signed-off-by: Ciara Loftus --- INSTALL.DPDK.md | 10 NEWS | 2 ++ lib/netdev-dpdk.c | 71 +-- 3 files changed, 66 insertions(+), 17 deletions(-) diff --git

[ovs-dev] [PATCH RFC 0/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-06-14 Thread Ciara Loftus
This RFC patch addresses the restrictions placed on dpdk port names. Currently dpdk ports must be named dpdkX where X is the dpdk port-id. This patch removes this restriction and introduces the requirement to specify the pci address of the device in the other_config db. eg. ovs-vsctl add-port br0

[ovs-dev] [RFC PATCH v2] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-01 Thread Ciara Loftus
et Interface my-port options:dpdk-pci=:06:00.3 Signed-off-by: Ciara Loftus --- INSTALL.DPDK.md | 12 ++--- NEWS | 2 + lib/netdev-dpdk.c | 142 +- 3 files changed, 127 insertions(+), 29 deletions(-) diff --git

[ovs-dev] [RFC PATCH v2] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-01 Thread Ciara Loftus
This RFC patch addresses the restrictions placed on dpdk port names. Currently dpdk ports must be named dpdkX where X is the dpdk port-id. This patch removes this restriction and introduces the requirement to specify the pci address of the device in the other_config db. eg. ovs-vsctl add-port br0

[ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-01 Thread Ciara Loftus
et Interface my-port options:dpdk-pci=:06:00.3 Signed-off-by: Ciara Loftus --- INSTALL.DPDK.md | 12 ++--- NEWS | 2 + lib/netdev-dpdk.c | 142 +- 3 files changed, 127 insertions(+), 29 deletions(-) diff --git

[ovs-dev] [RFC PATCH v2 0/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-01 Thread Ciara Loftus
This time with patch numbering :) This RFC patch addresses the restrictions placed on dpdk port names. Currently dpdk ports must be named dpdkX where X is the dpdk port-id. This patch removes this restriction and introduces the requirement to specify the pci address of the device in the other_con

[ovs-dev] [RFC PATCH 0/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-04 Thread Ciara Loftus
This RFC patch provides initial support for DPDK 16.07-rc1 (release candidate 1) which was tagged July 4th. I plan to submit a full patch once the 16.07 release is final, hopefully later this month. This RFC patch can be used in meantime to test with the DPDK master branch or 16.07-rc1 tag. The ma

[ovs-dev] [RFC PATCH 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-04 Thread Ciara Loftus
7;vid' Signed-off-by: Ciara Loftus --- .travis/linux-build.sh | 2 +- INSTALL.DPDK.md| 12 +-- lib/netdev-dpdk.c | 247 - 3 files changed, 128 insertions(+), 133 deletions(-) diff --git a/.travis/linux-build.sh b/.travis/linu

[ovs-dev] [PATCH] netdev-dpdk: Remove dpdkvhostcuse ports

2016-07-07 Thread Ciara Loftus
e. Signed-off-by: Ciara Loftus --- INSTALL.DPDK-ADVANCED.md | 241 - NEWS | 1 + acinclude.m4 | 12 -- lib/netdev-dpdk.c| 101 +--- rhel/README.RHEL | 2 - utilities/automake.mk| 1 - utilities/qemu-wrap.

[ovs-dev] [RFC PATCH v2 0/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-12 Thread Ciara Loftus
This RFC patch provides initial support for DPDK 16.07-rc2 (release candidate 2) which was tagged July 12th. I plan to submit a full patch once the 16.07 release is final, hopefully later this month. This RFC patch can be used in meantime to test with the DPDK master branch or 16.07-rc2 tag. The m

[ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-12 Thread Ciara Loftus
7;vid' Signed-off-by: Ciara Loftus --- .travis/linux-build.sh | 2 +- INSTALL.DPDK-ADVANCED.md | 8 +- INSTALL.DPDK.md | 20 ++-- lib/netdev-dpdk.c| 243 +++ 4 files changed, 135 insertions(+), 138 deletions(-) diff --git

[ovs-dev] [PATCH RFC 1/1] netdev-dpdk: NUMA Aware vHost

2016-03-04 Thread Ciara Loftus
s not on the default NUMA node. If this is the case, the mempool of the port is also changed to the new node, and a PMD thread currently servicing the port will no longer, in favour of a thread from the new node (if enabled in the CPU mask). Signed-off-by: Ciara Loftus --- INSTALL.DPDK.md

[ovs-dev] [PATCH RFC 0/1] NUMA Aware vHost

2016-03-04 Thread Ciara Loftus
This RFC patch makes use of the CONFIG_RTE_LIBRTE_VHOST_NUMA option available in DPDK v2.2 that relocates vhost device memory managed by DPDK to the same NUMA node that QEMU device memory is located on. In OVS, now the mempool and PMD servicing the port are relocated to this NUMA node as well. Prev

[ovs-dev] [RFC PATCH v2] netdev-dpdk: NUMA Aware vHost

2016-03-19 Thread Ciara Loftus
s not on the default NUMA node. If this is the case, the mempool of the port is also changed to the new node, and a PMD thread currently servicing the port will no longer, in favour of a thread from the new node (if enabled in the CPU mask). Signed-off-by: Ciara Loftus --- .travi

[ovs-dev] [RFC PATCH v2] NUMA Aware vHost

2016-03-19 Thread Ciara Loftus
This RFC patch makes use of the CONFIG_RTE_LIBRTE_VHOST_NUMA option available in DPDK v2.2 that relocates vhost device memory managed by DPDK to the same NUMA node that QEMU device memory is located on. In OVS, now the mempool and PMD servicing the port are attempted to be relocated to this NUMA no

[ovs-dev] [PATCH] netdev-dpdk: Use rte_eth_is_valid_port instead of manual check

2016-08-12 Thread Ciara Loftus
Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 9a1f7cd..329b4ea 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -648,7 +648,7 @@ dpdk_eth_dev_init(struct netdev_dpdk

[ovs-dev] [PATCH] netdev-dpdk: Remove unnecessary 'if' statement

2016-08-12 Thread Ciara Loftus
Only devices of type "DPDK_DEV_ETH" use the netdev_dpdk_set_config function, so no need to check for the device type within the function. Fixes: 9fd39370c12c ("netdev-dpdk: Add Flow Control support.") Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 27 +--

[ovs-dev] [PATCH v2] netdev-dpdk: Do not attempt to initialise flow control for 'dpdkr' ports

2016-08-15 Thread Ciara Loftus
Only 'dpdk' ports support flow control. This patch stops 'dpdkr' ports from attempting to initialise this feature as this port type does not support it. Fixes: 9fd39370c12c ("netdev-dpdk: Add Flow Control support.") Signed-off-by: Ciara Loftu

[ovs-dev] [PATCH v5 2/3] netdev-dpdk: Consistent naming for vhost

2016-08-15 Thread Ciara Loftus
A mix of vhost_user_ and vhost_ is used when naming vhost functions. The 'user_' has been dropped for consistency. Also remove empty init functions for netdev dpdk classes. Suggested-by: Daniele Di Proietto Acked-by: Daniele Di Proietto Acked-by: Flavio Leitner Signed-off-by: Ci

[ovs-dev] [PATCH v5 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-15 Thread Ciara Loftus
ed by QEMU. Once specified, the port stays in 'client' mode for the remainder of its lifetime. QEMU v2.7.0+ is required when using OVS in vHost client mode and QEMU in vHost server mode. Signed-off-by: Ciara Loftus Signed-off-by: Daniele Di Proietto --- v5: - Added Daniele's inc

[ovs-dev] [PATCH v5 1/3] netdev-dpdk: Remove dpdkvhostcuse ports

2016-08-15 Thread Ciara Loftus
two years old this should however be a low impact change. Signed-off-by: Ciara Loftus Acked-by: Flavio Leitner Acked-by: Daniele Di Proietto Acked-by: Ilya Maximets --- INSTALL.DPDK-ADVANCED.md| 242 - NEWS| 1 + ac

[ovs-dev] [PATCH] netdev-dpdk: Fix occurance of error log

2016-08-17 Thread Ciara Loftus
If NUMA information can't be derived from a vHost User device, only print an error if the VHOST_NUMA option is enabled in DPDK. Otherwise 'fail' silently. Fixes: 0a0f39df1d5a ("netdev-dpdk: Add support for DPDK 16.07") Signed-off-by: Ciara Loftus Reported-by: Ian

[ovs-dev] [PATCH] netdev-dpdk: Provide explicit flag to rte_vhost_driver_register

2016-08-18 Thread Ciara Loftus
dn't been set yet when the register function is called but happen to be zero. Provide an explicit flag instead for better practice. Fixes: ("c1ff66ac80b5: netdev-dpdk: vHost client mode and reconnect") Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 in

[ovs-dev] [PATCH] INSTALL.DPDK-ADVANCED.md: Fix incorrect numbering

2016-08-18 Thread Ciara Loftus
Fixes: 419876444357 ("netdev-dpdk: Remove dpdkvhostcuse ports") Signed-off-by: Ciara Loftus --- INSTALL.DPDK-ADVANCED.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INSTALL.DPDK-ADVANCED.md b/INSTALL.DPDK-ADVANCED.md index 9694003..857c805 100755 --- a/IN

[ovs-dev] [PATCH] netdev-dpdk: Add new 'dpdkvhostuserclient' port type

2016-08-18 Thread Ciara Loftus
The 'dpdkvhostuser' port type no longer supports both server and client mode. Instead, 'dpdkvhostuser' ports are always 'server' mode and 'dpdkvhostuserclient' ports are always 'client' mode. Signed-off-by: Ciara Loftus --- INSTALL.DPDK-A

[ovs-dev] [PATCH v2] netdev-dpdk: Add new 'dpdkvhostuserclient' port type

2016-08-19 Thread Ciara Loftus
The 'dpdkvhostuser' port type no longer supports both server and client mode. Instead, 'dpdkvhostuser' ports are always 'server' mode and 'dpdkvhostuserclient' ports are always 'client' mode. Suggested-by: Daniele Di Proietto Signed-off-by:

[ovs-dev] [PATCH] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-09 Thread Ciara Loftus
nching the daemon as changing the queue size requires the NIC to restart. Signed-off-by: Ciara Loftus --- INSTALL.DPDK-ADVANCED.md | 16 ++-- NEWS | 3 +++ lib/netdev-dpdk.c| 35 +++ vswitchd/vswitch.xml | 26 +++

[ovs-dev] [PATCH v2] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-20 Thread Ciara Loftus
nching the daemon as changing the queue size requires the NIC to restart. Signed-off-by: Ciara Loftus --- v2 * Rebase INSTALL.DPDK-ADVANCED.md | 16 ++-- NEWS | 3 +++ lib/netdev-dpdk.c| 35 +++ vswitchd/

[ovs-dev] [PATCH v3] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-20 Thread Ciara Loftus
however require the NIC to restart when changed. Signed-off-by: Ciara Loftus --- v3: * Make queue sizes per-port rather than global * Check if queue size is power of 2 - fail if so. v2: * Rebase INSTALL.DPDK-ADVANCED.md | 16 ++-- NEWS | 2 ++ lib/netde

[ovs-dev] [PATCH v4] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-21 Thread Ciara Loftus
however require the NIC to restart when changed. Signed-off-by: Ciara Loftus Acked-by: Yunhong Jiang --- v4: * Fix typos in vswitchd.xml * Use internal OVS function is_pow2 rather than DPDK function * Additional documentation v3: * Make queue sizes per-port rather than global * Check if queu

[ovs-dev] [PATCH v5] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-30 Thread Ciara Loftus
however require the NIC to restart when changed. Signed-off-by: Ciara Loftus Acked-by: Yunhong Jiang Acked-by: Ilya Maximets --- v5: * Rebase * If invalid value is specified, request a default value rather than the previous value. * Added requested values to get_config v4: * Fix typos i

[ovs-dev] [PATCH v6] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-30 Thread Ciara Loftus
however require the NIC to restart when changed. Signed-off-by: Ciara Loftus Acked-by: Yunhong Jiang Acked-by: Ilya Maximets --- v6: * Reintroduce check for queue_size >= 0 v5: * Rebase * If invalid value is specified, request a default value rather than the previous value. * Added request

[ovs-dev] [PATCH] NEWS: Move entry from 'v2.6.0' to 'Post-v2.6.0'

2016-10-04 Thread Ciara Loftus
Configurable queue sizing for DPDK ports did not make the 2.6 release however the NEWS entry suggests it did. Fix this. Signed-off-by: Ciara Loftus --- NEWS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 725754a..04943d4 100644 --- a/NEWS +++ b/NEWS

  1   2   >