Re: [ovs-dev] [PATCH] ovs-appctl: fix help message for ofporot/trace command

2012-11-20 Thread Ansis Atteka
On Tue, Nov 20, 2012 at 2:04 PM, Reid Price wrote: > s/ofporot/ofproto/ Thanks. Fixed that typo and applied to master and branch-1.9, ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCHv4] datapath: add skb mark matching and set action

2012-11-20 Thread Ansis Atteka
This patch adds support for skb mark matching and set action. Signed-off-by: Ansis Atteka --- NEWS|4 +++- datapath/actions.c |4 datapath/compat.h | 33 + datapath/datapath.c |8

Re: [ovs-dev] [PATCHv4] datapath: add skb mark matching and set action

2012-11-21 Thread Ansis Atteka
On Tue, Nov 20, 2012 at 3:15 PM, Ben Pfaff wrote: > On Tue, Nov 20, 2012 at 03:05:24PM -0800, Ansis Atteka wrote: >> This patch adds support for skb mark matching and set action. >> >> Signed-off-by: Ansis Atteka > > I would increment FLOW_WC_SEQ to draw attention

[ovs-dev] [PATCHv5] datapath: add skb mark matching and set action

2012-11-21 Thread Ansis Atteka
This patch adds support for skb mark matching and set action. Signed-off-by: Ansis Atteka --- NEWS|4 +++- datapath/actions.c |4 datapath/compat.h | 33 + datapath/datapath.c |8

Re: [ovs-dev] [PATCHv4] datapath: add skb mark matching and set action

2012-11-21 Thread Ansis Atteka
On Wed, Nov 21, 2012 at 11:46 AM, Jesse Gross wrote: > On Tue, Nov 20, 2012 at 3:05 PM, Ansis Atteka wrote: >> This patch adds support for skb mark matching and set action. >> >> Signed-off-by: Ansis Atteka > > Thanks, this looks good to me. Incrementing FLOW_WC_SEQ

[ovs-dev] [PATCH] vswitchd: fix 32-bit builds

2012-11-21 Thread Ansis Atteka
My previous dcb66daea433cd93593e517c3fac3c898f2c9f70 commit broke 32-bit builds. This patch assures that size of struct flow is equal on both 32-bit and 64-bit architectures so that build asserts do not fire anymore. Signed-off-by: Ansis Atteka --- lib/flow.h |1 + 1 file changed, 1

[ovs-dev] [PATCHv2] vswitchd: fix 32-bit builds

2012-11-22 Thread Ansis Atteka
My previous dcb66daea433cd93593e517c3fac3c898f2c9f70 commit broke 32-bit builds. This patch assures that size of struct flow is equal on both 32-bit and 64-bit architectures so that build asserts would not fire anymore. Signed-off-by: Ansis Atteka --- lib/flow.c |1 + lib/flow.h

Re: [ovs-dev] [PATCHv2] vswitchd: fix 32-bit builds

2012-11-22 Thread Ansis Atteka
On Thu, Nov 22, 2012 at 2:36 PM, Ben Pfaff wrote: > On Thu, Nov 22, 2012 at 11:29:24PM +0200, Ansis Atteka wrote: >> My previous dcb66daea433cd93593e517c3fac3c898f2c9f70 commit broke >> 32-bit builds. This patch assures that size of struct flow is equal >> on both 32-bit and

[ovs-dev] [PATCH] flow: use rule priority in match_format() function

2012-11-27 Thread Ansis Atteka
The flow_format() function was incorrectly passing skb_priority to the match_format() function. match_format() function instead expects rule priority. Signed-off-by: Ansis Atteka --- lib/flow.c|2 +- tests/ofp-print.at|8 +++ tests/ofproto-dpif.at | 56

Re: [ovs-dev] [PATCH] flow: use rule priority in match_format() function

2012-11-27 Thread Ansis Atteka
On Tue, Nov 27, 2012 at 11:28 AM, Ben Pfaff wrote: > On Tue, Nov 27, 2012 at 10:45:42AM -0800, Ansis Atteka wrote: >> The flow_format() function was incorrectly passing skb_priority >> to the match_format() function. match_format() function instead >> expects rule priority

Re: [ovs-dev] [PATCH] flow: use rule priority in match_format() function

2012-11-27 Thread Ansis Atteka
On Tue, Nov 27, 2012 at 1:51 PM, Jesse Gross wrote: > On Tue, Nov 27, 2012 at 1:35 PM, Ansis Atteka wrote: >> On Tue, Nov 27, 2012 at 11:28 AM, Ben Pfaff wrote: >>> On Tue, Nov 27, 2012 at 10:45:42AM -0800, Ansis Atteka wrote: >>>> The flow_format() function was in

Re: [ovs-dev] [PATCH] flow: use rule priority in match_format() function

2012-11-27 Thread Ansis Atteka
On Tue, Nov 27, 2012 at 2:25 PM, Ansis Atteka wrote: > On Tue, Nov 27, 2012 at 1:51 PM, Jesse Gross wrote: >> On Tue, Nov 27, 2012 at 1:35 PM, Ansis Atteka wrote: >>> On Tue, Nov 27, 2012 at 11:28 AM, Ben Pfaff wrote: >>>> On Tue, Nov 27, 2012 at 10:45:42AM -0800,

[ovs-dev] [PATCH] vswitchd: log skb_mark and skb_priority

2012-11-30 Thread Ansis Atteka
This patch adds logging support for skb_mark and skb_priority. Signed-off-by: Ansis Atteka --- lib/match.c| 30 +++ lib/match.h|2 ++ lib/meta-flow.c| 68 lib/meta-flow.h|2 ++ lib/ofp

Re: [ovs-dev] [PATCH] vswitchd: log skb_mark and skb_priority

2012-11-30 Thread Ansis Atteka
On Fri, Nov 30, 2012 at 4:27 PM, Jesse Gross wrote: > On Fri, Nov 30, 2012 at 4:24 PM, Ben Pfaff wrote: >> On Fri, Nov 30, 2012 at 04:20:33PM -0800, Jesse Gross wrote: >>> On Fri, Nov 30, 2012 at 4:13 PM, Ben Pfaff wrote: >>> > On Fri, Nov 30, 2012 at 04:07:

Re: [ovs-dev] [PATCH net-next 3/7] ipv6: improve ipv6_find_hdr() to skip empty routing headers

2012-12-04 Thread Ansis Atteka
On Tue, Dec 4, 2012 at 10:15 AM, Jesse Gross wrote: > On Mon, Dec 3, 2012 at 10:06 AM, Pablo Neira Ayuso > wrote: >> On Mon, Dec 03, 2012 at 09:28:55AM -0800, Jesse Gross wrote: >>> On Mon, Dec 3, 2012 at 6:04 AM, Pablo Neira Ayuso >>> wrote: >>> > On Thu, Nov 29, 2012 at 10:35:45AM -0800, Jes

[ovs-dev] [PATCHv2] vswitchd: log skb_mark and skb_priority

2012-12-17 Thread Ansis Atteka
This patch adds logging support for skb_mark and skb_priority. Signed-off-by: Ansis Atteka --- lib/match.c | 30 ++ lib/match.h |2 ++ lib/meta-flow.c | 68 + lib/meta-flow.h |2

Re: [ovs-dev] [PATCHv2] vswitchd: log skb_mark and skb_priority

2012-12-18 Thread Ansis Atteka
On Tue, Dec 18, 2012 at 9:10 AM, Jesse Gross wrote: > On Mon, Dec 17, 2012 at 9:08 PM, Ansis Atteka wrote: >> This patch adds logging support for skb_mark and skb_priority. >> >> Signed-off-by: Ansis Atteka > > Looks good to me, thanks. Thanks for the review. I pushe

[ovs-dev] [branch-1.4] ovs-monitor-ipsec: Detect correctly IPSEC configuration changes

2012-03-08 Thread Ansis Atteka
as missing in new_interfaces dictionary. Signed-off-by: Ansis Atteka Reported-by: Niklas Andersson --- debian/ovs-monitor-ipsec |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec index ac2cd7e..fc69268 100755 --- a/

[ovs-dev] [PATCH v2] ovs-monitor-ipsec: Detect correctly IPSEC configuration changes

2012-03-08 Thread Ansis Atteka
as missing in new_interfaces dictionary. v2: Do not fail buildtests Signed-off-by: Ansis Atteka Reported-by: Niklas Andersson --- debian/ovs-monitor-ipsec |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec ind

Re: [ovs-dev] [PATCH v2] ovs-monitor-ipsec: Detect correctly IPSEC configuration changes

2012-03-08 Thread Ansis Atteka
Thanks pushed into 1.[3456] and master. On Thu, Mar 8, 2012 at 7:22 PM, Ethan Jackson wrote: > Looks good to me, thanks. > > Ethan > > On Thu, Mar 8, 2012 at 19:18, Ansis Atteka wrote: > > If Open vSwitch has IPSEC tunnel (with certificates) and Interface > >

[ovs-dev] [PATCH] documentation: use correct rundir in INSTALL.Linux to terminate OVS

2012-03-21 Thread Ansis Atteka
This patch fixes a minor documentation flaw where INSTALL.Linux uses incorrect path to find ovsdb-server and ovs-vswitchd PIDs. The default rundir is actually /usr/local/var/run/openvswitch/ instead of /usr/local/var/run/. Signed-off-by: Ansis Atteka --- INSTALL.Linux |2 +- 1 files changed

Re: [ovs-dev] [PATCH] documentation: use correct rundir in INSTALL.Linux to terminate OVS

2012-03-21 Thread Ansis Atteka
Thanks, pushed it to master. On Wed, Mar 21, 2012 at 11:18 AM, Ben Pfaff wrote: > On Wed, Mar 21, 2012 at 11:13:36AM -0700, Ansis Atteka wrote: > > This patch fixes a minor documentation flaw where INSTALL.Linux uses > > incorrect path to find ovsdb-server and ovs-vswitchd PI

[ovs-dev] [PATCH] datapath: fix lock up issue in ovs_vport_cmd_set()

2012-03-21 Thread Ansis Atteka
If ovs_vport_cmd_build_info() function failed inside ovs_vport_cmd_set() then the rtnl lock must be released. Signed-off-by: Ansis Atteka --- datapath/datapath.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index d64fc32

Re: [ovs-dev] [libvirt] Problem with Open vSwitch and dnsmasq

2012-03-22 Thread Ansis Atteka
On Thu, Mar 22, 2012 at 11:11 AM, Daniele Milani wrote: > I think I could try the first solution. Can you explain me how do I > create the port used by dnsmasq? > > For example, is it correct to execute > # ovs-vsctl add-port virbr1 port2 tag=2 > to create a port for the vLan whose tag is 2 named

Re: [ovs-dev] [PATCH] datapath: fix lock up issue in ovs_vport_cmd_set()

2012-03-22 Thread Ansis Atteka
On Thu, Mar 22, 2012 at 10:37 AM, Jesse Gross wrote: > On Wed, Mar 21, 2012 at 5:13 PM, Ansis Atteka wrote: > > diff --git a/datapath/datapath.c b/datapath/datapath.c > > index d64fc32..aa5be89 100644 > > --- a/datapath/datapath.c > > +++ b/datapath/datapath.c >

Re: [ovs-dev] [libvirt] Problem with Open vSwitch and dnsmasq

2012-03-23 Thread Ansis Atteka
On Fri, Mar 23, 2012 at 4:14 AM, Daniele Milani wrote: > > > -- > Date: Thu, 22 Mar 2012 11:43:03 -0700 > > Subject: Re: [libvirt] Problem with Open vSwitch and dnsmasq > From: aatt...@nicira.com > To: dano1...@hotmail.it > CC: libvir-l...@redhat.com; roberto.sa...@pol

[ovs-dev] [PATCH 1/2] datapath: Do not send success message when OVS_VPORT_CMD_SET command fails

2012-03-23 Thread Ansis Atteka
kernel module (e.g. when user-space attempts to create two tunnels with duplicate configs). Issue#10285 Signed-off-by: Ansis Atteka --- datapath/datapath.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index

[ovs-dev] [PATCH 2/2] vswitchd: Remove port from datapath before setting ofport column to -1

2012-03-23 Thread Ansis Atteka
This patch removes port from datapath before vswitchd sets ofport column to -1 (e.g. if user-space attempted to create a duplicate tunnel then kernel would reject config changes and leave the old tunnel with its old config. Hence the user-space have to remove it) Signed-off-by: Ansis Atteka

Re: [ovs-dev] [PATCH 2/2] vswitchd: Remove port from datapath before setting ofport column to -1

2012-03-23 Thread Ansis Atteka
On Fri, Mar 23, 2012 at 6:04 PM, Ansis Atteka wrote: > This patch removes port from datapath before vswitchd sets ofport column > to -1 (e.g. if user-space attempted to create a duplicate tunnel then > kernel would reject config changes and leave the old tunnel with its old > confi

Re: [ovs-dev] [PATCH] DESIGN: Fix alignment in table.

2012-03-26 Thread Ansis Atteka
On Mon, Mar 26, 2012 at 3:01 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > DESIGN |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/DESIGN b/DESIGN > index 2112925..ec29e39 100644 > --- a/DESIGN > +++ b/DESIGN > @@ -125,8 +125,8 @@ below the table. >

[ovs-dev] [PATCH] ovs-test: Enhancments to the ovs-test tool

2012-03-30 Thread Ansis Atteka
Node2:ovs-test -c 127.0.0.1,1.1.1.1 192.168.122.151,1.1.1.2 -d -l 125 -t gre Signed-off-by: Ansis Atteka --- python/automake.mk |3 +- python/ovstest/args.py | 152 +++--- python/ovstest/rpcserver.py | 146 +++- python/ovstest/tcp.py

Re: [ovs-dev] [PATCH 2/2] vswitchd: Remove port from datapath before setting ofport column to -1

2012-03-30 Thread Ansis Atteka
On Fri, Mar 30, 2012 at 2:06 PM, Ben Pfaff wrote: > On Fri, Mar 23, 2012 at 06:04:50PM -0700, Ansis Atteka wrote: > > This patch removes port from datapath before vswitchd sets ofport column > > to -1 (e.g. if user-space attempted to create a duplicate tunnel then > > kerne

Re: [ovs-dev] Openvswitch support - port tagging

2012-04-02 Thread Ansis Atteka
On Mon, Apr 2, 2012 at 5:56 AM, Daniele Milani wrote: > I was looking at the release candidate of libvirt (0.9.11-rc2) and I > have not been able to understand if the openvswitch support includes the > port tagging support. > If your question is "Whether it is possible to specify VLAN tag in Dom

Re: [ovs-dev] [PATCH 1/2] datapath: Do not send success message when OVS_VPORT_CMD_SET command fails

2012-04-04 Thread Ansis Atteka
On Mon, Mar 26, 2012 at 11:21 AM, Jesse Gross wrote: > On Fri, Mar 23, 2012 at 6:04 PM, Ansis Atteka wrote: > > diff --git a/datapath/datapath.c b/datapath/datapath.c > > index d64fc32..daf7b69 100644 > > --- a/datapath/datapath.c > > +++ b/datapath/datapath.c >

Re: [ovs-dev] [PATCH] ovs-test: Enhancments to the ovs-test tool

2012-04-04 Thread Ansis Atteka
On Mon, Apr 2, 2012 at 1:28 PM, Ben Pfaff wrote: > On Fri, Mar 30, 2012 at 01:10:26PM -0700, Ansis Atteka wrote: > > -Implemented support for ovs-test client, so that it could automatically > > spawn an ovs-test server process from itself. This reduces the number of > > comm

Re: [ovs-dev] [ovs-discuss] Problem with KVM Creating Bridge

2012-04-05 Thread Ansis Atteka
it already exists, but I am >> > unable to use the bridge. >> >> That is strange. What's in the OVS log from the time that >> ovs-vswitchd started up? >> >> OVS by default persists the bridge setup from one boot to another. If >> you want to instea

[ovs-dev] [PATCH 1/3] datapath: Do not send notification if ovs_vport_set_options() failed

2012-04-06 Thread Ansis Atteka
There is no need to send a notification if ovs_vport_set_options() failed and ovs_vport_cmd_set() did not change anything. Issue#10285 Signed-off-by: Ansis Atteka --- datapath/datapath.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/datapath/datapath.c b/datapath

[ovs-dev] [PATCH 2/3] vswitchd: Remove port from datapath if it becomes non-operational

2012-04-06 Thread Ansis Atteka
options:remote_ip=2.1.1.1 options:key=123 type=gre ovs-vsctl set Interface p2 options:remote_ip=1.1.1.1 options:key=123 type=gre ovs-vsctl set Interface p2 options:remote_ip=2.1.1.1 options:key=123 type=gre ovs-dpctl show #observe that p2 does not appear here anymore Signed-off-by: Ansis Atteka --- vswitchd

[ovs-dev] [PATCH 3/3] datapath: Release rtnl_lock if ovs_vport_cmd_build_info() failed

2012-04-06 Thread Ansis Atteka
This patch fixes a possible lock-up bug where rtnl_lock might not get released. Signed-off-by: Ansis Atteka --- datapath/datapath.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 2fe6fdd..76f7a2c 100644 --- a/datapath

Re: [ovs-dev] [PATCH 1/3] datapath: Do not send notification if ovs_vport_set_options() failed

2012-04-10 Thread Ansis Atteka
Pushed this to master, 1.6 and 1.5. On Mon, Apr 9, 2012 at 9:08 AM, Jesse Gross wrote: > On Fri, Apr 6, 2012 at 6:07 PM, Ansis Atteka wrote: > > There is no need to send a notification if ovs_vport_set_options() failed > > and ovs_vport_cmd_set() did not change anything. >

Re: [ovs-dev] [PATCH 2/3] vswitchd: Remove port from datapath if it becomes non-operational

2012-04-10 Thread Ansis Atteka
Pushed into master, 1.6 and 1.5. On Sun, Apr 8, 2012 at 8:00 PM, Ben Pfaff wrote: > On Fri, Apr 06, 2012 at 06:07:57PM -0700, Ansis Atteka wrote: > > If kernel module rejects config changes then vswitchd sets the ofport > > column to -1, but does not remove the non-operationa

[ovs-dev] [PATCH] documentation: Add INSTALL.Libvirt file

2012-04-10 Thread Ansis Atteka
Add documentation on how to use OVS integration with the upcoming Libvirt 0.9.11 release. Signed-off-by: Ansis Atteka --- INSTALL.Libvirt | 73 +++ 1 files changed, 73 insertions(+), 0 deletions(-) create mode 100644 INSTALL.Libvirt diff

[ovs-dev] [PATCHv2] ovs-test: Enhancements to the ovs-test tool

2012-04-10 Thread Ansis Atteka
Node2:ovs-test -c 127.0.0.1,1.1.1.1 192.168.122.151,1.1.1.2 -d -l 125 -t gre Signed-off-by: Ansis Atteka --- NEWS|4 + python/automake.mk |3 +- python/ovstest/args.py | 156 +++-- python/ovstest/rpcserver.py | 156

Re: [ovs-dev] [PATCH] documentation: Add INSTALL.Libvirt file

2012-04-11 Thread Ansis Atteka
Kyle > > On Apr 10, 2012, at 4:32 PM, Ansis Atteka wrote: > > > Add documentation on how to use OVS integration > > with the upcoming Libvirt 0.9.11 release. > > > > Signed-off-by: Ansis Atteka > > --- > > INSTALL.Libvirt | 73 > ++

Re: [ovs-dev] [PATCH] documentation: Add INSTALL.Libvirt file

2012-04-12 Thread Ansis Atteka
On Wed, Apr 11, 2012 at 9:51 AM, Ben Pfaff wrote: > On Tue, Apr 10, 2012 at 02:32:48PM -0700, Ansis Atteka wrote: > > Add documentation on how to use OVS integration > > with the upcoming Libvirt 0.9.11 release. > > Thanks for writing this! > > Here, you might conside

[ovs-dev] [PATCHv2] documentation: Add INSTALL.Libvirt file

2012-04-15 Thread Ansis Atteka
Add documentation on how to use OVS integration with the upcoming Libvirt 0.9.11 release. Signed-off-by: Ansis Atteka --- INSTALL.Libvirt | 72 +++ Makefile.am |1 + README |2 + 3 files changed, 75 insertions(+), 0

[ovs-dev] [PATCH] ovs-save: Add "dev" keyword before interface names in the ip commands

2012-04-15 Thread Ansis Atteka
erated ip commands are clearly interpretable by the ip utility. Issue #9841 Signed-off-by: Ansis Atteka --- utilities/ovs-save |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/utilities/ovs-save b/utilities/ovs-save index 323d184..de31290 100755 --- a/utilities/ovs

Re: [ovs-dev] [PATCH] ovs-save: Add "dev" keyword before interface names in the ip commands

2012-04-16 Thread Ansis Atteka
On Mon, Apr 16, 2012 at 9:33 AM, Ben Pfaff wrote: > On Sun, Apr 15, 2012 at 11:35:26PM -0700, Ansis Atteka wrote: > > The "service force-reload-kmod" command did not work properly, if there > > was a bridge, which name was a prefix of string "broadcast" (e.g. &

Re: [ovs-dev] [PATCHv2] documentation: Add INSTALL.Libvirt file

2012-04-16 Thread Ansis Atteka
On Mon, Apr 16, 2012 at 9:36 AM, Ben Pfaff wrote: > On Sun, Apr 15, 2012 at 11:27:48PM -0700, Ansis Atteka wrote: > > Add documentation on how to use OVS integration > > with the upcoming Libvirt 0.9.11 release. > > > > Signed-off-by: Ansis Atteka > > Looks go

[ovs-dev] [PATCHv3] ovs-test: Enhancements to the ovs-test tool

2012-04-16 Thread Ansis Atteka
Node2:ovs-test -c 127.0.0.1,1.1.1.1 192.168.122.151,1.1.1.2 -d -l 125 -t gre Signed-off-by: Ansis Atteka --- NEWS|4 + python/automake.mk |3 +- python/ovstest/args.py | 180 ++--- python/ovstest/rpcserver.py | 167

[ovs-dev] [PATCHv4] ovs-test: Enhancements to the ovs-test tool

2012-04-17 Thread Ansis Atteka
Node2:ovs-test -c 127.0.0.1,1.1.1.1 192.168.122.151,1.1.1.2 -d -l 125 -t gre Signed-off-by: Ansis Atteka --- NEWS|4 + python/automake.mk |3 +- python/ovstest/args.py | 180 ++--- python/ovstest/rpcserver.py | 176

[ovs-dev] [PATCHv5] ovs-test: Enhancements to the ovs-test tool

2012-04-18 Thread Ansis Atteka
Node2:ovs-test -c 127.0.0.1,1.1.1.1 192.168.122.151,1.1.1.2 -d -l 125 -t gre Signed-off-by: Ansis Atteka --- NEWS|4 + python/automake.mk |3 +- python/ovstest/args.py | 180 ++--- python/ovstest/rpcserver.py | 176

[ovs-dev] [PATCH] automake: ofp-errors.[c|inc] are actually inside srcdir

2012-04-19 Thread Ansis Atteka
This patch fixes a build error when OVS is built inside "./_debian" directory. To reproduce this issue run "fakeroot debian/rules binary" or "debuild binary" inside the git root directory. Signed-off-by: Ansis Atteka --- lib/automake.mk |2 +- 1 file chang

Re: [ovs-dev] [PATCH] automake: ofp-errors.[c|inc] are actually inside srcdir

2012-04-20 Thread Ansis Atteka
On Fri, Apr 20, 2012 at 9:45 AM, Ben Pfaff wrote: > On Thu, Apr 19, 2012 at 12:54:16PM -0700, Ansis Atteka wrote: > > This patch fixes a build error when OVS is built inside > > "./_debian" directory. > > > > To reproduce this issue run "fakeroot d

Re: [ovs-dev] [PATCH] automake: ofp-errors.[c|inc] are actually inside srcdir

2012-04-20 Thread Ansis Atteka
On Fri, Apr 20, 2012 at 10:18 AM, Ben Pfaff wrote: > On Fri, Apr 20, 2012 at 10:08:01AM -0700, Ansis Atteka wrote: > > On Fri, Apr 20, 2012 at 9:45 AM, Ben Pfaff wrote: > > > > > On Thu, Apr 19, 2012 at 12:54:16PM -0700, Ansis Atteka wrote: > > > > This p

[ovs-dev] [PATCH] nicira-ext: Support masking of nd_target field

2012-04-25 Thread Ansis Atteka
This commit adds support to specify a mask in CIDR format for the nd_target field. Signed-off-by: Ansis Atteka --- NEWS |2 ++ include/openflow/nicira-ext.h |6 -- lib/classifier.c | 26 -- lib/classifier.h

Re: [ovs-dev] [PATCH branch-1.4] tests: Fix mirroring tests on big-endian architectures.

2012-04-26 Thread Ansis Atteka
On Thu, Apr 26, 2012 at 11:06 AM, Ben Pfaff wrote: > These tests had a hidden dependency on the hash function in use, > which yields different results on big-endian and little-endian > architectures. This commit fixes the problem by properly > parameterizing the parts that can differ. > > Signed

Re: [ovs-dev] [PATCH] nicira-ext: Support masking of nd_target field

2012-04-26 Thread Ansis Atteka
On Thu, Apr 26, 2012 at 3:14 PM, Ben Pfaff wrote: > On Wed, Apr 25, 2012 at 04:09:51PM -0700, Ansis Atteka wrote: > > This commit adds support to specify a mask in CIDR format for > > the nd_target field. > > > > Signed-off-by: Ansis Atteka > > Looks good to m

Re: [ovs-dev] [PATCH] meta-flow: Correctly set destination MAC in mf_set_flow_value().

2012-04-27 Thread Ansis Atteka
On Fri, Apr 27, 2012 at 8:45 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/meta-flow.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/meta-flow.c b/lib/meta-flow.c > index 3db528f..82e9e9b 100644 > --- a/lib/meta-flow.c > +++ b/lib/meta-flow.c >

[ovs-dev] [PATCHv2] datapath: Release rtnl_lock if ovs_vport_cmd_build_info() failed

2012-05-03 Thread Ansis Atteka
This patch fixes a possible lock-up bug where rtnl_lock might not get released. Signed-off-by: Ansis Atteka --- datapath/datapath.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 079b3f2..63713d8 100644 --- a/datapath

Re: [ovs-dev] [PATCHv2] datapath: Release rtnl_lock if ovs_vport_cmd_build_info() failed

2012-05-03 Thread Ansis Atteka
On Thu, May 3, 2012 at 5:12 PM, Jesse Gross wrote: > On Thu, May 3, 2012 at 2:29 PM, Ansis Atteka wrote: > > This patch fixes a possible lock-up bug where rtnl_lock might not > > get released. > > > > Signed-off-by: Ansis Atteka > > Thanks Ansis. > > Ack

[ovs-dev] [PATCH] ovs-l3ping: A new test utility that can detect L3 tunnel related issues

2012-06-28 Thread Ansis Atteka
replacement for ovs-test, because ovs-test covers much broader set of test cases. Sample usage: Node1: ovs-l3ping -s 192.168.122.236,10.1.1.1 -t gre Node2: ovs-l3ping -c 192.168.122.220,10.1.1.2,10.1.1.1 -t gre Issue#11791 Signed-off-by: Ansis Atteka --- NEWS |5

[ovs-dev] [PATCH] ovs-l3ping: A new test utility that allows to detect L3 tunneling issues

2012-06-28 Thread Ansis Atteka
-test, because ovs-test covers much broader set of test cases. Sample usage: Node1: ovs-l3ping -s 192.168.122.236,10.1.1.1 -t gre Node2: ovs-l3ping -c 192.168.122.220,10.1.1.2,10.1.1.1 -t gre Issue#11791 Signed-off-by: Ansis Atteka --- NEWS |5 + debian/openvswitch

[ovs-dev] [PATCv2] ovs-l3ping: A new test utility that allows to detect L3 tunneling issues

2012-06-29 Thread Ansis Atteka
-test, because ovs-test covers much broader set of test cases. Sample usage: Node1: ovs-l3ping -s 192.168.122.236,10.1.1.1 -t gre Node2: ovs-l3ping -c 192.168.122.220,10.1.1.2,10.1.1.1 -t gre Issue#11791 Signed-off-by: Ansis Atteka --- NEWS |5 + debian/openvswitch

Re: [ovs-dev] [PATCv2] ovs-l3ping: A new test utility that allows to detect L3 tunneling issues

2012-07-02 Thread Ansis Atteka
On Mon, Jul 2, 2012 at 9:46 AM, Ben Pfaff wrote: > On Fri, Jun 29, 2012 at 10:45:47PM -0700, Ansis Atteka wrote: > > ovs-l3ping is similar to ovs-test, but the main difference > > is that it does not require administrator to open firewall > > holes for the XML/RPC contro

Re: [ovs-dev] [PATCv2] ovs-l3ping: A new test utility that allows to detect L3 tunneling issues

2012-07-02 Thread Ansis Atteka
On Mon, Jul 2, 2012 at 11:39 AM, Ben Pfaff wrote: > On Mon, Jul 02, 2012 at 11:34:39AM -0700, Ansis Atteka wrote: > > On Mon, Jul 2, 2012 at 9:46 AM, Ben Pfaff wrote: > > > > > On Fri, Jun 29, 2012 at 10:45:47PM -0700, Ansis Atteka wrote: > > > > ovs-l3ping

[ovs-dev] [PATCv3] ovs-l3ping: A new test utility that allows to detect L3 tunneling issues

2012-07-02 Thread Ansis Atteka
-test, because ovs-test covers much broader set of test cases. Sample usage: Node1: ovs-l3ping -s 192.168.122.236,10.1.1.1 -t gre Node2: ovs-l3ping -c 192.168.122.220,10.1.1.2,10.1.1.1 -t gre Issue#11791 Signed-off-by: Ansis Atteka --- NEWS |3 + debian/openvswitch

[ovs-dev] [PATCv3] ovs-l3ping: A new test utility that allows to detect L3 tunneling issues

2012-07-02 Thread Ansis Atteka
-test, because ovs-test covers much broader set of test cases. Sample usage: Node1: ovs-l3ping -s 192.168.122.236,10.1.1.1 -t gre Node2: ovs-l3ping -c 192.168.122.220,10.1.1.2,10.1.1.1 -t gre Issue#11791 Signed-off-by: Ansis Atteka --- NEWS |3 + debian/openvswitch

Re: [ovs-dev] [PATCv3] ovs-l3ping: A new test utility that allows to detect L3 tunneling issues

2012-07-02 Thread Ansis Atteka
On Mon, Jul 2, 2012 at 12:22 PM, Ben Pfaff wrote: > On Mon, Jul 02, 2012 at 12:10:12PM -0700, Ansis Atteka wrote: > > ovs-l3ping is similar to ovs-test, but the main difference > > is that it does not require administrator to open firewall > > holes for the XML/RPC contro

[ovs-dev] [PATCH] Fix build error on XenServer

2012-07-02 Thread Ansis Atteka
A missing backslash broke the build. Signed-off-by: Ansis Atteka --- xenserver/openvswitch-xen.spec.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xenserver/openvswitch-xen.spec.in b/xenserver/openvswitch-xen.spec.in index 3b9582e..c34c7db 100644 --- a/xenserver

Re: [ovs-dev] [PATCH] Fix build error on XenServer

2012-07-02 Thread Ansis Atteka
On Mon, Jul 2, 2012 at 3:05 PM, Ben Pfaff wrote: > On Mon, Jul 02, 2012 at 03:03:46PM -0700, Ansis Atteka wrote: > > A missing backslash broke the build. > > > > Signed-off-by: Ansis Atteka > > Looks good, thanks. >

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid use-after-free upon "ofctl/unblock" when connection dies.

2012-07-12 Thread Ansis Atteka
On Thu, Jul 12, 2012 at 4:05 PM, Ben Pfaff wrote: > The implementation of "ofctl/block" used a nested poll loop, with an inner > call to unixctl_server_run(). This poll loop always ran inside an outer > call to unixctl_server_run(), since that's the context within which unixctl > command impleme

Re: [ovs-dev] [PATCH] ofp-actions: Improve comments.

2012-07-16 Thread Ansis Atteka
On Mon, Jul 16, 2012 at 9:37 AM, Ben Pfaff wrote: > Reported-by: Joe Stringer > Signed-off-by: Ben Pfaff > --- > lib/ofp-actions.c | 14 ++ > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c > index 93f6bf7..582b5ae 100644 >

Re: [ovs-dev] [PATCH] debian: Remove controller keys on openvswitch-controller package purge.

2012-07-20 Thread Ansis Atteka
On Fri, Jul 20, 2012 at 9:24 AM, Ben Pfaff wrote: > A Debian package is expected to remove all its configuration files (which > includes all files in /etc) when it is purged, but the > openvswitch-controller package wasn't doing that. This fixes the problem. > > Debian bug #682187. > CC: 682...@

Re: [ovs-dev] [PATCH] debian: Remove controller keys on openvswitch-controller package purge.

2012-07-20 Thread Ansis Atteka
On Fri, Jul 20, 2012 at 1:16 PM, Ben Pfaff wrote: > On Fri, Jul 20, 2012 at 12:16:30PM -0700, Ansis Atteka wrote: > > On Fri, Jul 20, 2012 at 9:24 AM, Ben Pfaff wrote: > > > > > A Debian package is expected to remove all its configuration files > (which > > >

Re: [ovs-dev] Bug#681880: [bug 681880 3/3] debian: Move database from /etc/openvswitch to /var/lib/openvswitch.

2012-07-26 Thread Ansis Atteka
On Thu, Jul 26, 2012 at 2:48 PM, Ben Pfaff wrote: > Debian bug #681880. > CC: 681...@bugs.debian.org > Reported-by: Bastian Blank > Signed-off-by: Ben Pfaff > --- > REPORTING-BUGS |2 +- > debian/automake.mk |1 + > debian/openvswitch-switch.dirs

Re: [ovs-dev] Bug#681880: [bug 681880 3/3] debian: Move database from /etc/openvswitch to /var/lib/openvswitch.

2012-07-26 Thread Ansis Atteka
On Thu, Jul 26, 2012 at 4:47 PM, Ansis Atteka wrote: > > > On Thu, Jul 26, 2012 at 2:48 PM, Ben Pfaff wrote: > >> Debian bug #681880. >> CC: 681...@bugs.debian.org >> Reported-by: Bastian Blank >> Signed-off-by: Ben Pfaff >> --- >> REPORTI

Re: [ovs-dev] Bug#681880: [bug 681880 2/3] ovsdb: Make "ovsdb-tool create" work through a dangling symlink.

2012-07-26 Thread Ansis Atteka
On Thu, Jul 26, 2012 at 2:48 PM, Ben Pfaff wrote: > open() with O_CREAT|O_EXCL yields EEXIST if the name passed in is a > symlink, but we would like "ovsdb-tool create /etc/openvswitch/conf.db" to > work if /etc/openvswitch/conf.db is a symlink to elsewhere in the file > system. This commit fixe

Re: [ovs-dev] [debian 0/9] move conf.db from /etc to /var on Debian

2012-07-30 Thread Ansis Atteka
On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff wrote: > Here's a series that takes the "bug 681880" series from last week > a step further, both fixing a bug that Bastian Blank pointed out > (regarding compaction) and making the implementation safer. > > Ansis already reviewed the first three patches

Re: [ovs-dev] [debian 0/9] move conf.db from /etc to /var on Debian

2012-07-30 Thread Ansis Atteka
On Mon, Jul 30, 2012 at 6:30 PM, Ansis Atteka wrote: > > > On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff wrote: > >> Here's a series that takes the "bug 681880" series from last week >> a step further, both fixing a bug that Bastian Blank pointed out &

Re: [ovs-dev] [debian 5/9] debian: Configure Debian packages to use /var/lib/openvswitch for conf.db.

2012-07-31 Thread Ansis Atteka
On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff wrote: > Working through symlinks is undesirable when one can avoid it. > > The Debian packaging still sets up the symlinks for compatibility with > existing software that expects the database to be in /etc/openvswitch. > > Signed-off-by: Ben Pfaff > --

Re: [ovs-dev] [debian 5/9] debian: Configure Debian packages to use /var/lib/openvswitch for conf.db.

2012-07-31 Thread Ansis Atteka
On Tue, Jul 31, 2012 at 9:21 AM, Ben Pfaff wrote: > On Tue, Jul 31, 2012 at 09:16:32AM -0700, Ansis Atteka wrote: > > On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff wrote: > > > > > Working through symlinks is undesirable when one can avoid it. > > > > > &

Re: [ovs-dev] [debian 7/9] util: New function follow_symlinks().

2012-07-31 Thread Ansis Atteka
On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff wrote: > It will acquire its first user in an upcoming commit. > > Signed-off-by: Ben Pfaff > --- > lib/util.c | 85 + > lib/util.h |3 ++ > tests/file_name.at | 97 > +

Re: [ovs-dev] [debian 6/9] tests: Slightly generalize utility function tests.

2012-07-31 Thread Ansis Atteka
On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff wrote: > This will allow passing arguments in for an upcoming test. > > Signed-off-by: Ben Pfaff > --- > tests/library.at | 15 ++-- > tests/test-util.c | 90 > +--- > 2 files changed, 68 inserti

Re: [ovs-dev] [debian 8/9] lockfile: Be more forgiving about lockfiles for symlinks.

2012-07-31 Thread Ansis Atteka
On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff wrote: > As the database is being transitioned from /etc to /var, there is a symlink > from the old to the new location for the database and a symlink for its > lockfile. This works OK, but it would be more user-friendly to still work > correctly in cas

Re: [ovs-dev] [debian 9/9] ovsdb: Do not replace symlinks by regular files during compaction.

2012-07-31 Thread Ansis Atteka
On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > ovsdb/file.c |7 +-- > ovsdb/ovsdb-tool.c| 22 ++ > tests/ovsdb-server.at | 15 ++- > tests/ovsdb-tool.at | 17 - > 4 files changed,

Re: [ovs-dev] [debian 4/9] Make the location of the database separately configurable.

2012-07-31 Thread Ansis Atteka
On Mon, Jul 30, 2012 at 3:18 PM, Ben Pfaff wrote: > The default is unchanged, /etc/openvswitch/conf.db. > > This makes it possible to transition each Open vSwitch packaging from > /etc/openvswitch/conf.db to /var/lib/openvswitch/conf.db independently. > > Signed-off-by: Ben Pfaff > --- > Makefi

[ovs-dev] [PATCH 2/2] debian: Decoupled ovs-vlan-test utility from main openvswitch package.

2011-10-18 Thread Ansis Atteka
--- debian/automake.mk |3 +++ debian/control | 10 ++ debian/openvswitch-switch.install |1 - debian/openvswitch-switch.manpages |1 - debian/openvswitch-test.dirs |1 + debian/openvswitch-test.install|1 + debian/openvs

[ovs-dev] [PATCH 1/2] ovs-vlan-test: Add iperf to test basic connectivity.

2011-10-18 Thread Ansis Atteka
ovs-vlan-test runs through a number of tests to identify VLAN issues. This is useful when trying to debug why a particular driver has issues, but it made the testing environment a bit harder to set up. This commit adds an iperf test to check basic functionality. It also useful in detecting perfo

Re: [ovs-dev] [PATCH 1/2] ovs-vlan-test: Add iperf to test basic connectivity.

2011-10-19 Thread Ansis Atteka
n send is 52-bytes Thanks, Ansis On Wed, Oct 19, 2011 at 11:21 AM, Jesse Gross wrote: > On Tue, Oct 18, 2011 at 9:23 PM, Ansis Atteka wrote: > > ovs-vlan-test runs through a number of tests to identify VLAN issues. > This > > is useful when trying to debug why a particular

Re: [ovs-dev] [PATCH 1/2] ovs-vlan-test: Add iperf to test basic connectivity.

2011-10-19 Thread Ansis Atteka
re fast > enough to handle the emulation at 1G. This is interesting to note but > is a hardware limitation, not a bug. > * Performance close (but probably not exactly) 0 for tagged traffic. > This is generally means that there is a problem with TSO and only > small packets get throug

Re: [ovs-dev] [PATCH 1/2] ovs-vlan-test: Add iperf to test basic connectivity.

2011-10-19 Thread Ansis Atteka
On Wed, Oct 19, 2011 at 6:33 PM, Jesse Gross wrote: > On Wed, Oct 19, 2011 at 5:28 PM, Ethan Jackson wrote: > >> Implement ovs-vlan-test server logic so that it would restart iperf TCP > >> server every-time iperf-server exited because of this bug, > >> For TCP (or maybe also for UDP) use a diff

Re: [ovs-dev] [PATCH 1/2] ovs-vlan-test: Add iperf to test basic connectivity.

2011-10-21 Thread Ansis Atteka
et close to 10 Gbps of traffic. Thanks, Ansis On Wed, Oct 19, 2011 at 8:45 PM, Jesse Gross wrote: > On Wed, Oct 19, 2011 at 6:55 PM, Ansis Atteka wrote: > > > > On Wed, Oct 19, 2011 at 6:33 PM, Jesse Gross wrote: > >> > >> On Wed, Oct 19, 2011 at 5:28 PM, Ethan J

[ovs-dev] [PATCH] ovs-test: A new tool that allows to diagnose connectivity and performance issues

2011-10-31 Thread Ansis Atteka
This tool will be a replacement for the current ovs-vlan-test utility. Besides from connectivity issues it will also be able to detect performance related issues in Open vSwitch setups. Currently it uses UDP and TCP protocols for stressing. Issue #6976 --- Makefile.am |1

[ovs-dev] [PATCH 1/2] packaging: dpkg --purge command fails on Ubuntu 11.04

2011-11-01 Thread Ansis Atteka
The problem is that postrm script is unable to remove contents of /var/log/openvswitch/ directory in case if it contains any other directories. Steps to reproduce on Ubuntu 11.04: 1. apt-get install openvswitch-switch 2. dpkg --purge openvswitch-switch 3. observe that purge failed, because of an em

[ovs-dev] [PATCH 2/2] ovs-appctl: Add fdb/flush command

2011-11-01 Thread Ansis Atteka
Added a new command that will allow to flush particular bridge's MAC learning table. Issue #7819 --- NEWS |2 ++ ofproto/ofproto-dpif.c | 18 ++ vswitchd/ovs-vswitchd.8.in |2 ++ 3 files changed, 22 insertions(+), 0 deletions(-) diff --git a/NE

Re: [ovs-dev] [PATCH] ovs-test: A new tool that allows to diagnose connectivity and performance issues

2011-11-02 Thread Ansis Atteka
On Wed, Nov 2, 2011 at 3:49 PM, Jesse Gross wrote: > On Mon, Oct 31, 2011 at 5:00 PM, Ansis Atteka wrote: > > UDP performance is currently limited to much lower numbers than for TCP. > > This could be improved in future releases. The cause for UDP performance > > penalty is

Re: [ovs-dev] [PATCH] ovs-test: A new tool that allows to diagnose connectivity and performance issues

2011-11-03 Thread Ansis Atteka
On Wed, Nov 2, 2011 at 6:36 PM, Jesse Gross wrote: > On Wed, Nov 2, 2011 at 5:13 PM, Ansis Atteka wrote: > > On Wed, Nov 2, 2011 at 3:49 PM, Jesse Gross wrote: > >> > >> On Mon, Oct 31, 2011 at 5:00 PM, Ansis Atteka > wrote: > >> > UDP performance

Re: [ovs-dev] [PATCH] ovs-test: A new tool that allows to diagnose connectivity and performance issues

2011-11-03 Thread Ansis Atteka
On Thu, Nov 3, 2011 at 1:32 PM, Jesse Gross wrote: > On Thu, Nov 3, 2011 at 10:38 AM, Ansis Atteka wrote: > > > > > > On Wed, Nov 2, 2011 at 6:36 PM, Jesse Gross wrote: > >> > >> On Wed, Nov 2, 2011 at 5:13 PM, Ansis Atteka > wrote: > >> &

[ovs-dev] [PATCH] datapath: Kernel flow metadata parsing should be less restrictive

2011-11-08 Thread Ansis Atteka
The function flow_metadata_from_nlattrs() is very restrictive about the ordering and type of metadata attributes that it receives. This patch will change flow_metadata_from_nlattrs() behavior by ignoring attributes that it does not understand and allowing them to be passed in arbitrary order. Issu

<    1   2   3   4   5   >