Hey Saurabh,
I applied the patches that you sent. Everything seems to compile fine and
install properly.
I tried to set-up a tunnel between two hypervisors following the steps in
INSTALL.Windows.
(I tried with Hyper-V to Hyper-V and KVM to Hyper-V)
Here is my configuration on H1:
PS C:\ovs_gu
{}
type: vxlan
PS C:\ovs_guys\binaries>
Kind Regards,
Alin.
From: Saurabh Shah [ssaur...@vmware.com]
Sent: Saturday, July 26, 2014 3:42 AM
To: Alin Serdean; Alessandro Pilotti
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2 0/3] Support for
kets=0, tx_bytes=0, tx_dropped=0, tx_errors=0, tx_packets=0}
status : {}
type: vxlan
Kind Regards,
Alin.
From: dev [dev-boun...@openvswitch.org] on behalf of Alin Serdean
[aserd...@cloudbasesolutions.com]
Sent: Saturday, July 26
t: Saturday, July 26, 2014 4:52 AM
To: Alin Serdean; Alessandro Pilotti
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2 0/3] Support for OVS datapath on Windows
platform.
Here is what I would like you to quickly try -
01. Disable TX/RX checksum offloads on both VM¹s & PNIC.
02. Do
AM
To: Alin Serdean; Alessandro Pilotti
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2 0/3] Support for OVS datapath on Windows
platform.
>
>I disabled RX/TX
>(02) works
>(03) works
>
>Here is a flow with a tun_id maybe it will help:
>PS C:\ovs_guys\binaries> .\ovs-d
Add MAX_LINKS define needed for nl_pool.
Add NLM_F_CREATE and NLM_F_EXCL defines also.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink-protocol.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/netlink-protocol.h b/lib/netlink-protocol.h
index 88b7abf..8938055 100644
--- a/lib/n
Bypass the error compilation when compiling under MSVC.
Signed-off-by: Alin Gabriel Serdean
---
lib/netlink-socket.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/netlink-socket.h b/lib/netlink-socket.h
index d53db4e..2b9ec52 100644
--- a/lib/netlink-socket.h
+++ b/lib/netlink-socket
Add two functions set_sock_pid_in_kernel and portid_next. This will allow
the channel identification for the kernel extension to send back messages.
Replace send with WriteFile equivalent and ignore nl_sock_drain for the moment
under MSVC.
Replace sendmsg and recvmsg with ReadFile and WriteFile e
Add netlink related files to the windows build.
Signed-off-by: Alin Gabriel Serdean
---
lib/automake.mk | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/automake.mk b/lib/automake.mk
index 0997df5..87a8faa 100644
--- a/lib/automake.mk
+++ b/lib/automake.mk
@@ -319,6 +319,15 @@ l
Add defines needed to compile netlink-socket.c and netlink.c.
Add a wrapper and the functionality behind it for syconf.
Add the newly created files to the noinst_HEADERS in windows/automake.mk
Signed-off-by: Alin Gabriel Serdean
---
include/windows/automake.mk| 1 +
include/windows/ne
, 2014 11:32 AM
To: Nithin Raju
Cc: Ben Pfaff; Saurabh Shah; dev@openvswitch.org; Alin Serdean; Guolin Yang;
Eitan Eliahu; Rajiv Krishnamurthy
Subject: Re: plan to integrate Hyper-V support
Hi Nithin,
I'd also add at least:
1) Design for mapping hyper-v ports to OVS ports
2) CI testing pl
Thank you for review and the changes.
Kind Regards,
Alin.
From: Ben Pfaff [b...@nicira.com]
Sent: Tuesday, July 29, 2014 7:38 PM
To: Alin Serdean
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2 4/5] Changes needed to netlink-socket for MSVC
On
Hi,
I have opened the following issues on the Hyper-V port.
Please take a look over the following links:
BSOD when trying to set up a VXLAN tunnel
https://github.com/openvswitch/ovs/issues/9
BSOD when trying to set up a VXLAN tunnel when compiling in Release
https://github.com/openvswitch/ovs/is
Updates to the ovsext.inf to change the kernel extension name.
This is in report to issue filed under:
https://github.com/openvswitch/ovs/issues/14
by Saurabh Shah .
Signed-off-by: Alin Gabriel Serdean
Reported-by: Saurabh Shah
---
datapath-windows/ovsext/OvsDriver.c | 10 +-
datapath-
Sorry Saurabh,
I already was writing the patch and did not check my emails it in the meantime.
Kind Regards,
Alin.
From: dev [dev-boun...@openvswitch.org] on behalf of Saurabh Shah
[ssaur...@vmware.com]
Sent: Thursday, July 31, 2014 12:55 AM
To: Justin Pe
Ack-by: Alin Gabriel Serdean
From: dev [dev-boun...@openvswitch.org] on behalf of Saurabh Shah
[ssaur...@vmware.com]
Sent: Wednesday, July 30, 2014 7:03 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: Rename the extension & vendor
Hi Justin,
Sent in the Acked-by. His spelling is more consistent to the project :).
Tx!
Kind Regards,
Alin.
From: Justin Pettit [jpet...@nicira.com]
Sent: Thursday, July 31, 2014 2:03 AM
To: Alin Serdean; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH
Was just being proactive changing the strings and GUID as well :).
Kind Regards,
Alin.
From: Saurabh Shah [ssaur...@vmware.com]
Sent: Thursday, July 31, 2014 2:05 AM
To: Alin Serdean; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] Change ovsext.inf
"Reported-by: Alin Serdean " not "Reported-by:
Alin Seardean ".
Tx :).
Alin.
From: dev [dev-boun...@openvswitch.org] on behalf of Saurabh Shah
[ssaur...@vmware.com]
Sent: Wednesday, July 30, 2014 2:58 PM
To: dev@openvswitch.org
Subje
Acked-by: Alin Gabriel Serdean
From: Saurabh Shah [ssaur...@vmware.com]
Sent: Thursday, July 31, 2014 9:26 PM
To: Gurucharan Shetty; Alin Serdean
Cc: dev
Subject: Re: [ovs-dev] [PATCH] datapath-windows: Add temporary files to
gitignore.
+Alin.
From: Gurucharan
I would like to test it out also to make sure the issue does not reproduce.
Please put me in copy on the "[PATCH v2]" so I am sure that I got the latest
one.
Kind Regards,
Alin.
From: dev [dev-boun...@openvswitch.org] on behalf of Saurabh Shah
[ssaur...@
The issue can be closed. Tested it out, got no crash and double checked with
the debugger.
Acked-by: : Alin Gabriel Serdean
Kind Regards,
Alin.
From: Eitan Eliahu [elia...@vmware.com]
Sent: Friday, August 01, 2014 8:12 PM
To: Eitan Eliahu; Alin Serdean
"Win8 Debug" solution configuration updated
Reported in: https://github.com/openvswitch/ovs-issues/issues/7
Reported-by: Alin Gabriel Serdean
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext.sln | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/datap
ysgit.0
From: Ben Pfaff [b...@nicira.com]
Sent: Wednesday, August 06, 2014 4:52 AM
To: Alin Serdean
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] Update to the ovsext.sln
Could you include an explanation of the problem and how this fixes it in the
commit message, please?
Good topic for the next meeting :).
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Wednesday, August 6, 2014 7:19 AM
Către: Alin Serdean
Cc: Ben Pfaff; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Update to the ovsext.sln
On Aug 5, 2014, at 6:58 PM, Alin
Hi,
+1 to drop the OVS prefix.
One another thing that comes to mind would be to have filenames in lowercase,
but maybe that is just me.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Saurabh Shah
Trimis: Wednesday, August 6, 2014 9:52 PM
Către: Samuel
Hi Sam,
Just some pointers from me:
- format the text up to 79 characters.
- " Do not use space after "(" or before ")" ", people using vi would have a
harder time
- "o) "_" prefix for private functions", I don't quite understand. Do you mean
static?
Alin.
-Mesaj original-
De la: dev
I fully understand Nithin, maybe it is just me :).
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Wednesday, August 6, 2014 10:46 PM
Către: Alin Serdean
Cc: Saurabh Shah; Samuel Ghinet; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH 02/15] datapath-windows
Hi Sam,
This looks like a lot of duplicate code from openvswitch.h/odp-netlink.h.
Let us wait for https://github.com/openvswitch/ovs-issues/issues/21 issue to be
fixed first, and after work on top of it.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele
We should wait on this topic until we have the Netlink interface in both
userspace and kernel.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Samuel Ghinet
Trimis: Wednesday, August 6, 2014 7:11 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 05/
Hi Sam,
Let us discuss this topic on our next meeting.
Ty!
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Samuel Ghinet
Trimis: Wednesday, August 6, 2014 7:12 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 08/15] datapath-windows: Add Spooky Has
Hi Sam,
Let us wait for until we have the Netlink interface in place until we want to
start adding other features.
The macros you want to put in place sound useful but they need use cases in the
code also :),
so you might consider respin the patches after we pass the compilation issue
that we
, August 6, 2014 10:58 PM
Către: Eitan Eliahu
Cc: dev@openvswitch.org; Rajiv Krishnamurthy; Alin Serdean; Ben Pfaff; Kaushik
Guha; Ben Pfaff; Justin Pettit; Ankur Sharma; Samuel Ghinet; Linda Sun; Keith
Amidon
Subiect: Re: Design notes for provisioning Netlink interface from the OVS
Windows driver
+1 from my point of view.
-Mesaj original-
De la: Saurabh Shah [mailto:ssaur...@vmware.com]
Trimis: Wednesday, August 6, 2014 11:24 PM
Către: Alin Serdean; Nithin Raju
Cc: Samuel Ghinet; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH 02/15] datapath-windows: Move and Rename files
Not
Hi Eitan,
> C. Implementation work flow:
> The driver creates a device object which provides a NetLink interface for
> user mode processes. During the development phase this device is created in
> addition to
> the existing DPIF device. (This means that the bring-up of the NL based user
> mode
an 'make distcheck' to verify that nothing is broken on
> linux.
>
> Signed-off-by: Ankur Sharma
> Co-authored-by: Saurabh Shah
> Tested-by: Ankur Sharma
> Reported-by: Alin Serdean
> Reported-by: Nithin Raju
> Reported-at:
> https://urldefense.pro
.
This can help us in allowing us to put extra defines if needed in the future.
Alin.
-Mesaj original-
De la: Ankur Sharma [mailto:ankursha...@vmware.com]
Trimis: Thursday, August 7, 2014 7:11 AM
Către: Alin Serdean; Nithin Raju
Cc:
Subiect: RE: [ovs-dev] [PATCH] odp-netlink.h: Autogenerate
which I would like to talk about in the next meeting. I plan to work in
the weekend though to get so we can be one step close to our goal :).
Alin.
-Mesaj original-
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Thursday, August 7, 2014 3:19 AM
Către: Alin Serdean; dev
Hi Ben,
I noticed today the windows build was broken.
Error is:
source='lib/bundle.c' object='lib/bundle.lo' libtool=yes \
DEPDIR=.deps depmode=none /bin/sh ./build-aux/depcomp \
/bin/sh ./libtool --tag=CC --mode=compile ./build-aux/cccl -DHAVE_CON
FIG_H -I. -I ./incl
Thanks for the quick fix Ben, I also tested it just to make sure everything is
in place.
Alin.
-Mesaj original-
De la: Ben Pfaff [mailto:bpf...@vmware.com]
Trimis: Tuesday, August 12, 2014 9:45 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: WINDOWS userspace build broken
Acked-by : Alin Serdean
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Tuesday, August 12, 2014 9:44 PM
Către: dev@openvswitch.org
Cc: Ben Pfaff; Alin Serdean
Subiect: [PATCH 1/2] ofp-actions: Make struct ofpact constant size across
implementations.
Before commit
Hi Ben,
Also remember to add them under .gitignore:
Untracked files:
(use "git add ..." to include in what will be committed)
lib/ofp-actions.inc1
lib/ofp-actions.inc2
diff --git a/lib/.gitignore b/lib/.gitignore
index 2d07244..32c1e4c 100644
--- a/lib/.gitignore
+++ b/lib/.git
This commit adds to the automake build system the full build required by the
forwarding extension solution.
It will help a lot in the future CI to check the full build of the project.
Also the documentation was updated.
Signed-off-by: Alin Gabriel Serdean
---
INSTALL.Windows | 34 +
Issue: cannot build properly when local date differs from UTC date.
Since Stampinf stamps the driver inf file with the local date set the Inf2Cat
to use local date as well.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/Package/package.VcxProj | 20 +++-
1 file changed
Adding newline at end of the following files: packet.h, uio.h.
Signed-off-by: Alin Gabriel Serdean
---
include/windows/netpacket/packet.h | 2 +-
include/windows/sys/uio.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/windows/netpacket/packet.h
b/includ
The following changes are just a start to begin a discussion.
Bypass all epoll functionality.
IOCP work the other way around than epoll: you get if the operation finished
for a HANDLE in contrast of getting the number of file descriptors that are
ready for an operation.
It also adds a lot of over
Preparing the include headers needed to compile dpif-linux.c with MSVC.
Signed-off-by: Alin Gabriel Serdean
---
include/windows/automake.mk | 3 +++
include/windows/linux/pkt_sched.h | 26 ++
include/windows/linux/types.h | 0
include/windows/sys/epoll.h
Add dpif-linux.c/h to the lib/automake.mk
Signed-off-by: Alin Gabriel Serdean
---
lib/automake.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/automake.mk b/lib/automake.mk
index e95191d..a561bba 100644
--- a/lib/automake.mk
+++ b/lib/automake.mk
@@ -324,6 +324,8 @@ endif
if WIN32
li
ation updates. The fix is
on the Tx side.
Validation (using dpif-windows.c):
- Was able to perform VTEP <-> VTEP ping with the configuration posted in the
issue.
- Was able to perform VIF <-> VIF ping when the setup was configured correctly.
Signed-off-by: Nithin Raju
Reported-by:
+1
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Wednesday, August 13, 2014 6:33 PM
Către: Samuel Ghinet
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] datapath-windows: Renaming files proposal
On Aug 13, 2014, at 8:29 AM, Samuel Ghinet
w
Hi Nithin,
Thank you for the feedback!
We would like to add the following topics:
5. Queue packets inside the kernel and only send information needed to the
userspace, instead of sending the whole packet.
6. Spooky hash.
7. Coding styles.
8. Packet buffer management.
9. Fixed sized array
10. Ref
ce
as well.
The Rx side of OvsDetectTunnelPkt() has only documentation updates. The fix is
on the Tx side.
Validation (using dpif-windows.c):
- Was able to perform VTEP <-> VTEP ping with the configuration posted in the
issue.
- Was able to perform VIF <-> VIF ping when the setup was c
: Friday, August 15, 2014 4:57 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [PATCH] Use local time for Inf2Cat
On a related note, while I see the log which says its stamping the local time
in INF file. The actual DriverVer in the INF remains unchanged. Not sure why.
I don't know wha
Hi Saurabh,
If Ben is ok with the name change I would be glad to send out a V2 of the patch.
Thanks,
Alin.
-Mesaj original-
De la: Saurabh Shah [mailto:ssaur...@vmware.com]
Trimis: Friday, August 15, 2014 4:21 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH 3
Nithin,
Thanks for the review I will send out a V2 as soon as possible.
Thanks,
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Friday, August 15, 2014 3:52 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Add build of
...@nicira.com]
Trimis: Friday, August 15, 2014 7:52 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Add build of ovsext.sln using MSBuild
On Wed, Aug 13, 2014 at 8:13 AM, Alin Serdean
wrote:
> This commit adds to the automake build system the full build requi
: Monday, August 18, 2014 5:20 PM
Către: Alin Serdean
Cc: Samuel Ghinet; dev@openvswitch.org
Subiect: Re: Netlink Reviews
+ovs-dev
hi Sam/Alin,
I want to propose that I can go ahead get my patches committed, since we am
working on more patches that are dependent on this. Any review comments that
Hi Nithin,
Just a few thoughts:
Since get PID is a special case would it not be better to treat it as a
DeviceIoControl;dwIoControlCode like OVS_IOCTL_TRANSACT (i.e.
OVS_IOCTL_GET_PID)?
We can drop the extra headers and the whole Netlink message building/parsing
since the goal is just to get
I'm fine with this patch with the idea in mind that OvsDpInterfaceExt.h can be
added to odp-netlink.h. Not sure about the name though :).
Also might be useful to define the fourth ioctl for the PID.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin
Good place to start in my opinion but I will leave the final review to Sam
because he is working on the Netlink integration part aswell.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Friday, August 15, 2014 6:36 AM
Către: dev@openvsw
The validation part I think needs more checking in some places, but it is a
good place to start.
Again I will leave the final review to Sam because he is also working on this
matter as well.
Thanks,
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin
tlink part in the
kernel up and running.
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Tuesday, August 19, 2014 3:29 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH 2/4 v2] datapath-windows: Add Datapath.[ch
...@nicira.com]
Trimis: Tuesday, August 19, 2014 12:12 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Add build of ovsext.sln using MSBuild
On Fri, Aug 15, 2014 at 9:58 AM, Alin Serdean
wrote:
> Hey Guru,
>
> I can add a follow up on the after the version 2 t
: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Tuesday, August 19, 2014 4:28 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH 2/4 v2] datapath-windows: Add Datapath.[ch] and
OVS_USE_NL_INTERFACE CPP
On Aug 18, 2014, at 5:35 PM, Alin Serdean
wrote:
> I think you
ovs/ovs-issues#15
All NET_BUFFERs of a NET_BUFFER_LIST must go through
the pipeline: extract, find flow, execute. Previously,
only the first NET_BUFFER of a NET_BUFFER_LIST was going
through this pipeline, which was erroneous.
OvsPartialCopyToMultipleNBLs is used to make each NET_BUFFER
have its
Will keep in mind. I targeted the ALL with the make not specific targets.
Kind Regards,
Alin.
From: Gurucharan Shetty [shet...@nicira.com]
Sent: Tuesday, August 19, 2014 5:37 PM
To: Alin Serdean
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] Add
Hi Saurabh,
At the end of the day today. Was on short PTO last week.
Alin.
-Mesaj original-
De la: Saurabh Shah [mailto:ssaur...@vmware.com]
Trimis: Wednesday, August 27, 2014 2:46 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Add build of ovsext.sln using
Hi Saurabh,
Could you please try to do the autoreconf again.
./boot.sh
./configure
Thanks.
-Mesaj original-
De la: Saurabh Shah [mailto:ssaur...@vmware.com]
Trimis: Wednesday, August 27, 2014 3:01 AM
Către: Samuel Ghinet; dev@openvswitch.org
Cc: Alin Serdean; Nithin Raju
Subiect: RE
Hi Eithan,
Yes. Also Win8 or Win8.1
I still to format it accordingly and will send out the patch.
Alin.
-Mesaj original-
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Wednesday, August 27, 2014 5:40 PM
Către: Alin Serdean; Saurabh Shah; dev@openvswitch.org
Subiect: RE: [ovs
Hi Eithan,
Will add them anyway for the moment.
Alin.
-Mesaj original-
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Wednesday, August 27, 2014 6:08 PM
Către: Alin Serdean; Saurabh Shah; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH] Add build of ovsext.sln using MSBuild
You need to commit the patch also. It needs to do the diff between git ls-files
and the actual files.
-Mesaj original-
De la: Saurabh Shah [mailto:ssaur...@vmware.com]
Trimis: Wednesday, August 27, 2014 6:59 PM
Către: Alin Serdean; Samuel Ghinet; dev@openvswitch.org
Cc: Nithin Raju
This commit adds to the automake build system the full build required
by the forwarding extension solution.
It will help a lot in the future CI to check the full build of the project.
To configure the forwarding extension to be built one could use the following:
./configure CC=./build-aux/cccl L
Acked-by: Alin Gabriel Serdean
Kind Regards,
Alin.
From: dev [dev-boun...@openvswitch.org] on behalf of Eitan Eliahu
[elia...@vmware.com]
Sent: Thursday, August 28, 2014 1:01 AM
To: Eitan Eliahu; Nithin Raju
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev]
Hi,
Will send the patch until the end of the day.
Alin.
-Mesaj original-
De la: Saurabh Shah [mailto:ssaur...@vmware.com]
Trimis: Thursday, August 28, 2014 9:31 PM
Către: Alin Serdean; dev@openvswitch.org; Ben Pfaff
Subiect: Re: [ovs-dev] [PATCH 3/4] Changes needed to compile dpif
Rename dpif_linux -> dpif_netlink the actual file can be renamed as well
in the future.
Bypass all epoll functionality.
Treat dpif_netlink_recv__ with lazy polling using GetOverlappedResult
with the newly added overlapped structure in netlink.c
Initialize dpif_netlink_class on MSVC as well and d
Hi Eitan,
I think we could use the same design.
I can respin the patch on Monday if you can wait.
Alin.
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Friday, August 29, 2014 6:30 AM
Către: Alin Serdean; dev@openvswitch.org; Nithin Raju; Saurabh Shah
Subiect: RE: [ovs-dev] [PATCHv2
MSVC does not like variable length array either.
This patch treats the following error:
lib/dpif-netdev.c(2272) :
error C2057: expected constant expression
lib/dpif-netdev.c(2272) :
error C2466: cannot allocate an array of constant size 0
lib/dpif-netdev.c(2272) :
error C2133: 'batches' : unknown
Hi Ankur,
Just a small nit I you use "git format-patch" could you also add the -M option?
Thank you,
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 3, 2014 4:04 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [
Please.
I will look over the other patches after the meeting :).
Alin.
-Mesaj original-
De la: Ankur Sharma [mailto:ankursha...@vmware.com]
Trimis: Wednesday, September 3, 2014 7:34 PM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH 1/5] datapath-windows/Netlink
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Tuesday, September 2, 2014 6:05 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 5/5] Netlink.c: Added netlink put APIs.
In this change we have added the
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Tuesday, September 2, 2014 6:05 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 4/5] OvsTypes.h : Added support for BE16
---
datapath-windows/ovsext/Typ
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Tuesday, September 2, 2014 6:05 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 3/5] NetlinkProto.h: Minor fix for typos and new
macro for padding.
Adde
Maybe just rename NL_BUF with NL_BUFFER otherwise I am fine with the patch.
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Tuesday, September 2, 2014 6:05 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PAT
Sure be my guest :).
-Mesaj original-
De la: Ankur Sharma [mailto:ankursha...@vmware.com]
Trimis: Wednesday, September 3, 2014 1:14 PM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH 1/5] datapath-windows/Netlink: Move netlink files
to a new directory.
Hi Alin
Hi Eitan,
#else
sock->fd = socket(AF_NETLINK, SOCK_RAW, protocol);
if (sock->fd < 0) {
+int last_error = GetLastError();
The above breaks linux build. You could leave last_error outside and use it
wherever appropriate.
#define OVS_DEVICE_NAME_NT L"\\Device\\OpenvSwitchDev
Hi Eitan
Beside some style issue in:
+#ifdef _WIN32
+/* Pend an I/O request in the driver. The driver completes the I/O whenever
+* an event or a packet is ready to be read. Once the I/O is completed
+* the overlapped structure event associated with the pending I/O will be set
+*/
Acked-by: Alin
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Tuesday, September 9, 2014 9:03 AM
Către: dev@openvswitch.org; Samuel Ghinet
Subiect: [ovs-dev] [PATCH v2] datapath-windows: update CodingStyle guideline
for vari
Hi Eitan,
Trailing whitespace:
+ OVS_CTRL_CMD_MC_SUBSCRIBE_REQ,
+static int __inline
And could not apply patch because
+/* NL Attributes for joining/unjoining an MC group */ enum
+ovs_nl_mcast_attr {
+OVS_NL_ATTR_MCAST_GRP, /* Join an MC group */
+OVS_NL_ATTR_
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Wednesday, September 10, 2014 10:56 PM
Către: dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: [ovs-dev] [PATCH 2/3] hash.h: Avoid compiler warnings with M
Acked-by: Alin Gabriel Serdean
Thanks for removing a lot warnings.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Wednesday, September 10, 2014 10:56 PM
Către: dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: [ovs-dev] [PATCH
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Wednesday, September 10, 2014 10:56 PM
Către: dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: [ovs-dev] [PATCH 1/3] ovs-ofctl: Workaround a compiler warni
Sorry I missed this one.
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Tuesday, September 9, 2014 10:39 PM
Către: dev@openvswitch.org
Cc: Alin Serdean; Eitan Eliahu; Gurucharan Shetty
Subiect: [PATCH] netlink-socket
Hi Guru,
You are right probably either use WaitForMultipleObjects or add wrapper
functionality for it.
Alin.
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Tuesday, September 9, 2014 11:28 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs
Hi Eitan,
I think putting in pragmas to disable warnings is a bit over our hand.
Either we just disable them in a common include header or we leave them and
actually fix the warnings.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Eitan Eliahu
Trimis:
Hi Eitan,
Still cannot get the patch to apply:
$ git apply patch1
error: patch failed: datapath-windows/include/OvsDpInterfaceExt.h:70
error: datapath-windows/include/OvsDpInterfaceExt.h: patch does not apply
This part:
@@ -70,6 +70,14 @@
/* Commands available under the OVS_WIN_CONTROL_FAMILY. *
: Alin Serdean; Gurucharan Shetty; dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: RE: [ovs-dev] [PATCH 3/3] Avoid uninitialized variable warnings with
OBJECT_OFFSETOF() in MSVC.
Hi Alin,
I would prefer to disable the warning in a very limited scope rather than
disabling them across all source
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Thursday, September 11, 2014 3:36 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v4 2/2] datapath-windows/Netlink: Nested attributes
put/parse.
Added A
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Thursday, September 11, 2014 3:36 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v4 1/2] datapath-windows/NetlinkBuf.h: Added NlBufSize
Added an inline
+1 :)
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Eitan Eliahu
Trimis: Thursday, September 11, 2014 8:01 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v5] Netlink_socket.c Join/Unjoin an MC group for
event subscription
Use a specific out of band d
The patch contains the necessary modifications to compile and also to run
under MSVC.
Added the files to the build system and also changed dpif_linux to be under
a more generic name dpif_windows.
Added a TODO under the windows part in case we want to implement another
counterpart for epoll functi
1 - 100 of 799 matches
Mail list logo
