Hi Justin, Sent in the Acked-by. His spelling is more consistent to the project :).
Tx! Kind Regards, Alin. ________________________________________ From: Justin Pettit [jpet...@nicira.com] Sent: Thursday, July 31, 2014 2:03 AM To: Alin Serdean; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] Change ovsext.inf Extension Name and GUID Thanks, Alin. It looks like you and Saurabh both addressed this. His spelling and abbreviation of Open vSwitch is more consistent with how we normally refer to it in the project. Rather than forcing you to respin your patch, if his patch looks good, can you give it your Acked-by, and I'll push it? --Justin On July 30, 2014 at 3:51:24 PM, Alin Serdean (aserd...@cloudbasesolutions.com) wrote: > Updates to the ovsext.inf to change the kernel extension name. > > This is in report to issue filed under: > https://github.com/openvswitch/ovs/issues/14 > by Saurabh Shah . > > Signed-off-by: Alin Gabriel Serdean > Reported-by: Saurabh Shah > --- > datapath-windows/ovsext/OvsDriver.c | 10 +++++----- > datapath-windows/ovsext/ovsext.inf | 24 ++++++++++++------------ > 2 files changed, 17 insertions(+), 17 deletions(-) > > diff --git a/datapath-windows/ovsext/OvsDriver.c > b/datapath-windows/ovsext/OvsDriver.c > index f027410..be6feeb 100644 > --- a/datapath-windows/ovsext/OvsDriver.c > +++ b/datapath-windows/ovsext/OvsDriver.c > @@ -51,12 +51,12 @@ static PWCHAR ovsExtServiceName = L"OVSExt"; > NDIS_STRING ovsExtGuidUC; > NDIS_STRING ovsExtFriendlyNameUC; > > -static PWCHAR ovsExtGuidStr = L"{583CC151-73EC-4A6A-8B47-578297AD7623}"; > +static PWCHAR ovsExtGuidStr = L"{8DD9C187-772D-452E-AC80-D29F9247BB7D}"; > static const GUID ovsExtGuid = { > - 0x583cc151, > - 0x73ec, > - 0x4a6a, > - {0x8b, 0x47, 0x57, 0x82, 0x97, 0xad, 0x76, 0x23} > + 0x8DD9C187, > + 0x772D, > + 0x452E, > + {0xAC, 0x80, 0xD2, 0x9F, 0x92, 0x47, 0xBB, 0x7D} > }; > > /* Declarations of callback functions for the filter driver. */ > diff --git a/datapath-windows/ovsext/ovsext.inf > b/datapath-windows/ovsext/ovsext.inf > index d1f68eb..f72f58c 100644 > --- a/datapath-windows/ovsext/ovsext.inf > +++ b/datapath-windows/ovsext/ovsext.inf > @@ -6,21 +6,21 @@ > Signature = "$Windows NT$" > Class = NetService > ClassGUID = {4D36E974-E325-11CE-BFC1-08002BE10318} > -Provider = %VMWare% > +Provider = %OpenVSwitch% > CatalogFile = ovsext.cat > DriverVer = 10/10/2013,1.0 > > [Manufacturer] > -%VMWare%=VMWare,NTx86,NTia64,NTamd64 > +%OpenVSwitch%=OpenVSwitch,NTx86,NTia64,NTamd64 > > -[VMWare.NTx86] > -%OVSExt_Desc%=Install, OVSExt > +[OpenVSwitch.NTx86] > +%OpenVSwitch%=Install, OVSExt > > -[VMWare.NTia64] > -%OVSExt_Desc%=Install, OVSExt > +[OpenVSwitch.NTia64] > +%OpenVSwitch%=Install, OVSExt > > -[VMWare.NTamd64] > -%OVSExt_Desc%=Install, OVSExt > +[OpenVSwitch.NTamd64] > +%OpenVSwitch%=Install, OVSExt > > ;------------------------------------------------------------------------- > ; Installation Section > @@ -28,7 +28,7 @@ DriverVer = 10/10/2013,1.0 > [Install] > AddReg=Inst_Ndi > Characteristics=0x40000 > -NetCfgInstanceId="{583CC151-73EC-4A6A-8B47-578297AD7623}" > +NetCfgInstanceId="{8DD9C187-772D-452E-AC80-D29F9247BB7D}" > Copyfiles = OVSExt.copyfiles.sys > > [SourceDisksNames] > @@ -80,6 +80,6 @@ AddReg = Common.Params.reg > DelService=OVSExt,0x200 > > [Strings] > -VMWare = "VMWare" > -OVSExt_Desc = "VMWare OVS Extension" > -OVSExt_HelpText = "VMWare OVS forwarding switch extension" > +OpenVSwitch = "OpenVSwitch" > +OVSExt_Desc = "OpenVSwitch forwarding switch extension" > +OVSExt_HelpText = "OpenVSwitch forwarding switch extension" > -- > 1.9.0.msysgit.0 > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
