Use #define's as opposed to magic numbers.
Signed-off-by: Justin Pettit
---
lib/packets.h| 4
ovn/controller/pinctrl.c | 7 +--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/lib/packets.h b/lib/packets.h
index 28b742d..617f058 100644
--- a/lib/packets.h
+++
This will have a caller in a future commit.
Signed-off-by: Justin Pettit
---
lib/packets.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/packets.h b/lib/packets.h
index 617f058..df6ce4b 100644
--- a/lib/packets.h
+++ b/lib/packets.h
@@ -980,6 +980,12 @@ in6_generate_lla(struct et
According to RFC 4861, Neighbor Discovery messages should only match
when the Hop Limit is 255 to prevent off-link senders from sending ND
messages. This commit limits matching to that Hop Limit.
It also introduces Neighbor Discovery Solicitation ("nd_sol") and
Advertisement ("nd_adv") definition
These will have callers later.
Signed-off-by: Justin Pettit
---
lib/packets.c | 38 ++
lib/packets.h | 3 +++
2 files changed, 41 insertions(+)
diff --git a/lib/packets.c b/lib/packets.c
index 9e4d0e7..9b34961 100644
--- a/lib/packets.c
+++ b/lib/packets.c
@
Rename "nd" to "nd_adv" to be more descriptive and consistent with other
ND messages and actions. This commit also fixes some minor
documentation issues and limits the action to responding to Neighbor
Solicitation messages.
Signed-off-by: Justin Pettit
---
ovn/controller/pinctrl.c | 15 +++-
TODO:
- Need to document new SB actions.
- Need to update ovn-northd flows.
---
ovn/controller/lflow.c | 25 -
ovn/controller/pinctrl.c | 54
ovn/lib/actions.c| 58 ++--
o
Future commits will add support for dynamic IPv6/MAC bindings.
TODO:
- ovn-northd man page needs updated flows.
- Add unit tests.
---
ovn/TODO| 19 +-
ovn/northd/ovn-northd.c | 475
2 files changed, 371 insertions(+), 123 d
TODO:
- Needs to update ovn-northd man page.
- Code should be cleaned up.
---
ovn/lib/ovn-util.c | 5 +
ovn/northd/ovn-northd.c | 39 ++-
ovn/ovn-nb.xml | 6 ++
3 files changed, 41 insertions(+), 9 deletions(-)
diff --git a/ovn/l
A new other_config DB option has been added called 'vhost_driver_mode'.
By default this is set to 'server' which is the mode of operation OVS
with DPDK has used up until this point - whereby OVS creates and manages
vHost user sockets.
If set to 'client', OVS will act as the vHost client and connec
This RFC patch enables vHost 'client' mode in OVS and reconnect
capability, both of which are features which will be available in DPDK
16.07 due later this month.
To use this patch, first apply the patch for 16.07 support:
http://openvswitch.org/pipermail/dev/2016-July/074921.html
Then apply this
On Tue, Jul 12, 2016 at 2:56 PM, Justin Pettit wrote:
> Rename "compose_nd" and "compose_na" to "compose_nd_sol" and
> "compose_nd_adv", respecively, to be clearer about their functionality.
> Also change the source and destination IPv6 addresses to take
> "struct in6_addr" arguments, which are mo
Your message was undeliverable due to the following reason:
Your message could not be delivered because the destination computer was
unreachable within the allowed queue period. The amount of time
a message is queued before it is returned depends on local configura-
tion parameters.
Most likely t
hi dev,
Here's that excel file (latest invoices) that you wanted.
Best regards,
Tommie Schwartz
CEO, Cafedirect
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema
> index 5102948..460d5bd 100644
> --- a/ovn/ovn-nb.ovsschema
> +++ b/ovn/ovn-nb.ovsschema
> @@ -1,7 +1,7 @@
> {
> "name": "OVN_Northbound",
> -"version": "4.0.0",
> -"cksum": "2156178478 7460",
> +"version": "5.0.0",
> +
hi dev,
Here's that excel file (latest invoices) that you wanted.
Best regards,
Nathanial Rush
Financial Director - Multinational Group
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
hi dev,
Here's that excel file (latest invoices) that you wanted.
Best regards,
Bessie Harris
nt of Business Development
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
hi dev,
Here's that excel file (latest invoices) that you wanted.
Best regards,
Fidel Donaldson
Executive Director Sales Account Management Training Performance Support
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/de
On Wed, 13 Jul 2016 01:25:45 +0800, Johnson Li wrote:
> In order to support NSH without depending on Simon's patch, we
> introduced new flow actions push_eth and pop_eth to support the
> Ethernet as a NSH transport.
That doesn't make any sense. Please build this on top of Simon's
patchset.
Jiri
On Wed, 13 Jul 2016 01:35:50 +0800, Johnson Li wrote:
> To remove dependency for Simon Horman's patch at:
> http://openvswitch.org/pipermail/dev/2016-June/072010.html
> We derived some codes to add the push_eth/pop_eth flow actions
> to enable Ethernet as the encapsulation layer.
The dependency is
On Tue, Jun 28, 2016 at 12:05 PM, Ryan Moats wrote:
> John McDowall wrote on 06/28/2016
> 10:54:31
> AM:
>
> > From: John McDowall
> > To: Ryan Moats/Omaha/IBM@IBMUS, Na Zhu
> > Cc: "dev@openvswitch.org"
> > Date: 06/28/2016 10:54 AM
> > Subject: Re: [ovs-dev] SFC-Summary: MultiTenant
> >
> >
Testing out the named pipe implementation revealed a problem in
"daemon --detach startup errors". If the daemon actually started nobody
is stopping it.
In the case of test failure kill the daemon.
Signed-off-by: Alin Gabriel Serdean
---
tests/daemon.at | 3 ++-
1 file changed, 2 insertions(+), 1
This patch series is intended to switch the current
implementation of TCP sockets to a named pipe implementation.
One test had to be changed in order for the current state of unit
tests to be the same.
Alin Gabriel Serdean (3):
Windows: Local named pipe implementation
Windows: Drop TCP sockets
Currently in the case of command line arguments punix/unix, on Windows
we create a file, write a TCP port number to connect. This is a security
concern.
This patch adds support for the command line arguments punix/unix trying
to mimic AF_UNIX behind a local named pipe.
Signed-off-by: Alin Gabriel
We do not write anything to the file created by the punix/unix arguments.
Switch tests to plain file existence.
Signed-off-by: Alin Gabriel Serdean
---
tests/ovsdb-server.at | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at
in
This patch drops the TCP socket implementation behind command line
arguments punix/unix and switches to the local named pipe implementation.
Signed-off-by: Alin Gabriel Serdean
---
lib/automake.mk | 1 +
lib/stream-tcp.c | 115 ---
2 files c
When QinQ is supported, ingress VLAN are kept after push_vlan actions,
so we should expect two VLAN headers.
Signed-off-by: Xiao Liang
---
tests/ofproto-dpif.at | 128 +++---
1 file changed, 70 insertions(+), 58 deletions(-)
diff --git a/tests/ofprot
These patches enable tpid 0x88a8, multiple VLAN headers, and add new vlan_mode
"dot1q-tunnel". See commit message of patch1 for details.
v2: Add VLAN handling test cases for dot1q-tunnel vlan_mode.
Adjust VLAN+MPLS test cases for multi VLAN.
v3: Set default max_vlan_headers of netdev and test
Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX
Signed-off-by: Xiao Liang
---
lib/dpif-netdev.c | 1 +
tests/test-odp.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 26cfaff..13c10f6 100644
--- a/lib/dpif-netdev.c
+++ b/li
Add dot1q-tunnel ports and ingress packet cases, in ofproto-dpif.at VLAN
handling.
Signed-off-by: Xiao Liang
---
tests/ofproto-dpif.at | 110 +-
1 file changed, 64 insertions(+), 46 deletions(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-d
On Tue, Jul 12, 2016 at 9:52 AM, Russell Bryant wrote:
> On Tue, Jun 28, 2016 at 12:05 PM, Ryan Moats wrote:
>
>> John McDowall wrote on 06/28/2016
>> 10:54:31
>> AM:
>>
>> > From: John McDowall
>> > To: Ryan Moats/Omaha/IBM@IBMUS, Na Zhu
>> > Cc: "dev@openvswitch.org"
>> > Date: 06/28/2016 1
It is useful to set the mac address and gateway while using ADD_VETH
to connect a namespace to a OVN logical topology. Upcoming commits
use this enhancement.
Signed-off-by: Gurucharan Shetty
---
tests/system-common-macros.at | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff
This unit test adds a basic OVN NAT test that tests north-south
DNAT, south-north SNAT and east-west DNAT and SNAT. It uses network
namespaces connected to br-int using veth pairs to act as logical
ports. This test does not cover multi-host scenarios, so there is
a gap. But userspace OVN tests do m
IntegrationGuide.md explains the meaning of the key 'iface-id'. Adding
it as part of ADD_VETH is useful for OVN related tests. For non-OVN
tests, it should have no effect. Upcoming commits take advantage of this.
Signed-off-by: Gurucharan Shetty
---
tests/system-common-macros.at | 3 ++-
1 file
Signed-off-by: Gurucharan Shetty
---
Please note that there are a couple of unit tests around fragmentation
(unrelated to OVN) that can cause kernel crashes when you run OVN kernel
tests. So, if you intend to run these, run it via:
make check-kmod TESTSUITEFLAGS="-k ovn"
---
tests/system-ovn.at |
Ciara Loftus writes:
> A new other_config DB option has been added called 'vhost_driver_mode'.
> By default this is set to 'server' which is the mode of operation OVS
> with DPDK has used up until this point - whereby OVS creates and manages
> vHost user sockets.
>
> If set to 'client', OVS will
Hi Alin!
I think that the same fix can be applied to " daemon --detach --monitor startup
errors"
Acked-by: Paul Boca
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
> Sent: Tuesday, July 12, 2016 6:36 PM
> To: dev@openvswitch.org
> Subjec
Thanks for the patch.
Overall it looks good my only suggestion would be to move it to a common ground
rather than multiplying the code wherever it is needed.
Thanks,
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Wednesday, July
I am wondering why you get an OSError instead of a select error?
The order of the exception should be inverted (first the select one and after
the OSerror one), or add a general exception at the end.
Thanks,
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În num
Thanks for the patch. I will change the test after the named pipe
implementation gets in.
Acked-by: Alin Gabriel Serdean
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Wednesday, July 6, 2016 3:38 PM
> Către: dev@openvswitch.org
> Su
Seems like "daemon --detach --monitor startup errors" is disabled on Windows.
Disregard my last comment.
Thanks,
Paul
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Paul Boca
> Sent: Tuesday, July 12, 2016 8:55 PM
> To: Alin Serdean; dev@openvswitch.org
Hi Alin!
As discussed offline, please see my comments inline.
Thanks,
Paul
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
> Sent: Tuesday, July 12, 2016 6:55 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH 1/3] Windows: Local name
Acked-by: Paul Boca
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
> Sent: Tuesday, July 12, 2016 6:55 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH 2/3] Windows: Drop TCP sockets and switch to
> named pipe
>
> This patch drops
Acked-by: Paul Boca
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
> Sent: Tuesday, July 12, 2016 6:55 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH 3/3] Windows tests: daemon specific tests
>
> We do not write anything to the f
I am wondering if it is better if we could just import the shared library and
call the detach function
(https://github.com/openvswitch/ovs/blob/master/lib/daemon-windows.c#L342)
instead of duplicating the effort.
I wonder if the same could be applied un the *unix side as well.
Thanks,
Alin.
>
On Mon, Jul 11, 2016 at 11:56:31PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thanks for the review!
> -Mesaj original-
> De la: Paul Boca
> Trimis: Tuesday, July 12, 2016 10:29 PM
> Către: Alin Serdean ;
> dev@openvswitch.org
> Subiect: RE: [PATCH 1/3] Windows: Local named pipe implementation
>
> Hi Alin!
>
> As discussed offline, please see my comments inline.
>
Signed-off-by: Justin Pettit
---
ovn/northd/ovn-northd.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index f4b4435..3fb4063 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -1
This doesn't fix a bug, but is more standard.
Signed-off-by: Justin Pettit
---
ovsdb/ovsdb-client.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c
index 80819a8..25fe903 100644
--- a/ovsdb/ovsdb-client.c
+++ b/ovsdb/ovsdb-client.
Signed-off-by: Justin Pettit
---
lib/dpctl.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/lib/dpctl.c b/lib/dpctl.c
index b870e30..003602a 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -577,13 +577,10 @@ show_dpif(struct dpif *dpif, struct dpctl_params *dpctl_p)
On Mon, Jul 11, 2016 at 11:56:32PM -0700, Justin Pettit wrote:
> Otherwise, errors are logged at "debug" level. Errors when pushing
> flows can then seemingly be silently lost.
>
> Signed-off-by: Justin Pettit
It'd be a little cleaner like this:
diff --git a/ovn/controller/ofctrl.c b/ovn/contr
On Mon, Jul 11, 2016 at 11:56:33PM -0700, Justin Pettit wrote:
> References to the specifc tables should probably be dropped, since
> they'll continue to drift towards wrong. In the meantime, correct the
> ones that are there.
>
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
__
Dear dev,
Please find attached the profile of Mr.Navarro for a suitable role in your
Organisation
King regards,
Drew Black
Managing Director - Property Advisory Industry
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/
On Mon, Jul 11, 2016 at 11:56:34PM -0700, Justin Pettit wrote:
> With eight 32-bit registers, we can only store two IPv6 addresses, which is
> pretty tight.
>
> Signed-off-by: Justin Pettit
We need a different long-term solution.
Acked-by: Ben Pfaff
Dear dev,
Please find attached the profile of Mr.Mercer for a suitable role in your
Organisation
King regards,
Nell Gross
Chief Executive Officer - Food Packaging Company
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo
> On Jul 12, 2016, at 1:28 PM, Ben Pfaff wrote:
>
> On Mon, Jul 11, 2016 at 11:56:32PM -0700, Justin Pettit wrote:
>> Otherwise, errors are logged at "debug" level. Errors when pushing
>> flows can then seemingly be silently lost.
>>
>> Signed-off-by: Justin Pettit
>
> It'd be a little clean
Dear dev,
Please find attached the profile of Mr.Lamb for a suitable role in your
Organisation
King regards,
Harland Gillespie
Vice President of Operations
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Dear dev,
Please find attached the profile of Mr.Leon for a suitable role in your
Organisation
King regards,
Annmarie Cox
Business Director USA Job
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Jul 8, 2016 at 12:20 PM, Lance Richardson
wrote:
> The "ovn-controller-vtep - vtep-macs 1" test case fails occasionally,
> with ovs-vswitchd logs similar to these:
>
> bridge|INFO|bridge br-vtep_vtep_ls1: added interface vx1 on port 2
> tunnel|WARN|bfd1.2.3.5: attempting to add tu
These patches should address the previous issue with building the
Python wrapper when builddir != srcdir. It also ensures that the
wrapper can be properly built by pip from out-of-tree by ensuring
that json.h is added to include/openvswitch/json.h.
Terry Wilson (2):
Move lib/json.h to include/op
To easily allow both in- and out-of-tree building of the Python
wrapper for the OVS JSON parser (e.g. w/ pip), move json.h to
include/openvswitch. This also requires moving lib/{hmap,shash}.h.
Both hmap.h and shash.h were #include-ing "util.h" even though the
headers themselves did not use anythin
There is no particularly good reason to use our own Python JSON
serialization implementation when serialization can be done faster
with Python's built-in JSON library.
A few tests were changed due to Python's default JSON library
returning slightly more precise floating point numbers.
Signed-off-
Acked-by: Nithin Raju
-Original Message-
From: Sairam Venugopal
Date: Tuesday, July 12, 2016 at 2:41 PM
To: Nithin Raju
Subject: FW: [PATCH v3 1/2] Windows: Add support for handling protocol
(netlink family)
>
>
>On 7/11/16, 2:59 PM, "Sairam Venugopal" wrote:
>
>>Windows datapath curr
It is wasteful to have two loops that go through all the NAT entries.
Signed-off-by: Gurucharan Shetty
---
ovn/northd/ovn-northd.c | 45 +
1 file changed, 13 insertions(+), 32 deletions(-)
diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
Acked-by: Nithin Raju
One another change that comes to mind is the validation that a socket of
type NETLINK_GENERIC does not send a CT command and vice-versa. It should
be a small change within Datapath.c and can be done as a incremental patch.
-Original Message-
From: Sairam Venugopal
This series fixes a couple of crashes that may occur due to the backports of
the inet_fragment.c code from upstream. These are primarily related to cases
where a fragment is received and cached in the OVS fragment handling code
with a timer attached to expire it, then the OVS kernel module is remov
If a user sends some fragments of an IPv6 message through OVS, but OVS
fails to assemble the IPv6 message and the OVS module is then unloaded
before the fragments expire, it could lead to a kernel panic like the
following:
Call Trace:
[] ? call_timer_fn+0x39/0x130
[] run_timer_softirq+0x20e/0x
This was previously backported to fix issues with our inet_fragment
backport; with that largely gone, we can get rid of this too.
Signed-off-by: Joe Stringer
---
This is effectively a revert of commit bf1f0d35ceb9 ("datapath: Fix IPv6
fragment expiry crash."). It should be paired with the previou
Remove a couple of functions that are available on all supported kernel
versions.
Signed-off-by: Joe Stringer
---
datapath/linux/compat/nf_conntrack_reasm.c | 39 +++---
1 file changed, 3 insertions(+), 36 deletions(-)
diff --git a/datapath/linux/compat/nf_conntrack_reas
The core fragmentation handling logic is exported on all supported
kernels, so it's not necessary to backport the latest version of this.
This greatly simplifies the code due to inconsistencies between the old
per-lookup garbage collection and the newer workqueue based garbage
collection.
As a res
This function is just a dummy to ensure that the corresponding netfilter
fragment module is loaded, to initialize the shared structures. But it
doesn't need to be invoked once per namespace; one call per protocol
should do the trick.
Signed-off-by: Joe Stringer
---
datapath/linux/compat/ip_fragm
Kernel 3.7 and lower are now unsupported, remove this fragment.
Signed-off-by: Joe Stringer
---
datapath/linux/compat/include/net/inet_frag.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/datapath/linux/compat/include/net/inet_frag.h
b/datapath/linux/compat/include/net/inet_frag.h
Based on Ryan's suggestions, here is my proposal for implementing the SFC
flowClassifier as ACLs. I wanted to get some feedback before I get into another
round of changes in the code.
Currently I have implemented SFC by adding a new table (ls_in_chain) in the
ova-stage of ovn-northd.c as follo
On Fri, Jul 8, 2016 at 7:16 AM, Lance Richardson
wrote:
> The ovn-controller-vtep "binding 1" test case fails occasionally
> due to a race with the ovs-vtep daemon. If ovs-vtep happens to
> execute handle_physical() after "ovs-vsctl del-port p0", but before
> the test script has executed "vtep-c
On Mon, Jul 11, 2016 at 11:56:35PM -0700, Justin Pettit wrote:
> These are needed to handle IPv6 addresses.
>
> Signed-off-by: Justin Pettit
The comment in meta-flow.h talks about "Nicira extension" registers. I
think this made sense a few years ago, but Nicira isn't very relevant
anymore, so I
It isn't. For networking-sfc, at least for OVS driver (the default), the
MPLS label is popped before the packet reaches the VNF.
But Russell did bring up a great solution for supporting multi-tenancy on
VNF... it does open the can of worm where we need to distinguish between
VNF that supports mult
On Mon, Jul 11, 2016 at 11:56:36PM -0700, Justin Pettit wrote:
> IPv6 addresses use four standard OVS registers, so move the existing
> named registers back to make room for using more logical registers.
>
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
__
On Mon, Jul 11, 2016 at 11:56:37PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Jul 11, 2016 at 11:56:38PM -0700, Justin Pettit wrote:
> With static routes, it's not necessary to have a separate default
> gateway parameter. This also makes configuring router ports clearer
> when IPv6 and IPv4 addresses may be assigned to the same port.
>
> Signed-off-by: Justin Petti
On Mon, Jul 11, 2016 at 11:56:39PM -0700, Justin Pettit wrote:
> Reduce the number of memory allocations and risk of introducing shadow
> variables.
>
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://o
On Mon, Jul 11, 2016 at 11:56:40PM -0700, Justin Pettit wrote:
> Reduce the amount of string conversions necessary. This will be
> convenient when we want to start using IPv6 addresses, too.
>
> Signed-off-by: Justin Pettit
It's getting weirder and weirder to use C as a string processing
langua
Hi Kyle/Russell,
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Kyle Mestery
Sent: Tuesday, July 12, 2016 9:19 AM
To: Russell Bryant
Cc: dev@openvswitch.org; John McDowall
Subject: Re: [ovs-dev] SFC-Summary: MultiTenant
On Tue, Jul 12, 2016 at 9:52 AM, Russ
On 11 July 2016 at 23:35, Gurucharan Shetty wrote:
> It is useful to set the mac address and gateway while using ADD_VETH
> to connect a namespace to a OVN logical topology. Upcoming commits
> use this enhancement.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Joe Stringer
On 11 July 2016 at 23:35, Gurucharan Shetty wrote:
> IntegrationGuide.md explains the meaning of the key 'iface-id'. Adding
> it as part of ADD_VETH is useful for OVN related tests. For non-OVN
> tests, it should have no effect. Upcoming commits take advantage of this.
>
> Signed-off-by: Guruchara
On Mon, Jul 11, 2016 at 11:56:41PM -0700, Justin Pettit wrote:
> A future commit will reduce the amount of conversions used by the
> existing users of 'lport_addresses'. This change will also make it
> possible to use this structure for logical router port networks.
>
> Signed-off-by: Justin Pett
> On Jul 12, 2016, at 4:15 PM, Ben Pfaff wrote:
>
> On Mon, Jul 11, 2016 at 11:56:35PM -0700, Justin Pettit wrote:
>> These are needed to handle IPv6 addresses.
>>
>> Signed-off-by: Justin Pettit
>
> The comment in meta-flow.h talks about "Nicira extension" registers. I
> think this made sen
On 11 July 2016 at 23:35, Gurucharan Shetty wrote:
> This unit test adds a basic OVN NAT test that tests north-south
> DNAT, south-north SNAT and east-west DNAT and SNAT. It uses network
> namespaces connected to br-int using veth pairs to act as logical
> ports. This test does not cover multi-hos
On 11 July 2016 at 23:35, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
> ---
Looks good, thanks. Only comment is if you add this file to
check-system-userspace then it should also get a CHECK_CONNTRACK() at
the start.
Acked-by: Joe Stringer
__
On 11 July 2016 at 23:35, Gurucharan Shetty wrote:
> This unit test adds a basic OVN NAT test that tests north-south
> DNAT, south-north SNAT and east-west DNAT and SNAT. It uses network
> namespaces connected to br-int using veth pairs to act as logical
> ports. This test does not cover multi-hos
Thanks for the patch.
This is not a complete review, but I have some preliminary comments.
If I understand correctly 'port_mutex' is converted to rwlock because
we want the pmd threads in dpif_netdev_xps_get_tx_qid() to be able to
grab it concurrently. I think that we can add a pointer from 'str
Looks good to me, thanks!
Acked-by: Daniele Di Proietto
2016-07-12 12:19 GMT-07:00 Justin Pettit :
> Signed-off-by: Justin Pettit
> ---
> lib/dpctl.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/lib/dpctl.c b/lib/dpctl.c
> index b870e30..003602a 100644
Thanks. Do you mind looking at the other patches, too? I think they're pretty
obviously correct.
--Justin
> On Jul 12, 2016, at 6:36 PM, Daniele Di Proietto wrote:
>
> Looks good to me, thanks!
>
> Acked-by: Daniele Di Proietto
>
> 2016-07-12 12:19 GMT-07:00 Justin Pettit :
> Signed-off-
On Mon, Jul 11, 2016 at 11:56:42PM -0700, Justin Pettit wrote:
> With the addition of IPv6 routing, there won't be much need to
> special-case not parsing IPv6 addresses.
>
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@op
> +
> +The regX symbols are 32-bit integers.
> +The xxregX symbols are 128-bit integers,
> +which overlay four of the 32-bit registers: xxreg0
> +overlays reg0 through reg3, with
> +reg0 supplying the most-significant bits of
> +xxreg0 and reg3
Hi John:
Please see inline for FS:
Message: 3
Date: Tue, 12 Jul 2016 22:32:58 +
From: John McDowall
To: "dev@openvswitch.org"
Subject: [ovs-dev] SFC ACL and Flow Classifier
Message-ID:
Content-Type: text/plain; charset="iso-8859-1"
Based on Ryan's suggestions, here is my proposal for imple
>I was thinking this could be handled with child / sub-ports. We do this
>today for containers in VMs. We can have a single VIF for a VM that is
>connected to multiple networks that are owned by separate tenants. Some
>sort of encapsulation (VLAN ID, MPLS header, whatever) would be used to
>diff
John, see my comments inline.
Pls take some time to look at my comments about
https://review.openstack.org/#/c/333172/, if not right, pls correct me,
thanks.
Regards,
Juno Zhu
IBM China Development Labs (CDL) Cloud IaaS Lab
Email: na...@cn.ibm.com
5F, Building 10, 399 Keyuan Road, Zhangjian
On Mon, Jul 11, 2016 at 11:56:43PM -0700, Justin Pettit wrote:
> Extract port security and logical switch port addresses once and store
> them as part of the ovn_port structure. Use the string representations
> from the extracted addresses.
>
> Signed-off-by: Justin Pettit
In build_port_securit
> On Jul 12, 2016, at 7:53 PM, Zong Kai Li wrote:
>
>> +
>> +The regX symbols are 32-bit integers.
>> +The xxregX symbols are 128-bit integers,
>> +which overlay four of the 32-bit registers: xxreg0
>> +overlays reg0 through reg3, with
>> +reg0 suppl
This patch series is intended to switch the current implementation of
TCP sockets to a named pipe implementation.
One test had to be changed in order for the current state of unit tests
to be the same.
Alin Gabriel Serdean (3):
Windows: Local named pipe implementation
Windows: Drop TCP socket
We do not write anything to the file created by the punix/unix arguments.
Switch tests to plain file existence.
Acked-by: Paul Boca
Signed-off-by: Alin Gabriel Serdean
---
v2: Add acked
---
tests/ovsdb-server.at | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/ovs
1 - 100 of 185 matches
Mail list logo
