On Mon, Jul 11, 2016 at 11:56:35PM -0700, Justin Pettit wrote:
> These are needed to handle IPv6 addresses.
>
> Signed-off-by: Justin Pettit <[email protected]>
The comment in meta-flow.h talks about "Nicira extension" registers. I
think this made sense a few years ago, but Nicira isn't very relevant
anymore, so I tend to try to say "Open vSwitch extension" these days;
Open vSwitch is still quite relevant!
I don't think that flow_get_xxreg() and flow_set_xxreg() are endian
independent. That is, suppose that actions set reg0, reg1, reg2, and
reg3 independently, and then read xxreg0. Will xxreg0 have the same
value on big-endian and little-endian architectures? That is something
that we guarantee for the xregs, so it would be bad to drop it for
xxregs.
Instead of this:
+ ovs_u128 u_zero = {.u64.hi = 0, .u64.lo = 0};
I'd suggest adding an OVS_U128_ZERO to include/openvswitch/types.h to go
along with OVS_U128_MAX.
Acked-by: Ben Pfaff <[email protected]>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
