Re: [ovs-dev] Bug: ovsdb monitor2 - includes unknown object

2015-12-16 Thread Justin Pettit
> On Dec 15, 2015, at 7:13 PM, Han Zhou wrote: > > For some reason my patch was blocked by the mailinglist, so I just removed > the http link from commit message and resent. Now it is seen in the > mailinglist: > > http://openvswitch.org/pipermail/dev/2015-December/063461.html Ben is right tha

Re: [ovs-dev] [PATCH v2 RFC] ovs-lib: try to call exit before killing

2015-12-16 Thread Ben Pfaff
On Wed, Dec 16, 2015 at 09:58:56AM +0300, Ilya Maximets wrote: > > > On 16.12.2015 09:53, Ben Pfaff wrote: > > On Wed, Dec 16, 2015 at 09:50:56AM +0300, Ilya Maximets wrote: > >> While killing OVS may not free all allocated resources. > >> > >> Eample: > >>Socket for vhost-user port will stay

Re: [ovs-dev] [PATCH v2 RFC] ovs-lib: try to call exit before killing

2015-12-16 Thread Ilya Maximets
On 16.12.2015 11:27, Ben Pfaff wrote: > On Wed, Dec 16, 2015 at 09:58:56AM +0300, Ilya Maximets wrote: >> >> >> On 16.12.2015 09:53, Ben Pfaff wrote: >>> On Wed, Dec 16, 2015 at 09:50:56AM +0300, Ilya Maximets wrote: While killing OVS may not free all allocated resources. Eample: >>>

Re: [ovs-dev] [PATCH 3/5] debian: Add a package for ovn-controller.

2015-12-16 Thread Ben Pfaff
On Tue, Dec 15, 2015 at 09:52:04AM -0800, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty I wonder whether the name of this package is well chosen. I know that the program that it starts is ovn-controller, and I know that that runs on every hypervisor in OVN, but still at first I ass

Re: [ovs-dev] [PATCH 5/5] debian: Add a package for OVN docker drivers.

2015-12-16 Thread Ben Pfaff
On Tue, Dec 15, 2015 at 09:52:06AM -0800, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty I think that this is architecture-independent (there's no actual binaries in it, just Python source), so that it should be Architecture: "all" instead of "linux-any". Is there a reason someone w

Re: [ovs-dev] [PATCH v2 RFC] ovs-lib: try to call exit before killing

2015-12-16 Thread Ben Pfaff
On Wed, Dec 16, 2015 at 12:07:23PM +0300, Ilya Maximets wrote: > On 16.12.2015 11:27, Ben Pfaff wrote: > > On Wed, Dec 16, 2015 at 09:58:56AM +0300, Ilya Maximets wrote: > >> > >> > >> On 16.12.2015 09:53, Ben Pfaff wrote: > >>> On Wed, Dec 16, 2015 at 09:50:56AM +0300, Ilya Maximets wrote: >

Re: [ovs-dev] [PATCH v2 RFC] ovs-lib: try to call exit before killing

2015-12-16 Thread Ilya Maximets
On 16.12.2015 13:02, Ben Pfaff wrote: > On Wed, Dec 16, 2015 at 12:07:23PM +0300, Ilya Maximets wrote: >> On 16.12.2015 11:27, Ben Pfaff wrote: >>> On Wed, Dec 16, 2015 at 09:58:56AM +0300, Ilya Maximets wrote: On 16.12.2015 09:53, Ben Pfaff wrote: > On Wed, Dec 16, 2015 at 09:

Re: [ovs-dev] [PATCH 05/14] Add OpenFlow support for new "arp" action.

2015-12-16 Thread Ben Pfaff
On Wed, Dec 09, 2015 at 05:57:47PM -0800, Justin Pettit wrote: > > > On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote: > > > > --- a/NEWS > > +++ b/NEWS > > @@ -1,5 +1,7 @@ > > Post-v2.5.0 > > - > > + - OpenFlow: > > + * New "arp" OpenFlow extension action for generating ARP

Re: [ovs-dev] [PATCH v2 RFC] ovs-lib: try to call exit before killing

2015-12-16 Thread Ben Pfaff
On Wed, Dec 16, 2015 at 01:31:03PM +0300, Ilya Maximets wrote: > > > On 16.12.2015 13:02, Ben Pfaff wrote: > > On Wed, Dec 16, 2015 at 12:07:23PM +0300, Ilya Maximets wrote: > >> On 16.12.2015 11:27, Ben Pfaff wrote: > >>> On Wed, Dec 16, 2015 at 09:58:56AM +0300, Ilya Maximets wrote: > > >>

Re: [ovs-dev] [PATCH 06/14] actions: Factor out new helper function add_prerequisite().

2015-12-16 Thread Ben Pfaff
Thanks, applied to master. On Thu, Dec 10, 2015 at 05:13:58PM -0800, Justin Pettit wrote: > Acked-by: Justin Pettit > > --Justin > > > > On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote: > > > > This will acquire new users in upcoming commits. > > > > Signed-off-by: Ben Pfaff > > --- > > ovn/li

Re: [ovs-dev] [PATCH 06/14] actions: Factor out new helper function add_prerequisite().

2015-12-16 Thread Ben Pfaff
Thanks, applied to master. On Thu, Dec 10, 2015 at 05:13:58PM -0800, Justin Pettit wrote: > Acked-by: Justin Pettit > > --Justin > > > > On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote: > > > > This will acquire new users in upcoming commits. > > > > Signed-off-by: Ben Pfaff > > --- > > ovn/li

Re: [ovs-dev] [PATCH 07/14] actions: Factor parsing a single action into a new function parse_action().

2015-12-16 Thread Ben Pfaff
Thanks, applied to master. On Thu, Dec 10, 2015 at 05:16:02PM -0800, Justin Pettit wrote: > Acked-by: Justin Pettit > > --Justin > > > > On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote: > > > > This will have another user in an upcoming commit. > > > > Signed-off-by: Ben Pfaff > > --- > > ovn/

Re: [ovs-dev] [PATCH 09/14] actions: Bundle action parsing parameters into a structure.

2015-12-16 Thread Ben Pfaff
On Tue, Dec 15, 2015 at 05:20:01PM -0800, Justin Pettit wrote: > > > On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote: > > > > This will make it easier to add and change parameters, as done in an > > upcoming commit. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Justin Pettit Thanks, applied to

[ovs-dev] [PATCH v3 RFC] ovs-lib: try to call exit before killing

2015-12-16 Thread Ilya Maximets
While killing OVS may not free all allocated resources. Eample: Socket for vhost-user port will stay in a system after 'systemctl stop openvswitch' and opening that port after restart will fail. Signed-off-by: Ilya Maximets --- version 3: * sleep after EXIT split

Re: [ovs-dev] [PATCH v3 RFC] ovs-lib: try to call exit before killing

2015-12-16 Thread Ben Pfaff
On Wed, Dec 16, 2015 at 03:32:21PM +0300, Ilya Maximets wrote: > While killing OVS may not free all allocated resources. > > Eample: > Socket for vhost-user port will stay in a system > after 'systemctl stop openvswitch' and opening > that port after restart will fail. > > Signe

Re: [ovs-dev] [PATCH v2 RFC] ovs-lib: try to call exit before killing

2015-12-16 Thread Ilya Maximets
On 16.12.2015 15:21, Ben Pfaff wrote: > On Wed, Dec 16, 2015 at 01:31:03PM +0300, Ilya Maximets wrote: >> >> >> On 16.12.2015 13:02, Ben Pfaff wrote: >>> On Wed, Dec 16, 2015 at 12:07:23PM +0300, Ilya Maximets wrote: On 16.12.2015 11:27, Ben Pfaff wrote: > On Wed, Dec 16, 2015 at 09:58:56A

Re: [ovs-dev] [PATCH 2/5] debian: Add a package for OVN common components.

2015-12-16 Thread Russell Bryant
On 12/16/2015 02:03 AM, b...@ovn.org wrote: > On Tue, Dec 15, 2015 at 09:52:03AM -0800, Gurucharan Shetty wrote: >> Signed-off-by: Gurucharan Shetty > > I'm not sure about the dependency on openvswitch-switch. One could run > northd and the nb and sb database on a machine that does not have an >

Re: [ovs-dev] [PATCH 1/5] ovn-ctl: Add daemon status functions.

2015-12-16 Thread Russell Bryant
On 12/16/2015 02:00 AM, Ben Pfaff wrote: > On Tue, Dec 15, 2015 at 10:59:58PM -0800, Ben Pfaff wrote: >> On Tue, Dec 15, 2015 at 09:52:02AM -0800, Gurucharan Shetty wrote: >>> Signed-off-by: Gurucharan Shetty >>> --- >>> ovn/utilities/ovn-ctl |6 ++ >>> 1 file changed, 6 insertions(+) >>>

Re: [ovs-dev] [PATCH 1/5] ovn-ctl: Add daemon status functions.

2015-12-16 Thread Guru Shetty
> > > Do you think it's worth breaking out individual statuses this way? > "ovs-ctl status" shows all OVS daemons' status; maybe "ovn-ctl status" > should follow the same pattern. > The reason I chose to break it was because I was splitting ovn-northd and ovn-controller into separate packages with

Re: [ovs-dev] [PATCH 2/5] debian: Add a package for OVN common components.

2015-12-16 Thread Guru Shetty
> > I'm not sure about the dependency on openvswitch-switch. One could run > northd and the nb and sb database on a machine that does not have an > openvswitch switch running; it might even be preferred in a large > deployment. What do you think? > openvswitch-switch has ovs-lib and ovn-ctl depe

Re: [ovs-dev] [PATCH 5/5] debian: Add a package for OVN docker drivers.

2015-12-16 Thread Guru Shetty
On 16 December 2015 at 01:55, Ben Pfaff wrote: > On Tue, Dec 15, 2015 at 09:52:06AM -0800, Gurucharan Shetty wrote: > > Signed-off-by: Gurucharan Shetty > > I think that this is architecture-independent (there's no actual > binaries in it, just Python source), so that it should be Architecture:

Re: [ovs-dev] [PATCH 3/5] debian: Add a package for ovn-controller.

2015-12-16 Thread Guru Shetty
On 16 December 2015 at 01:39, Ben Pfaff wrote: > On Tue, Dec 15, 2015 at 09:52:04AM -0800, Gurucharan Shetty wrote: > > Signed-off-by: Gurucharan Shetty > > I wonder whether the name of this package is well chosen. I know that > the program that it starts is ovn-controller, and I know that that

Re: [ovs-dev] Bug: ovsdb monitor2 - includes unknown object

2015-12-16 Thread Han Zhou
Justin, you are right. I am sorry it was my NTP out of sync when I sent the first patch, so the message was shown up in the middle of the earlier messages. Sorry for the confusion! On Wed, Dec 16, 2015 at 12:08 AM, Justin Pettit wrote: > > > On Dec 15, 2015, at 7:13 PM, Han Zhou wrote: > > > >

Re: [ovs-dev] [PATCH 11/14] ovn-controller: Add data structure for indexing lports, multicast groups.

2015-12-16 Thread Numan Siddique
On 12/09/2015 06:38 AM, Ben Pfaff wrote: > This was more or less implemented inside lflow.c until now, but some > upcoming code that shouldn't be in that file needs to use it too. > > This also adds a second index on lports, so that lports can be looked up > based on the logical datapath tunnel key

[ovs-dev] Your account has a debt and is past due

2015-12-16 Thread Leroy Black
Dear Customer, Our records show that your account has a debt of $363.{rand(10,99)}}. Previous attempts of collecting this sum have failed. Down below you can find an attached file with the information on your case. ___ dev mailing list dev@openvswitch.

Re: [ovs-dev] [PATCH 2/5] debian: Add a package for OVN common components.

2015-12-16 Thread Guru Shetty
> > > ovn-ctl assumes ovsdb-server is running locally for ovn-northd right > now. Is ovsdb-server in the -switch package? > > Yes. > -- > Russell Bryant > ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] match: Add support for matching IGMP fields.

2015-12-16 Thread Jarno Rajahalme
> On Dec 15, 2015, at 5:48 PM, Jarno Rajahalme wrote: > > >> On Dec 15, 2015, at 5:47 PM, Ben Pfaff mailto:b...@ovn.org>> >> wrote: >> >> On Mon, Dec 14, 2015 at 04:36:08PM -0800, Jarno Rajahalme wrote: >>> On Dec 14, 2015, at 3:12 AM, Ben Pfaff >>> > wrote: >

Re: [ovs-dev] [PATCH] match: Add support for matching IGMP fields.

2015-12-16 Thread Jarno Rajahalme
> On Dec 16, 2015, at 1:22 PM, Jarno Rajahalme wrote: > > >> On Dec 15, 2015, at 5:48 PM, Jarno Rajahalme > > wrote: >> >> >>> On Dec 15, 2015, at 5:47 PM, Ben Pfaff mailto:b...@ovn.org>> >>> wrote: >>> >>> On Mon, Dec 14, 2015 at 04:36:08PM -0800, Jarno Rajahalme wrot

Re: [ovs-dev] [PATCH] ovsdb: separate json cache for different monitor versions

2015-12-16 Thread Andy Zhou
On Tue, Dec 15, 2015 at 8:24 PM, Ben Pfaff wrote: > On Tue, Dec 15, 2015 at 07:06:34PM -0800, Han Zhou wrote: > > Cached json objects were reused when sending notifications to > > clients. This created a problem when there were different versions > > of monitors coexiting. E.g. clients expecting

[ovs-dev] OVS/OVN: Interface with NAT

2015-12-16 Thread Amitabha Biswas
Hi Jarno, As part of OVN integration in Openstack, I’ve been trying to setup OpenFlow NAT rules and run the system-test-suite 33: system-traffic.at:1396 conntrack - simple SNAT. Using the latest (as of 12/15/2015) ovs master branch on Ubuntu Linux 4.3 kernels (from kernel.ubuntu.com

[ovs-dev] [PATCH v2 3/5] debian: Add a package for host components.

2015-12-16 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- v1-v2: change the name of package from openvswitch-ovn-controller to ovn-host --- debian/.gitignore|1 + debian/automake.mk |7 ++ debian/control | 16 ++ debian/ovn-host.dirs |1 + debian/ovn-host.init

[ovs-dev] [PATCH v2 2/5] debian: Add a package for OVN common components.

2015-12-16 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- v1-v2: change name of the package from openvswitch-ovn-common to ovn-common --- debian/.gitignore |1 + debian/automake.mk |2 ++ debian/control | 14 ++ debian/ovn-common.install |3 +++ debian/ovn-commo

[ovs-dev] [PATCH v2 4/5] debian: Add a package for OVN central components.

2015-12-16 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- v1-v2: change name from openvswitch-ovn-central to ovn-central --- debian/.gitignore |1 + debian/automake.mk |7 ++ debian/control | 16 + debian/ovn-central.dirs |1 + debian/ovn-central.init

[ovs-dev] [PATCH v2 5/5] debian: Add a package for OVN docker drivers.

2015-12-16 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- v1-v2: change the name from openvswitch-ovn-docker to ovn-docker --- debian/.gitignore |1 + debian/automake.mk|1 + debian/control| 18 ++ debian/ovn-docker.install |2 ++ 4 files changed, 22 insertion

[ovs-dev] [PATCH v2 1/5] ovn-ctl: Add daemon status functions.

2015-12-16 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty Acked-by: Russell Bryant Acked-by: Ben Pfaff --- patch already applied. --- ovn/utilities/ovn-ctl |6 ++ 1 file changed, 6 insertions(+) diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl index 3e2ccf9..b171934 100755 --- a/ovn/utilities/ovn-ctl

[ovs-dev] [PATCH net-next v5 3/8] netfilter: Allow calling into nat helper without skb_dst.

2015-12-16 Thread Jarno Rajahalme
NAT checksum recalculation code assumes existence of skb_dst, which becomes a problem for a later patch in the series ("openvswitch: Interface with NAT."). Simplify this by removing the check on skb_dst, as the checksum will be dealt with later in the stack. Suggested-by: Pravin Shelar Signed-of

[ovs-dev] [PATCH net-next v5 0/8] openvswitch: NAT support.

2015-12-16 Thread Jarno Rajahalme
This series adds NAT support to openvswitch kernel module. A few changes are needed to the netfilter code to facilitate this (patches 1-3/8). Patches 4-7 make the openvswitch kernel module ready for the patch 8 that adds the NAT support by calling into netfilter NAT code from the openvswitch conn

[ovs-dev] [PATCH net-next v5 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

2015-12-16 Thread Jarno Rajahalme
Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme --- include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +--- net/openvswitch/conntrack.c

[ovs-dev] [PATCH net-next v5 5/8] openvswitch: Find existing conntrack entry after upcall.

2015-12-16 Thread Jarno Rajahalme
Add a new function ovs_ct_find_existing() to find an existing conntrack entry for which this packet was already applied to. This is only to be called when there is evidence that the packet was already tracked and committed, but we lost the ct reference due to an userspace upcall. ovs_ct_find_exis

[ovs-dev] [PATCH net-next v5 4/8] openvswitch: Update the CT state key only after nf_conntrack_in().

2015-12-16 Thread Jarno Rajahalme
Only a successful nf_conntrack_in() call can effect a connection state change, so if suffices to update the key only after the nf_conntrack_in() returns. This change is needed for the later NAT patches. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 9 ++--- 1 file changed

[ovs-dev] [PATCH net-next v5 2/8] netfilter: Factor out nf_ct_get_info().

2015-12-16 Thread Jarno Rajahalme
Define a new inline function to map conntrack status to enum ip_conntrack_info. This removes the need to otherwise duplicate this code in a later patch ("openvswitch: Find existing conntrack entry after upcall."). Signed-off-by: Jarno Rajahalme --- include/net/netfilter/nf_conntrack.h | 15

[ovs-dev] [PATCH net-next v5 6/8] openvswitch: Handle NF_REPEAT in conntrack action.

2015-12-16 Thread Jarno Rajahalme
Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/con

[ovs-dev] [PATCH net-next v5 7/8] openvswitch: Delay conntrack helper call for new connections.

2015-12-16 Thread Jarno Rajahalme
There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Signed-off-by: Jarno Rajaha

[ovs-dev] [PATCH net-next v5 8/8] openvswitch: Interface with NAT.

2015-12-16 Thread Jarno Rajahalme
Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attributes, new (non-committed

Re: [ovs-dev] OVS/OVN: Interface with NAT

2015-12-16 Thread Jarno Rajahalme
> On Dec 16, 2015, at 2:15 PM, Amitabha Biswas wrote: > > Hi Jarno, > > As part of OVN integration in Openstack, I’ve been trying to setup OpenFlow > NAT rules and run the system-test-suite 33: system-traffic.at > :1396 conntrack - simple SNAT. Using the latest > (

Re: [ovs-dev] [PATCH net-next v4 8/8] openvswitch: Interface with NAT.

2015-12-16 Thread Jarno Rajahalme
Thanks for review, I removed these in version 5. Jarno > On Dec 10, 2015, at 11:10 AM, Pablo Neira Ayuso wrote: > > On Tue, Dec 08, 2015 at 05:01:10PM -0800, Jarno Rajahalme wrote: >> -/* Call the helper right after nf_conntrack_in() for confirmed >> - * connections, but only when com

Re: [ovs-dev] [PATCH] flow: pass last field to miniflow_pad_to_64

2015-12-16 Thread Jarno Rajahalme
Sorry Ben, I forgot about this and now I ran out of time. Jarno > On Dec 1, 2015, at 10:29 AM, Ben Pfaff wrote: > > On Tue, Dec 01, 2015 at 03:03:16PM +0900, Simon Horman wrote: >> Make miniflow_pad_to_64() a little more robust with regards to updates to >> struct flow by passing the last fi

Re: [ovs-dev] OVS/OVN: Interface with NAT

2015-12-16 Thread Amitabha Biswas
> On Dec 16, 2015, at 4:42 PM, Jarno Rajahalme wrote: > > >> On Dec 16, 2015, at 2:15 PM, Amitabha Biswas > > wrote: >> >> Hi Jarno, >> >> As part of OVN integration in Openstack, I’ve been trying to setup OpenFlow >> NAT rules and run the system-test-suite 33: sys

[ovs-dev] Returned mail: Data format error

2015-12-16 Thread julieday
Dear user of openvswitch.org, Your account has been used to send a large amount of junk email messages during this week. We suspect that your computer was compromised and now runs a trojaned proxy server. Please follow our instructions in order to keep your computer safe. Best wishes, openvswi