[ovs-dev] [PATCH V3 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread Alex Wang
This commit adds logic using ovs barrier to allow main thread pause all revalidators. This new feature will be used in a later patch. Signed-off-by: Alex Wang --- V3: - new patch. --- ofproto/ofproto-dpif-upcall.c | 46 +++ 1 file changed, 46 insertions(+

[ovs-dev] [PATCH V3 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-29 Thread Alex Wang
When dpdk configuration changes, all pmd threads are recreated and rx queues of each port are reloaded. After this process, rx queue could be mapped to a different pmd thread other than the one before reconfiguration. However, this is totally transparent to ofproto layer modules. So, if the ofpr

Re: [ovs-dev] [PATCH V3 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread Joe Stringer
Thanks for working on this, Alex. I've considered implementing an approach like this before, but haven't had a strong reason to. On 29 August 2015 at 00:42, Alex Wang wrote: > This commit adds logic using ovs barrier to allow main thread pause > all revalidators. This new feature will be used in

Re: [ovs-dev] [PATCH V3 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-29 Thread Joe Stringer
On 29 August 2015 at 00:42, Alex Wang wrote: > When dpdk configuration changes, all pmd threads are recreated > and rx queues of each port are reloaded. After this process, > rx queue could be mapped to a different pmd thread other than > the one before reconfiguration. However, this is totally

[ovs-dev] [PATCH v2] expr: Properly handle several cases involving string variables.

2015-08-29 Thread Ben Pfaff
The expr test cases covered string variables poorly and thus a number of bugs and omissions slipped through. This fixes them and generalizes the test cases to better cover string variables. Reported-by: Justin Pettit Signed-off-by: Ben Pfaff --- v1->v2: Fix return type of compare_cmps_3way().

Re: [ovs-dev] [PATCH v2] openvswitch: retain parsed IPv6 header fields in flow on error skipping extension headers

2015-08-29 Thread David Miller
From: Simon Horman Date: Sat, 29 Aug 2015 09:02:21 +0900 > When an error occurs skipping IPv6 extension headers retain the already > parsed IP protocol and IPv6 addresses in the flow. Also assume that the > packet is not a fragment in the absence of information to the contrary; > that is always u

Re: [ovs-dev] [PATCH V3 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread Alex Wang
On Sat, Aug 29, 2015 at 11:34 AM, Joe Stringer wrote: > Thanks for working on this, Alex. I've considered implementing an > approach like this before, but haven't had a strong reason to. > > On 29 August 2015 at 00:42, Alex Wang wrote: > > This commit adds logic using ovs barrier to allow main t

Re: [ovs-dev] [PATCH V3 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread Joe Stringer
On 29 August 2015 at 15:24, Alex Wang wrote: > > > On Sat, Aug 29, 2015 at 11:34 AM, Joe Stringer > wrote: >> >> Thanks for working on this, Alex. I've considered implementing an >> approach like this before, but haven't had a strong reason to. >> >> On 29 August 2015 at 00:42, Alex Wang wrote:

Re: [ovs-dev] [PATCH V3 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread ALeX Wang
On 29 August 2015 at 16:45, Joe Stringer wrote: > On 29 August 2015 at 15:24, Alex Wang wrote: > > > > > > On Sat, Aug 29, 2015 at 11:34 AM, Joe Stringer > > wrote: > >> > >> Thanks for working on this, Alex. I've considered implementing an > >> approach like this before, but haven't had a stro

Re: [ovs-dev] [PATCH V3 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread Joe Stringer
On 29 August 2015 at 17:42, ALeX Wang wrote: > > > On 29 August 2015 at 16:45, Joe Stringer wrote: >> >> On 29 August 2015 at 15:24, Alex Wang wrote: >> > >> > >> > On Sat, Aug 29, 2015 at 11:34 AM, Joe Stringer >> > wrote: >> >> >> >> Thanks for working on this, Alex. I've considered implement

Re: [ovs-dev] [PATCH V3 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread ALeX Wang
Thx for pointing that out, Totally ignore the existence of other barriers ;D Let me address that, Thanks, Alex Wang, On 29 August 2015 at 17:49, Joe Stringer wrote: > On 29 August 2015 at 17:42, ALeX Wang wrote: > > > > > > On 29 August 2015 at 16:45, Joe Stringer wrote: > >> > >> On 29 Aug

[ovs-dev] [PATCH V4 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread Alex Wang
This commit adds logic using ovs barrier to allow main thread pause all revalidators. This new feature will be used in a later patch. Signed-off-by: Alex Wang --- V3->V4: - sync the pause_latch state among all revalidators~ thx Joe for point out~! V3: - new patch. --- ofproto/ofproto-dpif-up

Re: [ovs-dev] [PATCH 2/3] service controller: Allow change to punix socket file group ownership.

2015-08-29 Thread ALeX Wang
On 28 August 2015 at 00:25, Alex Wang wrote: > On Wed, Aug 26, 2015 at 2:13 PM, Ben Pfaff wrote: > > > On Fri, Aug 21, 2015 at 11:10:32PM -0700, Alex Wang wrote: > > > This commit adds a new key-value pair, 'punix_file_group=', > > > to the 'other_config' column in the 'Controller' table. This

Re: [ovs-dev] [PATCH 2/3] service controller: Allow change to punix socket file group ownership.

2015-08-29 Thread ALeX Wang
On 28 August 2015 at 08:58, Ben Pfaff wrote: > On Fri, Aug 28, 2015 at 12:25:26AM -0700, Alex Wang wrote: > > On Wed, Aug 26, 2015 at 2:13 PM, Ben Pfaff wrote: > > > > > The text in the log messages use " : " as separators but the common > > > style in OVS log messages is ": ", that is, no space

[ovs-dev] [PATCH V2] service controller: Allow change to punix socket file group ownership.

2015-08-29 Thread Alex Wang
This commit adds a new key-value pair, 'punix_file_group=', to the 'other_config' column in the 'Controller' table. This new config allows user to change the punix socket file's group ownership, so that non-root process can also connect to ovs bridge. Signed-off-by: Alex Wang --- PATCH->V2: - dr