On 29 August 2015 at 00:42, Alex Wang <ee07b...@gmail.com> wrote: > When dpdk configuration changes, all pmd threads are recreated > and rx queues of each port are reloaded. After this process, > rx queue could be mapped to a different pmd thread other than > the one before reconfiguration. However, this is totally > transparent to ofproto layer modules. So, if the ofproto-dpif-upcall > module still holds ukeys generated before pmd thread recreation, > this old ukey will collide with the ukey for the new upcalls > from same traffic flow, causing flow installation failure. > > To fix the bug, this commit adds a new call-back function > in dpif layer for notifying upper layer the purging of datapath > (e.g. pmd thread deletion in dpif-netdev). So, the > ofproto-dpif-upcall module can react properly with deleting > the ukeys and with collecting flows' last stats. > > Reported-by: Ilya Maximets <i.maxim...@samsung.com> > Signed-off-by: Alex Wang <ee07b...@gmail.com> > Acked-by: Daniele Di Proietto <diproiet...@vmware.com> > Tested-by: Daniele Di Proietto <diproiet...@vmware.com>
This looks good to me, so long as we can iron out the issues in patch 1. Acked-by: Joe Stringer <joestrin...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev